abapgit-agent 1.1.6 → 1.3.0

package/abap/CLAUDE.md

@@ -23,16 +23,68 @@ This is an ABAP project. **Do not attempt local syntax validation** - ABAP code
 4. **"Error updating where-used list" = SYNTAX ERROR** - This is NOT a warning!
 5. If Failed Objects > 0, there are syntax errors - fix them before proceeding
 
+## Inspect Command (Syntax Check)
+
+Use the `inspect` command to perform syntax validation on ABAP objects and CDS views.
+
+### Usage
+```bash
+# Syntax check single file
+abapgit-agent inspect --files abap/zcl_my_class.clas.abap
+
+# Syntax check multiple files
+abapgit-agent inspect --files abap/zcl_class1.clas.abap,abap/zcl_class2.clas.abap
+
+# Syntax check CDS view
+abapgit-agent inspect --files abap/zc_my_view.ddls.asddls
+```
+
+### Supported Object Types
+
+| Type | Description | Validation Method |
+|------|-------------|------------------|
+| CLAS | Class | Code Inspector (SCI) |
+| INTF | Interface | Code Inspector (SCI) |
+| PROG | Program | Code Inspector (SCI) |
+| DDLS | CDS View/Entity | DDL Handler |
+
+### CDS Views (DDLS) Validation
+
+For CDS views, the inspect command uses `CL_DD_DDL_HANDLER_FACTORY`:
+- Checks **inactive version first** (`get_state = 'M'`)
+- Falls back to active version if no inactive version exists
+- Uses `get_errors()` and `get_warnings()` methods for detailed error information
+
+### Examples
+
+**Passed:**
+```
+✅ CLAS ZCL_MY_CLASS - Syntax check passed
+```
+
+**With Warnings:**
+```
+⚠️  DDLS ZC_MY_VIEW - Syntax check passed with warnings (4):
+  Line 9 : ParentPackage
+  Line 11 : SoftwareComponent
+```
+
+**Failed:**
+```
+❌ DDLS ZC_MY_VIEW - Syntax check failed (1 error(s)):
+  Line 21, Column 12: Error message text
+```
+
 ## Fast Iteration Workflow
 
 For quick ABAP code changes:
 
 ```bash
 # 1. Make small change to ABAP file
-# 2. Commit and push
+# 2. Commit and push to git
 git add abap/zcl_my_class.clas.abap
 git commit -m "fix: ..."
-git push
+git push    # CRITICAL: Push BEFORE pulling!
 
 # 3. Pull only changed file (seconds, not minutes)
 abapgit-agent pull --files abap/zcl_my_class.clas.abap
@@ -66,6 +118,102 @@ abapgit-agent inspect --files abap/zcl_my_class.clas.abap
 ```
 This will show detailed syntax errors including line numbers and error messages.
 
+## View ABAP Object Definitions
+
+Use the `view` command to inspect ABAP object definitions (classes, interfaces, tables, data elements) directly from the ABAP system. **Very useful when working with unfamiliar tables** - shows complete structure including fields, types, and descriptions.
+
+```bash
+# View a table definition
+abapgit-agent view --objects ZMY_TABLE --type TABL
+
+# View a data element definition
+abapgit-agent view --objects ZMY_DTEL --type DTEL
+
+# View a class definition
+abapgit-agent view --objects ZCL_MY_CLASS
+
+# View an interface definition
+abapgit-agent view --objects ZIF_MY_INTERFACE
+
+# View a table type definition
+abapgit-agent view --objects ZMY_TTYP --type TTYP
+
+# View multiple objects
+abapgit-agent view --objects ZCL_CLASS1,ZCL_CLASS2,ZIF_INTERFACE1
+
+# JSON output for scripting
+abapgit-agent view --objects ZMY_TABLE --type TABL --json
+```
+
+### When to Use View Command
+
+AI assistant SHOULD call `view` command when:
+
+- User asks to "check", "look up", or "explore" an unfamiliar object
+- Working with a table/structure and you don't know the field names/types
+- Calling a class/interface method and you don't know the parameters
+- User provides an object name that may not exist in the git repository
+
+**Example workflow:**
+```
+User: "Check if SFLIGHT table has a PRICE field"
+
+Assistant: <calls `abapgit-agent view --objects SFLIGHT --type TABL`>
+→ Shows table structure with all fields including PRICE
+```
+
+## Explore Package Structure
+
+Use the `tree` command to display package hierarchy from ABAP system:
+
+```bash
+# Display package hierarchy
+abapgit-agent tree --package $MY_PACKAGE
+
+# With object counts
+abapgit-agent tree --package $MY_PACKAGE --include-objects
+
+# Limit depth
+abapgit-agent tree --package $MY_PACKAGE --depth 2
+
+# JSON output for scripting
+abapgit-agent tree --package $MY_PACKAGE --json
+```
+
+**Table Output Example:**
+```
+TABLE ZCAIS_D1:
+|----------------+-----+----------------+----------+----------------+----------------------|
+| Field          | Key | Type           |   Length | Data Elem      | Description          |
+|----------------+-----+----------------+----------+----------------+----------------------|
+| CLIENT         | X   | CLNT           |        3 | MANDT          | Client               |
+| ID             | X   | NUMC           |        4 | NUMC4          | Count parameters     |
+| NAME           |     | CHAR           |       50 | CHAR50         | Comment              |
+|----------------+-----+----------------+----------+----------------+----------------------|
+```
+
+**Data Element Output Example:**
+```
+DATA ELEMENT ZMY_DTEL:
+|----------------+----------------+----------+----------------+----------------------|
+| Field          | Type           |   Length | Domain         | Description          |
+|----------------+----------------+----------+----------------+----------------------|
+| DOMAIN         | CHAR           |       20 | ZMY_DOMAIN     | Domain: ZMY_DOMAIN   |
+| DATA_TYPE      | CHAR           |       10 |                | ABAP Type: CHAR      |
+| LENGTH         | NUMC           |        5 |                | Length: 20           |
+|----------------+----------------+----------+----------------+----------------------|
+```
+
+**Table Type Output Example:**
+```
+📖 ZMY_TTYP (Table Type)
+   Table Type ZMY_TTYP in $PACKAGE
+
+   Line Type: ZMY_STRUCTURE
+   Access Mode: STANDARD
+   Key Definition: WITH KEY
+```
+
 ## JSON Handling - ALWAYS Use /ui2/cl_json
 
 **CRITICAL**: Always use `/ui2/cl_json` for JSON serialization and deserialization.
@@ -138,7 +286,16 @@ ENDCLASS.
 
 ## Creating New ABAP Objects - XML Metadata Required
 
-**IMPORTANT**: When creating new ABAP objects in abapGit format, you MUST create XML metadata files alongside the `.clas.abap` and `.intf.abap` files.
+**CRITICAL CHECKLIST - Never Forget!**
+
+When creating ANY new ABAP object file, you MUST also create its XML metadata file:
+
+| ABAP File | Required XML File |
+|-----------|------------------|
+| `zcl_my_class.clas.abap` | `zcl_my_class.clas.xml` |
+| `zif_my_intf.intf.abap` | `zif_my_intf.intf.xml` |
+
+**Without XML files**, abapGit will NOT recognize the objects during pull, and they won't be activated.
 
 ### XML Metadata Format for CLAS
 
@@ -184,15 +341,27 @@ For `zif_abgagt_util.intf.abap`, create `zif_abgagt_util.intf.xml`:
 </abapGit>
 ```
 
-**Without XML files**, abapGit will NOT recognize the objects during pull, and they won't be activated in the ABAP system.
+### Important Notes
+
+1. **CRITICAL: Push to git BEFORE pulling into ABAP**
+   - Always commit and push ABAP files to git first
+   - Then run `abapgit-agent pull` to activate in ABAP
+   - Never run `abapgit-agent pull` without pushing changes first
+
+2. **Only pull ABAP files** - The XML metadata stays in git:
+   ```bash
+   abapgit-agent pull --files zcl_my_class.clas.abap
+   ```
+2. abapGit reads the XML from git to deserialize the ABAP code
+3. XML files are NOT activated in ABAP - they are only for abapGit
 
 ```bash
 # After making changes to ABAP files
 git add .
 git commit -m "Describe changes"
-git push
+git push    # CRITICAL: Push BEFORE pulling
 
-# Validate in ABAP system (single file - fast)
+# Then validate in ABAP system (single file - fast)
 abapgit-agent pull --files abap/zcl_my_class.clas.abap
 
 # Or validate all files
@@ -303,6 +472,113 @@ Common object types in this project:
 - `TABL` - Tables
 - `DDLS` - Data Definitions
 
+## Creating CDS Views (DDLS)
+
+CDS views (Data Definition Language Source) require specific file naming and structure for abapGit.
+
+### File Naming
+
+CDS views require **two files**:
+
+| File | Description |
+|------|-------------|
+| `zc_my_view.ddls.asddls` | DDL source code |
+| `zc_my_view.ddls.xml` | XML metadata |
+
+**Important:** Do NOT use `.ddls.abap` extension - use `.ddls.asddls` for the source.
+
+### DDL Source File (`.ddls.asddls`)
+
+```abap
+@AbapCatalog.sqlViewName: 'ZCMYVIEW'
+@AbapCatalog.compiler.compareFilter: true
+@AccessControl.authorizationCheck: #NOT_REQUIRED
+@EndUserText.label: 'My CDS View'
+define view ZC_My_View as select from tdevc
+{
+  key devclass as Devclass,
+      parentcl as ParentPackage,
+      ctext    as Description
+}
+where devclass not like '$%'
+```
+
+### XML Metadata File (`.ddls.xml`)
+
+```xml
+<?xml version="1.0" encoding="utf-8"?>
+<abapGit version="v1.0.0" serializer="LCL_OBJECT_DDLS" serializer_version="v1.0.0">
+ <asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
+  <asx:values>
+   <DDLS>
+    <DDLNAME>ZC_MY_VIEW</DDLNAME>
+    <DDLANGUAGE>E</DDLANGUAGE>
+    <DDTEXT>My CDS View</DDTEXT>
+   </DDLS>
+  </asx:values>
+ </asx:abap>
+</abapGit>
+```
+
+### Key Points
+
+1. **Avoid reserved words** - Field names like `PACKAGE`, `CLASS`, `INTERFACE` are reserved in CDS. Use alternatives like `PackageName`, `ClassName`.
+
+2. **Pull all files to activate** - When activating CDS views, use `abapgit-agent pull` (not single file) to ensure proper activation:
+   ```bash
+   abapgit-agent pull  # Pull all files
+   ```
+
+3. **System support** - CDS views require SAP systems with CDS capability (S/4HANA, SAP BW/4HANA, or ABAP 7.51+). Older systems will show error: "Object type DDLS is not supported by this system"
+
+### Debugging Activation Errors
+
+When pull shows generic errors like "Activation cancelled. Check the inactive objects":
+
+1. **Check in ADT/Eclipse** - Open the DDL source in ADT and run syntax check for detailed errors
+2. **Pull all files** - Sometimes `abapgit-agent pull` (all files) works better than single file for CDS views
+
+## Creating CDS View Entities
+
+CDS View Entities (`define view entity`) are the modern replacement for CDS Views with additional features like **associations for OData navigation**.
+
+### Differences from CDS Views
+
+| Aspect | CDS View | View Entity |
+|--------|----------|-------------|
+| Syntax | `define view` | `define view entity` |
+| Associations | No | Yes (exposed for navigation) |
+| OData/Navigation | Requires separate service | Auto-exposes associations |
+| ABAP Version | 7.40+ | 7.55+ / S/4HANA Cloud |
+
+### DDL Source File with Association
+
+```abap
+@EndUserText.label: 'Package Hierarchy'
+@AccessControl.authorizationCheck: #NOT_REQUIRED
+define view entity ZC_Pkg_Hierarchy_VE
+  as select from tdevc
+  association [0..1] to tdevc as _Parent
+    on _Parent.devclass = $projection.ParentPackage
+{
+  key devclass                           as PackageName,
+      parentcl                           as ParentPackage,
+      ctext                              as Description,
+      dlvunit                           as SoftwareComponent,
+
+      // Exposed associations
+      _Parent
+}
+where devclass not like '$%'
+```
+
+### Key Points for View Entities
+
+1. **Association syntax**: Use `$projection` to reference fields in the current entity
+2. **Association cardinality**: `[0..1]`, `[1..1]`, `[0..n]`, `[1..n]`
+3. **Expose associations**: Add the association name at the end of the SELECT to expose it for OData navigation
+4. **Activation warnings**: Search help warnings are informational and don't block activation
+
 ## Naming Conventions
 
 - Use `Z_` or `Y_` prefix for custom objects

package/abap/copilot-instructions.md

@@ -0,0 +1,79 @@
+# ABAP Development with abapGit
+
+You are working on an ABAP project using abapGit for version control.
+
+## Commands
+
+| Command | Description |
+|---------|-------------|
+| `abapgit-agent pull` | Pull and activate all ABAP objects |
+| `abapgit-agent pull --files <file>` | Pull and activate specific file only |
+| `abapgit-agent inspect --files <file>` | Syntax check ABAP source |
+| `abapgit-agent unit --files <file>` | Run AUnit tests |
+| `abapgit-agent tree --package <package>` | Display package hierarchy |
+| `abapgit-agent view --objects <name>` | View object definitions |
+
+## Explore Unknown Objects
+
+**Before working with unfamiliar objects, use `view` command:**
+
+```bash
+# Check table structure
+abapgit-agent view --objects ZMY_TABLE --type TABL
+
+# Check class definition
+abapgit-agent view --objects ZCL_UNKNOWN_CLASS
+
+# Check interface
+abapgit-agent view --objects ZIF_UNKNOWN_INTERFACE
+
+# Check data element
+abapgit-agent view --objects ZMY_DTEL --type DTEL
+```
+
+## When to Use View Command
+
+AI assistant SHOULD call `view` command when:
+- User asks to "check", "look up", or "explore" an unfamiliar object
+- Working with a table/structure and you don't know the fields
+- Calling a class/interface method and you don't know the parameters
+- You need to verify an object exists before using it
+
+## Key ABAP Rules
+
+1. **Global classes MUST use `PUBLIC`**:
+   ```abap
+   CLASS zcl_my_class DEFINITION PUBLIC.  " <- REQUIRED
+   ```
+
+2. **Use `/ui2/cl_json` for JSON**:
+   ```abap
+   DATA ls_data TYPE ty_request.
+   ls_data = /ui2/cl_json=>deserialize( json = lv_json ).
+   lv_json = /ui2/cl_json=>serialize( data = ls_response ).
+   ```
+
+3. **Test class name max 30 chars**: `ltcl_util` (not `ltcl_abgagt_util_test`)
+
+4. **Interface method implementation**: Use prefix `zif_interface~method_name`
+
+5. **abapGit files need XML metadata**: `.clas.xml`, `.intf.xml` alongside `.clas.abap`, `.intf.abap`
+
+## Workflow
+
+1. Edit ABAP file in `/abap/`
+2. `git add <file> && git commit -m "..." && git push`
+3. `abapgit-agent pull --files <file>` (seconds, not minutes)
+
+## Error Handling
+
+- Activation fails with "Error updating where-used list" = **syntax error**
+- Use `abapgit-agent inspect --files <file>` for detailed error messages
+
+## Object Naming
+
+| Pattern | Type |
+|---------|------|
+| `ZCL_*` | Class |
+| `ZIF_*` | Interface |
+| `Z*` | Other objects |

package/abap/zcl_abgagt_agent.clas.abap

@@ -389,8 +389,8 @@ CLASS zcl_abgagt_agent IMPLEMENTATION.
           ENDIF.
         ENDIF.
 
-        " Error/Abort/Warning messages - add to failed objects
-        IF ls_msg-type = 'E' OR ls_msg-type = 'A' OR ls_msg-type = 'W'.
+        " Error/Abort messages - add to failed objects (warnings are not failures)
+        IF ls_msg-type = 'E' OR ls_msg-type = 'A'.
           APPEND ls_object TO rs_result-failed_objects.
         ENDIF.
       ENDLOOP.

package/abap/zcl_abgagt_cmd_factory.clas.abap

@@ -27,6 +27,8 @@ CLASS zcl_abgagt_cmd_factory IMPLEMENTATION.
       ( command = zif_abgagt_command=>gc_unit   class_name = 'ZCL_ABGAGT_COMMAND_UNIT' )
       ( command = zif_abgagt_command=>gc_create class_name = 'ZCL_ABGAGT_COMMAND_CREATE' )
       ( command = zif_abgagt_command=>gc_import class_name = 'ZCL_ABGAGT_COMMAND_IMPORT' )
+      ( command = zif_abgagt_command=>gc_tree   class_name = 'ZCL_ABGAGT_COMMAND_TREE' )
+      ( command = zif_abgagt_command=>gc_view   class_name = 'ZCL_ABGAGT_COMMAND_VIEW' )
     ).
   ENDMETHOD.