abapgit-agent 1.0.0 → 1.1.0

package/abap/zcl_abgagt_command_import.clas.abap

@@ -0,0 +1,138 @@
+*"*"use source
+*"*"Local Interface:
+*"**********************************************************************
+CLASS zcl_abgagt_command_import DEFINITION PUBLIC FINAL CREATE PUBLIC.
+
+  PUBLIC SECTION.
+    INTERFACES zif_abgagt_command.
+
+    TYPES: BEGIN OF ty_import_params,
+             url TYPE string,
+             message TYPE string,
+             username TYPE string,
+             password TYPE string,
+           END OF ty_import_params.
+
+ENDCLASS.
+
+CLASS zcl_abgagt_command_import IMPLEMENTATION.
+
+  METHOD zif_abgagt_command~get_name.
+    rv_name = 'IMPORT'.
+  ENDMETHOD.
+
+  METHOD zif_abgagt_command~execute.
+    DATA: ls_params TYPE ty_import_params,
+          li_repo TYPE REF TO zif_abapgit_repo,
+          li_repo_online TYPE REF TO zif_abapgit_repo_online,
+          lo_stage TYPE REF TO zcl_abapgit_stage,
+          lt_files TYPE zif_abapgit_definitions=>ty_files_item_tt,
+          lv_package TYPE devclass,
+          lv_message TYPE string,
+          lv_files_staged TYPE i.
+
+    " Use separate variables to avoid inline DATA issues
+    DATA: li_user TYPE REF TO zif_abapgit_persist_user,
+          lv_committer_name TYPE string,
+          lv_committer_email TYPE string.
+
+    TRY.
+        IF is_param IS SUPPLIED.
+          ls_params = CORRESPONDING #( is_param ).
+        ENDIF.
+
+        " Validate URL
+        IF ls_params-url IS INITIAL.
+          rv_result = '{"success":"","error":"URL is required"}'.
+          RETURN.
+        ENDIF.
+
+        " Configure credentials if provided
+        IF ls_params-username IS NOT INITIAL AND ls_params-password IS NOT INITIAL.
+          zcl_abapgit_persist_factory=>get_user( )->set_repo_git_user_name(
+            iv_url = ls_params-url iv_username = ls_params-username ).
+          zcl_abapgit_persist_factory=>get_user( )->set_repo_login(
+            iv_url = ls_params-url iv_login = ls_params-username ).
+          zcl_abapgit_login_manager=>set_basic(
+            iv_uri      = ls_params-url
+            iv_username = ls_params-username
+            iv_password = ls_params-password ).
+        ENDIF.
+
+        " Find repository by URL
+        zcl_abapgit_repo_srv=>get_instance( )->get_repo_from_url(
+          EXPORTING iv_url = ls_params-url
+          IMPORTING ei_repo = li_repo ).
+
+        IF li_repo IS NOT BOUND.
+          rv_result = '{"success":"","error":"Repository not found"}'.
+          RETURN.
+        ENDIF.
+
+        " Cast to online repo for push operations
+        li_repo_online ?= li_repo.
+
+        " Get package from repository
+        lv_package = li_repo->get_package( ).
+
+        " Build commit message if not provided
+        IF ls_params-message IS INITIAL.
+          lv_message = |feat: initial import from ABAP package { lv_package }|.
+        ELSE.
+          lv_message = ls_params-message.
+        ENDIF.
+
+        " Refresh repository
+        li_repo->refresh( ).
+
+        " Get local files
+        lt_files = li_repo->get_files_local( ).
+
+        " Count files
+        lv_files_staged = lines( lt_files ).
+
+        " Check if there are files to import
+        IF lv_files_staged = 0.
+          rv_result = '{"success":"","error":"No objects found in package"}'.
+          RETURN.
+        ENDIF.
+
+        " Create stage
+        CREATE OBJECT lo_stage.
+
+        " Add all files to stage
+        LOOP AT lt_files ASSIGNING FIELD-SYMBOL(<ls_file>).
+          lo_stage->add(
+            iv_path     = <ls_file>-file-path
+            iv_filename = <ls_file>-file-filename
+            iv_data     = <ls_file>-file-data ).
+        ENDLOOP.
+
+        " Get user details for committer
+        li_user = zcl_abapgit_persist_factory=>get_user( ).
+        lv_committer_name = li_user->get_default_git_user_name( ).
+        lv_committer_email = li_user->get_default_git_user_email( ).
+
+        " Prepare commit
+        DATA: ls_comment TYPE zif_abapgit_git_definitions=>ty_comment.
+        ls_comment-committer-name  = lv_committer_name.
+        ls_comment-committer-email = lv_committer_email.
+        ls_comment-comment         = lv_message.
+
+        " Commit and push
+        li_repo_online->push(
+          is_comment = ls_comment
+          io_stage   = lo_stage ).
+
+        COMMIT WORK.
+
+        rv_result = '{"success":"X","files_staged":"' && lv_files_staged && '","commit_message":"' && lv_message && '"}'.
+
+      CATCH zcx_abapgit_exception INTO DATA(lx_error).
+        rv_result = '{"success":"","error":"' && lx_error->get_text( ) && '"}'.
+      CATCH cx_root INTO DATA(lx_other).
+        rv_result = '{"success":"","error":"' && lx_other->get_text( ) && '"}'.
+    ENDTRY.
+  ENDMETHOD.
+
+ENDCLASS.

package/abap/zcl_abgagt_command_import.clas.xml

@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="utf-8"?>
+<abapGit version="v1.0.0" serializer="LCL_OBJECT_CLAS" serializer_version="v1.0.0">
+ <asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
+  <asx:values>
+   <VSEOCLASS>
+    <CLSNAME>ZCL_ABGAGT_COMMAND_IMPORT</CLSNAME>
+    <LANGU>E</LANGU>
+    <DESCRIPT>Import command for ABAP Git Agent</DESCRIPT>
+    <EXPOSURE>2</EXPOSURE>
+    <STATE>1</STATE>
+    <UNICODE>X</UNICODE>
+   </VSEOCLASS>
+  </asx:values>
+ </asx:abap>
+</abapGit>

package/abap/zcl_abgagt_resource_create.clas.abap

@@ -0,0 +1,71 @@
+*"*"use source
+*"*"Local Interface:
+*"**********************************************************************
+CLASS zcl_abgagt_resource_create DEFINITION PUBLIC FINAL
+                             INHERITING FROM cl_rest_resource
+                             CREATE PUBLIC.
+
+  PUBLIC SECTION.
+    METHODS if_rest_resource~post REDEFINITION.
+
+ENDCLASS.
+
+CLASS zcl_abgagt_resource_create IMPLEMENTATION.
+
+  METHOD if_rest_resource~post.
+    DATA lv_json TYPE string.
+    lv_json = mo_request->get_entity( )->get_string_data( ).
+
+    " Parse JSON using /ui2/cl_json
+    DATA: BEGIN OF ls_request,
+            url TYPE string,
+            branch TYPE string,
+            package TYPE string,
+            display_name TYPE string,
+            name TYPE string,
+            folder_logic TYPE string,
+            folder TYPE string,
+            username TYPE string,
+            password TYPE string,
+          END OF ls_request.
+
+    /ui2/cl_json=>deserialize(
+      EXPORTING
+        json = lv_json
+      CHANGING
+        data = ls_request ).
+
+    " Validate required fields
+    IF ls_request-url IS INITIAL OR ls_request-package IS INITIAL.
+      DATA lv_json_resp TYPE string.
+      lv_json_resp = '{"success":"","error":"URL and package are required"}'.
+      DATA(lo_entity) = mo_response->create_entity( ).
+      lo_entity->set_content_type( iv_media_type = if_rest_media_type=>gc_appl_json ).
+      lo_entity->set_string_data( lv_json_resp ).
+      mo_response->set_status( cl_rest_status_code=>gc_client_error_bad_request ).
+      RETURN.
+    ENDIF.
+
+    " Get command from factory
+    DATA(lo_factory) = zcl_abgagt_cmd_factory=>get_instance( ).
+    DATA(lo_command) = lo_factory->get_command( zif_abgagt_command=>gc_create ).
+
+    IF lo_command IS NOT BOUND.
+      lv_json_resp = '{"success":"","error":"CREATE command not found"}'.
+      lo_entity = mo_response->create_entity( ).
+      lo_entity->set_content_type( iv_media_type = if_rest_media_type=>gc_appl_json ).
+      lo_entity->set_string_data( lv_json_resp ).
+      mo_response->set_status( cl_rest_status_code=>gc_client_error_bad_request ).
+      RETURN.
+    ENDIF.
+
+    " Execute command with is_param
+    DATA(lv_result) = lo_command->execute( is_param = ls_request ).
+
+    lo_entity = mo_response->create_entity( ).
+    lo_entity->set_content_type( iv_media_type = if_rest_media_type=>gc_appl_json ).
+    lo_entity->set_string_data( lv_result ).
+    mo_response->set_status( cl_rest_status_code=>gc_success_ok ).
+  ENDMETHOD.
+
+ENDCLASS.

package/abap/zcl_abgagt_resource_create.clas.xml

@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="utf-8"?>
+<abapGit version="v1.0.0" serializer="LCL_OBJECT_CLAS" serializer_version="v1.0.0">
+ <asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
+  <asx:values>
+   <VSEOCLASS>
+    <CLSNAME>ZCL_ABGAGT_RESOURCE_CREATE</CLSNAME>
+    <LANGU>E</LANGU>
+    <DESCRIPT>ABAP Git Agent - Create Resource</DESCRIPT>
+    <EXPOSURE>2</EXPOSURE>
+    <STATE>1</STATE>
+    <UNICODE>X</UNICODE>
+   </VSEOCLASS>
+  </asx:values>
+ </asx:abap>
+</abapGit>

package/abap/zcl_abgagt_resource_import.clas.abap

@@ -0,0 +1,66 @@
+*"*"use source
+*"*"Local Interface:
+*"**********************************************************************
+CLASS zcl_abgagt_resource_import DEFINITION PUBLIC FINAL
+                             INHERITING FROM cl_rest_resource
+                             CREATE PUBLIC.
+
+  PUBLIC SECTION.
+    METHODS if_rest_resource~post REDEFINITION.
+
+ENDCLASS.
+
+CLASS zcl_abgagt_resource_import IMPLEMENTATION.
+
+  METHOD if_rest_resource~post.
+    DATA lv_json TYPE string.
+    lv_json = mo_request->get_entity( )->get_string_data( ).
+
+    " Parse JSON using /ui2/cl_json
+    DATA: BEGIN OF ls_request,
+            url TYPE string,
+            message TYPE string,
+            username TYPE string,
+            password TYPE string,
+          END OF ls_request.
+
+    /ui2/cl_json=>deserialize(
+      EXPORTING
+        json = lv_json
+      CHANGING
+        data = ls_request ).
+
+    " Validate required fields
+    IF ls_request-url IS INITIAL.
+      DATA lv_json_resp TYPE string.
+      lv_json_resp = '{"success":"","error":"URL is required"}'.
+      DATA(lo_entity) = mo_response->create_entity( ).
+      lo_entity->set_content_type( iv_media_type = if_rest_media_type=>gc_appl_json ).
+      lo_entity->set_string_data( lv_json_resp ).
+      mo_response->set_status( cl_rest_status_code=>gc_client_error_bad_request ).
+      RETURN.
+    ENDIF.
+
+    " Get command from factory
+    DATA(lo_factory) = zcl_abgagt_cmd_factory=>get_instance( ).
+    DATA(lo_command) = lo_factory->get_command( zif_abgagt_command=>gc_import ).
+
+    IF lo_command IS NOT BOUND.
+      lv_json_resp = '{"success":"","error":"IMPORT command not found"}'.
+      lo_entity = mo_response->create_entity( ).
+      lo_entity->set_content_type( iv_media_type = if_rest_media_type=>gc_appl_json ).
+      lo_entity->set_string_data( lv_json_resp ).
+      mo_response->set_status( cl_rest_status_code=>gc_client_error_bad_request ).
+      RETURN.
+    ENDIF.
+
+    " Execute command with is_param
+    DATA(lv_result) = lo_command->execute( is_param = ls_request ).
+
+    lo_entity = mo_response->create_entity( ).
+    lo_entity->set_content_type( iv_media_type = if_rest_media_type=>gc_appl_json ).
+    lo_entity->set_string_data( lv_result ).
+    mo_response->set_status( cl_rest_status_code=>gc_success_ok ).
+  ENDMETHOD.
+
+ENDCLASS.

package/abap/zcl_abgagt_resource_import.clas.xml

@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="utf-8"?>
+<abapGit version="v1.0.0" serializer="LCL_OBJECT_CLAS" serializer_version="v1.0.0">
+ <asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
+  <asx:values>
+   <VSEOCLASS>
+    <CLSNAME>ZCL_ABGAGT_RESOURCE_IMPORT</CLSNAME>
+    <LANGU>E</LANGU>
+    <DESCRIPT>REST resource handler for /import endpoint</DESCRIPT>
+    <EXPOSURE>2</EXPOSURE>
+    <STATE>1</STATE>
+    <UNICODE>X</UNICODE>
+   </VSEOCLASS>
+  </asx:values>
+ </asx:abap>
+</abapGit>

package/abap/zcl_abgagt_rest_handler.clas.abap

@@ -20,6 +20,8 @@ CLASS zcl_abgagt_rest_handler IMPLEMENTATION.
     lo_router->attach( iv_template = '/health' iv_handler_class = 'ZCL_ABGAGT_RESOURCE_HEALTH' ).
     lo_router->attach( iv_template = '/inspect' iv_handler_class = 'ZCL_ABGAGT_RESOURCE_INSPECT' ).
     lo_router->attach( iv_template = '/unit' iv_handler_class = 'ZCL_ABGAGT_RESOURCE_UNIT' ).
+    lo_router->attach( iv_template = '/create' iv_handler_class = 'ZCL_ABGAGT_RESOURCE_CREATE' ).
+    lo_router->attach( iv_template = '/import' iv_handler_class = 'ZCL_ABGAGT_RESOURCE_IMPORT' ).
 
     ro_root_handler = lo_router.
   ENDMETHOD.

package/abap/zif_abgagt_agent.intf.abap

@@ -1,9 +1,6 @@
-" TODO: Implement detailed syntax error parsing
-" When a syntax error occurs, the log shows the affected object name
-" but not the specific line/column. For better error reporting:
-" - Parse the error message to extract object info
-" - For syntax errors, query SEPSA or TRINT_OBJECT_LOG for details
-" - Return structured error with line numbers and fix suggestions
+" Interface for abapGit Agent - handles pull operations only.
+" Note: inspect and run_tests are implemented in separate command classes
+" (zcl_abgagt_command_inspect, zcl_abgagt_command_unit) using ABAP standard classes.
 
 INTERFACE zif_abgagt_agent PUBLIC.
 
@@ -34,71 +31,6 @@ INTERFACE zif_abgagt_agent PUBLIC.
     finished_at TYPE timestampl,
   END OF ty_result.
 
-  TYPES: BEGIN OF ty_pull_params,
-    url TYPE string,
-    branch TYPE string,
-    username TYPE string,
-    password TYPE string,
-    package TYPE devclass,
-    folder_logic TYPE string,
-    create_new TYPE abap_bool,
-  END OF ty_pull_params.
-
-  " Types for inspect (syntax check)
-  TYPES: BEGIN OF ty_error,
-           line TYPE string,
-           column TYPE string,
-           text TYPE string,
-           word TYPE string,
-         END OF ty_error.
-
-  TYPES ty_errors TYPE STANDARD TABLE OF ty_error WITH NON-UNIQUE DEFAULT KEY.
-
-  TYPES: BEGIN OF ty_inspect_result,
-           success TYPE abap_bool,
-           object_type TYPE string,
-           object_name TYPE string,
-           error_count TYPE i,
-           errors TYPE ty_errors,
-         END OF ty_inspect_result.
-
-  " Types for unit tests
-  TYPES: BEGIN OF ty_test_result,
-           object_type TYPE string,
-           object_name TYPE string,
-           test_method TYPE string,
-           status TYPE string,
-           message TYPE string,
-           line TYPE string,
-         END OF ty_test_result.
-
-  TYPES ty_test_results TYPE STANDARD TABLE OF ty_test_result WITH NON-UNIQUE DEFAULT KEY.
-
-  TYPES: BEGIN OF ty_unit_result,
-           success TYPE abap_bool,
-           message TYPE string,
-           test_count TYPE i,
-           passed_count TYPE i,
-           failed_count TYPE i,
-           results TYPE ty_test_results,
-         END OF ty_unit_result.
-
-  TYPES: BEGIN OF ty_object_key,
-           object_type TYPE string,
-           object_name TYPE string,
-         END OF ty_object_key.
-
-  TYPES ty_object_keys TYPE STANDARD TABLE OF ty_object_key WITH NON-UNIQUE DEFAULT KEY.
-
-  TYPES: ty_log_table TYPE TABLE OF string.
-  TYPES: ty_job_status TYPE string.
-
-  CONSTANTS:
-    gc_status_pending TYPE ty_job_status VALUE 'PENDING',
-    gc_status_running TYPE ty_job_status VALUE 'RUNNING',
-    gc_status_completed TYPE ty_job_status VALUE 'COMPLETED',
-    gc_status_failed TYPE ty_job_status VALUE 'FAILED'.
-
   METHODS pull
     IMPORTING
       iv_url TYPE string
@@ -118,17 +50,4 @@ INTERFACE zif_abgagt_agent PUBLIC.
     RETURNING
       VALUE(rv_status) TYPE string.
 
-  METHODS inspect
-    IMPORTING
-      iv_file TYPE string
-    RETURNING
-      VALUE(rs_result) TYPE ty_inspect_result.
-
-  METHODS run_tests
-    IMPORTING
-      iv_package TYPE devclass OPTIONAL
-      it_objects TYPE ty_object_keys OPTIONAL
-    RETURNING
-      VALUE(rs_result) TYPE ty_unit_result.
-
 ENDINTERFACE.

package/abap/zif_abgagt_command.intf.abap

@@ -5,7 +5,9 @@ INTERFACE zif_abgagt_command PUBLIC.
   CONSTANTS:
     gc_pull TYPE string VALUE 'PULL',
     gc_inspect TYPE string VALUE 'INSPECT',
-    gc_unit TYPE string VALUE 'UNIT'.
+    gc_unit TYPE string VALUE 'UNIT',
+    gc_create TYPE string VALUE 'CREATE',
+    gc_import TYPE string VALUE 'IMPORT'.
 
   " Get command name
   METHODS get_name