abap-local-client 1.4.6 → 1.4.9

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "abap-local-client",
-  "version": "1.4.6",
+  "version": "1.4.9",
   "description": "SAP Local Client — WebSocket bridge with Basic, SPNEGO, X.509, SAML & SNC authentication",
   "main": "sso-sap-client.mjs",
   "type": "module",

package/sso-sap-client.mjs

@@ -483,7 +483,7 @@ class SAPClient {
         return { success: !hasErrors && response.status >= 200 && response.status < 300, status: response.status, statusText: response.statusText, headers: response.headers, data: { raw: response.data, ...extractedData }, ...(errorMessages.length > 0 && { error: `SAP validation failed: ${errorMessages.join('; ')}`, errorDetails: errorMessages }) };
     } catch (err) {
         console.error(`   ❌ RFC error: ${err.message}`);
-        return { success: false, status: 0, error: err.message, data: null };
+        return { success: false, status: 0, statusText: 'RFC Error', error: err.message, data: { raw: null } };
     }
   }
 
@@ -583,11 +583,27 @@ class SAPClient {
         console.error(`   ❌ RESPONSE HEADERS:`);
         for (const [k, v] of Object.entries(error.response.headers)) console.error(`   ❌   ${k}: ${v}`);
       }
-      const resBody = typeof error.response?.data === 'string'
+      const rawBody = typeof error.response?.data === 'string'
         ? error.response.data
-        : JSON.stringify(error.response?.data);
-      if (resBody) console.error(`   ❌ RESPONSE BODY:\n${resBody}`);
-      return { success: false, status, error: error.message, data: error.response?.data };
+        : (error.response?.data ? JSON.stringify(error.response.data) : null);
+      if (rawBody) console.error(`   ❌ RESPONSE BODY:\n${rawBody}`);
+
+      // Extract the real SAP error message from the XML body (exc:exception, etc.)
+      const { hasErrors, errorMessages } = parseSAPResponse(rawBody || '');
+      const sapError = hasErrors ? errorMessages.join('; ') : null;
+      // Precedence: parsed SAP message > raw XML body > Axios generic message
+      // Sending rawBody as fallback ensures the MCP server always gets the full SAP response
+      // even when parseSAPResponse doesn't recognise the XML format.
+      const errorMsg = sapError || rawBody || error.message;
+      if (sapError) console.error(`   ❌ SAP error: ${sapError}`);
+
+      return {
+        success: false,
+        status,
+        statusText: error.response?.statusText,
+        error: errorMsg,
+        data: { raw: rawBody, ...(hasErrors && { errorMessages }) },
+      };
     }
   }
 

package/xml-utils.js

@@ -50,8 +50,22 @@ export function parseSAPResponse(xmlString) {
       }
     }
 
-    // Add other error patterns here if needed (e.g., activation errors, etc.)
-    
+    // exc:exception — generic SAP ADT error (e.g. SQL query syntax errors, 4xx responses)
+    const exc = parsed['exc:exception'];
+    if (exc) {
+      const msg = exc['message'] || exc['localizedMessage'] || exc['@_message'] || '';
+      const typeId = exc['type']?.['@_id'] || exc['namespace']?.['@_id'] || '';
+      const text = [msg, typeId].filter(Boolean).join(' — ');
+      if (text) return { hasErrors: true, errorMessages: [text], parsedData: parsed };
+    }
+
+    // iaex:exception — another SAP error envelope
+    const iaex = parsed['iaex:exception'];
+    if (iaex) {
+      const msg = iaex['iaex:message'] || iaex['message'] || '';
+      if (msg) return { hasErrors: true, errorMessages: [String(msg)], parsedData: parsed };
+    }
+
     return { hasErrors: false, errorMessages: [], parsedData: parsed };
   } catch (error) {
     console.error('   ⚠️  XML parsing failed:', error.message);

package/xml-utils.mjs

@@ -7,7 +7,8 @@ const xmlParser = new XMLParser({
 });
 
 /**
- * Parse SAP XML response and check for errors
+ * Parse SAP XML response and check for errors.
+ * Handles: chkrun syntax errors, exc:exception envelope, adtcore activation errors.
  * Returns: { hasErrors: boolean, errorMessages: string[], parsedData: object }
  */
 export function parseSAPResponse(xmlString) {
@@ -17,14 +18,14 @@ export function parseSAPResponse(xmlString) {
 
   try {
     const parsed = xmlParser.parse(xmlString);
-    
-    // Check for syntax check errors (chkrun:checkMessage with type="E")
+
+    // ── 1. Syntax check errors (chkrun:checkMessage with type="E") ──────────
     if (parsed['chkrun:checkRunReports']) {
       const report = parsed['chkrun:checkRunReports']['chkrun:checkReport'];
       const messageList = report?.['chkrun:checkMessageList'];
-      
+
       if (messageList && messageList['chkrun:checkMessage']) {
-        const messages = Array.isArray(messageList['chkrun:checkMessage']) 
+        const messages = Array.isArray(messageList['chkrun:checkMessage'])
           ? messageList['chkrun:checkMessage']
           : [messageList['chkrun:checkMessage']];
 
@@ -34,9 +35,7 @@ export function parseSAPResponse(xmlString) {
             let line = null;
             if (msg['@_chkrun:uri'] && msg['@_chkrun:uri'].includes('#start=')) {
               const match = msg['@_chkrun:uri'].match(/#start=(\d+),(\d+)/);
-              if (match) {
-                line = parseInt(match[1]);
-              }
+              if (match) line = parseInt(match[1]);
             }
             const text = msg['@_chkrun:shortText'] || 'Unknown error';
             const lineInfo = line ? ` (line ${line})` : '';
@@ -50,11 +49,43 @@ export function parseSAPResponse(xmlString) {
       }
     }
 
-    // Add other error patterns here if needed (e.g., activation errors, etc.)
-    
+    // ── 2. exc:exception — SAP ADT error envelope ────────────────────────────
+    // Used by: SQL queries, create object, activate, and most 4xx responses
+    // Formats seen:
+    //   <exc:exception xmlns:exc="http://www.sap.com/abapxml/types/exception">
+    //     <message>Syntax error in ABAP Open SQL: ...</message>
+    //   </exc:exception>
+    //   <exc:exception xmlns:exc="http://www.sap.com/abapxml/types/communicationframework">
+    //     <message lang="EN">Verificacao da condicao fracassou.</message>
+    //     <localizedMessage lang="PT">...</localizedMessage>
+    //   </exc:exception>
+    const excKey = Object.keys(parsed).find(k => k === 'exc:exception' || k.endsWith(':exception'));
+    if (excKey) {
+      const exc = parsed[excKey];
+      let msg = null;
+
+      const msgNode = exc?.message;
+      if (typeof msgNode === 'string') {
+        msg = msgNode;
+      } else if (typeof msgNode === 'object' && msgNode !== null) {
+        const msgs = Array.isArray(msgNode) ? msgNode : [msgNode];
+        const en = msgs.find(m => m['@_lang'] === 'EN' || m['@_xml:lang'] === 'EN');
+        msg = (en ? en['#text'] : msgs[0]?.['#text']) || null;
+      }
+
+      // fallback: localizedMessage
+      if (!msg) {
+        const loc = exc?.localizedMessage;
+        if (typeof loc === 'string') msg = loc;
+        else if (typeof loc === 'object' && loc !== null) msg = loc?.['#text'] || null;
+      }
+
+      if (msg) return { hasErrors: true, errorMessages: [msg], parsedData: parsed };
+    }
+
     return { hasErrors: false, errorMessages: [], parsedData: parsed };
-  } catch (error) {
-    console.error('   ⚠️  XML parsing failed:', error.message);
+  } catch (err) {
+    console.error('   XML parsing failed:', err.message);
     return { hasErrors: false, errorMessages: [], parsedData: null };
   }
 }