abap-local-client 1.4.0 → 1.4.2

package/config-cli.mjs

@@ -87,6 +87,10 @@ Usage:
   node config-cli.mjs show-config
       Show the full configuration (API key and passwords REDACTED).
 
+  node config-cli.mjs set-username <systemId> <sapUser>
+      Set the SAP username for a system (required for SNC connections).
+      Example: node config-cli.mjs set-username S4D FGALASTRI
+
   node config-cli.mjs arcanum-fallback <on|off>
       Enable or disable Arcanum fallback for unknown system IDs.
 
@@ -304,6 +308,26 @@ switch (command) {
         break;
     }
 
+    // ── set-username ────────────────────────────────────────────────────────
+    case 'set-username': {
+        const systemId = args[1];
+        const username = args[2];
+        if (!systemId || !username) {
+            console.error('Usage: node config-cli.mjs set-username <systemId> <sapUser>');
+            console.error('  Example: node config-cli.mjs set-username S4D FGALASTRI');
+            process.exit(1);
+        }
+        const sys = config.getSystem(systemId);
+        if (!sys) {
+            console.error(`System "${systemId}" not found. Run list-systems to see configured systems.`);
+            process.exit(1);
+        }
+        sys.connection = { ...(sys.connection || {}), username: username.toUpperCase() };
+        config.addOrUpdateSystem(systemId, sys);
+        console.log(`✅ Username for "${systemId}" set to: ${username.toUpperCase()}`);
+        break;
+    }
+
     // ── set-ws-url ──────────────────────────────────────────────────────────
     case 'set-ws-url': {
         const url = args[1];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "abap-local-client",
-  "version": "1.4.0",
+  "version": "1.4.2",
   "description": "SAP Local Client — WebSocket bridge with Basic, SPNEGO, X.509, SAML & SNC authentication",
   "main": "sso-sap-client.mjs",
   "type": "module",

package/sso-sap-client.mjs

@@ -16,6 +16,11 @@ import * as config from './config-manager.mjs';
 try { process.loadEnvFile?.(); } catch {}
 const env = process.env;
 
+/** Resolve the SAP username from connection config. For SNC, set conn.username explicitly. */
+function resolveUsername(conn) {
+    return (conn.username || '').toUpperCase();
+}
+
 // ════════════════════════════════════════════════════════════════════════════
 // Multi-system auth session cache
 // ════════════════════════════════════════════════════════════════════════════
@@ -63,13 +68,22 @@ async function _createSession(resolvedId) {
     let useRfc = (authMode === 'snc' || hasSaprouter);
 
     if (useRfc) {
-        console.log(`   🛰️  RFC mode (no HTTP)`);
-        rfcClient = new SAPRFCClient({
+        console.log(`   🛰️  RFC mode (${authMode === 'snc' ? 'SNC' : 'Basic'})`);
+        const rfcParams = {
             host: conn.host, sysnr: conn.sysnr || '00',
             client: conn.client || '100', username: conn.username || '',
             password: conn.password || '', language: conn.language || 'EN',
             saprouter: conn.saprouter || '',
-        });
+        };
+        if (authMode === 'snc') {
+            rfcParams.sncMode = '1';
+            if (conn.sncPartnerName) rfcParams.sncPartnerName = conn.sncPartnerName;
+            if (conn.sncMyName)      rfcParams.sncMyName      = conn.sncMyName;
+            if (conn.sncQop)         rfcParams.sncQop         = conn.sncQop;
+            if (conn.sncLib)         rfcParams.sncLib         = conn.sncLib;
+            console.log(`   🔐 SNC partner: ${conn.sncPartnerName || '(not set)'}`);
+        }
+        rfcClient = new SAPRFCClient(rfcParams);
         try {
             await rfcClient.connect();
             console.log(`   ✅ RFC connection established`);
@@ -85,8 +99,8 @@ async function _createSession(resolvedId) {
             conn.username || '', conn.password || '',
             { language: conn.language || 'EN' });
         await httpSession.init();
-    } else if (!useRfc && authMode === 'snc') {
-        throw new Error(`Auth mode not yet implemented: ${authMode}`);
+    } else if (!useRfc) {
+        throw new Error(`RFC connection required for auth mode "${authMode}" but failed to connect`);
     }
 
     return { useRfc, rfcClient, httpSession, authMode, sysConfig, resolvedId };
@@ -394,7 +408,7 @@ class SAPClient {
     if (typeof body === 'string') {
         const lang = conn.language || 'EN';
         const client = conn.client || '100';
-        const user = (conn.username || '').toUpperCase();
+        const user = resolveUsername(conn);
         body = body
             .replace(/<SAP_LANGUAGE>/g,      lang)
             .replace(/<SAP_CLIENT>/g,        client)
@@ -466,7 +480,7 @@ class SAPClient {
     if (typeof rawBody === 'string') {
         const conn2 = this.session?.sysConfig?.connection || {};
         const lang2 = conn2.language || 'EN';
-        const user2 = (conn2.username || '').toUpperCase();
+        const user2 = resolveUsername(conn2);
         rawBody = rawBody
             .replace(/<SAP_LANGUAGE>/g,      lang2)
             .replace(/<SAP_CLIENT>/g,        conn2.client || '100')
@@ -644,7 +658,8 @@ class WebSocketClient {
         if (!sys) { this.sendResponse(requestId, false, { error: `Unknown system: ${sid}` }); return; }
         this.currentSystemId = sid;
         this.lockManager.clearAll();
-        await this.initSapClient();
+        const ok = await this.initSapClient();
+        if (!ok) { this.sendResponse(requestId, false, { error: `Failed to connect to ${sid}. Check RFC/SNC config and logs.` }); return; }
         this.sendResponse(requestId, true, [{ success: true, data: { system: sid, authMode: sys.authMode } }]);
         return;
       }