@zzzen/pyright-internal 1.2.0-dev.20250309 → 1.2.0-dev.20250323

package/dist/analyzer/checker.js

@@ -92,6 +92,8 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
         this._scopedNodes = [];
         // A list of all visited type parameter lists.
         this._typeParamLists = [];
+        // A list of all visited multipart import statements.
+        this._multipartImports = [];
         this._moduleNode = parseResults.parseTree;
         this._fileInfo = AnalyzerNodeInfo.getFileInfo(this._moduleNode);
     }
@@ -116,6 +118,7 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
         // Perform a one-time validation of symbols in all scopes
         // defined in this module for things like unaccessed variables.
         this._validateSymbolTables();
+        this._reportUnusedMultipartImports();
         this._reportDuplicateImports();
     }
     walk(node) {
@@ -952,6 +955,10 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
     visitImportAs(node) {
         this._conditionallyReportShadowedImport(node);
         this._evaluator.evaluateTypesForStatement(node);
+        const nameParts = node.d.module.d.nameParts;
+        if (nameParts.length > 1 && !node.d.alias) {
+            this._multipartImports.push(node);
+        }
         return true;
     }
     visitImportFrom(node) {
@@ -1104,6 +1111,50 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
         // Don't explore further.
         return false;
     }
+    _reportUnusedMultipartImports() {
+        this._multipartImports.forEach((node) => {
+            const nameParts = node.d.module.d.nameParts;
+            if (this._isMultipartImportUnused(node)) {
+                const multipartName = nameParts.map((np) => np.d.value).join('.');
+                let textRange = { start: nameParts[0].start, length: nameParts[0].length };
+                textRange = textRange_1.TextRange.extend(textRange, nameParts[nameParts.length - 1]);
+                this._fileInfo.diagnosticSink.addUnusedCodeWithTextRange(localize_1.LocMessage.unaccessedSymbol().format({ name: multipartName }), textRange, { action: "pyright.unusedImport" /* Commands.unusedImport */ });
+                this._evaluator.addDiagnosticForTextRange(this._fileInfo, diagnosticRules_1.DiagnosticRule.reportUnusedImport, localize_1.LocMessage.unaccessedImport().format({ name: multipartName }), textRange);
+            }
+        });
+    }
+    _isMultipartImportUnused(node) {
+        const nameParts = node.d.module.d.nameParts;
+        (0, debug_1.assert)(nameParts.length > 1);
+        // Get the top-level module type associated with this import.
+        let moduleType = this._evaluator.evaluateTypeForSubnode(node, () => {
+            this._evaluator.evaluateTypesForStatement(node);
+        })?.type;
+        if (!moduleType || !(0, types_1.isModule)(moduleType)) {
+            return false;
+        }
+        // Walk the module hierarchy to get the submodules in the
+        // multi-name import path until we get to the second-to-the-last
+        // part.
+        for (let i = 1; i < nameParts.length - 1; i++) {
+            const symbol = types_1.ModuleType.getField(moduleType, nameParts[i].d.value);
+            if (!symbol) {
+                return false;
+            }
+            const submoduleType = symbol.getSynthesizedType();
+            if (!submoduleType || !(0, types_1.isModule)(submoduleType.type)) {
+                return false;
+            }
+            moduleType = submoduleType.type;
+        }
+        // Look up the last part of the import to get its symbol ID.
+        const lastPartName = nameParts[nameParts.length - 1].d.value;
+        const symbol = types_1.ModuleType.getField(moduleType, lastPartName);
+        if (!symbol) {
+            return false;
+        }
+        return !this._fileInfo.accessedSymbolSet.has(symbol.id);
+    }
     _getImportResult(node, uri) {
         const execEnv = this._importResolver.getConfigOptions().findExecEnvironment(uri);
         const moduleNameNode = node.parent.d.module;
@@ -1330,6 +1381,7 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
     // have overlapping types.
     _validateComparisonTypes(node) {
         let rightExpression = node.d.rightExpr;
+        const assumeIsOperator = node.d.operator === 39 /* OperatorType.Is */ || node.d.operator === 40 /* OperatorType.IsNot */;
         // Check for chained comparisons.
         if (rightExpression.nodeType === 7 /* ParseNodeType.BinaryOperation */ &&
             !rightExpression.d.hasParens &&
@@ -1382,7 +1434,7 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
                     if (isComparable) {
                         return;
                     }
-                    if (this._evaluator.isTypeComparable(leftSubtype, rightSubtype)) {
+                    if (this._evaluator.isTypeComparable(leftSubtype, rightSubtype, assumeIsOperator)) {
                         isComparable = true;
                     }
                     return rightSubtype;
@@ -2481,15 +2533,12 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
                         }
                     }
                     else {
-                        // Handle multi-part names specially.
                         const nameParts = decl.node.d.module.d.nameParts;
-                        if (nameParts.length > 0) {
-                            const multipartName = nameParts.map((np) => np.d.value).join('.');
-                            let textRange = { start: nameParts[0].start, length: nameParts[0].length };
-                            textRange = textRange_1.TextRange.extend(textRange, nameParts[nameParts.length - 1]);
-                            this._fileInfo.diagnosticSink.addUnusedCodeWithTextRange(localize_1.LocMessage.unaccessedSymbol().format({ name: multipartName }), textRange, { action: "pyright.unusedImport" /* Commands.unusedImport */ });
-                            this._evaluator.addDiagnosticForTextRange(this._fileInfo, diagnosticRules_1.DiagnosticRule.reportUnusedImport, localize_1.LocMessage.unaccessedImport().format({ name: multipartName }), textRange);
-                            return;
+                        // Multi-part imports are handled separately, so ignore those here.
+                        if (nameParts.length === 1) {
+                            nameNode = nameParts[0];
+                            this._evaluator.addDiagnostic(diagnosticRules_1.DiagnosticRule.reportUnusedImport, localize_1.LocMessage.unaccessedImport().format({ name: nameNode.d.value }), nameNode);
+                            message = localize_1.LocMessage.unaccessedImport().format({ name: nameNode.d.value });
                         }
                     }
                 }