@zzzen/pyright-internal 1.2.0-dev.20230820 → 1.2.0-dev.20230827

package/dist/analyzer/checker.js

@@ -48,6 +48,7 @@ const stringTokenUtils_1 = require("../parser/stringTokenUtils");
 const AnalyzerNodeInfo = __importStar(require("./analyzerNodeInfo"));
 const declaration_1 = require("./declaration");
 const declarationUtils_1 = require("./declarationUtils");
+const deprecatedSymbols_1 = require("./deprecatedSymbols");
 const importResolver_1 = require("./importResolver");
 const importStatementUtils_1 = require("./importStatementUtils");
 const parameterUtils_1 = require("./parameterUtils");
@@ -66,43 +67,6 @@ const typeGuards_1 = require("./typeGuards");
 const typeUtils_1 = require("./typeUtils");
 const typeVarContext_1 = require("./typeVarContext");
 const types_1 = require("./types");
-const deprecatedAliases = new Map([
-    ['Tuple', { version: pythonVersion_1.PythonVersion.V3_9, fullName: 'builtins.tuple', replacementText: 'tuple' }],
-    ['List', { version: pythonVersion_1.PythonVersion.V3_9, fullName: 'builtins.list', replacementText: 'list' }],
-    ['Dict', { version: pythonVersion_1.PythonVersion.V3_9, fullName: 'builtins.dict', replacementText: 'dict' }],
-    ['Set', { version: pythonVersion_1.PythonVersion.V3_9, fullName: 'builtins.set', replacementText: 'set' }],
-    ['FrozenSet', { version: pythonVersion_1.PythonVersion.V3_9, fullName: 'builtins.frozenset', replacementText: 'frozenset' }],
-    ['Type', { version: pythonVersion_1.PythonVersion.V3_9, fullName: 'builtins.type', replacementText: 'type' }],
-    ['Deque', { version: pythonVersion_1.PythonVersion.V3_9, fullName: 'collections.deque', replacementText: 'collections.deque' }],
-    [
-        'DefaultDict',
-        {
-            version: pythonVersion_1.PythonVersion.V3_9,
-            fullName: 'collections.defaultdict',
-            replacementText: 'collections.defaultdict',
-        },
-    ],
-    [
-        'OrderedDict',
-        {
-            version: pythonVersion_1.PythonVersion.V3_9,
-            fullName: 'collections.OrderedDict',
-            replacementText: 'collections.OrderedDict',
-        },
-    ],
-    [
-        'Counter',
-        { version: pythonVersion_1.PythonVersion.V3_9, fullName: 'collections.Counter', replacementText: 'collections.Counter' },
-    ],
-    [
-        'ChainMap',
-        { version: pythonVersion_1.PythonVersion.V3_9, fullName: 'collections.ChainMap', replacementText: 'collections.ChainMap' },
-    ],
-]);
-const deprecatedSpecialForms = new Map([
-    ['Optional', { version: pythonVersion_1.PythonVersion.V3_10, fullName: 'typing.Optional', replacementText: '| None' }],
-    ['Union', { version: pythonVersion_1.PythonVersion.V3_10, fullName: 'typing.Union', replacementText: '|' }],
-]);
 // When enabled, this debug flag causes the code complexity of
 // functions to be emitted.
 const isPrintCodeComplexityEnabled = false;
@@ -936,7 +900,8 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
     }
     visitMemberAccess(node) {
         const type = this._evaluator.getType(node);
-        this._reportDeprecatedUse(node.memberName, type);
+        const leftExprType = this._evaluator.getType(node.leftExpression);
+        this._reportDeprecatedUse(node.memberName, type, leftExprType && (0, types_1.isModule)(leftExprType) && leftExprType.moduleName === 'typing');
         this._conditionallyReportPrivateUsage(node.memberName);
         // Walk the leftExpression but not the memberName.
         this.walk(node.leftExpression);
@@ -975,7 +940,7 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
         return true;
     }
     visitImportFromAs(node) {
-        var _a;
+        var _a, _b;
         if (this._fileInfo.isStubFile) {
             return false;
         }
@@ -999,8 +964,16 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
             this._addMissingModuleSourceDiagnosticIfNeeded(importResult, node.name);
             break;
         }
-        const type = this._evaluator.getType((_a = node.alias) !== null && _a !== void 0 ? _a : node.name);
-        this._reportDeprecatedUse(node.name, type);
+        let isImportFromTyping = false;
+        if (((_a = node.parent) === null || _a === void 0 ? void 0 : _a.nodeType) === 22 /* ImportFrom */) {
+            if (node.parent.module.leadingDots === 0 && node.parent.module.nameParts.length === 1) {
+                if (node.parent.module.nameParts[0].value === 'typing') {
+                    isImportFromTyping = true;
+                }
+            }
+        }
+        const type = this._evaluator.getType((_b = node.alias) !== null && _b !== void 0 ? _b : node.name);
+        this._reportDeprecatedUse(node.name, type, isImportFromTyping);
         return false;
     }
     visitModuleName(node) {
@@ -1935,17 +1908,25 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
                         implementationFunction = type;
                     }
                     if (!implementationFunction) {
-                        let isProtocolMethod = false;
+                        let exemptMissingImplementation = false;
                         const containingClassNode = ParseTreeUtils.getEnclosingClassOrFunction(primaryDecl.node);
                         if (containingClassNode && containingClassNode.nodeType === 10 /* Class */) {
                             const classType = this._evaluator.getTypeOfClass(containingClassNode);
-                            if (classType && types_1.ClassType.isProtocolClass(classType.classType)) {
-                                isProtocolMethod = true;
+                            if (classType) {
+                                if (types_1.ClassType.isProtocolClass(classType.classType)) {
+                                    exemptMissingImplementation = true;
+                                }
+                                else if (types_1.ClassType.supportsAbstractMethods(classType.classType)) {
+                                    if ((0, types_1.isOverloadedFunction)(type) &&
+                                        types_1.OverloadedFunctionType.getOverloads(type).every((overload) => types_1.FunctionType.isAbstractMethod(overload))) {
+                                        exemptMissingImplementation = true;
+                                    }
+                                }
                             }
                         }
                         // If this is a method within a protocol class, don't require that
                         // there is an implementation.
-                        if (!isProtocolMethod) {
+                        if (!exemptMissingImplementation) {
                             this._evaluator.addDiagnostic(this._fileInfo.diagnosticRuleSet.reportGeneralTypeIssues, diagnosticRules_1.DiagnosticRule.reportGeneralTypeIssues, localize_1.Localizer.Diagnostic.overloadWithoutImplementation().format({
                                 name: primaryDecl.node.name.value,
                             }), primaryDecl.node.name);
@@ -2639,8 +2620,8 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
         }
         return false;
     }
-    _reportDeprecatedUse(node, type) {
-        var _a;
+    _reportDeprecatedUse(node, type, isImportFromTyping = false) {
+        var _a, _b;
         if (!type) {
             return;
         }
@@ -2717,24 +2698,25 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
                 this._evaluator.addDiagnostic(this._fileInfo.diagnosticRuleSet.reportDeprecated, diagnosticRules_1.DiagnosticRule.reportDeprecated, errorMessage + diag.getString(), node);
             }
         }
-        // We'll leave this disabled for now because this would be too noisy for most
-        // code bases. We may want to add it at some future date.
-        if (0) {
-            const deprecatedForm = (_a = deprecatedAliases.get(node.value)) !== null && _a !== void 0 ? _a : deprecatedSpecialForms.get(node.value);
+        if (this._fileInfo.diagnosticRuleSet.deprecateTypingAliases) {
+            const deprecatedForm = (_a = deprecatedSymbols_1.deprecatedAliases.get(node.value)) !== null && _a !== void 0 ? _a : deprecatedSymbols_1.deprecatedSpecialForms.get(node.value);
             if (deprecatedForm) {
-                if ((0, types_1.isInstantiableClass)(type) && type.details.fullName === deprecatedForm.fullName) {
+                if (((0, types_1.isInstantiableClass)(type) && type.details.fullName === deprecatedForm.fullName) ||
+                    ((_b = type.typeAliasInfo) === null || _b === void 0 ? void 0 : _b.fullName) === deprecatedForm.fullName) {
                     if (this._fileInfo.executionEnvironment.pythonVersion >= deprecatedForm.version) {
-                        if (this._fileInfo.diagnosticRuleSet.reportDeprecated === 'none') {
-                            this._evaluator.addDeprecated(localize_1.Localizer.Diagnostic.deprecatedType().format({
-                                version: (0, pythonVersion_1.versionToString)(deprecatedForm.version),
-                                replacement: deprecatedForm.replacementText,
-                            }), node);
-                        }
-                        else {
-                            this._evaluator.addDiagnostic(this._fileInfo.diagnosticRuleSet.reportDeprecated, diagnosticRules_1.DiagnosticRule.reportDeprecated, localize_1.Localizer.Diagnostic.deprecatedType().format({
-                                version: (0, pythonVersion_1.versionToString)(deprecatedForm.version),
-                                replacement: deprecatedForm.replacementText,
-                            }), node);
+                        if (!deprecatedForm.typingImportOnly || isImportFromTyping) {
+                            if (this._fileInfo.diagnosticRuleSet.reportDeprecated === 'none') {
+                                this._evaluator.addDeprecated(localize_1.Localizer.Diagnostic.deprecatedType().format({
+                                    version: (0, pythonVersion_1.versionToString)(deprecatedForm.version),
+                                    replacement: deprecatedForm.replacementText,
+                                }), node);
+                            }
+                            else {
+                                this._evaluator.addDiagnostic(this._fileInfo.diagnosticRuleSet.reportDeprecated, diagnosticRules_1.DiagnosticRule.reportDeprecated, localize_1.Localizer.Diagnostic.deprecatedType().format({
+                                    version: (0, pythonVersion_1.versionToString)(deprecatedForm.version),
+                                    replacement: deprecatedForm.replacementText,
+                                }), node);
+                            }
                         }
                     }
                 }
@@ -3961,7 +3943,7 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
         if (!(0, types_1.isInstantiableClass)(baseClassAndSymbol.classType)) {
             return;
         }
-        if (baseClassAndSymbol.symbol.isIgnoredForOverrideChecks()) {
+        if (baseClassAndSymbol.symbol.isIgnoredForOverrideChecks() || overrideSymbol.isIgnoredForOverrideChecks()) {
             return;
         }
         // If the base class doesn't provide a type declaration, we won't bother