@zzzen/pyright-internal 1.2.0-dev.20230723 → 1.2.0-dev.20230806

package/dist/analyzer/checker.js

@@ -387,7 +387,7 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
             }
             // Verify common dunder signatures.
             this._validateDunderSignatures(node, functionTypeResult.functionType, containingClassNode !== undefined);
-            // Verify TypeGuard or StrictTypeGuard functions.
+            // Verify TypeGuard functions.
             this._validateTypeGuardFunction(node, functionTypeResult.functionType, containingClassNode !== undefined);
             this._validateFunctionTypeVarUsage(node, functionTypeResult);
         }
@@ -2973,7 +2973,6 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
         });
     }
     _validateTypeGuardFunction(node, functionType, isMethod) {
-        var _a;
         const returnType = functionType.details.declaredReturnType;
         if (!returnType) {
             return;
@@ -2981,9 +2980,7 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
         if (!(0, types_1.isClassInstance)(returnType) || !returnType.typeArguments || returnType.typeArguments.length < 1) {
             return;
         }
-        const isNormalTypeGuard = types_1.ClassType.isBuiltIn(returnType, 'TypeGuard');
-        const isStrictTypeGuard = types_1.ClassType.isBuiltIn(returnType, 'StrictTypeGuard');
-        if (!isNormalTypeGuard && !isStrictTypeGuard) {
+        if (!types_1.ClassType.isBuiltIn(returnType, 'TypeGuard')) {
             return;
         }
         // Make sure there's at least one input parameter provided.
@@ -2998,25 +2995,6 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
         if (paramCount < 1) {
             this._evaluator.addDiagnostic(this._fileInfo.diagnosticRuleSet.reportGeneralTypeIssues, diagnosticRules_1.DiagnosticRule.reportGeneralTypeIssues, localize_1.Localizer.Diagnostic.typeGuardParamCount(), node.name);
         }
-        if (isStrictTypeGuard) {
-            const typeGuardType = returnType.typeArguments[0];
-            // Determine the type of the first parameter.
-            const paramIndex = isMethod && !types_1.FunctionType.isStaticMethod(functionType) ? 1 : 0;
-            if (paramIndex >= functionType.details.parameters.length) {
-                return;
-            }
-            const paramType = types_1.FunctionType.getEffectiveParameterType(functionType, paramIndex);
-            // Verify that the typeGuardType is a narrower type than the paramType.
-            if (!this._evaluator.assignType(paramType, typeGuardType)) {
-                const returnAnnotation = node.returnTypeAnnotation || ((_a = node.functionAnnotationComment) === null || _a === void 0 ? void 0 : _a.returnTypeAnnotation);
-                if (returnAnnotation) {
-                    this._evaluator.addDiagnostic(this._fileInfo.diagnosticRuleSet.reportGeneralTypeIssues, diagnosticRules_1.DiagnosticRule.reportGeneralTypeIssues, localize_1.Localizer.Diagnostic.strictTypeGuardReturnType().format({
-                        type: this._evaluator.printType(paramType),
-                        returnType: this._evaluator.printType(typeGuardType),
-                    }), returnAnnotation);
-                }
-            }
-        }
     }
     _validateDunderSignatures(node, functionType, isMethod) {
         var _a;
@@ -3071,7 +3049,9 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
                     // If the function consists entirely of "...", assume that it's
                     // an abstract method or a protocol method and don't require that
                     // the return type matches. This check can also be skipped for an overload.
-                    if (!ParseTreeUtils.isSuiteEmpty(node.suite) && !types_1.FunctionType.isOverloaded(functionType)) {
+                    if (!ParseTreeUtils.isSuiteEmpty(node.suite) &&
+                        !types_1.FunctionType.isOverloaded(functionType) &&
+                        !types_1.FunctionType.isAsync(functionType)) {
                         this._evaluator.addDiagnostic(this._fileInfo.diagnosticRuleSet.reportGeneralTypeIssues, diagnosticRules_1.DiagnosticRule.reportGeneralTypeIssues, localize_1.Localizer.Diagnostic.noReturnReturnsNone(), returnAnnotation);
                     }
                 }