@zzzen/pyright-internal 1.2.0-dev.20230212 → 1.2.0-dev.20230226

package/dist/analyzer/checker.js

@@ -1368,6 +1368,7 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
                     // other types, and ParamSpecs. There are legitimate uses for singleton
                     // instances in these particular cases.
                     let isExempt = nameType.details.constraints.length > 0 ||
+                        !!nameType.details.defaultType ||
                         (exemptBoundTypeVar &&
                             nameType.details.boundType !== undefined &&
                             subscriptIndex !== undefined) ||
@@ -1416,6 +1417,7 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
                 if (constructorClass && nameType.scopeId === constructorClass.details.typeVarScopeId) {
                     const existingEntry = classTypeVarUsage.get(nameType.details.name);
                     const isParamTypeWithEllipsisUsage = ((_d = curParamNode === null || curParamNode === void 0 ? void 0 : curParamNode.defaultValue) === null || _d === void 0 ? void 0 : _d.nodeType) === 18 /* Ellipsis */;
+                    const isExempt = !!nameType.details.defaultType;
                     if (!existingEntry) {
                         classTypeVarUsage.set(nameType.details.name, {
                             nodes: [nameNode],
@@ -1423,7 +1425,7 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
                             paramTypeWithEllipsisUsageCount: isParamTypeWithEllipsisUsage ? 1 : 0,
                             returnTypeUsageCount: 0,
                             paramWithEllipsis: isParamTypeWithEllipsisUsage ? (_e = curParamNode === null || curParamNode === void 0 ? void 0 : curParamNode.name) === null || _e === void 0 ? void 0 : _e.value : undefined,
-                            isExempt: false,
+                            isExempt,
                         });
                     }
                     else {
@@ -1501,7 +1503,8 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
         classTypeVarUsage.forEach((usage) => {
             var _a;
             if (usage.paramTypeWithEllipsisUsageCount > 0 &&
-                usage.paramTypeUsageCount === usage.paramTypeWithEllipsisUsageCount) {
+                usage.paramTypeUsageCount === usage.paramTypeWithEllipsisUsageCount &&
+                !usage.isExempt) {
                 const diag = new diagnostic_1.DiagnosticAddendum();
                 diag.addMessage(localize_1.Localizer.DiagnosticAddendum.typeVarUnsolvableRemedy());
                 this._evaluator.addDiagnostic(this._fileInfo.diagnosticRuleSet.reportInvalidTypeVarUse, diagnosticRules_1.DiagnosticRule.reportInvalidTypeVarUse, localize_1.Localizer.Diagnostic.typeVarPossiblyUnsolvable().format({
@@ -4123,10 +4126,13 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
         }
         const typeVarContext = new typeVarContext_1.TypeVarContext((0, typeUtils_1.getTypeVarScopeId)(functionType));
         if (!this._evaluator.assignType(paramType, expectedType, /* diag */ undefined, typeVarContext)) {
-            this._evaluator.addDiagnostic(this._fileInfo.diagnosticRuleSet.reportGeneralTypeIssues, diagnosticRules_1.DiagnosticRule.reportGeneralTypeIssues, localize_1.Localizer.Diagnostic.clsSelfParamTypeMismatch().format({
-                name: paramInfo.name,
-                classType: this._evaluator.printType(expectedType),
-            }), paramInfo.typeAnnotation);
+            // We exempt Never from this check because it has a legitimate use in this case.
+            if (!(0, types_1.isNever)(paramType)) {
+                this._evaluator.addDiagnostic(this._fileInfo.diagnosticRuleSet.reportGeneralTypeIssues, diagnosticRules_1.DiagnosticRule.reportGeneralTypeIssues, localize_1.Localizer.Diagnostic.clsSelfParamTypeMismatch().format({
+                    name: paramInfo.name,
+                    classType: this._evaluator.printType(expectedType),
+                }), paramInfo.typeAnnotation);
+            }
         }
     }
     _validateYieldType(node, yieldType) {