@zzzen/pyright-internal 1.2.0-dev.20220828 → 1.2.0-dev.20220904

package/dist/analyzer/typeEvaluator.js

@@ -699,6 +699,13 @@ function createTypeEvaluator(importLookup, evaluatorOptions) {
         /* allowSpeculativeCaching */ true);
         if (expectedType && !(0, types_1.isAnyOrUnknown)(expectedType) && !(0, types_1.isNever)(expectedType)) {
             expectedTypeCache.set(node.id, expectedType);
+            if (!typeResult.isIncomplete && !typeResult.expectedTypeDiagAddendum) {
+                const diag = new diagnostic_1.DiagnosticAddendum();
+                if (!assignType(expectedType, typeResult.type, diag)) {
+                    typeResult.expectedTypeDiagAddendum = diag;
+                    diag.addTextRange(node);
+                }
+            }
         }
         if (printExpressionTypes) {
             printExpressionSpaceCount--;
@@ -3857,7 +3864,7 @@ function createTypeEvaluator(importLookup, evaluatorOptions) {
                     }
                 }
                 if (enforceTargetType) {
-                    let effectiveType = concreteSubtype;
+                    let effectiveType = subtype;
                     // If the code is patching a method (defined on the class)
                     // with an object-level function, strip the "self" parameter
                     // off the original type. This is sometimes done for test
@@ -4736,19 +4743,21 @@ function createTypeEvaluator(importLookup, evaluatorOptions) {
             });
             effectiveExpectedType = matchingSubtype;
         }
+        let expectedTypeDiagAddendum;
         if (effectiveExpectedType) {
             const result = getTypeOfTupleExpected(node, effectiveExpectedType);
-            if (result) {
+            if (result && !result.typeErrors) {
                 return result;
             }
+            expectedTypeDiagAddendum = result === null || result === void 0 ? void 0 : result.expectedTypeDiagAddendum;
         }
-        const resultType = getTypeOfTupleInferred(node);
+        const typeResult = getTypeOfTupleInferred(node);
         // If there was an expected type of Any, replace the resulting type
         // with Any rather than return a type with unknowns.
         if (expectedTypeContainsAny) {
-            resultType.type = types_1.AnyType.create();
+            typeResult.type = types_1.AnyType.create();
         }
-        return resultType;
+        return { ...typeResult, expectedTypeDiagAddendum };
     }
     function getTypeOfTupleExpected(node, expectedType) {
         expectedType = (0, typeUtils_1.transformPossibleRecursiveTypeAlias)(expectedType);
@@ -4792,7 +4801,17 @@ function createTypeEvaluator(importLookup, evaluatorOptions) {
         /* flags */ undefined, index < expectedTypes.length ? expectedTypes[index] : undefined));
         const type = (0, typeUtils_1.convertToInstance)((0, typeUtils_1.specializeTupleClass)(tupleClassType, buildTupleTypesList(entryTypeResults), 
         /* isTypeArgumentExplicit */ true));
-        return { type };
+        // Copy any expected type diag addenda for precision error reporting.
+        let expectedTypeDiagAddendum;
+        if (entryTypeResults.some((result) => result.expectedTypeDiagAddendum)) {
+            expectedTypeDiagAddendum = new diagnostic_1.DiagnosticAddendum();
+            entryTypeResults.forEach((result) => {
+                if (result.expectedTypeDiagAddendum) {
+                    expectedTypeDiagAddendum.addAddendum(result.expectedTypeDiagAddendum);
+                }
+            });
+        }
+        return { type, expectedTypeDiagAddendum };
     }
     function getTypeOfTupleInferred(node) {
         const entryTypeResults = node.expressions.map((expr) => getTypeOfExpression(expr));
@@ -5815,8 +5834,7 @@ function createTypeEvaluator(importLookup, evaluatorOptions) {
                         // the call is a constructor but the proper TypeVar scope has been lost.
                         // We'll add a wildcard TypeVar scope here. This is a bit of a hack and
                         // we may need to revisit this in the future.
-                        if (!effectiveTypeVarContext.getSolveForScopes() &&
-                            types_1.FunctionType.isConstructorMethod(expandedSubtype)) {
+                        if (types_1.FunctionType.isConstructorMethod(expandedSubtype)) {
                             effectiveTypeVarContext.addSolveForScope(types_1.WildcardTypeVarScopeId);
                         }
                     }
@@ -6807,12 +6825,14 @@ function createTypeEvaluator(importLookup, evaluatorOptions) {
     // types of each argument expression and validates that the resulting type is
     // compatible with the declared type of the corresponding parameter.
     function validateFunctionArgumentTypesWithExpectedType(errorNode, matchResults, typeVarContext, skipUnknownArgCheck = false, expectedType) {
+        var _a;
         const type = matchResults.overload;
         if (!expectedType ||
             (0, types_1.isAnyOrUnknown)(expectedType) ||
             (0, types_1.isNever)(expectedType) ||
             (0, typeUtils_1.requiresSpecialization)(expectedType) ||
-            !type.details.declaredReturnType) {
+            !type.details.declaredReturnType ||
+            !(0, typeUtils_1.requiresSpecialization)((_a = types_1.FunctionType.getSpecializedReturnType(type)) !== null && _a !== void 0 ? _a : types_1.UnknownType.create())) {
             return validateFunctionArgumentTypes(errorNode, matchResults, typeVarContext, skipUnknownArgCheck);
         }
         const effectiveReturnType = getFunctionEffectiveReturnType(type);
@@ -8673,13 +8693,16 @@ function createTypeEvaluator(importLookup, evaluatorOptions) {
             });
             effectiveExpectedType = matchingSubtype;
         }
+        let expectedTypeDiagAddendum;
         if (effectiveExpectedType) {
             const result = getTypeOfListOrSetExpected(node, effectiveExpectedType);
-            if (result) {
+            if (result && !result.typeErrors) {
                 return result;
             }
+            expectedTypeDiagAddendum = result === null || result === void 0 ? void 0 : result.expectedTypeDiagAddendum;
         }
-        return getTypeOfListOrSetInferred(node, /* hasExpectedType */ expectedType !== undefined);
+        const typeResult = getTypeOfListOrSetInferred(node, /* hasExpectedType */ expectedType !== undefined);
+        return { ...typeResult, expectedTypeDiagAddendum };
     }
     // Attempts to determine the type of a list or set statement based on an expected type.
     // Returns undefined if that type cannot be honored.
@@ -8705,6 +8728,7 @@ function createTypeEvaluator(importLookup, evaluatorOptions) {
         }
         const expectedEntryType = specializedListOrSet.typeArguments[0];
         const entryTypes = [];
+        const expectedTypeDiagAddendum = new diagnostic_1.DiagnosticAddendum();
         node.entries.forEach((entry) => {
             let entryTypeResult;
             if (entry.nodeType === 32 /* ListComprehension */) {
@@ -8720,15 +8744,18 @@ function createTypeEvaluator(importLookup, evaluatorOptions) {
             if (entryTypeResult.typeErrors) {
                 typeErrors = true;
             }
+            if (entryTypeResult.expectedTypeDiagAddendum) {
+                expectedTypeDiagAddendum.addAddendum(entryTypeResult.expectedTypeDiagAddendum);
+            }
         });
         const isExpectedTypeListOrSet = (0, types_1.isClassInstance)(expectedType) && types_1.ClassType.isBuiltIn(expectedType, builtInClassName);
         const specializedEntryType = inferTypeArgFromExpectedType(expectedEntryType, entryTypes, 
         /* isNarrowable */ !isExpectedTypeListOrSet);
         if (!specializedEntryType) {
-            return undefined;
+            return { type: types_1.UnknownType.create(), isIncomplete, typeErrors: true, expectedTypeDiagAddendum };
         }
         const type = getBuiltInObject(node, builtInClassName, [specializedEntryType]);
-        return { type, isIncomplete, typeErrors };
+        return { type, isIncomplete, typeErrors, expectedTypeDiagAddendum };
     }
     // Attempts to infer the type of a list or set statement with no "expected type".
     function getTypeOfListOrSetInferred(node, hasExpectedType) {
@@ -10366,6 +10393,9 @@ function createTypeEvaluator(importLookup, evaluatorOptions) {
         node.arguments.forEach((arg) => {
             // Ignore unpacked arguments.
             if (arg.argumentCategory !== 0 /* Simple */) {
+                // Evaluate the expression's type so symbols are marked accessed
+                // and errors are reported.
+                getTypeOfExpression(arg.valueExpression);
                 return;
             }
             if (!arg.name) {
@@ -10633,7 +10663,7 @@ function createTypeEvaluator(importLookup, evaluatorOptions) {
         if (metaclassNode) {
             const metaclassType = getTypeOfExpression(metaclassNode, exprFlags).type;
             if ((0, types_1.isInstantiableClass)(metaclassType) || (0, types_1.isUnknown)(metaclassType)) {
-                if ((0, typeUtils_1.requiresSpecialization)(metaclassType)) {
+                if ((0, typeUtils_1.requiresSpecialization)(metaclassType, /* ignorePseudoGeneric */ true)) {
                     addDiagnostic(fileInfo.diagnosticRuleSet.reportGeneralTypeIssues, diagnosticRules_1.DiagnosticRule.reportGeneralTypeIssues, localize_1.Localizer.Diagnostic.metaclassIsGeneric(), metaclassNode);
                 }
                 classType.details.declaredMetaclass = metaclassType;
@@ -10699,25 +10729,29 @@ function createTypeEvaluator(importLookup, evaluatorOptions) {
             // See if there's already a non-synthesized __init__ method.
             // We shouldn't override it.
             if (!skipSynthesizedInit) {
-                const initSymbol = (0, typeUtils_1.lookUpClassMember)(classType, '__init__', 2 /* SkipBaseClasses */);
+                const initSymbol = (0, typeUtils_1.lookUpClassMember)(classType, '__init__', 4 /* SkipObjectBaseClass */);
                 if (initSymbol) {
-                    const initSymbolType = getTypeOfMember(initSymbol);
-                    if ((0, types_1.isFunction)(initSymbolType)) {
-                        if (!types_1.FunctionType.isSynthesizedMethod(initSymbolType)) {
+                    if (!(0, types_1.isClass)(initSymbol.classType) || !types_1.ClassType.isBuiltIn(initSymbol.classType, 'NamedTuple')) {
+                        const initSymbolType = getTypeOfMember(initSymbol);
+                        if ((0, types_1.isFunction)(initSymbolType)) {
+                            if (!types_1.FunctionType.isSynthesizedMethod(initSymbolType)) {
+                                hasExistingInitMethod = true;
+                            }
+                        }
+                        else {
                             hasExistingInitMethod = true;
                         }
                     }
-                    else {
-                        hasExistingInitMethod = true;
-                    }
                 }
             }
             let skipSynthesizeHash = false;
-            const hashSymbol = (0, typeUtils_1.lookUpClassMember)(classType, '__hash__', 2 /* SkipBaseClasses */);
+            const hashSymbol = (0, typeUtils_1.lookUpClassMember)(classType, '__hash__', 4 /* SkipObjectBaseClass */);
             if (hashSymbol) {
-                const hashSymbolType = getTypeOfMember(hashSymbol);
-                if ((0, types_1.isFunction)(hashSymbolType) && !types_1.FunctionType.isSynthesizedMethod(hashSymbolType)) {
-                    skipSynthesizeHash = true;
+                if (!(0, types_1.isClass)(hashSymbol.classType) || !types_1.ClassType.isBuiltIn(hashSymbol.classType, 'NamedTuple')) {
+                    const hashSymbolType = getTypeOfMember(hashSymbol);
+                    if ((0, types_1.isFunction)(hashSymbolType) && !types_1.FunctionType.isSynthesizedMethod(hashSymbolType)) {
+                        skipSynthesizeHash = true;
+                    }
                 }
             }
             (0, dataClasses_1.synthesizeDataClassMethods)(evaluatorInterface, node, classType, skipSynthesizedInit, hasExistingInitMethod, skipSynthesizeHash);
@@ -14603,16 +14637,11 @@ function createTypeEvaluator(importLookup, evaluatorOptions) {
         // If the source is unbounded, expand the unbounded argument to try
         // to make the source and dest arg counts match.
         if (srcUnboundedIndex >= 0) {
-            const requiredSrcArgCount = destVariadicIndex >= 0 || destUnboundedIndex >= 0 ? destTypeArgs.length - 1 : destTypeArgs.length;
             const typeToReplicate = srcTypeArgs.length > 0 ? srcTypeArgs[srcUnboundedIndex].type : types_1.AnyType.create();
-            while (srcTypeArgs.length < requiredSrcArgCount) {
-                srcTypeArgs.splice(srcUnboundedIndex, 0, { type: typeToReplicate, isUnbounded: false });
+            while (srcTypeArgs.length < destTypeArgs.length) {
+                srcTypeArgs.splice(srcUnboundedIndex, 0, { type: typeToReplicate, isUnbounded: true });
             }
         }
-        if (destVariadicIndex >= 0 && srcUnboundedIndex >= 0) {
-            diag === null || diag === void 0 ? void 0 : diag.addMessage(localize_1.Localizer.DiagnosticAddendum.typeVarTupleRequiresKnownLength());
-            return false;
-        }
         // If the dest is unbounded or contains a variadic, determine which
         // source args map to the unbounded or variadic arg.
         if (destUnboundedIndex >= 0 || destVariadicIndex >= 0) {
@@ -14625,7 +14654,7 @@ function createTypeEvaluator(importLookup, evaluatorOptions) {
                         const removedArgs = srcTypeArgs.splice(destVariadicIndex, srcArgsToCapture);
                         // Package up the remaining type arguments into a tuple object.
                         const variadicTuple = (0, typeUtils_1.convertToInstance)((0, typeUtils_1.specializeTupleClass)(tupleClassType, removedArgs.map((typeArg) => {
-                            return { type: stripLiteralValue(typeArg.type), isUnbounded: false };
+                            return { type: stripLiteralValue(typeArg.type), isUnbounded: typeArg.isUnbounded };
                         }), 
                         /* isTypeArgumentExplicit */ true, 
                         /* isUnpackedTuple */ true));
@@ -14683,13 +14712,20 @@ function createTypeEvaluator(importLookup, evaluatorOptions) {
     // specified inheritance chain, taking into account its type arguments.
     function assignClassWithTypeArgs(destType, srcType, inheritanceChain, diag, destTypeVarContext, srcTypeVarContext, flags, recursionCount) {
         let curSrcType = srcType;
-        let curTypeVarContext = destTypeVarContext !== null && destTypeVarContext !== void 0 ? destTypeVarContext : new typeVarContext_1.TypeVarContext((0, typeUtils_1.getTypeVarScopeId)(destType));
+        let curTypeVarContext = destTypeVarContext;
         let effectiveFlags = flags;
         inferTypeParameterVarianceForClass(destType);
-        // If we're using a private typeVarContext, don't skip solving type vars.
+        effectiveFlags |= 8 /* SkipSolveTypeVars */;
         if (!destTypeVarContext) {
+            curTypeVarContext = new typeVarContext_1.TypeVarContext((0, typeUtils_1.getTypeVarScopeId)(destType));
             effectiveFlags &= ~8 /* SkipSolveTypeVars */;
         }
+        else {
+            // If we're using the caller's type var context, don't solve the
+            // type vars in this pass. We'll do this after we're done looping
+            // through the inheritance chain.
+            effectiveFlags |= 8 /* SkipSolveTypeVars */;
+        }
         for (let ancestorIndex = inheritanceChain.length - 1; ancestorIndex >= 0; ancestorIndex--) {
             const ancestorType = inheritanceChain[ancestorIndex];
             // If we've hit an "unknown", all bets are off, and we need to assume
@@ -14857,22 +14893,11 @@ function createTypeEvaluator(importLookup, evaluatorOptions) {
         if ((0, types_1.isUnion)(srcType) && srcType.subtypes.length === 1 && (0, types_1.isVariadicTypeVar)(srcType.subtypes[0])) {
             srcType = srcType.subtypes[0];
         }
-        if (destType === srcType) {
-            // If the dest type is a TypeVar and a typeVarContext was provided, we may
-            // need to assign the TypeVar to itself under certain circumstances.
-            // This is needed for cases where generic class A[T] calls its own
-            // constructor with an argument of type T.
-            if ((0, types_1.isTypeVar)(destType) &&
-                !destType.details.isParamSpec &&
-                !destType.details.isVariadic &&
-                destType.scopeType === 0 /* Class */ &&
-                destTypeVarContext &&
-                !destTypeVarContext.isLocked() &&
-                destTypeVarContext.hasSolveForScope(destType.scopeId) &&
-                !destTypeVarContext.getTypeVar(destType) &&
-                (flags & (8 /* SkipSolveTypeVars */ | 2 /* ReverseTypeVarMatching */)) === 0) {
-                destTypeVarContext.setTypeVarType(destType, srcType);
-            }
+        // Handle the case where the dest and src types are the same object.
+        // We can normally shortcut this and say that they are compatible,
+        // but if the type includes TypeVars, we need to go through
+        // the rest of the logic.
+        if (destType === srcType && !(0, typeUtils_1.requiresSpecialization)(destType)) {
             return true;
         }
         if (recursionCount > types_1.maxTypeRecursionCount) {
@@ -14928,13 +14953,26 @@ function createTypeEvaluator(importLookup, evaluatorOptions) {
         // Before performing any other checks, see if the dest type is a
         // TypeVar that we are attempting to match.
         if ((0, types_1.isTypeVar)(destType)) {
+            if ((0, types_1.isTypeSame)(destType, srcType)) {
+                if (destType.scopeId && (destTypeVarContext === null || destTypeVarContext === void 0 ? void 0 : destTypeVarContext.hasSolveForScope(destType.scopeId))) {
+                    return (0, constraintSolver_1.assignTypeToTypeVar)(evaluatorInterface, destType, srcType, diag, destTypeVarContext, flags, recursionCount);
+                }
+                return true;
+            }
             // If the dest is a constrained or bound type variable and all of the
             // types in the source are conditioned on that same type variable
             // and have compatible types, we'll consider it assignable.
             if (assignConditionalTypeToTypeVar(destType, srcType, recursionCount)) {
                 return true;
             }
-            if ((0, types_1.isTypeSame)(destType, srcType)) {
+            // If the source is a conditional type associated with a bound TypeVar
+            // and the bound TypeVar matches the condition, the types are compatible.
+            const destTypeVar = destType;
+            if (types_1.TypeBase.isInstantiable(destType) === types_1.TypeBase.isInstantiable(srcType) &&
+                srcType.condition &&
+                srcType.condition.some((cond) => {
+                    return !cond.isConstrainedTypeVar && cond.typeVarName === destTypeVar.nameWithScope;
+                })) {
                 return true;
             }
             if ((0, types_1.isUnion)(srcType)) {
@@ -15456,7 +15494,7 @@ function createTypeEvaluator(importLookup, evaluatorOptions) {
         // For union sources, all of the types need to be assignable to the dest.
         let isIncompatible = false;
         // Sort the subtypes so we have a deterministic order for unions.
-        (0, typeUtils_1.doForEachSubtype)(srcType, (subtype, subtypeIndex) => {
+        (0, typeUtils_1.doForEachSubtype)(srcType, (subtype, subtypeIndex, allSubtypes) => {
             if (isIncompatible) {
                 return;
             }
@@ -15466,7 +15504,7 @@ function createTypeEvaluator(importLookup, evaluatorOptions) {
                 // Determine if the current subtype is subsumed by another subtype
                 // in the same union. If so, we can ignore this.
                 let isSubtypeSubsumed = false;
-                (0, typeUtils_1.doForEachSubtype)(srcType, (innerSubtype, innerSubtypeIndex) => {
+                allSubtypes.forEach((innerSubtype, innerSubtypeIndex) => {
                     if (isSubtypeSubsumed || subtypeIndex === innerSubtypeIndex || (0, types_1.isAnyOrUnknown)(innerSubtype)) {
                         return;
                     }
@@ -15807,7 +15845,9 @@ function createTypeEvaluator(importLookup, evaluatorOptions) {
         let specializedDestType = destType;
         let reverseMatchingFailed = false;
         if ((flags & 2 /* ReverseTypeVarMatching */) === 0) {
-            specializedDestType = (0, typeUtils_1.applySolvedTypeVars)(destType, destTypeVarContext);
+            specializedDestType = (0, typeUtils_1.applySolvedTypeVars)(destType, destTypeVarContext, 
+            /* unknownIfNotFound */ undefined, 
+            /* useNarrowBoundOnly */ true);
             if ((0, typeUtils_1.requiresSpecialization)(specializedDestType)) {
                 reverseMatchingFailed = !assignType(specializedSrcType, specializedDestType, 
                 /* diag */ undefined, srcTypeVarContext, destTypeVarContext, (flags ^ 2 /* ReverseTypeVarMatching */) |
@@ -15817,7 +15857,9 @@ function createTypeEvaluator(importLookup, evaluatorOptions) {
             }
         }
         else {
-            specializedSrcType = (0, typeUtils_1.applySolvedTypeVars)(srcType, srcTypeVarContext);
+            specializedSrcType = (0, typeUtils_1.applySolvedTypeVars)(srcType, srcTypeVarContext, 
+            /* unknownIfNotFound */ undefined, 
+            /* useNarrowBoundOnly */ true);
             if ((0, typeUtils_1.requiresSpecialization)(specializedSrcType)) {
                 reverseMatchingFailed = !assignType(specializedSrcType, specializedDestType, 
                 /* diag */ undefined, srcTypeVarContext, destTypeVarContext, (flags ^ 2 /* ReverseTypeVarMatching */) |