@zzzen/pyright-internal 1.2.0-dev.20220821 → 1.2.0-dev.20220911

package/dist/analyzer/checker.d.ts

@@ -67,6 +67,7 @@ export declare class Checker extends ParseTreeWalker {
     private _validateExhaustiveMatch;
     private _suppressUnboundCheck;
     private _validateIllegalDefaultParamInitializer;
+    private _validateStandardCollectionInstantiation;
     private _validateContainmentTypes;
     private _validateComparisonTypes;
     private _isTypeComparable;

package/dist/analyzer/checker.js

@@ -440,6 +440,7 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
         var _a;
         this._validateIsInstanceCall(node);
         this._validateIllegalDefaultParamInitializer(node);
+        this._validateStandardCollectionInstantiation(node);
         if (this._fileInfo.diagnosticRuleSet.reportUnusedCallResult !== 'none' ||
             this._fileInfo.diagnosticRuleSet.reportUnusedCoroutine !== 'none') {
             if (((_a = node.parent) === null || _a === void 0 ? void 0 : _a.nodeType) === 47 /* StatementList */) {
@@ -948,8 +949,21 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
             40 /* Number */,
             11 /* Constant */,
             38 /* Name */,
+            52 /* Tuple */,
         ];
+        let reportAsUnused = false;
         if (simpleExpressionTypes.some((nodeType) => nodeType === node.nodeType)) {
+            reportAsUnused = true;
+        }
+        else if (node.nodeType === 31 /* List */ ||
+            node.nodeType === 45 /* Set */ ||
+            node.nodeType === 15 /* Dictionary */) {
+            // Exclude comprehensions.
+            if (!node.entries.some((entry) => entry.nodeType === 32 /* ListComprehension */)) {
+                reportAsUnused = true;
+            }
+        }
+        if (reportAsUnused) {
             this._evaluator.addDiagnostic(this._fileInfo.diagnosticRuleSet.reportUnusedExpression, diagnosticRules_1.DiagnosticRule.reportUnusedExpression, localize_1.Localizer.Diagnostic.unusedExpression(), node);
         }
     }
@@ -987,6 +1001,22 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
             }
         }
     }
+    _validateStandardCollectionInstantiation(node) {
+        const leftType = this._evaluator.getType(node.leftExpression);
+        if (leftType &&
+            (0, types_1.isInstantiableClass)(leftType) &&
+            types_1.ClassType.isBuiltIn(leftType) &&
+            !leftType.includeSubclasses &&
+            leftType.aliasName) {
+            const nonInstantiable = ['List', 'Set', 'Dict', 'Tuple'];
+            if (nonInstantiable.some((name) => name === leftType.aliasName)) {
+                this._evaluator.addDiagnostic(this._fileInfo.diagnosticRuleSet.reportGeneralTypeIssues, diagnosticRules_1.DiagnosticRule.reportGeneralTypeIssues, localize_1.Localizer.Diagnostic.collectionAliasInstantiation().format({
+                    type: leftType.aliasName,
+                    alias: leftType.details.name,
+                }), node.leftExpression);
+            }
+        }
+    }
     _validateContainmentTypes(node) {
         const leftType = this._evaluator.getType(node.leftExpression);
         const containerType = this._evaluator.getType(node.rightExpression);