@zzzen/pyright-internal 1.2.0-dev.2022-07-02 → 1.2.0-dev.20220717

package/dist/analyzer/checker.js

@@ -50,8 +50,8 @@ const importStatementUtils_1 = require("./importStatementUtils");
 const ParseTreeUtils = __importStar(require("./parseTreeUtils"));
 const parseTreeWalker_1 = require("./parseTreeWalker");
 const patternMatching_1 = require("./patternMatching");
-const protocols_1 = require("./protocols");
 const scopeUtils_1 = require("./scopeUtils");
+const sourceFile_1 = require("./sourceFile");
 const sourceMapper_1 = require("./sourceMapper");
 const staticExpressions_1 = require("./staticExpressions");
 const SymbolNameUtils = __importStar(require("./symbolNameUtils"));
@@ -111,6 +111,8 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
         // A list of all nodes that are defined within the module that
         // have their own scopes.
         this._scopedNodes = [];
+        // A list of all visited type parameter lists.
+        this._typeParameterLists = [];
         this._fileInfo = AnalyzerNodeInfo.getFileInfo(_moduleNode);
     }
     check() {
@@ -156,6 +158,9 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
     }
     visitClass(node) {
         const classTypeResult = this._evaluator.getTypeOfClass(node);
+        if (node.typeParameters) {
+            this.walk(node.typeParameters);
+        }
         this.walk(node.suite);
         this.walkMultiple(node.decorators);
         this.walkMultiple(node.arguments);
@@ -211,6 +216,9 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
     }
     visitFunction(node) {
         var _a;
+        if (node.typeParameters) {
+            this.walk(node.typeParameters);
+        }
         const functionTypeResult = this._evaluator.getTypeOfFunction(node);
         const containingClassNode = ParseTreeUtils.getEnclosingClass(node, /* stopAtFunction */ true);
         if (functionTypeResult) {
@@ -320,7 +328,7 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
                 if (annotationNode && index < functionTypeResult.functionType.details.parameters.length) {
                     const paramType = functionTypeResult.functionType.details.parameters[index].type;
                     if ((0, types_1.isTypeVar)(paramType) &&
-                        paramType.details.variance === 1 /* Covariant */ &&
+                        paramType.details.declaredVariance === 3 /* Covariant */ &&
                         !paramType.details.isSynthesized &&
                         functionTypeResult.functionType.details.name !== '__init__') {
                         this._evaluator.addDiagnostic(this._fileInfo.diagnosticRuleSet.reportGeneralTypeIssues, diagnosticRules_1.DiagnosticRule.reportGeneralTypeIssues, localize_1.Localizer.Diagnostic.paramTypeCovariant(), annotationNode);
@@ -378,14 +386,19 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
         }
         this._scopedNodes.push(node);
         if (functionTypeResult && (0, types_1.isOverloadedFunction)(functionTypeResult.decoratedType)) {
-            const overloads = functionTypeResult.decoratedType.overloads;
-            if (overloads.length > 1) {
-                const maxOverloadConsistencyCheckLength = 100;
-                // The check is n^2 in time, so if the number of overloads
-                // is very large (which can happen for some generated code),
-                // skip this check to avoid quadratic analysis time.
-                if (overloads.length < maxOverloadConsistencyCheckLength) {
-                    this._validateOverloadConsistency(node, overloads[overloads.length - 1], overloads.slice(0, overloads.length - 1));
+            // If this is the implementation for the overloaded function, skip
+            // overload consistency checks.
+            if (types_1.OverloadedFunctionType.getImplementation(functionTypeResult.decoratedType) !==
+                functionTypeResult.functionType) {
+                const overloads = types_1.OverloadedFunctionType.getOverloads(functionTypeResult.decoratedType);
+                if (overloads.length > 1) {
+                    const maxOverloadConsistencyCheckLength = 100;
+                    // The check is n^2 in time, so if the number of overloads
+                    // is very large (which can happen for some generated code),
+                    // skip this check to avoid quadratic analysis time.
+                    if (overloads.length < maxOverloadConsistencyCheckLength) {
+                        this._validateOverloadConsistency(node, overloads[overloads.length - 1], overloads.slice(0, overloads.length - 1));
+                    }
                 }
             }
         }
@@ -854,6 +867,13 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
         }
         return false;
     }
+    visitTypeParameterList(node) {
+        this._typeParameterLists.push(node);
+        return true;
+    }
+    visitTypeParameter(node) {
+        return false;
+    }
     visitTypeAnnotation(node) {
         this._evaluator.getType(node.typeAnnotation);
         return true;
@@ -1270,9 +1290,7 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
     _validateOverloadConsistency(node, functionType, prevOverloads) {
         for (let i = 0; i < prevOverloads.length; i++) {
             const prevOverload = prevOverloads[i];
-            if (types_1.FunctionType.isOverloaded(functionType) &&
-                types_1.FunctionType.isOverloaded(prevOverload) &&
-                this._isOverlappingOverload(functionType, prevOverload)) {
+            if (this._isOverlappingOverload(functionType, prevOverload)) {
                 this._evaluator.addDiagnostic(this._fileInfo.diagnosticRuleSet.reportOverlappingOverload, diagnosticRules_1.DiagnosticRule.reportOverlappingOverload, localize_1.Localizer.Diagnostic.overlappingOverload().format({
                     name: node.name.value,
                     obscured: prevOverloads.length + 1,
@@ -1283,9 +1301,7 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
         }
         for (let i = 0; i < prevOverloads.length; i++) {
             const prevOverload = prevOverloads[i];
-            if (types_1.FunctionType.isOverloaded(functionType) &&
-                types_1.FunctionType.isOverloaded(prevOverload) &&
-                this._isOverlappingOverload(prevOverload, functionType)) {
+            if (this._isOverlappingOverload(prevOverload, functionType)) {
                 const prevReturnType = types_1.FunctionType.getSpecializedReturnType(prevOverload);
                 const returnType = types_1.FunctionType.getSpecializedReturnType(functionType);
                 if (prevReturnType &&
@@ -1313,7 +1329,7 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
             return undefined;
         }
         for (const decl of decls) {
-            if (decl.type === 3 /* Function */) {
+            if (decl.type === 5 /* Function */) {
                 const functionType = this._evaluator.getTypeOfFunction(decl.node);
                 if ((functionType === null || functionType === void 0 ? void 0 : functionType.functionType) === overloadType) {
                     return decl.node;
@@ -1373,7 +1389,7 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
                     const start = statement.start;
                     const lastStatement = statements[statements.length - 1];
                     const end = textRange_1.TextRange.getEnd(lastStatement);
-                    this._evaluator.addUnusedCode(statement, { start, length: end - start });
+                    this._evaluator.addUnreachableCode(statement, { start, length: end - start });
                     reportedUnreachable = true;
                 }
             }
@@ -1542,15 +1558,32 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
                 });
             }
         }
+        // Report unaccessed type parameters.
+        const accessedSymbolSet = this._fileInfo.accessedSymbolSet;
+        for (const paramList of this._typeParameterLists) {
+            for (const param of paramList.parameters) {
+                const symbol = AnalyzerNodeInfo.getTypeParameterSymbol(param.name);
+                (0, debug_1.assert)(symbol);
+                if (!accessedSymbolSet.has(symbol.id)) {
+                    const decls = symbol.getDeclarations();
+                    decls.forEach((decl) => {
+                        this._conditionallyReportUnusedDeclaration(decl, /* isPrivate */ false);
+                    });
+                }
+            }
+        }
     }
     _reportInvalidOverload(name, symbol) {
         const typedDecls = symbol.getTypedDeclarations();
         if (typedDecls.length >= 1) {
             const primaryDecl = typedDecls[0];
-            if (primaryDecl.type === 3 /* Function */) {
+            if (primaryDecl.type === 5 /* Function */) {
                 const type = this._evaluator.getEffectiveTypeOfSymbol(symbol);
-                const functions = (0, types_1.isOverloadedFunction)(type) ? type.overloads : (0, types_1.isFunction)(type) ? [type] : [];
-                const overloadedFunctions = functions.filter((func) => types_1.FunctionType.isOverloaded(func));
+                const overloadedFunctions = (0, types_1.isOverloadedFunction)(type)
+                    ? types_1.OverloadedFunctionType.getOverloads(type)
+                    : (0, types_1.isFunction)(type) && types_1.FunctionType.isOverloaded(type)
+                        ? [type]
+                        : [];
                 if (overloadedFunctions.length === 1) {
                     // There should never be a single overload.
                     this._evaluator.addDiagnostic(this._fileInfo.diagnosticRuleSet.reportGeneralTypeIssues, diagnosticRules_1.DiagnosticRule.reportGeneralTypeIssues, localize_1.Localizer.Diagnostic.singleOverload().format({ name }), primaryDecl.node.name);
@@ -1567,9 +1600,8 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
                 // verify that there is an implementation.
                 if (!this._fileInfo.isStubFile && overloadedFunctions.length > 0) {
                     let implementationFunction;
-                    if ((0, types_1.isOverloadedFunction)(type) &&
-                        !types_1.FunctionType.isOverloaded(type.overloads[type.overloads.length - 1])) {
-                        implementationFunction = type.overloads[type.overloads.length - 1];
+                    if ((0, types_1.isOverloadedFunction)(type) && types_1.OverloadedFunctionType.getImplementation(type)) {
+                        implementationFunction = types_1.OverloadedFunctionType.getImplementation(type);
                     }
                     else if ((0, types_1.isFunction)(type) && !types_1.FunctionType.isOverloaded(type)) {
                         implementationFunction = type;
@@ -1593,11 +1625,8 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
                     }
                     else if ((0, types_1.isOverloadedFunction)(type)) {
                         // Verify that all overload signatures are assignable to implementation signature.
-                        type.overloads.forEach((overload, index) => {
+                        types_1.OverloadedFunctionType.getOverloads(type).forEach((overload, index) => {
                             var _a, _b, _c, _d;
-                            if (overload === implementationFunction || !types_1.FunctionType.isOverloaded(overload)) {
-                                return;
-                            }
                             const diag = new diagnostic_1.DiagnosticAddendum();
                             if (!this._isLegalOverloadImplementation(overload, implementationFunction, diag)) {
                                 if (implementationFunction.details.declaration) {
@@ -1697,10 +1726,10 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
         let otherDecls = symbol.getDeclarations().filter((decl) => decl !== primaryDecl);
         // If it's a function, we can skip any other declarations
         // that are overloads or property setters/deleters.
-        if (primaryDecl.type === 3 /* Function */) {
+        if (primaryDecl.type === 5 /* Function */) {
             const primaryDeclTypeInfo = this._evaluator.getTypeOfFunction(primaryDecl.node);
             otherDecls = otherDecls.filter((decl) => {
-                if (decl.type !== 3 /* Function */) {
+                if (decl.type !== 5 /* Function */) {
                     return true;
                 }
                 const funcTypeInfo = this._evaluator.getTypeOfFunction(decl.node);
@@ -1728,7 +1757,7 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
             return;
         }
         let primaryDeclInfo;
-        if (primaryDecl.type === 3 /* Function */) {
+        if (primaryDecl.type === 5 /* Function */) {
             if (primaryDecl.isMethod) {
                 primaryDeclInfo = localize_1.Localizer.DiagnosticAddendum.seeMethodDeclaration();
             }
@@ -1736,7 +1765,7 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
                 primaryDeclInfo = localize_1.Localizer.DiagnosticAddendum.seeFunctionDeclaration();
             }
         }
-        else if (primaryDecl.type === 4 /* Class */) {
+        else if (primaryDecl.type === 6 /* Class */) {
             primaryDeclInfo = localize_1.Localizer.DiagnosticAddendum.seeClassDeclaration();
         }
         else if (primaryDecl.type === 2 /* Parameter */) {
@@ -1745,13 +1774,16 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
         else if (primaryDecl.type === 1 /* Variable */) {
             primaryDeclInfo = localize_1.Localizer.DiagnosticAddendum.seeVariableDeclaration();
         }
+        else if (primaryDecl.type === 4 /* TypeAlias */) {
+            primaryDeclInfo = localize_1.Localizer.DiagnosticAddendum.seeTypeAliasDeclaration();
+        }
         else {
             primaryDeclInfo = localize_1.Localizer.DiagnosticAddendum.seeDeclaration();
         }
         const addPrimaryDeclInfo = (diag) => {
             if (diag) {
                 let primaryDeclNode;
-                if (primaryDecl.type === 3 /* Function */ || primaryDecl.type === 4 /* Class */) {
+                if (primaryDecl.type === 5 /* Function */ || primaryDecl.type === 6 /* Class */) {
                     primaryDeclNode = primaryDecl.node.name;
                 }
                 else if (primaryDecl.type === 1 /* Variable */) {
@@ -1759,7 +1791,8 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
                         primaryDeclNode = primaryDecl.node;
                     }
                 }
-                else if (primaryDecl.type === 2 /* Parameter */) {
+                else if (primaryDecl.type === 2 /* Parameter */ ||
+                    primaryDecl.type === 3 /* TypeParameter */) {
                     if (primaryDecl.node.name) {
                         primaryDeclNode = primaryDecl.node.name;
                     }
@@ -1770,11 +1803,19 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
             }
         };
         for (const otherDecl of otherDecls) {
-            if (otherDecl.type === 4 /* Class */) {
-                const diag = this._evaluator.addDiagnostic(this._fileInfo.diagnosticRuleSet.reportGeneralTypeIssues, diagnosticRules_1.DiagnosticRule.reportGeneralTypeIssues, localize_1.Localizer.Diagnostic.obscuredClassDeclaration().format({ name }), otherDecl.node.name);
-                addPrimaryDeclInfo(diag);
+            if (otherDecl.type === 6 /* Class */) {
+                let duplicateIsOk = false;
+                if (primaryDecl.type === 3 /* TypeParameter */) {
+                    // The error will be reported elsewhere if a type parameter is
+                    // involved, so don't report it here.
+                    duplicateIsOk = true;
+                }
+                if (!duplicateIsOk) {
+                    const diag = this._evaluator.addDiagnostic(this._fileInfo.diagnosticRuleSet.reportGeneralTypeIssues, diagnosticRules_1.DiagnosticRule.reportGeneralTypeIssues, localize_1.Localizer.Diagnostic.obscuredClassDeclaration().format({ name }), otherDecl.node.name);
+                    addPrimaryDeclInfo(diag);
+                }
             }
-            else if (otherDecl.type === 3 /* Function */) {
+            else if (otherDecl.type === 5 /* Function */) {
                 const primaryType = this._evaluator.getTypeForDeclaration(primaryDecl);
                 let duplicateIsOk = false;
                 // If the return type has not yet been inferred, do so now.
@@ -1797,6 +1838,11 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
                 if (!isInSameStatementList && primaryType && otherType && (0, types_1.isTypeSame)(primaryType, otherType)) {
                     duplicateIsOk = true;
                 }
+                if (primaryDecl.type === 3 /* TypeParameter */) {
+                    // The error will be reported elsewhere if a type parameter is
+                    // involved, so don't report it here.
+                    duplicateIsOk = true;
+                }
                 if (!duplicateIsOk) {
                     const diag = this._evaluator.addDiagnostic(this._fileInfo.diagnosticRuleSet.reportGeneralTypeIssues, diagnosticRules_1.DiagnosticRule.reportGeneralTypeIssues, otherDecl.isMethod
                         ? localize_1.Localizer.Diagnostic.obscuredMethodDeclaration().format({ name })
@@ -1806,8 +1852,17 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
             }
             else if (otherDecl.type === 2 /* Parameter */) {
                 if (otherDecl.node.name) {
-                    const diag = this._evaluator.addDiagnostic(this._fileInfo.diagnosticRuleSet.reportGeneralTypeIssues, diagnosticRules_1.DiagnosticRule.reportGeneralTypeIssues, localize_1.Localizer.Diagnostic.obscuredParameterDeclaration().format({ name }), otherDecl.node.name);
-                    addPrimaryDeclInfo(diag);
+                    let duplicateIsOk = false;
+                    if (primaryDecl.type === 3 /* TypeParameter */) {
+                        // The error will be reported elsewhere if a type parameter is
+                        // involved, so don't report it here.
+                        duplicateIsOk = true;
+                    }
+                    if (!duplicateIsOk) {
+                        const message = localize_1.Localizer.Diagnostic.obscuredParameterDeclaration();
+                        const diag = this._evaluator.addDiagnostic(this._fileInfo.diagnosticRuleSet.reportGeneralTypeIssues, diagnosticRules_1.DiagnosticRule.reportGeneralTypeIssues, message.format({ name }), otherDecl.node.name);
+                        addPrimaryDeclInfo(diag);
+                    }
                 }
             }
             else if (otherDecl.type === 1 /* Variable */) {
@@ -1820,6 +1875,11 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
                         if (primaryType && otherType && (0, types_1.isTypeSame)(primaryType, otherType)) {
                             duplicateIsOk = true;
                         }
+                        if (primaryDecl.type === 3 /* TypeParameter */) {
+                            // The error will be reported elsewhere if a type parameter is
+                            // involved, so don't report it here.
+                            duplicateIsOk = true;
+                        }
                         if (!duplicateIsOk) {
                             const diag = this._evaluator.addDiagnostic(this._fileInfo.diagnosticRuleSet.reportGeneralTypeIssues, diagnosticRules_1.DiagnosticRule.reportGeneralTypeIssues, localize_1.Localizer.Diagnostic.obscuredVariableDeclaration().format({ name }), otherDecl.node);
                             addPrimaryDeclInfo(diag);
@@ -1827,11 +1887,17 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
                     }
                 }
             }
+            else if (otherDecl.type === 4 /* TypeAlias */) {
+                const diag = this._evaluator.addDiagnostic(this._fileInfo.diagnosticRuleSet.reportGeneralTypeIssues, diagnosticRules_1.DiagnosticRule.reportGeneralTypeIssues, localize_1.Localizer.Diagnostic.obscuredTypeAliasDeclaration().format({ name }), otherDecl.node.name);
+                addPrimaryDeclInfo(diag);
+            }
         }
     }
     _conditionallyReportUnusedSymbol(name, symbol, scopeType) {
         const accessedSymbolSet = this._fileInfo.accessedSymbolSet;
-        if (symbol.isIgnoredForProtocolMatch() || accessedSymbolSet.has(symbol.id)) {
+        if (symbol.isIgnoredForProtocolMatch() ||
+            accessedSymbolSet.has(symbol.id) ||
+            this._fileInfo.ipythonMode === sourceFile_1.IPythonMode.CellDocs) {
             return;
         }
         // A name of "_" means "I know this symbol isn't used", so
@@ -1853,7 +1919,7 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
         let message;
         let rule;
         switch (decl.type) {
-            case 6 /* Alias */:
+            case 8 /* Alias */:
                 diagnosticLevel = this._fileInfo.diagnosticRuleSet.reportUnusedImport;
                 rule = diagnosticRules_1.DiagnosticRule.reportUnusedImport;
                 if (decl.node.nodeType === 21 /* ImportAs */) {
@@ -1892,6 +1958,7 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
                     message = localize_1.Localizer.Diagnostic.unaccessedImport().format({ name: nameNode.value });
                 }
                 break;
+            case 4 /* TypeAlias */:
             case 1 /* Variable */:
             case 2 /* Parameter */:
                 if (!isPrivate) {
@@ -1913,7 +1980,7 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
                 }
                 else if (decl.node.nodeType === 41 /* Parameter */) {
                     nameNode = decl.node.name;
-                    // Don't emit a diagnostic for unused parameters.
+                    // Don't emit a diagnostic for unused parameters or type parameters.
                     diagnosticLevel = 'none';
                 }
                 if (nameNode) {
@@ -1921,7 +1988,7 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
                     message = localize_1.Localizer.Diagnostic.unaccessedVariable().format({ name: nameNode.value });
                 }
                 break;
-            case 4 /* Class */:
+            case 6 /* Class */:
                 if (!isPrivate) {
                     return;
                 }
@@ -1935,7 +2002,7 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
                 rule = diagnosticRules_1.DiagnosticRule.reportUnusedClass;
                 message = localize_1.Localizer.Diagnostic.unaccessedClass().format({ name: nameNode.value });
                 break;
-            case 3 /* Function */:
+            case 5 /* Function */:
                 if (!isPrivate) {
                     return;
                 }
@@ -1949,13 +2016,23 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
                 rule = diagnosticRules_1.DiagnosticRule.reportUnusedFunction;
                 message = localize_1.Localizer.Diagnostic.unaccessedFunction().format({ name: nameNode.value });
                 break;
-            default:
+            case 3 /* TypeParameter */:
+                // Never report a diagnostic for an unused TypeParameter.
+                diagnosticLevel = 'none';
+                nameNode = decl.node.name;
+                break;
+            case 0 /* Intrinsic */:
+            case 7 /* SpecialBuiltInClass */:
                 return;
+            default:
+                (0, debug_1.assertNever)(decl);
         }
-        if (nameNode && rule !== undefined && message) {
-            const action = rule === diagnosticRules_1.DiagnosticRule.reportUnusedImport ? { action: "pyright.unusedImport" /* unusedImport */ } : undefined;
+        const action = rule === diagnosticRules_1.DiagnosticRule.reportUnusedImport ? { action: "pyright.unusedImport" /* unusedImport */ } : undefined;
+        if (nameNode) {
             this._fileInfo.diagnosticSink.addUnusedCodeWithTextRange(localize_1.Localizer.Diagnostic.unaccessedSymbol().format({ name: nameNode.value }), nameNode, action);
-            this._evaluator.addDiagnostic(diagnosticLevel, rule, message, nameNode);
+            if (rule !== undefined && message) {
+                this._evaluator.addDiagnostic(diagnosticLevel, rule, message, nameNode);
+            }
         }
     }
     // Validates that a call to isinstance or issubclass are necessary. This is a
@@ -2288,7 +2365,7 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
         if (!primaryDeclaration || primaryDeclaration.node === node) {
             return;
         }
-        if (primaryDeclaration.type === 6 /* Alias */) {
+        if (primaryDeclaration.type === 8 /* Alias */) {
             // If this symbol is an import alias (i.e. it's a local name rather than the
             // original imported name), skip the private check.
             if (primaryDeclaration.usesLocalName) {
@@ -2474,7 +2551,8 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
                     }), returnAnnotation);
                 }
                 const diag = new diagnostic_1.DiagnosticAddendum();
-                if ((0, types_1.isTypeVar)(declaredReturnType) && declaredReturnType.details.variance === 2 /* Contravariant */) {
+                if ((0, types_1.isTypeVar)(declaredReturnType) &&
+                    declaredReturnType.details.declaredVariance === 4 /* Contravariant */) {
                     diag.addMessage(localize_1.Localizer.DiagnosticAddendum.typeVarIsContravariant().format({
                         name: types_1.TypeVarType.getReadableName(declaredReturnType),
                     }));
@@ -2604,7 +2682,7 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
                         }
                     }
                 }
-                else if (decls[0].type === 3 /* Function */) {
+                else if (decls[0].type === 5 /* Function */) {
                     if (ParseTreeUtils.isSuiteEmpty(decls[0].node.suite) && decls[0]) {
                         if ((0, pathUtils_1.getFileExtension)(decls[0].path).toLowerCase() !== '.pyi') {
                             if (!isSymbolImplemented(name)) {
@@ -2793,9 +2871,8 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
     // the proper variance (invariant, covariant, contravariant). See PEP 544
     // for an explanation for why this is important to enforce.
     _validateProtocolTypeParamVariance(errorNode, classType) {
-        const origTypeParams = classType.details.typeParameters.filter((typeParam) => !(0, types_1.isParamSpec)(typeParam));
-        // If this isn't a generic protocol, there's nothing to do here.
-        if (origTypeParams.length === 0) {
+        // If this protocol has no TypeVars with specified variance, there's nothing to do here.
+        if (classType.details.typeParameters.length === 0) {
             return;
         }
         const objectType = this._evaluator.getBuiltInType(errorNode, 'object');
@@ -2803,13 +2880,17 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
             return;
         }
         // Replace all of the type parameters with invariant TypeVars.
-        const updatedTypeParams = origTypeParams.map((typeParam) => (0, types_1.isVariadicTypeVar)(typeParam) ? typeParam : types_1.TypeVarType.cloneAsInvariant(typeParam));
+        const updatedTypeParams = classType.details.typeParameters.map((typeParam) => types_1.TypeVarType.cloneAsInvariant(typeParam));
         const updatedClassType = types_1.ClassType.cloneWithNewTypeParameters(classType, updatedTypeParams);
         const objectObject = types_1.ClassType.cloneAsInstance(objectType);
-        const dummyTypeObject = types_1.ClassType.createInstantiable('__protocolVarianceDummy', '', '', '', 0, 0, undefined, undefined);
+        const dummyTypeObject = types_1.ClassType.createInstantiable('__varianceDummy', '', '', '', 0, 0, undefined, undefined);
         updatedTypeParams.forEach((param, paramIndex) => {
-            // Skip variadics.
-            if (param.details.isVariadic) {
+            // Skip variadics and ParamSpecs.
+            if (param.details.isVariadic || param.details.isParamSpec) {
+                return;
+            }
+            // Skip type variables with auto-variance.
+            if (param.details.declaredVariance === 0 /* Auto */) {
                 return;
             }
             // Replace all type arguments with a dummy type except for the
@@ -2829,29 +2910,29 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
             /* isTypeArgumentExplicit */ true);
             const destType = types_1.ClassType.cloneForSpecialization(updatedClassType, destTypeArgs, 
             /* isTypeArgumentExplicit */ true);
-            const isDestSubtypeOfSrc = (0, protocols_1.assignProtocolClassToSelf)(this._evaluator, srcType, destType);
+            const isDestSubtypeOfSrc = this._evaluator.assignClassToSelf(srcType, destType);
             let expectedVariance;
             if (isDestSubtypeOfSrc) {
-                expectedVariance = 1 /* Covariant */;
+                expectedVariance = 3 /* Covariant */;
             }
             else {
-                const isSrcSubtypeOfDest = (0, protocols_1.assignProtocolClassToSelf)(this._evaluator, destType, srcType);
+                const isSrcSubtypeOfDest = this._evaluator.assignClassToSelf(destType, srcType);
                 if (isSrcSubtypeOfDest) {
-                    expectedVariance = 2 /* Contravariant */;
+                    expectedVariance = 4 /* Contravariant */;
                 }
                 else {
-                    expectedVariance = 0 /* Invariant */;
+                    expectedVariance = 2 /* Invariant */;
                 }
             }
-            if (expectedVariance !== origTypeParams[paramIndex].details.variance) {
+            if (expectedVariance !== classType.details.typeParameters[paramIndex].details.declaredVariance) {
                 let message;
-                if (expectedVariance === 1 /* Covariant */) {
+                if (expectedVariance === 3 /* Covariant */) {
                     message = localize_1.Localizer.Diagnostic.protocolVarianceCovariant().format({
                         variable: param.details.name,
                         class: classType.details.name,
                     });
                 }
-                else if (expectedVariance === 2 /* Contravariant */) {
+                else if (expectedVariance === 4 /* Contravariant */) {
                     message = localize_1.Localizer.Diagnostic.protocolVarianceContravariant().format({
                         variable: param.details.name,
                         class: classType.details.name,
@@ -2931,7 +3012,7 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
         }
         if ((0, types_1.isOverloadedFunction)(newMemberType)) {
             // Find the implementation, not the overloaded signatures.
-            newMemberType = newMemberType.overloads.find((func) => !types_1.FunctionType.isOverloaded(func));
+            newMemberType = types_1.OverloadedFunctionType.getImplementation(newMemberType);
             if (!newMemberType) {
                 return;
             }
@@ -2946,7 +3027,7 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
         }
         if ((0, types_1.isOverloadedFunction)(initMemberType)) {
             // Find the implementation, not the overloaded signatures.
-            initMemberType = initMemberType.overloads.find((func) => !types_1.FunctionType.isOverloaded(func));
+            initMemberType = types_1.OverloadedFunctionType.getImplementation(initMemberType);
             if (!initMemberType) {
                 return;
             }
@@ -3084,9 +3165,9 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
             }
             else if ((0, types_1.isOverloadedFunction)(overrideType)) {
                 // Use the last overload.
-                overrideFunction = overrideType.overloads[overrideType.overloads.length - 1];
+                overrideFunction = types_1.OverloadedFunctionType.getImplementation(overrideType);
                 // If the last overload isn't an implementation, skip the check for this symbol.
-                if (types_1.FunctionType.isOverloaded(overrideFunction)) {
+                if (!overrideFunction) {
                     return;
                 }
             }
@@ -3094,7 +3175,7 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
                 if (!this._evaluator.validateOverrideMethod(baseType, overrideFunction, diagAddendum, 
                 /* enforceParamNameMatch */ true)) {
                     const decl = overrideFunction.details.declaration;
-                    if (decl && decl.type === 3 /* Function */) {
+                    if (decl && decl.type === 5 /* Function */) {
                         diag = this._evaluator.addDiagnostic(this._fileInfo.diagnosticRuleSet.reportIncompatibleMethodOverride, diagnosticRules_1.DiagnosticRule.reportIncompatibleMethodOverride, localize_1.Localizer.Diagnostic.baseClassMethodTypeIncompatible().format({
                             classType: childClassType.details.name,
                             name: memberName,
@@ -3154,7 +3235,7 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
             }
             // If the symbol has no declaration, and the type is inferred,
             // skip this check.
-            if (!symbol.hasTypedDeclarations()) {
+            if (!symbol.hasTypedDeclarations() && !(0, symbolUtils_1.isFinalVariable)(symbol)) {
                 return;
             }
             // Get the symbol type defined in this class.
@@ -3182,7 +3263,6 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
         });
     }
     _validateBaseClassOverride(baseClassAndSymbol, overrideSymbol, overrideType, childClassType, memberName) {
-        var _a;
         if (!(0, types_1.isInstantiableClass)(baseClassAndSymbol.classType)) {
             return;
         }
@@ -3200,15 +3280,7 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
         const baseType = (0, typeUtils_1.partiallySpecializeType)(this._evaluator.getEffectiveTypeOfSymbol(baseClassAndSymbol.symbol), baseClassAndSymbol.classType);
         if ((0, types_1.isFunction)(baseType) || (0, types_1.isOverloadedFunction)(baseType)) {
             const diagAddendum = new diagnostic_1.DiagnosticAddendum();
-            let overrideFunction;
-            if ((0, types_1.isFunction)(overrideType)) {
-                overrideFunction = overrideType;
-            }
-            else if ((0, types_1.isOverloadedFunction)(overrideType)) {
-                // Use the last overload.
-                overrideFunction = overrideType.overloads[overrideType.overloads.length - 1];
-            }
-            if (overrideFunction) {
+            if ((0, types_1.isFunction)(overrideType) || (0, types_1.isOverloadedFunction)(overrideType)) {
                 const exemptMethods = ['__init__', '__new__', '__init_subclass__'];
                 // Don't enforce parameter names for dundered methods. Many of them
                 // are misnamed in typeshed stubs, so this would result in many
@@ -3217,13 +3289,15 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
                 // Don't check certain magic functions or private symbols.
                 if (!exemptMethods.some((exempt) => exempt === memberName) &&
                     !SymbolNameUtils.isPrivateName(memberName)) {
-                    if (!this._evaluator.validateOverrideMethod(baseType, overrideFunction, diagAddendum, enforceParamNameMatch)) {
-                        const decl = (_a = overrideFunction.details.declaration) !== null && _a !== void 0 ? _a : (0, symbolUtils_1.getLastTypedDeclaredForSymbol)(overrideSymbol);
+                    if (!this._evaluator.validateOverrideMethod(baseType, overrideType, diagAddendum, enforceParamNameMatch)) {
+                        const decl = (0, types_1.isFunction)(overrideType) && overrideType.details.declaration
+                            ? overrideType.details.declaration
+                            : (0, symbolUtils_1.getLastTypedDeclaredForSymbol)(overrideSymbol);
                         if (decl) {
                             const diag = this._evaluator.addDiagnostic(this._fileInfo.diagnosticRuleSet.reportIncompatibleMethodOverride, diagnosticRules_1.DiagnosticRule.reportIncompatibleMethodOverride, localize_1.Localizer.Diagnostic.incompatibleMethodOverride().format({
                                 name: memberName,
                                 className: baseClassAndSymbol.classType.details.name,
-                            }) + diagAddendum.getString(), decl.type === 3 /* Function */ ? decl.node.name : decl.node);
+                            }) + diagAddendum.getString(), decl.type === 5 /* Function */ ? decl.node.name : decl.node);
                             const origDecl = (0, symbolUtils_1.getLastTypedDeclaredForSymbol)(baseClassAndSymbol.symbol);
                             if (diag && origDecl) {
                                 diag.addRelatedInfo(localize_1.Localizer.DiagnosticAddendum.overriddenMethod(), origDecl.path, origDecl.range);
@@ -3235,7 +3309,7 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
                     // Private names (starting with double underscore) are exempt from this check.
                     if (!SymbolNameUtils.isPrivateName(memberName) && types_1.FunctionType.isFinal(baseType)) {
                         const decl = (0, symbolUtils_1.getLastTypedDeclaredForSymbol)(overrideSymbol);
-                        if (decl && decl.type === 3 /* Function */) {
+                        if (decl && decl.type === 5 /* Function */) {
                             const diag = this._evaluator.addError(localize_1.Localizer.Diagnostic.finalMethodOverride().format({
                                 name: memberName,
                                 className: baseClassAndSymbol.classType.details.name,
@@ -3317,7 +3391,7 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
                                             name: methodName,
                                         }));
                                         const decl = subclassMethodType.details.declaration;
-                                        if (decl && decl.type === 3 /* Function */) {
+                                        if (decl && decl.type === 5 /* Function */) {
                                             const diag = this._evaluator.addDiagnostic(this._fileInfo.diagnosticRuleSet.reportIncompatibleMethodOverride, diagnosticRules_1.DiagnosticRule.reportIncompatibleMethodOverride, localize_1.Localizer.Diagnostic.propertyOverridden().format({
                                                 name: memberName,
                                                 className: baseClassType.details.name,
@@ -3355,6 +3429,18 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
                             diag.addRelatedInfo(localize_1.Localizer.DiagnosticAddendum.overriddenSymbol(), origDecl.path, origDecl.range);
                         }
                     }
+                    // Verify that there is not a Final mismatch.
+                    const isBaseVarFinal = (0, symbolUtils_1.isFinalVariable)(baseClassAndSymbol.symbol);
+                    const overrideFinalVarDecl = decls.find((d) => (0, declarationUtils_1.isFinalVariableDeclaration)(d));
+                    if (!isBaseVarFinal && overrideFinalVarDecl) {
+                        const diag = this._evaluator.addDiagnostic(this._fileInfo.diagnosticRuleSet.reportIncompatibleVariableOverride, diagnosticRules_1.DiagnosticRule.reportIncompatibleVariableOverride, localize_1.Localizer.Diagnostic.variableFinalOverride().format({
+                            name: memberName,
+                            className: baseClassAndSymbol.classType.details.name,
+                        }), lastDecl.node);
+                        if (diag) {
+                            diag.addRelatedInfo(localize_1.Localizer.DiagnosticAddendum.overriddenSymbol(), overrideFinalVarDecl.path, overrideFinalVarDecl.range);
+                        }
+                    }
                     // Verify that a class variable isn't overriding an instance
                     // variable or vice versa.
                     const isBaseClassVar = baseClassAndSymbol.symbol.isClassVar();
@@ -3368,7 +3454,7 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
                         }
                         // If the subclass is declaring an inner class, we'll consider that
                         // to be a ClassVar.
-                        if (overrideSymbol.getTypedDeclarations().every((decl) => decl.type === 4 /* Class */)) {
+                        if (overrideSymbol.getTypedDeclarations().every((decl) => decl.type === 6 /* Class */)) {
                             isClassVar = true;
                         }
                     }
@@ -3689,7 +3775,7 @@ class Checker extends parseTreeWalker_1.ParseTreeWalker {
                 // Were all of the exception types overridden?
                 if (typesOfThisExcept.length === overriddenExceptionCount) {
                     this._evaluator.addDiagnostic(this._fileInfo.diagnosticRuleSet.reportGeneralTypeIssues, diagnosticRules_1.DiagnosticRule.reportGeneralTypeIssues, localize_1.Localizer.Diagnostic.unreachableExcept() + diagAddendum.getString(), except.typeExpression);
-                    this._evaluator.addUnusedCode(except, except.exceptSuite);
+                    this._evaluator.addUnreachableCode(except, except.exceptSuite);
                 }
             }
             exceptionTypesSoFar.push(...typesOfThisExcept);