@zukhruf/eslint 0.6.11 → 0.6.13
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +5 -3
- package/dist/class-state/no-phase-flag.d.ts.map +1 -1
- package/dist/class-state/no-phase-flag.js +107 -38
- package/dist/class-state/no-phase-flag.js.map +1 -1
- package/dist/environment/no-undeclared-process-env.d.ts.map +1 -1
- package/dist/environment/no-undeclared-process-env.js +38 -26
- package/dist/environment/no-undeclared-process-env.js.map +1 -1
- package/dist/hermes/no-compact-notation.d.ts +7 -0
- package/dist/hermes/no-compact-notation.d.ts.map +1 -0
- package/dist/hermes/no-compact-notation.js +15 -0
- package/dist/hermes/no-compact-notation.js.map +1 -0
- package/dist/hermes/plugin.d.ts +1 -0
- package/dist/hermes/plugin.d.ts.map +1 -1
- package/dist/hermes/plugin.js +6 -1
- package/dist/hermes/plugin.js.map +1 -1
- package/dist/island/no-generic-port.d.ts +0 -5
- package/dist/island/no-generic-port.d.ts.map +1 -1
- package/dist/island/no-generic-port.js +40 -8
- package/dist/island/no-generic-port.js.map +1 -1
- package/dist/react.d.ts.map +1 -1
- package/dist/react.js +2 -0
- package/dist/react.js.map +1 -1
- package/package.json +6 -2
package/README.md
CHANGED
|
@@ -222,15 +222,16 @@ It gives these configs, in this order:
|
|
|
222
222
|
2. `flat.recommended` of `eslint-plugin-react-hooks`: the rules of the React team.
|
|
223
223
|
3. `recommended-type-checked` of `@eslint-react/eslint-plugin`: the React rules, for example `@eslint-react/no-missing-key`. The rules use type information. `zukhruf/base` gives it, because it sets `projectService`.
|
|
224
224
|
4. `disable-conflict-eslint-plugin-react-hooks` of `@eslint-react/eslint-plugin`: it turns off the 12 rules of `eslint-plugin-react-hooks` that `@eslint-react/eslint-plugin` also has.
|
|
225
|
+
5. `strict` of `eslint-plugin-react-you-might-not-need-an-effect`: its 10 rules report an effect that React does not need, for example state derived from props or an event handler run from an effect. `strict` makes each rule an error.
|
|
225
226
|
|
|
226
|
-
Thus `@eslint-react/eslint-plugin` owns the hook rules, for example `@eslint-react/rules-of-hooks` and `@eslint-react/exhaustive-deps`, and ESLint reports each problem one time. This is the path of the eslint-react guide "Migrating from eslint-plugin-react-hooks". `eslint-plugin-react-hooks` adds only its 4 React Compiler rules: `preserve-manual-memoization`, `incompatible-library`, `config` and `gating`. Each rule has the severity that its plugin ships.
|
|
227
|
+
Thus `@eslint-react/eslint-plugin` owns the hook rules, for example `@eslint-react/rules-of-hooks` and `@eslint-react/exhaustive-deps`, and ESLint reports each problem one time. This is the path of the eslint-react guide "Migrating from eslint-plugin-react-hooks". `eslint-plugin-react-hooks` adds only its 4 React Compiler rules: `preserve-manual-memoization`, `incompatible-library`, `config` and `gating`. Each rule of the first 4 configs has the severity that its plugin ships.
|
|
227
228
|
|
|
228
229
|
The style rules of zukhruf for React are not in this export. They are in the config `zukhruf/react`.
|
|
229
230
|
|
|
230
|
-
Install the
|
|
231
|
+
Install the 4 plugins in the React workspace:
|
|
231
232
|
|
|
232
233
|
```sh
|
|
233
|
-
npm install --save-dev @eslint-react/eslint-plugin eslint-plugin-jsx-a11y-x eslint-plugin-react-hooks
|
|
234
|
+
npm install --save-dev @eslint-react/eslint-plugin eslint-plugin-jsx-a11y-x eslint-plugin-react-hooks eslint-plugin-react-you-might-not-need-an-effect
|
|
234
235
|
```
|
|
235
236
|
|
|
236
237
|
They are optional peers of this package. With the peers, npm writes the lockfile edges from `@zukhruf/eslint` to the 3 plugins, so a lint input on `@zukhruf/eslint` also hashes the plugins.
|
|
@@ -244,6 +245,7 @@ They are optional peers of this package. With the peers, npm writes the lockfile
|
|
|
244
245
|
- the `Intl` APIs Hermes does not have: es-x's `no-intl-displaynames`, `no-intl-durationformat`, `no-intl-listformat`, `no-intl-locale`, `no-intl-pluralrules`, `no-intl-relativetimeformat` and `no-intl-segmenter`;
|
|
245
246
|
- Node's built-in modules: `import-x/no-nodejs-modules`;
|
|
246
247
|
- `hermes/no-missing-console`: `console.clear`, `dir`, `dirxml`, `profile`, `profileEnd` and `timeLog`, which React Native release builds do not have, and `console[name]` with a computed name.
|
|
248
|
+
- `hermes/no-compact-notation`: `notation: 'compact'` and `compactDisplay` in the options of `Intl.NumberFormat`, which Hermes on iOS ignores: `format(44000)` gives `44,000`, not `44K`. Build the short form yourself.
|
|
247
249
|
|
|
248
250
|
```js
|
|
249
251
|
import hermes from '@zukhruf/eslint/react-native';
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"no-phase-flag.d.ts","sourceRoot":"","sources":["../../src/class-state/no-phase-flag.ts"],"names":[],"mappings":";
|
|
1
|
+
{"version":3,"file":"no-phase-flag.d.ts","sourceRoot":"","sources":["../../src/class-state/no-phase-flag.ts"],"names":[],"mappings":";AAwWA,wBAAgC"}
|
|
@@ -1,11 +1,50 @@
|
|
|
1
|
-
import { ESLintUtils } from '@typescript-eslint/utils';
|
|
2
|
-
import { isBooleanLiteralType, isIntrinsicBooleanType, isIntrinsicUndefinedType, unionConstituents, } from 'ts-api-utils';
|
|
1
|
+
import { AST_NODE_TYPES, ESLintUtils, } from '@typescript-eslint/utils';
|
|
2
|
+
import { isBooleanLiteralType, isIntrinsicBooleanType, isIntrinsicNullType, isIntrinsicUndefinedType, unionConstituents, } from 'ts-api-utils';
|
|
3
3
|
import { eslintRule } from "../authoring/rule-module.js";
|
|
4
|
-
/** Whether `type` is a flag, or can be `undefined` until something sets it. */
|
|
4
|
+
/** Whether `type` is a flag, or can be `undefined` or `null` until something sets it. */
|
|
5
5
|
function holdsFlag(type) {
|
|
6
6
|
return unionConstituents(type).some((part) => isBooleanLiteralType(part) ||
|
|
7
7
|
isIntrinsicBooleanType(part) ||
|
|
8
|
-
isIntrinsicUndefinedType(part)
|
|
8
|
+
isIntrinsicUndefinedType(part) ||
|
|
9
|
+
isIntrinsicNullType(part));
|
|
10
|
+
}
|
|
11
|
+
function isFunction(node) {
|
|
12
|
+
return (node.type === 'ArrowFunctionExpression' ||
|
|
13
|
+
node.type === 'FunctionDeclaration' ||
|
|
14
|
+
node.type === 'FunctionExpression');
|
|
15
|
+
}
|
|
16
|
+
/** Nodes that hold a function as a value without calling it. */
|
|
17
|
+
const holdsValue = new Set([
|
|
18
|
+
AST_NODE_TYPES.ArrayExpression,
|
|
19
|
+
AST_NODE_TYPES.ClassBody,
|
|
20
|
+
AST_NODE_TYPES.ClassExpression,
|
|
21
|
+
AST_NODE_TYPES.MethodDefinition,
|
|
22
|
+
AST_NODE_TYPES.ObjectExpression,
|
|
23
|
+
AST_NODE_TYPES.Property,
|
|
24
|
+
AST_NODE_TYPES.PropertyDefinition,
|
|
25
|
+
AST_NODE_TYPES.TSAsExpression,
|
|
26
|
+
AST_NODE_TYPES.TSSatisfiesExpression,
|
|
27
|
+
]);
|
|
28
|
+
/** Whether `fn` is returned, or held by the returned object, array or class. */
|
|
29
|
+
function returned(fn) {
|
|
30
|
+
let node = fn;
|
|
31
|
+
while (node.parent && holdsValue.has(node.parent.type))
|
|
32
|
+
node = node.parent;
|
|
33
|
+
return node.parent?.type === 'ReturnStatement';
|
|
34
|
+
}
|
|
35
|
+
/**
|
|
36
|
+
* Whether `write` runs after `factory` returns, the way a method runs after
|
|
37
|
+
* the constructor: the outermost function around it is part of what `factory`
|
|
38
|
+
* returns. A callback that `factory` calls, such as one passed to `map`, has
|
|
39
|
+
* finished by then.
|
|
40
|
+
*/
|
|
41
|
+
function writtenAfterReturn(write, factory) {
|
|
42
|
+
let outermost;
|
|
43
|
+
for (let node = write.parent; node && node !== factory; node = node.parent) {
|
|
44
|
+
if (isFunction(node))
|
|
45
|
+
outermost = node;
|
|
46
|
+
}
|
|
47
|
+
return outermost !== undefined && returned(outermost);
|
|
9
48
|
}
|
|
10
49
|
/** A private field and a public field of the same name are different fields. */
|
|
11
50
|
function keyOf(name) {
|
|
@@ -37,24 +76,21 @@ function inConstructor(ancestors) {
|
|
|
37
76
|
}
|
|
38
77
|
return false;
|
|
39
78
|
}
|
|
40
|
-
/** Whether `statement` is `
|
|
41
|
-
function memoStatement(statement,
|
|
79
|
+
/** Whether `statement` is `target ??= …;` on its own, for one of `targets`. */
|
|
80
|
+
function memoStatement(statement, targets) {
|
|
42
81
|
if (statement.type !== 'ExpressionStatement')
|
|
43
82
|
return false;
|
|
44
83
|
const { expression } = statement;
|
|
45
84
|
return (expression.type === 'AssignmentExpression' &&
|
|
46
85
|
expression.operator === '??=' &&
|
|
47
|
-
expression.left
|
|
48
|
-
expression.left.object.type === 'ThisExpression' &&
|
|
49
|
-
expression.left.property.type === 'PrivateIdentifier' &&
|
|
50
|
-
expression.left.property.name === name);
|
|
86
|
+
targets.has(expression.left));
|
|
51
87
|
}
|
|
52
88
|
/**
|
|
53
|
-
* Whether a read
|
|
54
|
-
*
|
|
55
|
-
*
|
|
89
|
+
* Whether a read comes after a top-level `target ??= …;` statement of its own
|
|
90
|
+
* function body. That statement always runs first, so the read never sees the
|
|
91
|
+
* value before it is set.
|
|
56
92
|
*/
|
|
57
|
-
function readsAfterMemo(read,
|
|
93
|
+
function readsAfterMemo(read, targets) {
|
|
58
94
|
let node = read.parent;
|
|
59
95
|
while (node &&
|
|
60
96
|
node.type !== 'FunctionExpression' &&
|
|
@@ -64,67 +100,81 @@ function readsAfterMemo(read, name) {
|
|
|
64
100
|
}
|
|
65
101
|
if (node?.body?.type !== 'BlockStatement')
|
|
66
102
|
return false;
|
|
67
|
-
return node.body.body.some((statement) => statement.range[1] <= read.range[0] && memoStatement(statement,
|
|
103
|
+
return node.body.body.some((statement) => statement.range[1] <= read.range[0] && memoStatement(statement, targets));
|
|
68
104
|
}
|
|
69
|
-
/** Whether `
|
|
70
|
-
function patternTarget(
|
|
71
|
-
const { parent } =
|
|
105
|
+
/** Whether `target` is the target of a destructuring or loop assignment. */
|
|
106
|
+
function patternTarget(target) {
|
|
107
|
+
const { parent } = target;
|
|
108
|
+
if (!parent)
|
|
109
|
+
return false;
|
|
72
110
|
switch (parent.type) {
|
|
73
111
|
case 'ArrayPattern':
|
|
74
112
|
case 'RestElement':
|
|
75
113
|
return true;
|
|
76
114
|
case 'AssignmentPattern':
|
|
77
|
-
return parent.right !==
|
|
115
|
+
return parent.right !== target;
|
|
78
116
|
case 'Property':
|
|
79
|
-
return parent.parent.type === 'ObjectPattern' && parent.value ===
|
|
117
|
+
return parent.parent.type === 'ObjectPattern' && parent.value === target;
|
|
80
118
|
case 'ForInStatement':
|
|
81
119
|
case 'ForOfStatement':
|
|
82
|
-
return parent.left ===
|
|
120
|
+
return parent.left === target;
|
|
83
121
|
default:
|
|
84
122
|
return false;
|
|
85
123
|
}
|
|
86
124
|
}
|
|
87
125
|
/**
|
|
88
|
-
* Whether the
|
|
89
|
-
*
|
|
90
|
-
*
|
|
91
|
-
*
|
|
126
|
+
* Whether the uses of a field or variable make it a lazy memo: every write is
|
|
127
|
+
* `target ??= …`, so it never goes back to nullish, and every read is the value
|
|
128
|
+
* of a `??=` or comes after a top-level `target ??= …;` of its own function
|
|
129
|
+
* body. One that nothing reads is a flag, not a memo.
|
|
92
130
|
*/
|
|
93
|
-
function lazyMemo(
|
|
131
|
+
function lazyMemo(uses) {
|
|
132
|
+
const targets = new Set(uses);
|
|
94
133
|
let read = false;
|
|
95
|
-
for (const
|
|
96
|
-
const
|
|
97
|
-
if (
|
|
98
|
-
member.property !== occurrence ||
|
|
99
|
-
member.object.type !== 'ThisExpression') {
|
|
134
|
+
for (const use of uses) {
|
|
135
|
+
const { parent } = use;
|
|
136
|
+
if (!parent)
|
|
100
137
|
return false;
|
|
101
|
-
|
|
102
|
-
const { parent } = member;
|
|
103
|
-
if (parent.type === 'AssignmentExpression' && parent.left === member) {
|
|
138
|
+
if (parent.type === 'AssignmentExpression' && parent.left === use) {
|
|
104
139
|
if (parent.operator !== '??=')
|
|
105
140
|
return false;
|
|
106
141
|
if (parent.parent.type !== 'ExpressionStatement')
|
|
107
142
|
read = true;
|
|
108
143
|
continue;
|
|
109
144
|
}
|
|
110
|
-
if (parent.type === 'UpdateExpression' || patternTarget(
|
|
145
|
+
if (parent.type === 'UpdateExpression' || patternTarget(use)) {
|
|
111
146
|
return false;
|
|
112
147
|
}
|
|
113
|
-
if (!readsAfterMemo(
|
|
148
|
+
if (!readsAfterMemo(use, targets))
|
|
114
149
|
return false;
|
|
115
150
|
read = true;
|
|
116
151
|
}
|
|
117
152
|
return read;
|
|
118
153
|
}
|
|
154
|
+
/** `this.#name` around each occurrence, or nothing when one is on another object. */
|
|
155
|
+
function thisMembers(occurrences) {
|
|
156
|
+
const members = [];
|
|
157
|
+
for (const occurrence of occurrences) {
|
|
158
|
+
const member = occurrence.parent;
|
|
159
|
+
if (member.type !== 'MemberExpression' ||
|
|
160
|
+
member.property !== occurrence ||
|
|
161
|
+
member.object.type !== 'ThisExpression') {
|
|
162
|
+
return undefined;
|
|
163
|
+
}
|
|
164
|
+
members.push(member);
|
|
165
|
+
}
|
|
166
|
+
return members;
|
|
167
|
+
}
|
|
119
168
|
const rule = ESLintUtils.RuleCreator.withoutDocs({
|
|
120
169
|
meta: {
|
|
121
170
|
type: 'problem',
|
|
122
171
|
docs: {
|
|
123
|
-
description: 'Disallow boolean or optional class fields that change after the constructor, which store a phase',
|
|
172
|
+
description: 'Disallow boolean or optional class fields that change after the constructor, and boolean or optional variables that a returned function changes after its factory returns, which store a phase',
|
|
124
173
|
},
|
|
125
174
|
schema: [],
|
|
126
175
|
messages: {
|
|
127
176
|
phaseFlag: 'Do not keep a phase in a flag or optional field that changes after the constructor: every reader must know which phase holds. Model the phases as State objects, wait on a one-shot latch, push the fact as an event, or ask the platform for it.',
|
|
177
|
+
phaseVariable: 'Do not keep a phase in a flag or optional variable that the returned object or function changes after its factory returns: every reader must know which phase holds. Model the phases as State objects, wait on a one-shot latch, push the fact as an event, or ask the platform for it.',
|
|
128
178
|
},
|
|
129
179
|
},
|
|
130
180
|
defaultOptions: [],
|
|
@@ -139,6 +189,25 @@ const rule = ESLintUtils.RuleCreator.withoutDocs({
|
|
|
139
189
|
current()?.fields.set(key, field);
|
|
140
190
|
};
|
|
141
191
|
return {
|
|
192
|
+
'VariableDeclaration[kind="let"]'(node) {
|
|
193
|
+
for (const variable of context.sourceCode.getDeclaredVariables(node)) {
|
|
194
|
+
const factory = variable.scope.variableScope;
|
|
195
|
+
if (factory.type !== 'function')
|
|
196
|
+
continue;
|
|
197
|
+
const uses = variable.references
|
|
198
|
+
.filter((reference) => !reference.init)
|
|
199
|
+
.map((reference) => reference.identifier);
|
|
200
|
+
const changedLater = variable.references.some((reference) => reference.isWrite() &&
|
|
201
|
+
writtenAfterReturn(reference.identifier, factory.block));
|
|
202
|
+
const [name] = variable.identifiers;
|
|
203
|
+
if (name &&
|
|
204
|
+
changedLater &&
|
|
205
|
+
holdsFlag(services.getTypeAtLocation(name)) &&
|
|
206
|
+
!lazyMemo(uses)) {
|
|
207
|
+
context.report({ node: name, messageId: 'phaseVariable' });
|
|
208
|
+
}
|
|
209
|
+
}
|
|
210
|
+
},
|
|
142
211
|
ClassBody(node) {
|
|
143
212
|
const declared = new Set();
|
|
144
213
|
for (const member of node.body) {
|
|
@@ -208,7 +277,7 @@ const rule = ESLintUtils.RuleCreator.withoutDocs({
|
|
|
208
277
|
if (!body.changed.has(key))
|
|
209
278
|
continue;
|
|
210
279
|
if (field.name.type === 'PrivateIdentifier' &&
|
|
211
|
-
lazyMemo(body.occurrences.get(field.name.name) ?? [])) {
|
|
280
|
+
lazyMemo(thisMembers(body.occurrences.get(field.name.name) ?? []) ?? [])) {
|
|
212
281
|
continue;
|
|
213
282
|
}
|
|
214
283
|
if (field.optional ||
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"no-phase-flag.js","sourceRoot":"","sources":["../../src/class-state/no-phase-flag.ts"],"names":[],"mappings":"AAAA,OAAO,
|
|
1
|
+
{"version":3,"file":"no-phase-flag.js","sourceRoot":"","sources":["../../src/class-state/no-phase-flag.ts"],"names":[],"mappings":"AAAA,OAAO,EACL,cAAc,EACd,WAAW,GAEZ,MAAM,0BAA0B,CAAC;AAClC,OAAO,EACL,oBAAoB,EACpB,sBAAsB,EACtB,mBAAmB,EACnB,wBAAwB,EACxB,iBAAiB,GAClB,MAAM,cAAc,CAAC;AAGtB,OAAO,EAAE,UAAU,EAAE,MAAM,6BAA6B,CAAC;AAEzD,yFAAyF;AACzF,SAAS,SAAS,CAAC,IAAa;IAC9B,OAAO,iBAAiB,CAAC,IAAI,CAAC,CAAC,IAAI,CACjC,CAAC,IAAI,EAAE,EAAE,CACP,oBAAoB,CAAC,IAAI,CAAC;QAC1B,sBAAsB,CAAC,IAAI,CAAC;QAC5B,wBAAwB,CAAC,IAAI,CAAC;QAC9B,mBAAmB,CAAC,IAAI,CAAC,CAC5B,CAAC;AACJ,CAAC;AAOD,SAAS,UAAU,CAAC,IAAmB;IACrC,OAAO,CACL,IAAI,CAAC,IAAI,KAAK,yBAAyB;QACvC,IAAI,CAAC,IAAI,KAAK,qBAAqB;QACnC,IAAI,CAAC,IAAI,KAAK,oBAAoB,CACnC,CAAC;AACJ,CAAC;AAED,gEAAgE;AAChE,MAAM,UAAU,GAAG,IAAI,GAAG,CAAiB;IACzC,cAAc,CAAC,eAAe;IAC9B,cAAc,CAAC,SAAS;IACxB,cAAc,CAAC,eAAe;IAC9B,cAAc,CAAC,gBAAgB;IAC/B,cAAc,CAAC,gBAAgB;IAC/B,cAAc,CAAC,QAAQ;IACvB,cAAc,CAAC,kBAAkB;IACjC,cAAc,CAAC,cAAc;IAC7B,cAAc,CAAC,qBAAqB;CACrC,CAAC,CAAC;AAEH,gFAAgF;AAChF,SAAS,QAAQ,CAAC,EAAgB;IAChC,IAAI,IAAI,GAAkB,EAAE,CAAC;IAC7B,OAAO,IAAI,CAAC,MAAM,IAAI,UAAU,CAAC,GAAG,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC;QAAE,IAAI,GAAG,IAAI,CAAC,MAAM,CAAC;IAC3E,OAAO,IAAI,CAAC,MAAM,EAAE,IAAI,KAAK,iBAAiB,CAAC;AACjD,CAAC;AAED;;;;;GAKG;AACH,SAAS,kBAAkB,CACzB,KAAoB,EACpB,OAAsB;IAEtB,IAAI,SAAmC,CAAC;IACxC,KAAK,IAAI,IAAI,GAAG,KAAK,CAAC,MAAM,EAAE,IAAI,IAAI,IAAI,KAAK,OAAO,EAAE,IAAI,GAAG,IAAI,CAAC,MAAM,EAAE,CAAC;QAC3E,IAAI,UAAU,CAAC,IAAI,CAAC;YAAE,SAAS,GAAG,IAAI,CAAC;IACzC,CAAC;IACD,OAAO,SAAS,KAAK,SAAS,IAAI,QAAQ,CAAC,SAAS,CAAC,CAAC;AACxD,CAAC;AAED,gFAAgF;AAChF,SAAS,KAAK,CAAC,IAAmB;IAChC,IAAI,IAAI,CAAC,IAAI,KAAK,mBAAmB;QAAE,OAAO,IAAI,IAAI,CAAC,IAAI,EAAE,CAAC;IAC9D,IAAI,IAAI,CAAC,IAAI,KAAK,YAAY;QAAE,OAAO,IAAI,CAAC,IAAI,CAAC;IACjD,OAAO,SAAS,CAAC;AACnB,CAAC;AAED;;;;GAIG;AACH,SAAS,aAAa,CAAC,SAA0B;IAC/C,KAAK,MAAM,IAAI,IAAI,SAAS,CAAC,UAAU,EAAE,EAAE,CAAC;QAC1C,IAAI,IAAI,CAAC,IAAI,KAAK,yBAAyB;YAAE,OAAO,KAAK,CAAC;QAC1D,IACE,IAAI,CAAC,IAAI,KAAK,oBAAoB;YAClC,IAAI,CAAC,IAAI,KAAK,qBAAqB,EACnC,CAAC;YACD,OAAO,CACL,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,kBAAkB;gBACvC,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,aAAa,CACnC,CAAC;QACJ,CAAC;QACD,IACE,IAAI,CAAC,IAAI,KAAK,oBAAoB;YAClC,IAAI,CAAC,IAAI,KAAK,aAAa;YAC3B,IAAI,CAAC,IAAI,KAAK,WAAW,EACzB,CAAC;YACD,OAAO,KAAK,CAAC;QACf,CAAC;IACH,CAAC;IACD,OAAO,KAAK,CAAC;AACf,CAAC;AAQD,+EAA+E;AAC/E,SAAS,aAAa,CACpB,SAAwB,EACxB,OAAmC;IAEnC,IAAI,SAAS,CAAC,IAAI,KAAK,qBAAqB;QAAE,OAAO,KAAK,CAAC;IAC3D,MAAM,EAAE,UAAU,EAAE,GAAG,SAAS,CAAC;IACjC,OAAO,CACL,UAAU,CAAC,IAAI,KAAK,sBAAsB;QAC1C,UAAU,CAAC,QAAQ,KAAK,KAAK;QAC7B,OAAO,CAAC,GAAG,CAAC,UAAU,CAAC,IAAI,CAAC,CAC7B,CAAC;AACJ,CAAC;AAED;;;;GAIG;AACH,SAAS,cAAc,CACrB,IAAmB,EACnB,OAAmC;IAEnC,IAAI,IAAI,GAA8B,IAAI,CAAC,MAAM,CAAC;IAClD,OACE,IAAI;QACJ,IAAI,CAAC,IAAI,KAAK,oBAAoB;QAClC,IAAI,CAAC,IAAI,KAAK,yBAAyB;QACvC,IAAI,CAAC,IAAI,KAAK,qBAAqB,EACnC,CAAC;QACD,IAAI,GAAG,IAAI,CAAC,MAAM,CAAC;IACrB,CAAC;IACD,IAAI,IAAI,EAAE,IAAI,EAAE,IAAI,KAAK,gBAAgB;QAAE,OAAO,KAAK,CAAC;IACxD,OAAO,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,CACxB,CAAC,SAAS,EAAE,EAAE,CACZ,SAAS,CAAC,KAAK,CAAC,CAAC,CAAC,IAAI,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,IAAI,aAAa,CAAC,SAAS,EAAE,OAAO,CAAC,CAC3E,CAAC;AACJ,CAAC;AAED,4EAA4E;AAC5E,SAAS,aAAa,CAAC,MAAqB;IAC1C,MAAM,EAAE,MAAM,EAAE,GAAG,MAAM,CAAC;IAC1B,IAAI,CAAC,MAAM;QAAE,OAAO,KAAK,CAAC;IAC1B,QAAQ,MAAM,CAAC,IAAI,EAAE,CAAC;QACpB,KAAK,cAAc,CAAC;QACpB,KAAK,aAAa;YAChB,OAAO,IAAI,CAAC;QACd,KAAK,mBAAmB;YACtB,OAAO,MAAM,CAAC,KAAK,KAAK,MAAM,CAAC;QACjC,KAAK,UAAU;YACb,OAAO,MAAM,CAAC,MAAM,CAAC,IAAI,KAAK,eAAe,IAAI,MAAM,CAAC,KAAK,KAAK,MAAM,CAAC;QAC3E,KAAK,gBAAgB,CAAC;QACtB,KAAK,gBAAgB;YACnB,OAAO,MAAM,CAAC,IAAI,KAAK,MAAM,CAAC;QAChC;YACE,OAAO,KAAK,CAAC;IACjB,CAAC;AACH,CAAC;AAED;;;;;GAKG;AACH,SAAS,QAAQ,CAAC,IAA8B;IAC9C,MAAM,OAAO,GAAG,IAAI,GAAG,CAAC,IAAI,CAAC,CAAC;IAC9B,IAAI,IAAI,GAAG,KAAK,CAAC;IACjB,KAAK,MAAM,GAAG,IAAI,IAAI,EAAE,CAAC;QACvB,MAAM,EAAE,MAAM,EAAE,GAAG,GAAG,CAAC;QACvB,IAAI,CAAC,MAAM;YAAE,OAAO,KAAK,CAAC;QAC1B,IAAI,MAAM,CAAC,IAAI,KAAK,sBAAsB,IAAI,MAAM,CAAC,IAAI,KAAK,GAAG,EAAE,CAAC;YAClE,IAAI,MAAM,CAAC,QAAQ,KAAK,KAAK;gBAAE,OAAO,KAAK,CAAC;YAC5C,IAAI,MAAM,CAAC,MAAM,CAAC,IAAI,KAAK,qBAAqB;gBAAE,IAAI,GAAG,IAAI,CAAC;YAC9D,SAAS;QACX,CAAC;QACD,IAAI,MAAM,CAAC,IAAI,KAAK,kBAAkB,IAAI,aAAa,CAAC,GAAG,CAAC,EAAE,CAAC;YAC7D,OAAO,KAAK,CAAC;QACf,CAAC;QACD,IAAI,CAAC,cAAc,CAAC,GAAG,EAAE,OAAO,CAAC;YAAE,OAAO,KAAK,CAAC;QAChD,IAAI,GAAG,IAAI,CAAC;IACd,CAAC;IACD,OAAO,IAAI,CAAC;AACd,CAAC;AAED,qFAAqF;AACrF,SAAS,WAAW,CAClB,WAAkD;IAElD,MAAM,OAAO,GAAgC,EAAE,CAAC;IAChD,KAAK,MAAM,UAAU,IAAI,WAAW,EAAE,CAAC;QACrC,MAAM,MAAM,GAAG,UAAU,CAAC,MAAM,CAAC;QACjC,IACE,MAAM,CAAC,IAAI,KAAK,kBAAkB;YAClC,MAAM,CAAC,QAAQ,KAAK,UAAU;YAC9B,MAAM,CAAC,MAAM,CAAC,IAAI,KAAK,gBAAgB,EACvC,CAAC;YACD,OAAO,SAAS,CAAC;QACnB,CAAC;QACD,OAAO,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;IACvB,CAAC;IACD,OAAO,OAAO,CAAC;AACjB,CAAC;AAED,MAAM,IAAI,GAAG,WAAW,CAAC,WAAW,CAAC,WAAW,CAAC;IAC/C,IAAI,EAAE;QACJ,IAAI,EAAE,SAAS;QACf,IAAI,EAAE;YACJ,WAAW,EACT,gMAAgM;SACnM;QACD,MAAM,EAAE,EAAE;QACV,QAAQ,EAAE;YACR,SAAS,EACP,mPAAmP;YACrP,aAAa,EACX,0RAA0R;SAC7R;KACF;IACD,cAAc,EAAE,EAAE;IAClB,MAAM,CAAC,OAAO;QACZ,4EAA4E;QAC5E,MAAM,QAAQ,GAAG,WAAW,CAAC,iBAAiB,CAAC,OAAO,CAAC,CAAC;QACxD,MAAM,OAAO,GAKP,EAAE,CAAC;QACT,MAAM,OAAO,GAAG,GAAG,EAAE,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC;QAErC,MAAM,MAAM,GAAG,CAAC,KAAY,EAAE,EAAE;YAC9B,MAAM,GAAG,GAAG,KAAK,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;YAC9B,IAAI,GAAG;gBAAE,OAAO,EAAE,EAAE,MAAM,CAAC,GAAG,CAAC,GAAG,EAAE,KAAK,CAAC,CAAC;QAC7C,CAAC,CAAC;QAEF,OAAO;YACL,iCAAiC,CAAC,IAAkC;gBAClE,KAAK,MAAM,QAAQ,IAAI,OAAO,CAAC,UAAU,CAAC,oBAAoB,CAAC,IAAI,CAAC,EAAE,CAAC;oBACrE,MAAM,OAAO,GAAG,QAAQ,CAAC,KAAK,CAAC,aAAa,CAAC;oBAC7C,IAAI,OAAO,CAAC,IAAI,KAAK,UAAU;wBAAE,SAAS;oBAC1C,MAAM,IAAI,GAAG,QAAQ,CAAC,UAAU;yBAC7B,MAAM,CAAC,CAAC,SAAS,EAAE,EAAE,CAAC,CAAC,SAAS,CAAC,IAAI,CAAC;yBACtC,GAAG,CAAC,CAAC,SAAS,EAAE,EAAE,CAAC,SAAS,CAAC,UAAU,CAAC,CAAC;oBAC5C,MAAM,YAAY,GAAG,QAAQ,CAAC,UAAU,CAAC,IAAI,CAC3C,CAAC,SAAS,EAAE,EAAE,CACZ,SAAS,CAAC,OAAO,EAAE;wBACnB,kBAAkB,CAAC,SAAS,CAAC,UAAU,EAAE,OAAO,CAAC,KAAK,CAAC,CAC1D,CAAC;oBACF,MAAM,CAAC,IAAI,CAAC,GAAG,QAAQ,CAAC,WAAW,CAAC;oBACpC,IACE,IAAI;wBACJ,YAAY;wBACZ,SAAS,CAAC,QAAQ,CAAC,iBAAiB,CAAC,IAAI,CAAC,CAAC;wBAC3C,CAAC,QAAQ,CAAC,IAAI,CAAC,EACf,CAAC;wBACD,OAAO,CAAC,MAAM,CAAC,EAAE,IAAI,EAAE,IAAI,EAAE,SAAS,EAAE,eAAe,EAAE,CAAC,CAAC;oBAC7D,CAAC;gBACH,CAAC;YACH,CAAC;YACD,SAAS,CAAC,IAAwB;gBAChC,MAAM,QAAQ,GAAG,IAAI,GAAG,EAAU,CAAC;gBACnC,KAAK,MAAM,MAAM,IAAI,IAAI,CAAC,IAAI,EAAE,CAAC;oBAC/B,IAAI,KAAK,IAAI,MAAM,IAAI,MAAM,CAAC,GAAG,CAAC,IAAI,KAAK,mBAAmB,EAAE,CAAC;wBAC/D,QAAQ,CAAC,GAAG,CAAC,MAAM,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC;oBAChC,CAAC;gBACH,CAAC;gBACD,OAAO,CAAC,IAAI,CAAC;oBACX,MAAM,EAAE,IAAI,GAAG,EAAE;oBACjB,OAAO,EAAE,IAAI,GAAG,EAAE;oBAClB,QAAQ;oBACR,WAAW,EAAE,IAAI,GAAG,EAAE;iBACvB,CAAC,CAAC;YACL,CAAC;YACD,iBAAiB,CAAC,IAAgC;gBAChD,IAAI,KAAK,IAAI,IAAI,CAAC,MAAM,IAAI,IAAI,CAAC,MAAM,CAAC,GAAG,KAAK,IAAI;oBAAE,OAAO;gBAC7D,MAAM,IAAI,GAAG,OAAO,EAAE,CAAC;gBACvB,IAAI,CAAC,IAAI;oBAAE,OAAO;gBAClB,MAAM,IAAI,GAAG,IAAI,CAAC,WAAW,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC;gBACnD,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;gBAChB,IAAI,CAAC,WAAW,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC;YACxC,CAAC;YACD,gCAAgC,CAAC,IAAiC;gBAChE,IAAI,IAAI,CAAC,MAAM,IAAI,IAAI,CAAC,QAAQ,IAAI,IAAI,CAAC,QAAQ;oBAAE,OAAO;gBAC1D,MAAM,CAAC,EAAE,IAAI,EAAE,IAAI,EAAE,IAAI,CAAC,GAAG,EAAE,QAAQ,EAAE,IAAI,CAAC,QAAQ,EAAE,CAAC,CAAC;YAC5D,CAAC;YACD,mBAAmB,CAAC,IAAkC;gBACpD,IAAI,IAAI,CAAC,QAAQ,IAAI,IAAI,CAAC,MAAM;oBAAE,OAAO;gBACzC,MAAM,IAAI,GACR,IAAI,CAAC,SAAS,CAAC,IAAI,KAAK,mBAAmB;oBACzC,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,IAAI;oBACrB,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC;gBACrB,MAAM,QAAQ,GAAG,UAAU,IAAI,IAAI,IAAI,IAAI,CAAC,QAAQ,KAAK,IAAI,CAAC;gBAC9D,MAAM,CAAC,EAAE,IAAI,EAAE,IAAI,EAAE,QAAQ,EAAE,CAAC,CAAC;YACnC,CAAC;YACD,oBAAoB,CAAC,IAAmC;gBACtD,MAAM,MAAM,GAAG,IAAI,CAAC,IAAI,CAAC;gBACzB,IACE,MAAM,CAAC,IAAI,KAAK,kBAAkB;oBAClC,MAAM,CAAC,QAAQ;oBACf,MAAM,CAAC,MAAM,CAAC,IAAI,KAAK,gBAAgB,EACvC,CAAC;oBACD,OAAO;gBACT,CAAC;gBACD,IAAI,aAAa,CAAC,OAAO,CAAC,UAAU,CAAC,YAAY,CAAC,IAAI,CAAC,CAAC;oBAAE,OAAO;gBACjE,MAAM,GAAG,GAAG,KAAK,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC;gBACnC,IAAI,GAAG;oBAAE,OAAO,EAAE,EAAE,OAAO,CAAC,GAAG,CAAC,GAAG,CAAC,CAAC;YACvC,CAAC;YACD,gBAAgB;gBACd,MAAM,IAAI,GAAG,OAAO,CAAC,GAAG,EAAE,CAAC;gBAC3B,IAAI,CAAC,IAAI;oBAAE,OAAO;gBAClB,mEAAmE;gBACnE,MAAM,KAAK,GAAG,OAAO,EAAE,CAAC;gBACxB,KAAK,MAAM,CAAC,IAAI,EAAE,IAAI,CAAC,IAAI,IAAI,CAAC,WAAW,EAAE,CAAC;oBAC5C,IAAI,IAAI,CAAC,QAAQ,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,KAAK;wBAAE,SAAS;oBAChD,KAAK,CAAC,WAAW,CAAC,GAAG,CAAC,IAAI,EAAE;wBAC1B,GAAG,CAAC,KAAK,CAAC,WAAW,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC;wBACtC,GAAG,IAAI;qBACR,CAAC,CAAC;gBACL,CAAC;gBACD,KAAK,MAAM,CAAC,GAAG,EAAE,KAAK,CAAC,IAAI,IAAI,CAAC,MAAM,EAAE,CAAC;oBACvC,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,GAAG,CAAC,GAAG,CAAC;wBAAE,SAAS;oBACrC,IACE,KAAK,CAAC,IAAI,CAAC,IAAI,KAAK,mBAAmB;wBACvC,QAAQ,CACN,WAAW,CAAC,IAAI,CAAC,WAAW,CAAC,GAAG,CAAC,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,IAAI,EAAE,CAC/D,EACD,CAAC;wBACD,SAAS;oBACX,CAAC;oBACD,IACE,KAAK,CAAC,QAAQ;wBACd,SAAS,CAAC,QAAQ,CAAC,iBAAiB,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,EACjD,CAAC;wBACD,OAAO,CAAC,MAAM,CAAC,EAAE,IAAI,EAAE,KAAK,CAAC,IAAI,EAAE,SAAS,EAAE,WAAW,EAAE,CAAC,CAAC;oBAC/D,CAAC;gBACH,CAAC;YACH,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC,CAAC;AAEH,eAAe,UAAU,CAAC,IAAI,CAAC,CAAC"}
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"no-undeclared-process-env.d.ts","sourceRoot":"","sources":["../../src/environment/no-undeclared-process-env.ts"],"names":[],"mappings":"AAGA,OAAO,KAAK,EAAE,IAAI,EAAE,MAAM,QAAQ,CAAC;
|
|
1
|
+
{"version":3,"file":"no-undeclared-process-env.d.ts","sourceRoot":"","sources":["../../src/environment/no-undeclared-process-env.ts"],"names":[],"mappings":"AAGA,OAAO,KAAK,EAAE,IAAI,EAAE,MAAM,QAAQ,CAAC;AAkNnC;;;;;;GAMG;AACH,QAAA,MAAM,IAAI,EAAE,IAAI,CAAC,UA2DhB,CAAC;AAEF,eAAe,IAAI,CAAC"}
|
|
@@ -8,6 +8,18 @@ import { relativeToWorkspace, workspaceRootOf, } from "../workspace/workspace-ro
|
|
|
8
8
|
// Keyed by absolute path. A changed mtime re-parses, so a long-lived ESLint
|
|
9
9
|
// process (an editor) picks up an edit to the schema.
|
|
10
10
|
const declaredByStartupPath = new Map();
|
|
11
|
+
/** The key and its property node, when `node` reads `process.env.<key>`. */
|
|
12
|
+
function processEnvRead(node) {
|
|
13
|
+
if (!isType(node, 'MemberExpression') ||
|
|
14
|
+
!isProcessEnvMember(node['object'])) {
|
|
15
|
+
return undefined;
|
|
16
|
+
}
|
|
17
|
+
const key = memberKey(node);
|
|
18
|
+
const property = node['property'];
|
|
19
|
+
if (!key || !isAstNode(property))
|
|
20
|
+
return undefined;
|
|
21
|
+
return { key, property };
|
|
22
|
+
}
|
|
11
23
|
function memberKey(node) {
|
|
12
24
|
const property = node['property'];
|
|
13
25
|
if (node['computed'] !== true) {
|
|
@@ -154,38 +166,38 @@ const rule = {
|
|
|
154
166
|
create(context) {
|
|
155
167
|
const startupPath = resolveStartupPath(context, startupFileSetting(context));
|
|
156
168
|
const declared = declaredEnvOf(startupPath);
|
|
157
|
-
|
|
169
|
+
const { error } = declared;
|
|
170
|
+
if (error) {
|
|
171
|
+
// One report per file, on its first read of process.env.
|
|
172
|
+
const reads = [];
|
|
173
|
+
return {
|
|
174
|
+
MemberExpression(node) {
|
|
175
|
+
const read = processEnvRead(node);
|
|
176
|
+
if (read)
|
|
177
|
+
reads.push(read.property);
|
|
178
|
+
},
|
|
179
|
+
'Program:exit'() {
|
|
180
|
+
const [first] = reads;
|
|
181
|
+
if (first) {
|
|
182
|
+
context.report({
|
|
183
|
+
node: first,
|
|
184
|
+
messageId: 'startupUnavailable',
|
|
185
|
+
data: { error },
|
|
186
|
+
});
|
|
187
|
+
}
|
|
188
|
+
},
|
|
189
|
+
};
|
|
190
|
+
}
|
|
158
191
|
return {
|
|
159
192
|
MemberExpression(node) {
|
|
160
|
-
|
|
161
|
-
|
|
162
|
-
return;
|
|
163
|
-
}
|
|
164
|
-
const key = memberKey(node);
|
|
165
|
-
const property = node['property'];
|
|
166
|
-
if (!key || !isAstNode(property)) {
|
|
193
|
+
const read = processEnvRead(node);
|
|
194
|
+
if (!read || declared.keys.has(read.key))
|
|
167
195
|
return;
|
|
168
|
-
}
|
|
169
|
-
if (declared.error) {
|
|
170
|
-
if (reportedStartupError) {
|
|
171
|
-
return;
|
|
172
|
-
}
|
|
173
|
-
reportedStartupError = true;
|
|
174
|
-
context.report({
|
|
175
|
-
node: property,
|
|
176
|
-
messageId: 'startupUnavailable',
|
|
177
|
-
data: { error: declared.error },
|
|
178
|
-
});
|
|
179
|
-
return;
|
|
180
|
-
}
|
|
181
|
-
if (declared.keys.has(key)) {
|
|
182
|
-
return;
|
|
183
|
-
}
|
|
184
196
|
context.report({
|
|
185
|
-
node: property,
|
|
197
|
+
node: read.property,
|
|
186
198
|
messageId: 'undeclaredEnv',
|
|
187
199
|
data: {
|
|
188
|
-
key,
|
|
200
|
+
key: read.key,
|
|
189
201
|
startupFile: relativeToWorkspace(startupPath),
|
|
190
202
|
},
|
|
191
203
|
});
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"no-undeclared-process-env.js","sourceRoot":"","sources":["../../src/environment/no-undeclared-process-env.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,YAAY,EAAE,QAAQ,EAAE,MAAM,SAAS,CAAC;AACjD,OAAO,EAAE,OAAO,EAAE,OAAO,EAAE,MAAM,WAAW,CAAC;AAG7C,OAAO,KAAK,EAAE,MAAM,YAAY,CAAC;AAEjC,OAAO,EAEL,cAAc,EACd,SAAS,EACT,MAAM,GACP,MAAM,qBAAqB,CAAC;AAC7B,OAAO,EAAE,QAAQ,EAAE,MAAM,sBAAsB,CAAC;AAChD,OAAO,EAAE,SAAS,EAAE,MAAM,kCAAkC,CAAC;AAC7D,OAAO,EACL,mBAAmB,EACnB,eAAe,GAChB,MAAM,gCAAgC,CAAC;AAQxC,4EAA4E;AAC5E,sDAAsD;AACtD,MAAM,qBAAqB,GAAG,IAAI,GAAG,EAAuB,CAAC;AAE7D,SAAS,SAAS,CAAC,IAAa;IAC9B,MAAM,QAAQ,GAAG,IAAI,CAAC,UAAU,CAAC,CAAC;IAClC,IAAI,IAAI,CAAC,UAAU,CAAC,KAAK,IAAI,EAAE,CAAC;QAC9B,OAAO,cAAc,CAAC,QAAQ,CAAC,CAAC;IAClC,CAAC;IAED,IAAI,MAAM,CAAC,QAAQ,EAAE,SAAS,CAAC,IAAI,OAAO,QAAQ,CAAC,OAAO,CAAC,KAAK,QAAQ,EAAE,CAAC;QACzE,OAAO,QAAQ,CAAC,OAAO,CAAC,CAAC;IAC3B,CAAC;IAED,OAAO,SAAS,CAAC;AACnB,CAAC;AAED,SAAS,kBAAkB,CAAC,IAAa;IACvC,OAAO,CACL,MAAM,CAAC,IAAI,EAAE,kBAAkB,CAAC;QAChC,SAAS,CAAC,IAAI,CAAC,KAAK,KAAK;QACzB,cAAc,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,KAAK,SAAS,CAC7C,CAAC;AACJ,CAAC;AAED,MAAM,oBAAoB,GAAG,gBAAgB,CAAC;AAE9C;;;;GAIG;AACH,SAAS,kBAAkB,CAAC,OAAyB;IACnD,MAAM,WAAW,GAAG,QAAQ,CAAC,OAAO,CAAC,QAAQ,CAAC;QAC5C,CAAC,CAAC,OAAO,CAAC,QAAQ,CAAC,KAAK,CAAC;QACzB,CAAC,CAAC,SAAS,CAAC;IACd,MAAM,WAAW,GAAG,QAAQ,CAAC,WAAW,CAAC;QACvC,CAAC,CAAC,WAAW,CAAC,aAAa,CAAC;QAC5B,CAAC,CAAC,SAAS,CAAC;IACd,IAAI,WAAW,KAAK,SAAS,EAAE,CAAC;QAC9B,OAAO,oBAAoB,CAAC;IAC9B,CAAC;IACD,IAAI,OAAO,WAAW,KAAK,QAAQ,EAAE,CAAC;QACpC,MAAM,IAAI,SAAS,CACjB,uEAAuE,CACxE,CAAC;IACJ,CAAC;IACD,OAAO,WAAW,CAAC;AACrB,CAAC;AAED;;;;GAIG;AACH,SAAS,kBAAkB,CACzB,OAAyB,EACzB,WAAmB;IAEnB,MAAM,QAAQ,GAAG,OAAO,CAAC,OAAO,CAAC,GAAG,EAAE,OAAO,CAAC,gBAAgB,CAAC,CAAC;IAChE,MAAM,IAAI,GACR,SAAS,CAAC,QAAQ,CAAC,EAAE,IAAI;QACzB,eAAe,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAC;QAClC,OAAO,CAAC,GAAG,CAAC;IACd,OAAO,OAAO,CAAC,IAAI,EAAE,WAAW,CAAC,CAAC;AACpC,CAAC;AAED,SAAS,kBAAkB,CAAC,IAAqB;IAC/C,IACE,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC;QACrB,EAAE,CAAC,eAAe,CAAC,IAAI,CAAC;QACxB,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,EACzB,CAAC;QACD,OAAO,IAAI,CAAC,IAAI,CAAC;IACnB,CAAC;IAED,OAAO,SAAS,CAAC;AACnB,CAAC;AAED,SAAS,gBAAgB,CACvB,IAAmB;IAEnB,IACE,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC;QACzB,EAAE,CAAC,0BAA0B,CAAC,IAAI,CAAC,UAAU,CAAC;QAC9C,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,UAAU,CAAC,UAAU,CAAC;QAC3C,IAAI,CAAC,UAAU,CAAC,UAAU,CAAC,IAAI,KAAK,GAAG;QACvC,IAAI,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,KAAK,QAAQ,EACtC,CAAC;QACD,MAAM,CAAC,MAAM,CAAC,GAAG,IAAI,CAAC,SAAS,CAAC;QAChC,OAAO,MAAM,IAAI,EAAE,CAAC,yBAAyB,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,SAAS,CAAC;IAC7E,CAAC;IAED,OAAO,SAAS,CAAC;AACnB,CAAC;AAED,SAAS,oBAAoB,CAAC,WAAmB;IAC/C,MAAM,MAAM,GAAG,YAAY,CAAC,WAAW,EAAE,MAAM,CAAC,CAAC;IACjD,MAAM,UAAU,GAAG,EAAE,CAAC,gBAAgB,CACpC,WAAW,EACX,MAAM,EACN,EAAE,CAAC,YAAY,CAAC,MAAM,EACtB,IAAI,EACJ,EAAE,CAAC,UAAU,CAAC,EAAE,CACjB,CAAC;IACF,MAAM,IAAI,GAAG,IAAI,GAAG,EAAU,CAAC;IAC/B,IAAI,cAAc,GAAG,KAAK,CAAC;IAE3B,SAAS,KAAK,CAAC,IAAa;QAC1B,IACE,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC;YAC9B,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,IAAI,CAAC;YAC1B,IAAI,CAAC,IAAI,CAAC,IAAI,KAAK,KAAK;YACxB,IAAI,CAAC,WAAW,EAChB,CAAC;YACD,MAAM,aAAa,GAAG,gBAAgB,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;YACzD,IAAI,aAAa,EAAE,CAAC;gBAClB,cAAc,GAAG,IAAI,CAAC;gBACtB,KAAK,MAAM,QAAQ,IAAI,aAAa,CAAC,UAAU,EAAE,CAAC;oBAChD,IACE,EAAE,CAAC,oBAAoB,CAAC,QAAQ,CAAC;wBACjC,EAAE,CAAC,6BAA6B,CAAC,QAAQ,CAAC;wBAC1C,EAAE,CAAC,mBAAmB,CAAC,QAAQ,CAAC,EAChC,CAAC;wBACD,MAAM,GAAG,GAAG,kBAAkB,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;wBAC9C,IAAI,GAAG,EAAE,CAAC;4BACR,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC,CAAC;wBAChB,CAAC;oBACH,CAAC;gBACH,CAAC;YACH,CAAC;QACH,CAAC;QAED,EAAE,CAAC,YAAY,CAAC,IAAI,EAAE,KAAK,CAAC,CAAC;IAC/B,CAAC;IAED,KAAK,CAAC,UAAU,CAAC,CAAC;IAElB,IAAI,CAAC,cAAc,EAAE,CAAC;QACpB,MAAM,IAAI,KAAK,CACb,iDAAiD,WAAW,EAAE,CAC/D,CAAC;IACJ,CAAC;IAED,OAAO,IAAI,CAAC;AACd,CAAC;AAED,SAAS,aAAa,CAAC,WAAmB;IACxC,IAAI,CAAC;QACH,MAAM,EAAE,OAAO,EAAE,GAAG,QAAQ,CAAC,WAAW,CAAC,CAAC;QAC1C,MAAM,MAAM,GAAG,qBAAqB,CAAC,GAAG,CAAC,WAAW,CAAC,CAAC;QACtD,IAAI,MAAM,IAAI,MAAM,CAAC,OAAO,KAAK,OAAO,EAAE,CAAC;YACzC,OAAO,MAAM,CAAC;QAChB,CAAC;QAED,MAAM,KAAK,GAAgB;YACzB,OAAO;YACP,IAAI,EAAE,oBAAoB,CAAC,WAAW,CAAC;SACxC,CAAC;QACF,qBAAqB,CAAC,GAAG,CAAC,WAAW,EAAE,KAAK,CAAC,CAAC;QAC9C,OAAO,KAAK,CAAC;IACf,CAAC;IAAC,OAAO,KAAK,EAAE,CAAC;QACf,MAAM,KAAK,GAAgB;YACzB,OAAO,EAAE,CAAC,CAAC;YACX,IAAI,EAAE,IAAI,GAAG,EAAE;YACf,KAAK,EAAE,KAAK,YAAY,KAAK,CAAC,CAAC,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,CAAC,MAAM,CAAC,KAAK,CAAC;SAC9D,CAAC;QACF,qBAAqB,CAAC,GAAG,CAAC,WAAW,EAAE,KAAK,CAAC,CAAC;QAC9C,OAAO,KAAK,CAAC;IACf,CAAC;AACH,CAAC;AAED;;;;;;GAMG;AACH,MAAM,IAAI,GAAoB;IAC5B,IAAI,EAAE;QACJ,IAAI,EAAE,SAAS;QACf,IAAI,EAAE;YACJ,WAAW,EACT,wEAAwE;SAC3E;QACD,QAAQ,EAAE;YACR,kBAAkB,EAChB,+FAA+F;YACjG,aAAa,EACX,sEAAsE;SACzE;QACD,MAAM,EAAE,EAAE;KACX;IACD,MAAM,CAAC,OAAO;QACZ,MAAM,WAAW,GAAG,kBAAkB,CACpC,OAAO,EACP,kBAAkB,CAAC,OAAO,CAAC,CAC5B,CAAC;QACF,MAAM,QAAQ,GAAG,aAAa,CAAC,WAAW,CAAC,CAAC;QAC5C,
|
|
1
|
+
{"version":3,"file":"no-undeclared-process-env.js","sourceRoot":"","sources":["../../src/environment/no-undeclared-process-env.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,YAAY,EAAE,QAAQ,EAAE,MAAM,SAAS,CAAC;AACjD,OAAO,EAAE,OAAO,EAAE,OAAO,EAAE,MAAM,WAAW,CAAC;AAG7C,OAAO,KAAK,EAAE,MAAM,YAAY,CAAC;AAEjC,OAAO,EAEL,cAAc,EACd,SAAS,EACT,MAAM,GACP,MAAM,qBAAqB,CAAC;AAC7B,OAAO,EAAE,QAAQ,EAAE,MAAM,sBAAsB,CAAC;AAChD,OAAO,EAAE,SAAS,EAAE,MAAM,kCAAkC,CAAC;AAC7D,OAAO,EACL,mBAAmB,EACnB,eAAe,GAChB,MAAM,gCAAgC,CAAC;AAQxC,4EAA4E;AAC5E,sDAAsD;AACtD,MAAM,qBAAqB,GAAG,IAAI,GAAG,EAAuB,CAAC;AAE7D,4EAA4E;AAC5E,SAAS,cAAc,CACrB,IAAa;IAEb,IACE,CAAC,MAAM,CAAC,IAAI,EAAE,kBAAkB,CAAC;QACjC,CAAC,kBAAkB,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,EACnC,CAAC;QACD,OAAO,SAAS,CAAC;IACnB,CAAC;IACD,MAAM,GAAG,GAAG,SAAS,CAAC,IAAI,CAAC,CAAC;IAC5B,MAAM,QAAQ,GAAG,IAAI,CAAC,UAAU,CAAC,CAAC;IAClC,IAAI,CAAC,GAAG,IAAI,CAAC,SAAS,CAAC,QAAQ,CAAC;QAAE,OAAO,SAAS,CAAC;IACnD,OAAO,EAAE,GAAG,EAAE,QAAQ,EAAE,CAAC;AAC3B,CAAC;AAED,SAAS,SAAS,CAAC,IAAa;IAC9B,MAAM,QAAQ,GAAG,IAAI,CAAC,UAAU,CAAC,CAAC;IAClC,IAAI,IAAI,CAAC,UAAU,CAAC,KAAK,IAAI,EAAE,CAAC;QAC9B,OAAO,cAAc,CAAC,QAAQ,CAAC,CAAC;IAClC,CAAC;IAED,IAAI,MAAM,CAAC,QAAQ,EAAE,SAAS,CAAC,IAAI,OAAO,QAAQ,CAAC,OAAO,CAAC,KAAK,QAAQ,EAAE,CAAC;QACzE,OAAO,QAAQ,CAAC,OAAO,CAAC,CAAC;IAC3B,CAAC;IAED,OAAO,SAAS,CAAC;AACnB,CAAC;AAED,SAAS,kBAAkB,CAAC,IAAa;IACvC,OAAO,CACL,MAAM,CAAC,IAAI,EAAE,kBAAkB,CAAC;QAChC,SAAS,CAAC,IAAI,CAAC,KAAK,KAAK;QACzB,cAAc,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,KAAK,SAAS,CAC7C,CAAC;AACJ,CAAC;AAED,MAAM,oBAAoB,GAAG,gBAAgB,CAAC;AAE9C;;;;GAIG;AACH,SAAS,kBAAkB,CAAC,OAAyB;IACnD,MAAM,WAAW,GAAG,QAAQ,CAAC,OAAO,CAAC,QAAQ,CAAC;QAC5C,CAAC,CAAC,OAAO,CAAC,QAAQ,CAAC,KAAK,CAAC;QACzB,CAAC,CAAC,SAAS,CAAC;IACd,MAAM,WAAW,GAAG,QAAQ,CAAC,WAAW,CAAC;QACvC,CAAC,CAAC,WAAW,CAAC,aAAa,CAAC;QAC5B,CAAC,CAAC,SAAS,CAAC;IACd,IAAI,WAAW,KAAK,SAAS,EAAE,CAAC;QAC9B,OAAO,oBAAoB,CAAC;IAC9B,CAAC;IACD,IAAI,OAAO,WAAW,KAAK,QAAQ,EAAE,CAAC;QACpC,MAAM,IAAI,SAAS,CACjB,uEAAuE,CACxE,CAAC;IACJ,CAAC;IACD,OAAO,WAAW,CAAC;AACrB,CAAC;AAED;;;;GAIG;AACH,SAAS,kBAAkB,CACzB,OAAyB,EACzB,WAAmB;IAEnB,MAAM,QAAQ,GAAG,OAAO,CAAC,OAAO,CAAC,GAAG,EAAE,OAAO,CAAC,gBAAgB,CAAC,CAAC;IAChE,MAAM,IAAI,GACR,SAAS,CAAC,QAAQ,CAAC,EAAE,IAAI;QACzB,eAAe,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAC;QAClC,OAAO,CAAC,GAAG,CAAC;IACd,OAAO,OAAO,CAAC,IAAI,EAAE,WAAW,CAAC,CAAC;AACpC,CAAC;AAED,SAAS,kBAAkB,CAAC,IAAqB;IAC/C,IACE,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC;QACrB,EAAE,CAAC,eAAe,CAAC,IAAI,CAAC;QACxB,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,EACzB,CAAC;QACD,OAAO,IAAI,CAAC,IAAI,CAAC;IACnB,CAAC;IAED,OAAO,SAAS,CAAC;AACnB,CAAC;AAED,SAAS,gBAAgB,CACvB,IAAmB;IAEnB,IACE,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC;QACzB,EAAE,CAAC,0BAA0B,CAAC,IAAI,CAAC,UAAU,CAAC;QAC9C,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,UAAU,CAAC,UAAU,CAAC;QAC3C,IAAI,CAAC,UAAU,CAAC,UAAU,CAAC,IAAI,KAAK,GAAG;QACvC,IAAI,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,KAAK,QAAQ,EACtC,CAAC;QACD,MAAM,CAAC,MAAM,CAAC,GAAG,IAAI,CAAC,SAAS,CAAC;QAChC,OAAO,MAAM,IAAI,EAAE,CAAC,yBAAyB,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,SAAS,CAAC;IAC7E,CAAC;IAED,OAAO,SAAS,CAAC;AACnB,CAAC;AAED,SAAS,oBAAoB,CAAC,WAAmB;IAC/C,MAAM,MAAM,GAAG,YAAY,CAAC,WAAW,EAAE,MAAM,CAAC,CAAC;IACjD,MAAM,UAAU,GAAG,EAAE,CAAC,gBAAgB,CACpC,WAAW,EACX,MAAM,EACN,EAAE,CAAC,YAAY,CAAC,MAAM,EACtB,IAAI,EACJ,EAAE,CAAC,UAAU,CAAC,EAAE,CACjB,CAAC;IACF,MAAM,IAAI,GAAG,IAAI,GAAG,EAAU,CAAC;IAC/B,IAAI,cAAc,GAAG,KAAK,CAAC;IAE3B,SAAS,KAAK,CAAC,IAAa;QAC1B,IACE,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC;YAC9B,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,IAAI,CAAC;YAC1B,IAAI,CAAC,IAAI,CAAC,IAAI,KAAK,KAAK;YACxB,IAAI,CAAC,WAAW,EAChB,CAAC;YACD,MAAM,aAAa,GAAG,gBAAgB,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;YACzD,IAAI,aAAa,EAAE,CAAC;gBAClB,cAAc,GAAG,IAAI,CAAC;gBACtB,KAAK,MAAM,QAAQ,IAAI,aAAa,CAAC,UAAU,EAAE,CAAC;oBAChD,IACE,EAAE,CAAC,oBAAoB,CAAC,QAAQ,CAAC;wBACjC,EAAE,CAAC,6BAA6B,CAAC,QAAQ,CAAC;wBAC1C,EAAE,CAAC,mBAAmB,CAAC,QAAQ,CAAC,EAChC,CAAC;wBACD,MAAM,GAAG,GAAG,kBAAkB,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;wBAC9C,IAAI,GAAG,EAAE,CAAC;4BACR,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC,CAAC;wBAChB,CAAC;oBACH,CAAC;gBACH,CAAC;YACH,CAAC;QACH,CAAC;QAED,EAAE,CAAC,YAAY,CAAC,IAAI,EAAE,KAAK,CAAC,CAAC;IAC/B,CAAC;IAED,KAAK,CAAC,UAAU,CAAC,CAAC;IAElB,IAAI,CAAC,cAAc,EAAE,CAAC;QACpB,MAAM,IAAI,KAAK,CACb,iDAAiD,WAAW,EAAE,CAC/D,CAAC;IACJ,CAAC;IAED,OAAO,IAAI,CAAC;AACd,CAAC;AAED,SAAS,aAAa,CAAC,WAAmB;IACxC,IAAI,CAAC;QACH,MAAM,EAAE,OAAO,EAAE,GAAG,QAAQ,CAAC,WAAW,CAAC,CAAC;QAC1C,MAAM,MAAM,GAAG,qBAAqB,CAAC,GAAG,CAAC,WAAW,CAAC,CAAC;QACtD,IAAI,MAAM,IAAI,MAAM,CAAC,OAAO,KAAK,OAAO,EAAE,CAAC;YACzC,OAAO,MAAM,CAAC;QAChB,CAAC;QAED,MAAM,KAAK,GAAgB;YACzB,OAAO;YACP,IAAI,EAAE,oBAAoB,CAAC,WAAW,CAAC;SACxC,CAAC;QACF,qBAAqB,CAAC,GAAG,CAAC,WAAW,EAAE,KAAK,CAAC,CAAC;QAC9C,OAAO,KAAK,CAAC;IACf,CAAC;IAAC,OAAO,KAAK,EAAE,CAAC;QACf,MAAM,KAAK,GAAgB;YACzB,OAAO,EAAE,CAAC,CAAC;YACX,IAAI,EAAE,IAAI,GAAG,EAAE;YACf,KAAK,EAAE,KAAK,YAAY,KAAK,CAAC,CAAC,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,CAAC,MAAM,CAAC,KAAK,CAAC;SAC9D,CAAC;QACF,qBAAqB,CAAC,GAAG,CAAC,WAAW,EAAE,KAAK,CAAC,CAAC;QAC9C,OAAO,KAAK,CAAC;IACf,CAAC;AACH,CAAC;AAED;;;;;;GAMG;AACH,MAAM,IAAI,GAAoB;IAC5B,IAAI,EAAE;QACJ,IAAI,EAAE,SAAS;QACf,IAAI,EAAE;YACJ,WAAW,EACT,wEAAwE;SAC3E;QACD,QAAQ,EAAE;YACR,kBAAkB,EAChB,+FAA+F;YACjG,aAAa,EACX,sEAAsE;SACzE;QACD,MAAM,EAAE,EAAE;KACX;IACD,MAAM,CAAC,OAAO;QACZ,MAAM,WAAW,GAAG,kBAAkB,CACpC,OAAO,EACP,kBAAkB,CAAC,OAAO,CAAC,CAC5B,CAAC;QACF,MAAM,QAAQ,GAAG,aAAa,CAAC,WAAW,CAAC,CAAC;QAC5C,MAAM,EAAE,KAAK,EAAE,GAAG,QAAQ,CAAC;QAE3B,IAAI,KAAK,EAAE,CAAC;YACV,yDAAyD;YACzD,MAAM,KAAK,GAAc,EAAE,CAAC;YAC5B,OAAO;gBACL,gBAAgB,CAAC,IAAI;oBACnB,MAAM,IAAI,GAAG,cAAc,CAAC,IAAI,CAAC,CAAC;oBAClC,IAAI,IAAI;wBAAE,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;gBACtC,CAAC;gBACD,cAAc;oBACZ,MAAM,CAAC,KAAK,CAAC,GAAG,KAAK,CAAC;oBACtB,IAAI,KAAK,EAAE,CAAC;wBACV,OAAO,CAAC,MAAM,CAAC;4BACb,IAAI,EAAE,KAAK;4BACX,SAAS,EAAE,oBAAoB;4BAC/B,IAAI,EAAE,EAAE,KAAK,EAAE;yBAChB,CAAC,CAAC;oBACL,CAAC;gBACH,CAAC;aACF,CAAC;QACJ,CAAC;QAED,OAAO;YACL,gBAAgB,CAAC,IAAI;gBACnB,MAAM,IAAI,GAAG,cAAc,CAAC,IAAI,CAAC,CAAC;gBAClC,IAAI,CAAC,IAAI,IAAI,QAAQ,CAAC,IAAI,CAAC,GAAG,CAAC,IAAI,CAAC,GAAG,CAAC;oBAAE,OAAO;gBACjD,OAAO,CAAC,MAAM,CAAC;oBACb,IAAI,EAAE,IAAI,CAAC,QAAQ;oBACnB,SAAS,EAAE,eAAe;oBAC1B,IAAI,EAAE;wBACJ,GAAG,EAAE,IAAI,CAAC,GAAG;wBACb,WAAW,EAAE,mBAAmB,CAAC,WAAW,CAAC;qBAC9C;iBACF,CAAC,CAAC;YACL,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC;AAEF,eAAe,IAAI,CAAC"}
|
|
@@ -0,0 +1,7 @@
|
|
|
1
|
+
/**
|
|
2
|
+
* Hermes on iOS ignores `notation: 'compact'` and `compactDisplay` without an
|
|
3
|
+
* error: `format(44000)` gives `44,000`, not `44K`.
|
|
4
|
+
*/
|
|
5
|
+
declare const _default: import("eslint").Rule.RuleModule;
|
|
6
|
+
export default _default;
|
|
7
|
+
//# sourceMappingURL=no-compact-notation.d.ts.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"no-compact-notation.d.ts","sourceRoot":"","sources":["../../src/hermes/no-compact-notation.ts"],"names":[],"mappings":"AAKA;;;GAGG;;AACH,wBASG"}
|
|
@@ -0,0 +1,15 @@
|
|
|
1
|
+
import { selectorRule } from "../authoring/selector-rule.js";
|
|
2
|
+
const numberFormat = ":matches(NewExpression, CallExpression)[callee.object.name='Intl'][callee.property.name='NumberFormat'] > ObjectExpression";
|
|
3
|
+
/**
|
|
4
|
+
* Hermes on iOS ignores `notation: 'compact'` and `compactDisplay` without an
|
|
5
|
+
* error: `format(44000)` gives `44,000`, not `44K`.
|
|
6
|
+
*/
|
|
7
|
+
export default selectorRule({
|
|
8
|
+
description: "Disallow notation: 'compact' and compactDisplay in Intl.NumberFormat options, which Hermes on iOS ignores",
|
|
9
|
+
selectors: [
|
|
10
|
+
`${numberFormat} > Property:matches([key.name='notation'], [key.value='notation'])[value.value='compact']`,
|
|
11
|
+
`${numberFormat} > Property:matches([key.name='compactDisplay'], [key.value='compactDisplay'])`,
|
|
12
|
+
],
|
|
13
|
+
message: "Hermes on iOS ignores notation: 'compact' and compactDisplay, and formats the full number. Build the short form yourself.",
|
|
14
|
+
});
|
|
15
|
+
//# sourceMappingURL=no-compact-notation.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"no-compact-notation.js","sourceRoot":"","sources":["../../src/hermes/no-compact-notation.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,YAAY,EAAE,MAAM,+BAA+B,CAAC;AAE7D,MAAM,YAAY,GAChB,4HAA4H,CAAC;AAE/H;;;GAGG;AACH,eAAe,YAAY,CAAC;IAC1B,WAAW,EACT,2GAA2G;IAC7G,SAAS,EAAE;QACT,GAAG,YAAY,2FAA2F;QAC1G,GAAG,YAAY,gFAAgF;KAChG;IACD,OAAO,EACL,2HAA2H;CAC9H,CAAC,CAAC"}
|
package/dist/hermes/plugin.d.ts
CHANGED
|
@@ -11,6 +11,7 @@ declare const plugin: {
|
|
|
11
11
|
namespace: string;
|
|
12
12
|
};
|
|
13
13
|
rules: {
|
|
14
|
+
'no-compact-notation': import("eslint").Rule.RuleModule;
|
|
14
15
|
'no-missing-console': import("eslint").Rule.RuleModule;
|
|
15
16
|
};
|
|
16
17
|
configs: Record<string, Linter.Config<import("@eslint/core", { with: { "resolution-mode": "require" } }).RulesConfig>[]>;
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"plugin.d.ts","sourceRoot":"","sources":["../../src/hermes/plugin.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAU,MAAM,EAAE,MAAM,QAAQ,CAAC;
|
|
1
|
+
{"version":3,"file":"plugin.d.ts","sourceRoot":"","sources":["../../src/hermes/plugin.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAU,MAAM,EAAE,MAAM,QAAQ,CAAC;AAqB7C;;;;;GAKG;AACH,QAAA,MAAM,MAAM;;;;;;;;;;CAIa,CAAC;AA2B1B,eAAe,MAAM,CAAC"}
|
package/dist/hermes/plugin.js
CHANGED
|
@@ -1,8 +1,12 @@
|
|
|
1
1
|
import esx from 'eslint-plugin-es-x';
|
|
2
2
|
import importX from 'eslint-plugin-import-x';
|
|
3
3
|
import { CONFIG_FILES, SCRIPTS, SOURCE, TESTS, TEST_SUPPORT, } from "../files.js";
|
|
4
|
+
import noCompactNotation from "./no-compact-notation.js";
|
|
4
5
|
import noMissingConsole from "./no-missing-console.js";
|
|
5
|
-
const rules = {
|
|
6
|
+
const rules = {
|
|
7
|
+
'no-compact-notation': noCompactNotation,
|
|
8
|
+
'no-missing-console': noMissingConsole,
|
|
9
|
+
};
|
|
6
10
|
const configs = {};
|
|
7
11
|
/**
|
|
8
12
|
* Hermes: the JavaScript engine of React Native. Code that ships in the app
|
|
@@ -26,6 +30,7 @@ configs['recommended'] = [
|
|
|
26
30
|
ignores: [...TESTS, ...TEST_SUPPORT, ...CONFIG_FILES, ...SCRIPTS],
|
|
27
31
|
rules: {
|
|
28
32
|
'hermes/no-missing-console': 'error',
|
|
33
|
+
'hermes/no-compact-notation': 'error',
|
|
29
34
|
// Hermes implements Collator, DateTimeFormat and NumberFormat only.
|
|
30
35
|
'es-x/no-intl-displaynames': 'error',
|
|
31
36
|
'es-x/no-intl-durationformat': 'error',
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"plugin.js","sourceRoot":"","sources":["../../src/hermes/plugin.ts"],"names":[],"mappings":"AACA,OAAO,GAAG,MAAM,oBAAoB,CAAC;AACrC,OAAO,OAAO,MAAM,wBAAwB,CAAC;AAE7C,OAAO,EACL,YAAY,EACZ,OAAO,EACP,MAAM,EACN,KAAK,EACL,YAAY,GACb,MAAM,aAAa,CAAC;AACrB,OAAO,gBAAgB,MAAM,yBAAyB,CAAC;AAEvD,MAAM,KAAK,GAAG,EAAE,oBAAoB,EAAE,gBAAgB,
|
|
1
|
+
{"version":3,"file":"plugin.js","sourceRoot":"","sources":["../../src/hermes/plugin.ts"],"names":[],"mappings":"AACA,OAAO,GAAG,MAAM,oBAAoB,CAAC;AACrC,OAAO,OAAO,MAAM,wBAAwB,CAAC;AAE7C,OAAO,EACL,YAAY,EACZ,OAAO,EACP,MAAM,EACN,KAAK,EACL,YAAY,GACb,MAAM,aAAa,CAAC;AACrB,OAAO,iBAAiB,MAAM,0BAA0B,CAAC;AACzD,OAAO,gBAAgB,MAAM,yBAAyB,CAAC;AAEvD,MAAM,KAAK,GAAG;IACZ,qBAAqB,EAAE,iBAAiB;IACxC,oBAAoB,EAAE,gBAAgB;CACvC,CAAC;AAEF,MAAM,OAAO,GAAoC,EAAE,CAAC;AAEpD;;;;;GAKG;AACH,MAAM,MAAM,GAAG;IACb,IAAI,EAAE,EAAE,IAAI,EAAE,8BAA8B,EAAE,SAAS,EAAE,QAAQ,EAAE;IACnE,KAAK;IACL,OAAO;CACgB,CAAC;AAE1B,OAAO,CAAC,aAAa,CAAC,GAAG;IACvB;QACE,IAAI,EAAE,4BAA4B;QAClC,OAAO,EAAE,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,EAAE,GAAG,EAAE,UAAU,EAAE,OAAO,EAAE;KAC9D;IACD;QACE,IAAI,EAAE,oBAAoB;QAC1B,KAAK,EAAE,MAAM;QACb,OAAO,EAAE,CAAC,GAAG,KAAK,EAAE,GAAG,YAAY,EAAE,GAAG,YAAY,EAAE,GAAG,OAAO,CAAC;QACjE,KAAK,EAAE;YACL,2BAA2B,EAAE,OAAO;YACpC,4BAA4B,EAAE,OAAO;YACrC,oEAAoE;YACpE,2BAA2B,EAAE,OAAO;YACpC,6BAA6B,EAAE,OAAO;YACtC,yBAAyB,EAAE,OAAO;YAClC,qBAAqB,EAAE,OAAO;YAC9B,0BAA0B,EAAE,OAAO;YACnC,iCAAiC,EAAE,OAAO;YAC1C,wBAAwB,EAAE,OAAO;YACjC,4BAA4B,EAAE,OAAO;SACtC;KACF;CACF,CAAC;AAEF,eAAe,MAAM,CAAC"}
|
|
@@ -1,8 +1,3 @@
|
|
|
1
|
-
/**
|
|
2
|
-
* A port the host implements (a requester, a store) returns `unknown`, and
|
|
3
|
-
* each consumer narrows it where it reads it. A generic response forces every
|
|
4
|
-
* test stub to assert into T or to return `any`.
|
|
5
|
-
*/
|
|
6
1
|
declare const _default: import("eslint").Rule.RuleModule;
|
|
7
2
|
export default _default;
|
|
8
3
|
//# sourceMappingURL=no-generic-port.d.ts.map
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"no-generic-port.d.ts","sourceRoot":"","sources":["../../src/island/no-generic-port.ts"],"names":[],"mappings":"
|
|
1
|
+
{"version":3,"file":"no-generic-port.d.ts","sourceRoot":"","sources":["../../src/island/no-generic-port.ts"],"names":[],"mappings":";AAgEA,wBAAgC"}
|
|
@@ -1,14 +1,46 @@
|
|
|
1
|
-
import {
|
|
1
|
+
import { ESLintUtils } from '@typescript-eslint/utils';
|
|
2
|
+
import { eslintRule } from "../authoring/rule-module.js";
|
|
3
|
+
const isSignature = (node) => node.type === 'TSMethodSignature' ||
|
|
4
|
+
node.type === 'TSFunctionType' ||
|
|
5
|
+
node.type === 'TSCallSignatureDeclaration';
|
|
2
6
|
/**
|
|
3
7
|
* A port the host implements (a requester, a store) returns `unknown`, and
|
|
4
8
|
* each consumer narrows it where it reads it. A generic response forces every
|
|
5
|
-
* test stub to assert into T or to return `any`.
|
|
9
|
+
* test stub to assert into T or to return `any`. A type parameter that only
|
|
10
|
+
* the inputs use, such as the rows of a callback, is not a response.
|
|
6
11
|
*/
|
|
7
|
-
|
|
8
|
-
|
|
9
|
-
|
|
10
|
-
|
|
11
|
-
|
|
12
|
-
|
|
12
|
+
const rule = ESLintUtils.RuleCreator.withoutDocs({
|
|
13
|
+
meta: {
|
|
14
|
+
type: 'problem',
|
|
15
|
+
docs: {
|
|
16
|
+
description: 'Disallow ports (interfaces and function types) whose methods are generic in their response',
|
|
17
|
+
},
|
|
18
|
+
schema: [],
|
|
19
|
+
messages: {
|
|
20
|
+
matched: 'A port must not be generic in its response. Return unknown and narrow at the call site.',
|
|
21
|
+
},
|
|
22
|
+
},
|
|
23
|
+
defaultOptions: [],
|
|
24
|
+
create(context) {
|
|
25
|
+
const reported = new Set();
|
|
26
|
+
return {
|
|
27
|
+
':matches(TSInterfaceDeclaration, TSTypeAliasDeclaration) TSTypeReference'(reference) {
|
|
28
|
+
if (reference.typeName.type !== 'Identifier')
|
|
29
|
+
return;
|
|
30
|
+
const { name } = reference.typeName;
|
|
31
|
+
const ancestors = context.sourceCode.getAncestors(reference);
|
|
32
|
+
// The nearest signature that declares the name owns the reference.
|
|
33
|
+
const owner = ancestors.findLast((node) => isSignature(node) &&
|
|
34
|
+
node.typeParameters?.params.some((parameter) => parameter.name.name === name) === true);
|
|
35
|
+
if (owner?.returnType &&
|
|
36
|
+
ancestors.includes(owner.returnType) &&
|
|
37
|
+
!reported.has(owner)) {
|
|
38
|
+
reported.add(owner);
|
|
39
|
+
context.report({ node: owner, messageId: 'matched' });
|
|
40
|
+
}
|
|
41
|
+
},
|
|
42
|
+
};
|
|
43
|
+
},
|
|
13
44
|
});
|
|
45
|
+
export default eslintRule(rule);
|
|
14
46
|
//# sourceMappingURL=no-generic-port.js.map
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"no-generic-port.js","sourceRoot":"","sources":["../../src/island/no-generic-port.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,
|
|
1
|
+
{"version":3,"file":"no-generic-port.js","sourceRoot":"","sources":["../../src/island/no-generic-port.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,WAAW,EAAiB,MAAM,0BAA0B,CAAC;AAEtE,OAAO,EAAE,UAAU,EAAE,MAAM,6BAA6B,CAAC;AAOzD,MAAM,WAAW,GAAG,CAAC,IAAmB,EAAqB,EAAE,CAC7D,IAAI,CAAC,IAAI,KAAK,mBAAmB;IACjC,IAAI,CAAC,IAAI,KAAK,gBAAgB;IAC9B,IAAI,CAAC,IAAI,KAAK,4BAA4B,CAAC;AAE7C;;;;;GAKG;AACH,MAAM,IAAI,GAAG,WAAW,CAAC,WAAW,CAAC,WAAW,CAAC;IAC/C,IAAI,EAAE;QACJ,IAAI,EAAE,SAAS;QACf,IAAI,EAAE;YACJ,WAAW,EACT,4FAA4F;SAC/F;QACD,MAAM,EAAE,EAAE;QACV,QAAQ,EAAE;YACR,OAAO,EACL,yFAAyF;SAC5F;KACF;IACD,cAAc,EAAE,EAAE;IAClB,MAAM,CAAC,OAAO;QACZ,MAAM,QAAQ,GAAG,IAAI,GAAG,EAAa,CAAC;QACtC,OAAO;YACL,0EAA0E,CACxE,SAAmC;gBAEnC,IAAI,SAAS,CAAC,QAAQ,CAAC,IAAI,KAAK,YAAY;oBAAE,OAAO;gBACrD,MAAM,EAAE,IAAI,EAAE,GAAG,SAAS,CAAC,QAAQ,CAAC;gBACpC,MAAM,SAAS,GAAG,OAAO,CAAC,UAAU,CAAC,YAAY,CAAC,SAAS,CAAC,CAAC;gBAC7D,mEAAmE;gBACnE,MAAM,KAAK,GAAG,SAAS,CAAC,QAAQ,CAC9B,CAAC,IAAI,EAAqB,EAAE,CAC1B,WAAW,CAAC,IAAI,CAAC;oBACjB,IAAI,CAAC,cAAc,EAAE,MAAM,CAAC,IAAI,CAC9B,CAAC,SAAS,EAAE,EAAE,CAAC,SAAS,CAAC,IAAI,CAAC,IAAI,KAAK,IAAI,CAC5C,KAAK,IAAI,CACb,CAAC;gBACF,IACE,KAAK,EAAE,UAAU;oBACjB,SAAS,CAAC,QAAQ,CAAC,KAAK,CAAC,UAAU,CAAC;oBACpC,CAAC,QAAQ,CAAC,GAAG,CAAC,KAAK,CAAC,EACpB,CAAC;oBACD,QAAQ,CAAC,GAAG,CAAC,KAAK,CAAC,CAAC;oBACpB,OAAO,CAAC,MAAM,CAAC,EAAE,IAAI,EAAE,KAAK,EAAE,SAAS,EAAE,SAAS,EAAE,CAAC,CAAC;gBACxD,CAAC;YACH,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC,CAAC;AAEH,eAAe,UAAU,CAAC,IAAI,CAAC,CAAC"}
|
package/dist/react.d.ts.map
CHANGED
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"react.d.ts","sourceRoot":"","sources":["../src/react.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
|
|
1
|
+
{"version":3,"file":"react.d.ts","sourceRoot":"","sources":["../src/react.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;AAiBA,wBAMsD"}
|
package/dist/react.js
CHANGED
|
@@ -1,6 +1,7 @@
|
|
|
1
1
|
import eslintReact from '@eslint-react/eslint-plugin';
|
|
2
2
|
import jsxA11y from 'eslint-plugin-jsx-a11y-x';
|
|
3
3
|
import reactHooks from 'eslint-plugin-react-hooks';
|
|
4
|
+
import youMightNotNeedAnEffect from 'eslint-plugin-react-you-might-not-need-an-effect';
|
|
4
5
|
import { TYPESCRIPT } from "./files.js";
|
|
5
6
|
// react is an optional peer, because its version changes the lint result:
|
|
6
7
|
// @eslint-react/shared 5.28.8 (dist/index.js:184, :190-195) reads the version
|
|
@@ -16,5 +17,6 @@ export default [
|
|
|
16
17
|
reactHooks.configs.flat.recommended,
|
|
17
18
|
eslintReact.configs['recommended-type-checked'],
|
|
18
19
|
eslintReact.configs['disable-conflict-eslint-plugin-react-hooks'],
|
|
20
|
+
youMightNotNeedAnEffect.configs.strict,
|
|
19
21
|
].map((config) => ({ ...config, files: TYPESCRIPT }));
|
|
20
22
|
//# sourceMappingURL=react.js.map
|
package/dist/react.js.map
CHANGED
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"react.js","sourceRoot":"","sources":["../src/react.ts"],"names":[],"mappings":"AAAA,OAAO,WAAW,MAAM,6BAA6B,CAAC;AACtD,OAAO,OAAO,MAAM,0BAA0B,CAAC;AAC/C,OAAO,UAAU,MAAM,2BAA2B,CAAC;
|
|
1
|
+
{"version":3,"file":"react.js","sourceRoot":"","sources":["../src/react.ts"],"names":[],"mappings":"AAAA,OAAO,WAAW,MAAM,6BAA6B,CAAC;AACtD,OAAO,OAAO,MAAM,0BAA0B,CAAC;AAC/C,OAAO,UAAU,MAAM,2BAA2B,CAAC;AACnD,OAAO,uBAAuB,MAAM,kDAAkD,CAAC;AAEvF,OAAO,EAAE,UAAU,EAAE,MAAM,YAAY,CAAC;AAExC,0EAA0E;AAC1E,8EAA8E;AAC9E,+EAA+E;AAC/E,6EAA6E;AAC7E,sCAAsC;AAEtC,oFAAoF;AACpF,6EAA6E;AAC7E,4DAA4D;AAC5D,uBAAuB;AACvB,eAAe;IACb,OAAO,CAAC,OAAO,CAAC,WAAW;IAC3B,UAAU,CAAC,OAAO,CAAC,IAAI,CAAC,WAAW;IACnC,WAAW,CAAC,OAAO,CAAC,0BAA0B,CAAC;IAC/C,WAAW,CAAC,OAAO,CAAC,4CAA4C,CAAC;IACjE,uBAAuB,CAAC,OAAO,CAAC,MAAM;CACvC,CAAC,GAAG,CAAC,CAAC,MAAM,EAAE,EAAE,CAAC,CAAC,EAAE,GAAG,MAAM,EAAE,KAAK,EAAE,UAAU,EAAE,CAAC,CAAC,CAAC"}
|
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "@zukhruf/eslint",
|
|
3
|
-
"version": "0.6.
|
|
3
|
+
"version": "0.6.13",
|
|
4
4
|
"description": "ESLint rules and configs shared across workspaces. Every check is its own named rule, so a repo's own config cannot silently erase it.",
|
|
5
5
|
"license": "MIT",
|
|
6
6
|
"repository": {
|
|
@@ -62,7 +62,7 @@
|
|
|
62
62
|
"ts-api-utils": "^2.5.0"
|
|
63
63
|
},
|
|
64
64
|
"devDependencies": {
|
|
65
|
-
"@zukhruf/testing": "^0.6.
|
|
65
|
+
"@zukhruf/testing": "^0.6.13"
|
|
66
66
|
},
|
|
67
67
|
"peerDependencies": {
|
|
68
68
|
"@eslint-react/eslint-plugin": "^5.28.8",
|
|
@@ -75,6 +75,7 @@
|
|
|
75
75
|
"eslint-plugin-import-x": "^4.16.0",
|
|
76
76
|
"eslint-plugin-jsx-a11y-x": "^0.2.0",
|
|
77
77
|
"eslint-plugin-react-hooks": "^7.0.0",
|
|
78
|
+
"eslint-plugin-react-you-might-not-need-an-effect": "^1.1.0",
|
|
78
79
|
"jsonc-eslint-parser": "^2.4.0 || ^3.0.0",
|
|
79
80
|
"react": "*",
|
|
80
81
|
"typescript": ">=5.8.0 <6.1.0",
|
|
@@ -99,6 +100,9 @@
|
|
|
99
100
|
"eslint-plugin-react-hooks": {
|
|
100
101
|
"optional": true
|
|
101
102
|
},
|
|
103
|
+
"eslint-plugin-react-you-might-not-need-an-effect": {
|
|
104
|
+
"optional": true
|
|
105
|
+
},
|
|
102
106
|
"react": {
|
|
103
107
|
"optional": true
|
|
104
108
|
}
|