@zukhruf/eslint 0.3.41 → 0.3.43

package/dist/test-files/no-timer-race.js

@@ -0,0 +1,144 @@
+import { identifierName, isAstNode, isType, } from "../authoring/ast.js";
+/** Timers that take a callback: `setTimeout(() => reject(...), ms)`. */
+const CALLBACK_TIMERS = new Set(['setTimeout']);
+/** Timers that return a promise: `sleep(ms)`, `delay(ms)`, and `setTimeout(ms)` of `node:timers/promises`. */
+const PROMISE_TIMERS = new Set(['sleep', 'delay', 'setTimeout']);
+function calleeName(call) {
+    const callee = call['callee'];
+    if (isType(callee, 'MemberExpression'))
+        return identifierName(callee['property']);
+    return identifierName(callee);
+}
+function isTimerCall(node, names) {
+    if (!isType(node, 'CallExpression'))
+        return false;
+    const name = calleeName(node);
+    return name !== undefined && names.has(name);
+}
+/** Whether a reference to `variable` sits in the arguments of a callback timer. */
+function calledByTimer(variable) {
+    return (variable?.references ?? []).some(({ identifier }) => {
+        let child = identifier;
+        let parent = isAstNode(child) ? child['parent'] : undefined;
+        while (isAstNode(parent)) {
+            if (isTimerCall(parent, CALLBACK_TIMERS) &&
+                Array.isArray(parent['arguments']) &&
+                parent['arguments'].includes(child)) {
+                return true;
+            }
+            child = parent;
+            parent = parent['parent'];
+        }
+        return false;
+    });
+}
+function declared(context, node, name) {
+    return context.sourceCode
+        .getDeclaredVariables(node)
+        .find((variable) => variable.name === name);
+}
+/** `new Promise((_, reject) => setTimeout(() => reject(...), ms))`. */
+function rejectingExecutor(context, node) {
+    if (identifierName(node['callee']) !== 'Promise')
+        return false;
+    const executor = Array.isArray(node['arguments'])
+        ? node['arguments'][0]
+        : undefined;
+    if (!isType(executor, 'ArrowFunctionExpression') &&
+        !isType(executor, 'FunctionExpression')) {
+        return false;
+    }
+    const params = Array.isArray(executor['params']) ? executor['params'] : [];
+    return calledByTimer(declared(context, executor, identifierName(params[1])));
+}
+/** `sleep(ms).then(() => { throw ... })`. */
+function throwingContinuation(node) {
+    const callee = node['callee'];
+    if (!isType(callee, 'MemberExpression') ||
+        identifierName(callee['property']) !== 'then' ||
+        !isTimerCall(callee['object'], PROMISE_TIMERS)) {
+        return false;
+    }
+    const onFulfilled = Array.isArray(node['arguments'])
+        ? node['arguments'][0]
+        : undefined;
+    const body = isAstNode(onFulfilled) ? onFulfilled['body'] : undefined;
+    return (isType(body, 'BlockStatement') &&
+        Array.isArray(body['body']) &&
+        body['body'].some((statement) => isType(statement, 'ThrowStatement')));
+}
+/**
+ * `const { promise, reject } = Promise.withResolvers()`, or any other
+ * destructured `reject`, with `reject` called by a timer.
+ */
+function rejectingResolvers(context, declarator) {
+    const pattern = declarator['id'];
+    if (!isType(pattern, 'ObjectPattern'))
+        return false;
+    const properties = pattern['properties'];
+    if (!Array.isArray(properties))
+        return false;
+    const reject = properties.find((property) => isType(property, 'Property') &&
+        identifierName(property['key']) === 'reject');
+    return (isAstNode(reject) &&
+        calledByTimer(declared(context, declarator, identifierName(reject['value']))));
+}
+function rejectsOnTimer(context, element, resolveBinding) {
+    if (isType(element, 'NewExpression')) {
+        return rejectingExecutor(context, element);
+    }
+    if (isType(element, 'CallExpression'))
+        return throwingContinuation(element);
+    if (!resolveBinding || !isType(element, 'Identifier'))
+        return false;
+    const reference = context.sourceCode
+        .getScope(element)
+        .references.find(({ identifier }) => identifier === element);
+    const definition = reference?.resolved?.defs[0];
+    if (definition?.type !== 'Variable' || !isAstNode(definition.node)) {
+        return false;
+    }
+    const declarator = definition.node;
+    return isType(declarator['id'], 'Identifier')
+        ? rejectsOnTimer(context, declarator['init'], false)
+        : rejectingResolvers(context, declarator);
+}
+/**
+ * A race against a timer that rejects fails the test when the promise is late,
+ * with an error the test wrote itself, and leaves the promise running. A
+ * timeout belongs to the test (`{ timeout }`), or to `settleWithin`, which
+ * names what was late. Follows one variable: a timer built in a helper that
+ * returns it is not seen. A timer that resolves a marker
+ * (`sleep(ms).then(() => false)`, `delay(ms, 'pending')`) asserts that the
+ * promise stays pending, which is a different check, and stays allowed.
+ */
+const rule = {
+    meta: {
+        type: 'problem',
+        docs: {
+            description: 'Disallow Promise.race against a timer that rejects',
+        },
+        schema: [],
+        messages: {
+            matched: 'This race fails the test when the promise is late: use settleWithin(promise, label, ms) from @zukhruf/testing/async, or give the test its own { timeout }.',
+        },
+    },
+    create(context) {
+        return {
+            'CallExpression[callee.object.name="Promise"][callee.property.name="race"] > ArrayExpression.arguments'(array) {
+                if (!isType(array, 'ArrayExpression'))
+                    return;
+                const elements = Array.isArray(array['elements'])
+                    ? array['elements']
+                    : [];
+                for (const element of elements) {
+                    if (isAstNode(element) && rejectsOnTimer(context, element, true)) {
+                        context.report({ node: element, messageId: 'matched' });
+                    }
+                }
+            },
+        };
+    },
+};
+export default rule;
+//# sourceMappingURL=no-timer-race.js.map

package/dist/test-files/no-timer-race.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"no-timer-race.js","sourceRoot":"","sources":["../../src/test-files/no-timer-race.ts"],"names":[],"mappings":"AAEA,OAAO,EAEL,cAAc,EACd,SAAS,EACT,MAAM,GACP,MAAM,qBAAqB,CAAC;AAE7B,wEAAwE;AACxE,MAAM,eAAe,GAAG,IAAI,GAAG,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC;AAChD,8GAA8G;AAC9G,MAAM,cAAc,GAAG,IAAI,GAAG,CAAC,CAAC,OAAO,EAAE,OAAO,EAAE,YAAY,CAAC,CAAC,CAAC;AAEjE,SAAS,UAAU,CAAC,IAAa;IAC/B,MAAM,MAAM,GAAG,IAAI,CAAC,QAAQ,CAAC,CAAC;IAC9B,IAAI,MAAM,CAAC,MAAM,EAAE,kBAAkB,CAAC;QACpC,OAAO,cAAc,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC,CAAC;IAC5C,OAAO,cAAc,CAAC,MAAM,CAAC,CAAC;AAChC,CAAC;AAED,SAAS,WAAW,CAAC,IAAa,EAAE,KAAkB;IACpD,IAAI,CAAC,MAAM,CAAC,IAAI,EAAE,gBAAgB,CAAC;QAAE,OAAO,KAAK,CAAC;IAClD,MAAM,IAAI,GAAG,UAAU,CAAC,IAAI,CAAC,CAAC;IAC9B,OAAO,IAAI,KAAK,SAAS,IAAI,KAAK,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC;AAC/C,CAAC;AAED,mFAAmF;AACnF,SAAS,aAAa,CAAC,QAAoC;IACzD,OAAO,CAAC,QAAQ,EAAE,UAAU,IAAI,EAAE,CAAC,CAAC,IAAI,CAAC,CAAC,EAAE,UAAU,EAAE,EAAE,EAAE;QAC1D,IAAI,KAAK,GAAY,UAAU,CAAC;QAChC,IAAI,MAAM,GAAG,SAAS,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;QAC5D,OAAO,SAAS,CAAC,MAAM,CAAC,EAAE,CAAC;YACzB,IACE,WAAW,CAAC,MAAM,EAAE,eAAe,CAAC;gBACpC,KAAK,CAAC,OAAO,CAAC,MAAM,CAAC,WAAW,CAAC,CAAC;gBAClC,MAAM,CAAC,WAAW,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,EACnC,CAAC;gBACD,OAAO,IAAI,CAAC;YACd,CAAC;YACD,KAAK,GAAG,MAAM,CAAC;YACf,MAAM,GAAG,MAAM,CAAC,QAAQ,CAAC,CAAC;QAC5B,CAAC;QACD,OAAO,KAAK,CAAC;IACf,CAAC,CAAC,CAAC;AACL,CAAC;AAED,SAAS,QAAQ,CACf,OAAyB,EACzB,IAAa,EACb,IAAwB;IAExB,OAAO,OAAO,CAAC,UAAU;SACtB,oBAAoB,CAAC,IAAI,CAAC;SAC1B,IAAI,CAAC,CAAC,QAAQ,EAAE,EAAE,CAAC,QAAQ,CAAC,IAAI,KAAK,IAAI,CAAC,CAAC;AAChD,CAAC;AAED,uEAAuE;AACvE,SAAS,iBAAiB,CAAC,OAAyB,EAAE,IAAa;IACjE,IAAI,cAAc,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,KAAK,SAAS;QAAE,OAAO,KAAK,CAAC;IAC/D,MAAM,QAAQ,GAAG,KAAK,CAAC,OAAO,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;QAC/C,CAAC,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC,CAAC,CAAC;QACtB,CAAC,CAAC,SAAS,CAAC;IACd,IACE,CAAC,MAAM,CAAC,QAAQ,EAAE,yBAAyB,CAAC;QAC5C,CAAC,MAAM,CAAC,QAAQ,EAAE,oBAAoB,CAAC,EACvC,CAAC;QACD,OAAO,KAAK,CAAC;IACf,CAAC;IACD,MAAM,MAAM,GAAG,KAAK,CAAC,OAAO,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC;IAC3E,OAAO,aAAa,CAAC,QAAQ,CAAC,OAAO,EAAE,QAAQ,EAAE,cAAc,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;AAC/E,CAAC;AAED,6CAA6C;AAC7C,SAAS,oBAAoB,CAAC,IAAa;IACzC,MAAM,MAAM,GAAG,IAAI,CAAC,QAAQ,CAAC,CAAC;IAC9B,IACE,CAAC,MAAM,CAAC,MAAM,EAAE,kBAAkB,CAAC;QACnC,cAAc,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC,KAAK,MAAM;QAC7C,CAAC,WAAW,CAAC,MAAM,CAAC,QAAQ,CAAC,EAAE,cAAc,CAAC,EAC9C,CAAC;QACD,OAAO,KAAK,CAAC;IACf,CAAC;IACD,MAAM,WAAW,GAAG,KAAK,CAAC,OAAO,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;QAClD,CAAC,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC,CAAC,CAAC;QACtB,CAAC,CAAC,SAAS,CAAC;IACd,MAAM,IAAI,GAAG,SAAS,CAAC,WAAW,CAAC,CAAC,CAAC,CAAC,WAAW,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;IACtE,OAAO,CACL,MAAM,CAAC,IAAI,EAAE,gBAAgB,CAAC;QAC9B,KAAK,CAAC,OAAO,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;QAC3B,IAAI,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,CAAC,SAAS,EAAE,EAAE,CAAC,MAAM,CAAC,SAAS,EAAE,gBAAgB,CAAC,CAAC,CACtE,CAAC;AACJ,CAAC;AAED;;;GAGG;AACH,SAAS,kBAAkB,CACzB,OAAyB,EACzB,UAAmB;IAEnB,MAAM,OAAO,GAAG,UAAU,CAAC,IAAI,CAAC,CAAC;IACjC,IAAI,CAAC,MAAM,CAAC,OAAO,EAAE,eAAe,CAAC;QAAE,OAAO,KAAK,CAAC;IACpD,MAAM,UAAU,GAAY,OAAO,CAAC,YAAY,CAAC,CAAC;IAClD,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,UAAU,CAAC;QAAE,OAAO,KAAK,CAAC;IAC7C,MAAM,MAAM,GAAY,UAAU,CAAC,IAAI,CACrC,CAAC,QAAiB,EAAE,EAAE,CACpB,MAAM,CAAC,QAAQ,EAAE,UAAU,CAAC;QAC5B,cAAc,CAAC,QAAQ,CAAC,KAAK,CAAC,CAAC,KAAK,QAAQ,CAC/C,CAAC;IACF,OAAO,CACL,SAAS,CAAC,MAAM,CAAC;QACjB,aAAa,CACX,QAAQ,CAAC,OAAO,EAAE,UAAU,EAAE,cAAc,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,CAAC,CAC/D,CACF,CAAC;AACJ,CAAC;AAED,SAAS,cAAc,CACrB,OAAyB,EACzB,OAAgB,EAChB,cAAuB;IAEvB,IAAI,MAAM,CAAC,OAAO,EAAE,eAAe,CAAC,EAAE,CAAC;QACrC,OAAO,iBAAiB,CAAC,OAAO,EAAE,OAAO,CAAC,CAAC;IAC7C,CAAC;IACD,IAAI,MAAM,CAAC,OAAO,EAAE,gBAAgB,CAAC;QAAE,OAAO,oBAAoB,CAAC,OAAO,CAAC,CAAC;IAC5E,IAAI,CAAC,cAAc,IAAI,CAAC,MAAM,CAAC,OAAO,EAAE,YAAY,CAAC;QAAE,OAAO,KAAK,CAAC;IACpE,MAAM,SAAS,GAAG,OAAO,CAAC,UAAU;SACjC,QAAQ,CAAC,OAAO,CAAC;SACjB,UAAU,CAAC,IAAI,CAAC,CAAC,EAAE,UAAU,EAAE,EAAE,EAAE,CAAC,UAAU,KAAK,OAAO,CAAC,CAAC;IAC/D,MAAM,UAAU,GAAG,SAAS,EAAE,QAAQ,EAAE,IAAI,CAAC,CAAC,CAAC,CAAC;IAChD,IAAI,UAAU,EAAE,IAAI,KAAK,UAAU,IAAI,CAAC,SAAS,CAAC,UAAU,CAAC,IAAI,CAAC,EAAE,CAAC;QACnE,OAAO,KAAK,CAAC;IACf,CAAC;IACD,MAAM,UAAU,GAAG,UAAU,CAAC,IAAI,CAAC;IACnC,OAAO,MAAM,CAAC,UAAU,CAAC,IAAI,CAAC,EAAE,YAAY,CAAC;QAC3C,CAAC,CAAC,cAAc,CAAC,OAAO,EAAE,UAAU,CAAC,MAAM,CAAC,EAAE,KAAK,CAAC;QACpD,CAAC,CAAC,kBAAkB,CAAC,OAAO,EAAE,UAAU,CAAC,CAAC;AAC9C,CAAC;AAED;;;;;;;;GAQG;AACH,MAAM,IAAI,GAAoB;IAC5B,IAAI,EAAE;QACJ,IAAI,EAAE,SAAS;QACf,IAAI,EAAE;YACJ,WAAW,EAAE,oDAAoD;SAClE;QACD,MAAM,EAAE,EAAE;QACV,QAAQ,EAAE;YACR,OAAO,EACL,4JAA4J;SAC/J;KACF;IACD,MAAM,CAAC,OAAO;QACZ,OAAO;YACL,uGAAuG,CACrG,KAAgB;gBAEhB,IAAI,CAAC,MAAM,CAAC,KAAK,EAAE,iBAAiB,CAAC;oBAAE,OAAO;gBAC9C,MAAM,QAAQ,GAAG,KAAK,CAAC,OAAO,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC;oBAC/C,CAAC,CAAC,KAAK,CAAC,UAAU,CAAC;oBACnB,CAAC,CAAC,EAAE,CAAC;gBACP,KAAK,MAAM,OAAO,IAAI,QAAQ,EAAE,CAAC;oBAC/B,IAAI,SAAS,CAAC,OAAO,CAAC,IAAI,cAAc,CAAC,OAAO,EAAE,OAAO,EAAE,IAAI,CAAC,EAAE,CAAC;wBACjE,OAAO,CAAC,MAAM,CAAC,EAAE,IAAI,EAAE,OAAO,EAAE,SAAS,EAAE,SAAS,EAAE,CAAC,CAAC;oBAC1D,CAAC;gBACH,CAAC;YACH,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC;AAEF,eAAe,IAAI,CAAC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zukhruf/eslint",
-  "version": "0.3.41",
+  "version": "0.3.43",
   "description": "ESLint rules and configs shared across workspaces. Every check is its own named rule, so a repo's own config cannot silently erase it.",
   "license": "MIT",
   "repository": {

package/dist/test-files/require-msw-error-on-unhandled-request.d.ts

@@ -1,11 +0,0 @@
-/**
- * msw answers only what a handler lists. Without this option an unstubbed
- * request is warned about and sent to the real network, so the test passes on
- * a live dependency it never meant to touch. msw 3 names the option
- * `onUnhandledFrame`; msw 2 named it `onUnhandledRequest`. Scoped by the
- * `msw/node` import; a `listen()` on something else in the same file, called
- * with no argument or an object, is the one known false positive.
- */
-declare const _default: import("eslint").Rule.RuleModule;
-export default _default;
-//# sourceMappingURL=require-msw-error-on-unhandled-request.d.ts.map

package/dist/test-files/require-msw-error-on-unhandled-request.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"require-msw-error-on-unhandled-request.d.ts","sourceRoot":"","sources":["../../src/test-files/require-msw-error-on-unhandled-request.ts"],"names":[],"mappings":"AAEA;;;;;;;GAOG;;AACH,wBAOG"}

package/dist/test-files/require-msw-error-on-unhandled-request.js

@@ -1,17 +0,0 @@
-import { selectorRule } from "../authoring/selector-rule.js";
-/**
- * msw answers only what a handler lists. Without this option an unstubbed
- * request is warned about and sent to the real network, so the test passes on
- * a live dependency it never meant to touch. msw 3 names the option
- * `onUnhandledFrame`; msw 2 named it `onUnhandledRequest`. Scoped by the
- * `msw/node` import; a `listen()` on something else in the same file, called
- * with no argument or an object, is the one known false positive.
- */
-export default selectorRule({
-    description: "Require msw's server.listen() to fail on unhandled requests",
-    selectors: [
-        'Program:has(ImportDeclaration[source.value="msw/node"]) CallExpression[callee.property.name="listen"]:matches([arguments.length=0], [arguments.0.type="ObjectExpression"]):not(:has(Property[key.name=/^onUnhandled(Frame|Request)$/] > Literal[value="error"]))',
-    ],
-    message: "msw: server.listen() must pass { onUnhandledFrame: 'error' } (msw 2: onUnhandledRequest) so an unstubbed request fails the test instead of reaching the network.",
-});
-//# sourceMappingURL=require-msw-error-on-unhandled-request.js.map

package/dist/test-files/require-msw-error-on-unhandled-request.js.map

@@ -1 +0,0 @@
-{"version":3,"file":"require-msw-error-on-unhandled-request.js","sourceRoot":"","sources":["../../src/test-files/require-msw-error-on-unhandled-request.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,YAAY,EAAE,MAAM,+BAA+B,CAAC;AAE7D;;;;;;;GAOG;AACH,eAAe,YAAY,CAAC;IAC1B,WAAW,EAAE,6DAA6D;IAC1E,SAAS,EAAE;QACT,kQAAkQ;KACnQ;IACD,OAAO,EACL,kKAAkK;CACrK,CAAC,CAAC"}