@zukhruf/eslint 0.3.22 → 0.3.24

package/README.md

@@ -47,7 +47,7 @@ Put framework presets (for example Nx's `flat/react`) **before** the zukhruf con
 | `diagnostics`     | source, not tests     | `no-fabricated-fallback`, `no-hardcoded-id-shape`, `consistent-event-name`                                                                                                                                                                                                                                                                                                                                                                                                                |
 | `env`             | TypeScript, not tests | `no-undeclared-process-env`, `no-single-env-read-wrapper`, `no-default-for-path-env`                                                                                                                                                                                                                                                                                                                                                                                                      |
 | `packaged-app`    | TypeScript, not tests | `no-bare-spawn`                                                                                                                                                                                                                                                                                                                                                                                                                                                                           |
-| `react`           | `.tsx`, `.jsx`        | `require-combobox-popover-modal`                                                                                                                                                                                                                                                                                                                                                                                                                                                          |
+| `react`           | `.tsx`, `.jsx`        | `no-as-child`                                                                                                                                                                                                                                                                                                                                                                                                                                                                             |
 | `react-router`    | source                | `require-loader-data-type-argument`; outside tests: `no-raw-route-path`, `no-internal-anchor`                                                                                                                                                                                                                                                                                                                                                                                             |
 | `hono`            | TypeScript, not tests | `no-untyped-empty-json`                                                                                                                                                                                                                                                                                                                                                                                                                                                                   |
 | `tailwind`        | source                | `no-h-screen`, `no-arbitrary-z-index`, `no-will-change`                                                                                                                                                                                                                                                                                                                                                                                                                                   |

package/dist/react/config.d.ts

@@ -1,4 +1,4 @@
 import { type Concept } from '../concept.ts';
-/** React components built from shadcn/ui and Radix primitives. */
+/** React components built from shadcn/ui and Base UI primitives. */
 export declare const react: Concept;
 //# sourceMappingURL=config.d.ts.map

package/dist/react/config.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"config.d.ts","sourceRoot":"","sources":["../../src/react/config.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,KAAK,OAAO,EAAU,MAAM,eAAe,CAAC;AAMrD,kEAAkE;AAClE,eAAO,MAAM,KAAK,EAAE,OAMnB,CAAC"}
+{"version":3,"file":"config.d.ts","sourceRoot":"","sources":["../../src/react/config.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,KAAK,OAAO,EAAU,MAAM,eAAe,CAAC;AAMrD,oEAAoE;AACpE,eAAO,MAAM,KAAK,EAAE,OAMnB,CAAC"}

package/dist/react/config.js

@@ -1,8 +1,8 @@
 import { enable } from "../concept.js";
 import { JSX } from "../files.js";
-import requireComboboxPopoverModal from "./require-combobox-popover-modal.js";
-const rules = { 'require-combobox-popover-modal': requireComboboxPopoverModal };
-/** React components built from shadcn/ui and Radix primitives. */
+import noAsChild from "./no-as-child.js";
+const rules = { 'no-as-child': noAsChild };
+/** React components built from shadcn/ui and Base UI primitives. */
 export const react = {
     name: 'react',
     rules,

package/dist/react/config.js.map

@@ -1 +1 @@
-{"version":3,"file":"config.js","sourceRoot":"","sources":["../../src/react/config.ts"],"names":[],"mappings":"AAAA,OAAO,EAAgB,MAAM,EAAE,MAAM,eAAe,CAAC;AACrD,OAAO,EAAE,GAAG,EAAE,MAAM,aAAa,CAAC;AAClC,OAAO,2BAA2B,MAAM,qCAAqC,CAAC;AAE9E,MAAM,KAAK,GAAG,EAAE,gCAAgC,EAAE,2BAA2B,EAAE,CAAC;AAEhF,kEAAkE;AAClE,MAAM,CAAC,MAAM,KAAK,GAAY;IAC5B,IAAI,EAAE,OAAO;IACb,KAAK;IACL,MAAM,EAAE,CAAC,OAAO,EAAE,EAAE,CAAC;QACnB,EAAE,IAAI,EAAE,eAAe,EAAE,KAAK,EAAE,GAAG,EAAE,OAAO,EAAE,KAAK,EAAE,MAAM,CAAC,KAAK,CAAC,EAAE;KACrE;CACF,CAAC"}
+{"version":3,"file":"config.js","sourceRoot":"","sources":["../../src/react/config.ts"],"names":[],"mappings":"AAAA,OAAO,EAAgB,MAAM,EAAE,MAAM,eAAe,CAAC;AACrD,OAAO,EAAE,GAAG,EAAE,MAAM,aAAa,CAAC;AAClC,OAAO,SAAS,MAAM,kBAAkB,CAAC;AAEzC,MAAM,KAAK,GAAG,EAAE,aAAa,EAAE,SAAS,EAAE,CAAC;AAE3C,oEAAoE;AACpE,MAAM,CAAC,MAAM,KAAK,GAAY;IAC5B,IAAI,EAAE,OAAO;IACb,KAAK;IACL,MAAM,EAAE,CAAC,OAAO,EAAE,EAAE,CAAC;QACnB,EAAE,IAAI,EAAE,eAAe,EAAE,KAAK,EAAE,GAAG,EAAE,OAAO,EAAE,KAAK,EAAE,MAAM,CAAC,KAAK,CAAC,EAAE;KACrE;CACF,CAAC"}

package/dist/react/no-as-child.d.ts

@@ -0,0 +1,3 @@
+declare const _default: import("eslint").Rule.RuleModule;
+export default _default;
+//# sourceMappingURL=no-as-child.d.ts.map

package/dist/react/no-as-child.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"no-as-child.d.ts","sourceRoot":"","sources":["../../src/react/no-as-child.ts"],"names":[],"mappings":";AAEA,wBAMG"}

package/dist/react/no-as-child.js

@@ -0,0 +1,7 @@
+import { selectorRule } from "../authoring/selector-rule.js";
+export default selectorRule({
+    description: 'Disallow the Radix `asChild` prop; Base UI sets the rendered element with `render`',
+    selectors: ["JSXAttribute[name.name='asChild']"],
+    message: 'Do not use `asChild`. It is a Radix UI prop, and Base UI does not have it. Use the `render` prop: `<DialogTrigger render={<Button />}>`. When the element is not a button, also set `nativeButton={false}`. For a link that looks like a button, do not use `render`. Use a plain link with `className={cn(buttonVariants(...))}`.',
+});
+//# sourceMappingURL=no-as-child.js.map

package/dist/react/no-as-child.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"no-as-child.js","sourceRoot":"","sources":["../../src/react/no-as-child.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,YAAY,EAAE,MAAM,+BAA+B,CAAC;AAE7D,eAAe,YAAY,CAAC;IAC1B,WAAW,EACT,oFAAoF;IACtF,SAAS,EAAE,CAAC,mCAAmC,CAAC;IAChD,OAAO,EACL,oUAAoU;CACvU,CAAC,CAAC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zukhruf/eslint",
-  "version": "0.3.22",
+  "version": "0.3.24",
   "description": "ESLint rules and configs shared across workspaces. Every check is its own named rule, so a repo's own config cannot silently erase it.",
   "license": "MIT",
   "repository": {

package/dist/react/require-combobox-popover-modal.d.ts

@@ -1,10 +0,0 @@
-import type { Rule } from 'eslint';
-/**
- * A modal <Dialog> locks scrolling with react-remove-scroll, which lets wheel
- * events through only inside the dialog's subtree. A combobox <Popover> portals
- * to document.body, outside that subtree, so its list silently stops scrolling
- * with the wheel unless the popover holds its own lock (`modal`).
- */
-declare const rule: Rule.RuleModule;
-export default rule;
-//# sourceMappingURL=require-combobox-popover-modal.d.ts.map

package/dist/react/require-combobox-popover-modal.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"require-combobox-popover-modal.d.ts","sourceRoot":"","sources":["../../src/react/require-combobox-popover-modal.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,IAAI,EAAE,MAAM,QAAQ,CAAC;AA4DnC;;;;;GAKG;AACH,QAAA,MAAM,IAAI,EAAE,IAAI,CAAC,UAkDhB,CAAC;AAEF,eAAe,IAAI,CAAC"}

package/dist/react/require-combobox-popover-modal.js

@@ -1,101 +0,0 @@
-import { isAstNode, isType } from "../authoring/ast.js";
-// The opening tag of a JSX element, but only for the plain-identifier form
-// (`<Popover>`). The member/namespaced forms (`<Popover.Root>`) are not this
-// rule's concern — the shadcn wrapper this rule guards is always used as a bare
-// identifier.
-function plainTag(node) {
-    if (!isType(node, 'JSXElement'))
-        return undefined;
-    const opening = node['openingElement'];
-    if (!isAstNode(opening))
-        return undefined;
-    const name = opening['name'];
-    if (!isType(name, 'JSXIdentifier') || typeof name['name'] !== 'string') {
-        return undefined;
-    }
-    return { opening, name, text: name['name'] };
-}
-function readModal(opening) {
-    const attributes = opening['attributes'];
-    const list = Array.isArray(attributes) ? attributes : [];
-    let hasSpread = false;
-    for (const attribute of list) {
-        if (isType(attribute, 'JSXSpreadAttribute')) {
-            hasSpread = true;
-            continue;
-        }
-        if (!isType(attribute, 'JSXAttribute'))
-            continue;
-        const name = attribute['name'];
-        if (!isType(name, 'JSXIdentifier') || name['name'] !== 'modal')
-            continue;
-        const value = attribute['value'];
-        if (value === null)
-            return { kind: 'ok' }; // `<Popover modal>`
-        if (isType(value, 'JSXExpressionContainer')) {
-            const expression = value['expression'];
-            if (isType(expression, 'Literal') && expression['value'] === false) {
-                return { kind: 'false', attribute };
-            }
-        }
-        // `modal={true}`, `modal={someVar}`, `modal="..."` — leave the author's
-        // explicit/dynamic choice alone.
-        return { kind: 'ok' };
-    }
-    // A spread could supply `modal` at runtime; too imprecise to flag.
-    return hasSpread ? { kind: 'ok' } : { kind: 'absent' };
-}
-/**
- * A modal <Dialog> locks scrolling with react-remove-scroll, which lets wheel
- * events through only inside the dialog's subtree. A combobox <Popover> portals
- * to document.body, outside that subtree, so its list silently stops scrolling
- * with the wheel unless the popover holds its own lock (`modal`).
- */
-const rule = {
-    meta: {
-        type: 'problem',
-        fixable: 'code',
-        docs: {
-            description: 'Require `modal` on a <Popover> that wraps a <Command> combobox so wheel scrolling survives inside a modal <Dialog>',
-        },
-        messages: {
-            requireModal: 'A <Popover> wrapping a <Command> combobox must set `modal`. Rendered inside a modal <Dialog>, react-remove-scroll allows wheel events only within the dialog subtree; this popover portals to document.body, so without its own lock the wheel is silently canceled (arrow keys still work via cmdk scrollIntoView). Add `modal`, or disable this line if this popover is never mounted inside a modal Dialog.',
-            noExplicitFalse: '`modal={false}` on a <Popover> wrapping a <Command> combobox reintroduces the wheel-scroll bug inside a modal <Dialog>. Remove it (default to `modal`), or disable this line if this popover is never mounted inside a modal Dialog.',
-        },
-        schema: [],
-    },
-    create(context) {
-        const reported = new Set();
-        return {
-            JSXElement(node) {
-                if (plainTag(node)?.text !== 'Command')
-                    return;
-                // The nearest syntactic ancestor, so an enclosing <Popover> is matched
-                // only when the <Command> is genuinely nested inside it in the same
-                // file — the co-located shadcn combobox shape — never a sibling
-                // <Popover> elsewhere in the module.
-                const popover = context.sourceCode
-                    .getAncestors(node)
-                    .map(plainTag)
-                    .findLast((tag) => tag?.text === 'Popover');
-                if (!popover || reported.has(popover.opening))
-                    return;
-                const modal = readModal(popover.opening);
-                if (modal.kind === 'ok')
-                    return;
-                reported.add(popover.opening);
-                if (modal.kind === 'absent') {
-                    context.report({
-                        node: popover.opening,
-                        messageId: 'requireModal',
-                        fix: (fixer) => fixer.insertTextAfter(popover.name, ' modal'),
-                    });
-                    return;
-                }
-                context.report({ node: modal.attribute, messageId: 'noExplicitFalse' });
-            },
-        };
-    },
-};
-export default rule;
-//# sourceMappingURL=require-combobox-popover-modal.js.map

package/dist/react/require-combobox-popover-modal.js.map

@@ -1 +0,0 @@
-{"version":3,"file":"require-combobox-popover-modal.js","sourceRoot":"","sources":["../../src/react/require-combobox-popover-modal.ts"],"names":[],"mappings":"AAEA,OAAO,EAAgB,SAAS,EAAE,MAAM,EAAE,MAAM,qBAAqB,CAAC;AAQtE,2EAA2E;AAC3E,6EAA6E;AAC7E,gFAAgF;AAChF,cAAc;AACd,SAAS,QAAQ,CAAC,IAAa;IAC7B,IAAI,CAAC,MAAM,CAAC,IAAI,EAAE,YAAY,CAAC;QAAE,OAAO,SAAS,CAAC;IAClD,MAAM,OAAO,GAAG,IAAI,CAAC,gBAAgB,CAAC,CAAC;IACvC,IAAI,CAAC,SAAS,CAAC,OAAO,CAAC;QAAE,OAAO,SAAS,CAAC;IAC1C,MAAM,IAAI,GAAG,OAAO,CAAC,MAAM,CAAC,CAAC;IAC7B,IAAI,CAAC,MAAM,CAAC,IAAI,EAAE,eAAe,CAAC,IAAI,OAAO,IAAI,CAAC,MAAM,CAAC,KAAK,QAAQ,EAAE,CAAC;QACvE,OAAO,SAAS,CAAC;IACnB,CAAC;IACD,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,IAAI,EAAE,IAAI,CAAC,MAAM,CAAC,EAAE,CAAC;AAC/C,CAAC;AAOD,SAAS,SAAS,CAAC,OAAgB;IACjC,MAAM,UAAU,GAAG,OAAO,CAAC,YAAY,CAAC,CAAC;IACzC,MAAM,IAAI,GAAuB,KAAK,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,CAAC,EAAE,CAAC;IAC7E,IAAI,SAAS,GAAG,KAAK,CAAC;IACtB,KAAK,MAAM,SAAS,IAAI,IAAI,EAAE,CAAC;QAC7B,IAAI,MAAM,CAAC,SAAS,EAAE,oBAAoB,CAAC,EAAE,CAAC;YAC5C,SAAS,GAAG,IAAI,CAAC;YACjB,SAAS;QACX,CAAC;QACD,IAAI,CAAC,MAAM,CAAC,SAAS,EAAE,cAAc,CAAC;YAAE,SAAS;QACjD,MAAM,IAAI,GAAG,SAAS,CAAC,MAAM,CAAC,CAAC;QAC/B,IAAI,CAAC,MAAM,CAAC,IAAI,EAAE,eAAe,CAAC,IAAI,IAAI,CAAC,MAAM,CAAC,KAAK,OAAO;YAAE,SAAS;QAEzE,MAAM,KAAK,GAAG,SAAS,CAAC,OAAO,CAAC,CAAC;QACjC,IAAI,KAAK,KAAK,IAAI;YAAE,OAAO,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC,CAAC,oBAAoB;QAC/D,IAAI,MAAM,CAAC,KAAK,EAAE,wBAAwB,CAAC,EAAE,CAAC;YAC5C,MAAM,UAAU,GAAG,KAAK,CAAC,YAAY,CAAC,CAAC;YACvC,IAAI,MAAM,CAAC,UAAU,EAAE,SAAS,CAAC,IAAI,UAAU,CAAC,OAAO,CAAC,KAAK,KAAK,EAAE,CAAC;gBACnE,OAAO,EAAE,IAAI,EAAE,OAAO,EAAE,SAAS,EAAE,CAAC;YACtC,CAAC;QACH,CAAC;QACD,wEAAwE;QACxE,iCAAiC;QACjC,OAAO,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC;IACxB,CAAC;IAED,mEAAmE;IACnE,OAAO,SAAS,CAAC,CAAC,CAAC,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC,CAAC,CAAC,EAAE,IAAI,EAAE,QAAQ,EAAE,CAAC;AACzD,CAAC;AAED;;;;;GAKG;AACH,MAAM,IAAI,GAAoB;IAC5B,IAAI,EAAE;QACJ,IAAI,EAAE,SAAS;QACf,OAAO,EAAE,MAAM;QACf,IAAI,EAAE;YACJ,WAAW,EACT,oHAAoH;SACvH;QACD,QAAQ,EAAE;YACR,YAAY,EACV,gZAAgZ;YAClZ,eAAe,EACb,sOAAsO;SACzO;QACD,MAAM,EAAE,EAAE;KACX;IACD,MAAM,CAAC,OAAO;QACZ,MAAM,QAAQ,GAAG,IAAI,GAAG,EAAW,CAAC;QAEpC,OAAO;YACL,UAAU,CAAC,IAAe;gBACxB,IAAI,QAAQ,CAAC,IAAI,CAAC,EAAE,IAAI,KAAK,SAAS;oBAAE,OAAO;gBAE/C,uEAAuE;gBACvE,oEAAoE;gBACpE,gEAAgE;gBAChE,qCAAqC;gBACrC,MAAM,OAAO,GAAG,OAAO,CAAC,UAAU;qBAC/B,YAAY,CAAC,IAAI,CAAC;qBAClB,GAAG,CAAC,QAAQ,CAAC;qBACb,QAAQ,CAAC,CAAC,GAAG,EAAE,EAAE,CAAC,GAAG,EAAE,IAAI,KAAK,SAAS,CAAC,CAAC;gBAC9C,IAAI,CAAC,OAAO,IAAI,QAAQ,CAAC,GAAG,CAAC,OAAO,CAAC,OAAO,CAAC;oBAAE,OAAO;gBAEtD,MAAM,KAAK,GAAG,SAAS,CAAC,OAAO,CAAC,OAAO,CAAC,CAAC;gBACzC,IAAI,KAAK,CAAC,IAAI,KAAK,IAAI;oBAAE,OAAO;gBAChC,QAAQ,CAAC,GAAG,CAAC,OAAO,CAAC,OAAO,CAAC,CAAC;gBAE9B,IAAI,KAAK,CAAC,IAAI,KAAK,QAAQ,EAAE,CAAC;oBAC5B,OAAO,CAAC,MAAM,CAAC;wBACb,IAAI,EAAE,OAAO,CAAC,OAAO;wBACrB,SAAS,EAAE,cAAc;wBACzB,GAAG,EAAE,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,eAAe,CAAC,OAAO,CAAC,IAAI,EAAE,QAAQ,CAAC;qBAC9D,CAAC,CAAC;oBACH,OAAO;gBACT,CAAC;gBAED,OAAO,CAAC,MAAM,CAAC,EAAE,IAAI,EAAE,KAAK,CAAC,SAAS,EAAE,SAAS,EAAE,iBAAiB,EAAE,CAAC,CAAC;YAC1E,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC;AAEF,eAAe,IAAI,CAAC"}