@zudojs/plugins 1.0.0 → 1.1.0

package/README.md

@@ -70,7 +70,12 @@ next begins, so a plugin may rely on its dependencies being installed by
 the time its own `initialize` runs.
 
 If any phase throws, `manager.start` stops and disposes everything it had
-already brought up, then rethrows. `manager.stop` continues past a failing
+already brought up, then rethrows. A disposed plugin cannot be brought back:
+calling `manager.start` again after `manager.stop`, or after a rolled-back
+startup, throws `PluginStateError` rather than silently starting nothing (or
+starting still-registered dependents on top of disposed dependencies).
+Unregister the disposed plugins and register fresh instances, or create a
+new manager. `manager.stop` continues past a failing
 plugin so one bad `stop` cannot strand the rest; those failures are
 reported through the `onError` option (and logged to `console.error` if you
 do not supply one) rather than swallowed.

package/dist/pluginDependencies/versionCheck.core.js

@@ -31,7 +31,11 @@ export class PluginDependencyVersionError extends PluginDependencyError {
     }
 }
 const SEMVER_PATTERN = /^(\d+)\.(\d+)\.(\d+)(?:-([0-9A-Za-z.-]+))?(?:\+[0-9A-Za-z.-]+)?$/;
-const RANGE_PATTERN = /^\s*(\^|~|>=|<=|>|<|=)?\s*(.+?)\s*$/;
+// The input is already trimmed, so the outer `\s*` are unnecessary, and
+// `(\S.*)` rather than `(.+?)\s*$`: `.` matches spaces too, so a lazy group
+// followed by `\s*$` lets the engine split a whitespace run at every
+// position before giving up.
+const RANGE_PATTERN = /^(\^|~|>=|<=|>|<|=)?\s*(\S.*)$/;
 /**
  * Parses a semantic version, returning `undefined` if it is not one.
  */
@@ -63,7 +67,35 @@ export function compareVersions(a, b) {
         return 1;
     if (b.prerelease === undefined)
         return -1;
-    return a.prerelease < b.prerelease ? -1 : 1;
+    return comparePrerelease(a.prerelease, b.prerelease);
+}
+/**
+ * Compares two prerelease strings identifier by identifier, as semver
+ * specifies: numeric identifiers compare numerically and rank below
+ * alphanumeric ones, and a longer identifier list ranks higher when the
+ * shared prefix is equal. A plain string comparison put `alpha.10`
+ * before `alpha.9`.
+ */
+function comparePrerelease(a, b) {
+    const left = a.split(".");
+    const right = b.split(".");
+    const length = Math.min(left.length, right.length);
+    for (let index = 0; index < length; index += 1) {
+        const x = left[index];
+        const y = right[index];
+        if (x === y)
+            continue;
+        const xNumeric = /^\d+$/.test(x);
+        const yNumeric = /^\d+$/.test(y);
+        if (xNumeric && yNumeric)
+            return Number(x) - Number(y);
+        if (xNumeric)
+            return -1;
+        if (yNumeric)
+            return 1;
+        return x < y ? -1 : 1;
+    }
+    return left.length - right.length;
 }
 /**
  * Tests a version against a range.

package/dist/pluginManager/pluginManager.core.js

@@ -2,7 +2,7 @@ import { PluginRegistryImpl } from "../pluginRegistry/pluginRegistry.core.js";
 import { DependencyResolver, assertResolutionValid, } from "../pluginDependencies/dependencyResolver.core.js";
 import { assertDependencyVersions } from "../pluginDependencies/versionCheck.core.js";
 import { LifecycleController } from "../pluginLifecycle/pluginLifecycle.core.js";
-import { PluginError, PluginRegistrationError } from "@zudojs/errors";
+import { PluginError, PluginRegistrationError, PluginStateError, } from "@zudojs/errors";
 import { createOwnedPluginContext } from "../pluginIntegration/pluginContext.core.js";
 import { buildDiagnosticReport } from "../pluginDiagnostics/pluginDiagnostic.core.js";
 import { PLUGIN_EVENTS, createPluginLifecycleEvent, } from "../pluginEvents/pluginEvent.core.js";
@@ -124,10 +124,21 @@ export class PluginManager {
                 assertDependencyVersions(this.plugins);
             }
             this.startupOrder = resolution.ordered;
+            // A disposed plugin has released its resources and the state
+            // machine offers no way back. `start()` used to skip such plugins
+            // silently — so a second `start()` after `stop()` resolved with
+            // nothing running, and after a rolled-back startup it brought up
+            // still-registered dependents on top of disposed dependencies.
+            for (const name of this.startupOrder) {
+                const registered = this.registry.get(name);
+                if (registered?.state === "disposed") {
+                    throw new PluginStateError(name, "disposed", "installing");
+                }
+            }
             try {
                 for (const name of this.startupOrder) {
                     const registered = this.registry.get(name);
-                    if (!registered || registered.state === "disposed")
+                    if (!registered)
                         continue;
                     // Guarded so a restart — where plugins are already installed
                     // and merely stopped — re-runs only the phases it needs.
@@ -137,7 +148,7 @@ export class PluginManager {
                 }
                 for (const name of this.startupOrder) {
                     const registered = this.registry.get(name);
-                    if (!registered || registered.state === "disposed")
+                    if (!registered)
                         continue;
                     if (registered.state === "installed") {
                         await this.lifecycle.initialize(registered, this.contextFor(registered, context));
@@ -145,7 +156,7 @@ export class PluginManager {
                 }
                 for (const name of this.startupOrder) {
                     const registered = this.registry.get(name);
-                    if (!registered || registered.state === "disposed")
+                    if (!registered)
                         continue;
                     if (registered.state === "initialized" ||
                         registered.state === "stopped") {

package/package.json

@@ -1,8 +1,12 @@
 {
   "name": "@zudojs/plugins",
-  "version": "1.0.0",
+  "version": "1.1.0",
   "description": "Plugin system for extending Zudojs applications with modular capabilities.",
   "license": "MIT",
+  "author": {
+    "name": "Oluwayemi Oyinlola",
+    "url": "https://github.com/oyinlola-tech"
+  },
   "type": "module",
   "main": "./dist/index.js",
   "module": "./dist/index.js",
@@ -20,8 +24,8 @@
     "!dist/.tsbuildinfo"
   ],
   "dependencies": {
-    "@zudojs/errors": "1.0.0",
-    "@zudojs/constants": "1.0.0",
+    "@zudojs/errors": "1.0.1",
+    "@zudojs/constants": "1.0.1",
     "@zudojs/types": "1.0.0"
   },
   "devDependencies": {