@ztffn/presentation-generator-plugin 1.4.6 → 1.5.0

package/.claude-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "presentation-generator",
   "description": "Generate complete graph-based presentations from natural language briefs and project documents. Pipeline: content extraction, narrative design, deterministic graph generation, and visual styling.",
-  "version": "1.4.6",
+  "version": "1.5.0",
   "author": {
     "name": "Huma"
   },

package/DEFERRED-FIXES.md

@@ -4,6 +4,33 @@ Issues that require architectural changes and should be addressed in targeted, f
 
 ---
 
+## v1.5.0 fixes ✓ resolved
+
+**Bug: Style agent always launched as `undefined`**
+`enforce-style-schema.sh` returned `updatedInput: { prompt: "..." }` which replaced
+the entire tool_input, dropping `subagent_type`. Fixed by merging the modified prompt
+into the original tool_input: `updatedInput: ($orig + {prompt: $prompt})`.
+
+**Bug: Content brief triggered presentation validator**
+Hook patterns `*_temp/presentation*.json` matched `_temp/presentation-content-brief.json`,
+causing the validator to reject it. Removed the broad arm — only `*_temp/presentation-draft.json`
+needs validation now.
+
+**Bug: Bare agent names caused first-attempt failures**
+SKILL.md used `presentation-content` etc; Task tool requires fully-qualified
+`presentation-generator:presentation-content`. Fixed in all three phases (2, 3, 6).
+
+**UX: Visual intent annotations leaking into slide content**
+Narrative agents sometimes write `**Visual intent:** bookend` inside `**Content:**` blocks.
+Added `**Visual intent:**` as a recognized field marker in `extract_fields()` so it acts
+as a boundary, preventing bleed into `data.content`. Documented in `outline-format/SKILL.md`.
+
+**UX: Intimidating inline scripts in permission prompts**
+Phase 1 multi-line if/elif replaced with a single `find` one-liner.
+Phase 5 Python heredoc extracted into `scripts/verify_node_count.py`.
+
+---
+
 ## Issue 3 — `topic` badge truncation ✓ resolved
 
 **Was:** Badge clips at ~180px wide when `topic` strings are long.

package/bin/index.js

@@ -264,19 +264,12 @@ function clearInstalledPluginsEntry() {
 function writeInstalledPluginsJson(version, installDir, scope) {
   // Claude Code's `claude plugin install` writes stale version/installPath data
   // (a known bug: https://github.com/anthropics/claude-code/issues/15642).
-  // We overwrite the entry directly with the correct values after install.
+  // We overwrite the entry directly, pointing installPath at installDir so
+  // Claude reads from the actual installed location, not a global cache copy.
   const registryPath = path.join(
     os.homedir(), ".claude", "plugins", "installed_plugins.json"
   );
 
-  // Ensure the cache dir exists and contains the plugin files.
-  const cacheDir = path.join(
-    os.homedir(), ".claude", "plugins", "cache", MARKETPLACE_NAME, PLUGIN_NAME, version
-  );
-  if (!fs.existsSync(cacheDir)) {
-    execSync(`cp -r "${installDir}/." "${cacheDir}"`, { stdio: "pipe" });
-  }
-
   let registry = { version: 2, plugins: {} };
   if (fs.existsSync(registryPath)) {
     try { registry = JSON.parse(fs.readFileSync(registryPath, "utf8")); } catch {}
@@ -287,7 +280,7 @@ function writeInstalledPluginsJson(version, installDir, scope) {
   const existing = (registry.plugins[key] || []).find((e) => e.scope === scope);
   const entry = {
     scope,
-    installPath: cacheDir,
+    installPath: installDir,
     version,
     installedAt: existing?.installedAt || now,
     lastUpdated: now,

package/hooks/enforce-style-schema.sh

@@ -60,11 +60,17 @@ Your report MUST include the exact validator terminal output."
 # Build the modified prompt
 MODIFIED_PROMPT="${PREAMBLE}${ORIGINAL_PROMPT}${SUFFIX}"
 
-# Return updatedInput with the augmented prompt
-jq -n --arg prompt "$MODIFIED_PROMPT" '{
-  hookSpecificOutput: {
-    hookEventName: "PreToolUse",
-    permissionDecision: "allow",
-    updatedInput: { prompt: $prompt }
-  }
-}'
+# Return updatedInput: merge modified prompt into original tool_input so
+# subagent_type (and any other fields) are preserved.
+ORIGINAL_INPUT=$(jq '.tool_input' <<< "$INPUT")
+
+jq -n \
+  --argjson orig "$ORIGINAL_INPUT" \
+  --arg prompt "$MODIFIED_PROMPT" \
+  '{
+    hookSpecificOutput: {
+      hookEventName: "PreToolUse",
+      permissionDecision: "allow",
+      updatedInput: ($orig + {prompt: $prompt})
+    }
+  }'

package/hooks/pre-validate-presentation-json.sh

@@ -12,7 +12,7 @@ FILE=$(jq -r '.tool_input.file_path // empty' <<< "$INPUT")
 
 # Only validate presentation JSON
 case "$FILE" in
-  *presentations/*.json|*_temp/presentation-draft.json|*_temp/presentation*.json) ;;
+  *presentations/*.json|*_temp/presentation-draft.json) ;;
   *) exit 0 ;;
 esac
 

package/hooks/validate-presentation-json.sh

@@ -14,7 +14,7 @@ fi
 
 # Only validate presentation JSON files
 case "$FILE" in
-  *presentations/*.json|*_temp/presentation-draft.json|*_temp/presentation*.json)
+  *presentations/*.json|*_temp/presentation-draft.json)
     ;;
   *)
     exit 0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ztffn/presentation-generator-plugin",
-  "version": "1.4.6",
+  "version": "1.5.0",
   "description": "Claude Code plugin for generating graph-based presentations",
   "bin": {
     "presentation-generator-plugin": "bin/index.js"

package/scripts/outline_to_graph.py

@@ -155,12 +155,17 @@ def extract_fields(text):
     """Extract Key message, Content, Speaker notes, Transition from a content block."""
     fields = {}
 
-    # Define field markers in order
+    # Define field markers in order.
+    # visual_intent is listed between content and speaker_notes so the parser
+    # treats it as a boundary — stopping content extraction before the annotation
+    # if the narrative agent places it there. The extracted value is stored but
+    # not used in the output JSON (it is metadata for the style agent only).
     markers = [
-        ("key_message", r"\*\*Key message:\*\*"),
-        ("content", r"\*\*Content:\*\*"),
+        ("key_message",   r"\*\*Key message:\*\*"),
+        ("content",       r"\*\*Content:\*\*"),
+        ("visual_intent", r"\*\*Visual intent:\*\*"),
         ("speaker_notes", r"\*\*Speaker notes:\*\*"),
-        ("transition", r"\*\*Transition to next:\*\*"),
+        ("transition",    r"\*\*Transition to next:\*\*"),
     ]
 
     # Find positions of all markers

package/scripts/verify_node_count.py

@@ -0,0 +1,46 @@
+#!/usr/bin/env python3
+"""
+verify_node_count.py — Checks that the JSON node count matches the outline declaration.
+Usage: python3 verify_node_count.py <outline.md> <presentation.json>
+Exit:  0 if counts match, 1 if mismatch.
+"""
+
+import json
+import re
+import sys
+from pathlib import Path
+
+
+def main():
+    if len(sys.argv) != 3:
+        print("Usage: python3 verify_node_count.py <outline.md> <presentation.json>")
+        sys.exit(1)
+
+    outline = Path(sys.argv[1]).read_text(encoding="utf-8")
+
+    # Scope counts to their respective sections to avoid false matches
+    spine_m = re.search(r"^## SPINE\b",            outline, re.MULTILINE)
+    dd_m    = re.search(r"^## DRILL-DOWNS\b",      outline, re.MULTILINE)
+    cont_m  = re.search(r"^## CONTENT PER SLIDE\b", outline, re.MULTILINE)
+
+    spine_text = outline[spine_m.end():dd_m.start()]   if spine_m and dd_m    else ""
+    dd_text    = outline[dd_m.end():cont_m.start()]    if dd_m    and cont_m  else ""
+
+    spine_count = len(re.findall(r"^\d+\.\s+\*\*",         spine_text, re.MULTILINE))
+    drill_count = len(re.findall(r"^-\s+\*\*\d+\.\d+\*\*", dd_text,    re.MULTILINE))
+    expected    = spine_count + drill_count
+
+    data   = json.loads(Path(sys.argv[2]).read_text(encoding="utf-8"))
+    actual = len(data["nodes"])
+
+    print(f"Outline declares {expected} nodes "
+          f"({spine_count} spine + {drill_count} drill-down), JSON has {actual}")
+
+    if actual < expected:
+        print(f"MISMATCH: {expected - actual} node(s) missing — "
+              f"inspect DRILL-DOWNS headers and child entry format in the outline")
+        sys.exit(1)
+
+
+if __name__ == "__main__":
+    main()

package/skills/outline-format/SKILL.md

@@ -100,6 +100,7 @@ One H3 block per slide for every spine and drill-down node declared above:
 The detailed slide content. Use bullet points and markdown formatting.
 - Point one with a specific number or named entity
 - Point two — consequence or contrast
+**Visual intent:** workhorse
 **Speaker notes:**
 What the presenter says that is not on screen. Talking points, anticipated questions, timing.
 **Transition to next:**
@@ -128,7 +129,8 @@ Rules:
 - Spine header: `### SPINE N: Title`
 - Drill-down header: `### SPINE N.M: Title` — same N.M notation as DRILL-DOWNS section
 - Every node declared in SPINE and DRILL-DOWNS must have a corresponding content block
-- Field markers must be exactly: `**Key message:**`, `**Content:**`, `**Speaker notes:**`, `**Transition to next:**`
+- Field markers must be exactly: `**Key message:**`, `**Content:**`, `**Visual intent:**` (optional), `**Speaker notes:**`, `**Transition to next:**`
+- `**Visual intent:**` is optional metadata for the style agent. If included, place it **after** `**Content:**` and **before** `**Speaker notes:**` on its own line. The parser treats it as a boundary so it never bleeds into `data.content` in the JSON. Valid values: `bookend`, `workhorse`, `breathing-room`, `chapter-opener`, `impact`, `evidence`.
 - Do NOT add parenthetical context like `(drill-down under Slide 3)` after the title
 
 ---

package/skills/presentation-generator/SKILL.md

@@ -18,15 +18,12 @@ You are an orchestrator. Execute these 7 phases in order. Do not skip phases. Do
 Run this bash command to find the plugin:
 
 ```bash
-if [ -f ".claude/plugins/presentation-generator/scripts/outline_to_graph.py" ]; then
-  echo "PLUGIN_ROOT=.claude/plugins/presentation-generator"
-elif [ -f "$HOME/.claude/plugins/presentation-generator/scripts/outline_to_graph.py" ]; then
-  echo "PLUGIN_ROOT=$HOME/.claude/plugins/presentation-generator"
-else
-  echo "ERROR: plugin not found"
-fi
+find -L .claude ~/.claude -path "*/presentation-generator/scripts/outline_to_graph.py" 2>/dev/null | head -1 | sed 's|/scripts/outline_to_graph.py||'
 ```
 
+The output is the PLUGIN_ROOT path (e.g. `.claude/plugins/presentation-generator`).
+If the output is empty, the plugin is not installed — stop and tell the user.
+
 Save the PLUGIN_ROOT value. You need it for every later phase.
 
 Then extract from the user's message:
@@ -46,7 +43,7 @@ Say: **"Phase 2 — Extracting content from documents"**
 
 Call the Task tool with exactly these parameters:
 
-- subagent_type: `presentation-content`
+- subagent_type: `presentation-generator:presentation-content`
 - description: `Extract content brief`
 - prompt: (copy this template, fill in the bracketed values)
 
@@ -76,7 +73,7 @@ Say: **"Phase 3 — Designing narrative structure"**
 
 Call the Task tool with exactly these parameters:
 
-- subagent_type: `presentation-narrative`
+- subagent_type: `presentation-generator:presentation-narrative`
 - description: `Design narrative outline`
 - prompt: (copy this template, fill in the bracketed values)
 
@@ -136,33 +133,7 @@ If exit code is non-zero, show the errors and stop.
 After a successful run, verify node count against the outline:
 
 ```bash
-python3 - <<'EOF'
-import json, re, sys
-
-with open("_temp/presentation-outline.md") as f:
-    outline = f.read()
-
-# Scope counts to their respective sections to avoid false matches
-spine_m = re.search(r"^## SPINE\b", outline, re.MULTILINE)
-dd_m    = re.search(r"^## DRILL-DOWNS\b", outline, re.MULTILINE)
-cont_m  = re.search(r"^## CONTENT PER SLIDE\b", outline, re.MULTILINE)
-
-spine_text = outline[spine_m.end():dd_m.start()]   if spine_m and dd_m   else ""
-dd_text    = outline[dd_m.end():cont_m.start()]     if dd_m and cont_m   else ""
-
-spine_count = len(re.findall(r"^\d+\.\s+\*\*", spine_text, re.MULTILINE))
-drill_count = len(re.findall(r"^-\s+\*\*\d+\.\d+\*\*", dd_text, re.MULTILINE))
-expected    = spine_count + drill_count
-
-with open("presentations/{SLUG}/{SLUG}.json") as f:
-    data = json.load(f)
-actual = len(data["nodes"])
-
-print(f"Outline declares {expected} nodes ({spine_count} spine + {drill_count} drill-down), JSON has {actual}")
-if actual < expected:
-    print(f"MISMATCH: {expected - actual} node(s) missing — inspect DRILL-DOWNS headers and child entry format in the outline")
-    sys.exit(1)
-EOF
+python3 "{PLUGIN_ROOT}/scripts/verify_node_count.py" _temp/presentation-outline.md "presentations/{SLUG}/{SLUG}.json"
 ```
 
 If this count check fails: read the DRILL-DOWNS section of `_temp/presentation-outline.md`, identify format mismatches against `outline-format/SKILL.md`, and do NOT proceed to Phase 6 until the outline is corrected and Phase 5 re-run.
@@ -175,7 +146,7 @@ Say: **"Phase 6 — Applying visual styling"**
 
 Call the Task tool with exactly these parameters:
 
-- subagent_type: `presentation-style`
+- subagent_type: `presentation-generator:presentation-style`
 - description: `Apply visual treatments`
 - prompt: (copy this template, fill in the bracketed values)