@ztffn/presentation-generator-plugin 1.4.2 → 1.4.4

package/bin/index.js

@@ -244,9 +244,9 @@ function cleanOldCacheVersions(keepVersion) {
   }
 }
 
-function purgeInstalledPluginsJson() {
-  // Directly remove all entries for this plugin from Claude's global registry
-  // so that a subsequent `claude plugin install` always writes a fresh entry.
+function clearInstalledPluginsEntry() {
+  // Remove all registry entries for this plugin so `claude plugin install`
+  // starts from a clean slate and cannot restore a stale cache path/version.
   const registryPath = path.join(
     os.homedir(), ".claude", "plugins", "installed_plugins.json"
   );
@@ -258,25 +258,59 @@ function purgeInstalledPluginsJson() {
       delete registry.plugins[key];
       fs.writeFileSync(registryPath, JSON.stringify(registry, null, 2) + "\n");
     }
-  } catch {
-    // registry unreadable/corrupt — leave it alone
+  } catch {}
+}
+
+function writeInstalledPluginsJson(version, installDir, scope) {
+  // Claude Code's `claude plugin install` writes stale version/installPath data
+  // (a known bug: https://github.com/anthropics/claude-code/issues/15642).
+  // We overwrite the entry directly with the correct values after install.
+  const registryPath = path.join(
+    os.homedir(), ".claude", "plugins", "installed_plugins.json"
+  );
+
+  // Ensure the cache dir exists and contains the plugin files.
+  const cacheDir = path.join(
+    os.homedir(), ".claude", "plugins", "cache", MARKETPLACE_NAME, PLUGIN_NAME, version
+  );
+  if (!fs.existsSync(cacheDir)) {
+    execSync(`cp -r "${installDir}/." "${cacheDir}"`, { stdio: "pipe" });
   }
+
+  let registry = { version: 2, plugins: {} };
+  if (fs.existsSync(registryPath)) {
+    try { registry = JSON.parse(fs.readFileSync(registryPath, "utf8")); } catch {}
+  }
+
+  const key = `${PLUGIN_NAME}@${MARKETPLACE_NAME}`;
+  const now = new Date().toISOString();
+  const existing = (registry.plugins[key] || []).find((e) => e.scope === scope);
+  const entry = {
+    scope,
+    installPath: cacheDir,
+    version,
+    installedAt: existing?.installedAt || now,
+    lastUpdated: now,
+    projectPath: process.cwd(),
+  };
+
+  // Replace all entries for this scope, keep entries for other scopes.
+  const others = (registry.plugins[key] || []).filter((e) => e.scope !== scope);
+  registry.plugins[key] = [...others, entry];
+  fs.mkdirSync(path.dirname(registryPath), { recursive: true });
+  fs.writeFileSync(registryPath, JSON.stringify(registry, null, 2) + "\n");
 }
 
-function registerWithClaude(installDir, scope) {
+function registerWithClaude(installDir, scope, version) {
   const pluginsDir = path.dirname(installDir);
   ensureMarketplaceJson(pluginsDir);
 
-  // Remove any stale registration (e.g. from a previous install at a different path)
-  // before adding the current one. Errors are ignored — it may not exist yet.
+  // Remove any stale marketplace registration before re-adding.
   try {
     execSync(`claude plugin marketplace remove "${MARKETPLACE_NAME}"`, { stdio: "pipe" });
-  } catch {
-    // didn't exist or not removable — ignore
-  }
+  } catch {}
 
-  // Uninstall any stale plugin entries from both scopes before re-installing.
-  // This prevents Claude from reusing a cached entry pointing at an old version path.
+  // Uninstall stale plugin entries from both scopes before re-installing.
   try {
     execSync(`claude plugin uninstall ${PLUGIN_NAME}@${MARKETPLACE_NAME} --scope project`, { stdio: "pipe" });
   } catch {}
@@ -284,14 +318,26 @@ function registerWithClaude(installDir, scope) {
     execSync(`claude plugin uninstall ${PLUGIN_NAME}@${MARKETPLACE_NAME} --scope user`, { stdio: "pipe" });
   } catch {}
 
-  // Belt-and-suspenders: also purge the registry JSON directly in case
-  // `claude plugin uninstall` doesn't clean installed_plugins.json reliably.
-  purgeInstalledPluginsJson();
+  // Directly clear the registry entry regardless of whether the CLI uninstall
+  // removed it (the CLI skips entries whose projectPath != cwd).
+  clearInstalledPluginsEntry();
+
+  // Remove stale cache dirs so `claude plugin install` has nothing stale to
+  // restore. writeInstalledPluginsJson will recreate the correct version dir.
+  const cachePluginDir = path.join(
+    os.homedir(), ".claude", "plugins", "cache", MARKETPLACE_NAME, PLUGIN_NAME
+  );
+  if (fs.existsSync(cachePluginDir)) {
+    fs.rmSync(cachePluginDir, { recursive: true, force: true });
+  }
 
   execSync(`claude plugin marketplace add "${pluginsDir}"`, { stdio: "pipe" });
 
   const scopeFlag = scope === "project" ? "--scope project" : "--scope user";
   execSync(`claude plugin install ${PLUGIN_NAME}@${MARKETPLACE_NAME} ${scopeFlag}`, { stdio: "pipe" });
+
+  // Overwrite whatever Claude wrote with the correct version and cache path.
+  writeInstalledPluginsJson(version, installDir, scope);
 }
 
 function removeFromSettings(settingsPath) {
@@ -313,14 +359,36 @@ function removeFromSettings(settingsPath) {
 // ── Commands ──────────────────────────────────────────────────────────────────
 
 async function install() {
+  // Warn if this installer binary is outdated (npx caches old versions).
+  // Stale installers lack bug fixes — users should run with @latest.
+  const latestMeta = await getLatestNpmMeta();
+  if (latestMeta) {
+    const versionLt = (a, b) => {
+      const [aMaj, aMin, aPat] = a.split(".").map(Number);
+      const [bMaj, bMin, bPat] = b.split(".").map(Number);
+      return aMaj < bMaj || (aMaj === bMaj && aMin < bMin) || (aMaj === bMaj && aMin === bMin && aPat < bPat);
+    };
+    if (versionLt(CURRENT_VERSION, latestMeta.version)) {
+      console.log(`\nWarning: installer v${CURRENT_VERSION} is outdated (v${latestMeta.version} available).`);
+      console.log(`Run with @latest to get the current installer:`);
+      console.log(`  npx ${NPM_PACKAGE}@latest install\n`);
+      return;
+    }
+  }
+
+  const meta = latestMeta;
+  if (!meta) {
+    console.error("\nCould not fetch latest version from npm registry. Check your internet connection.\n");
+    process.exit(1);
+  }
+
   const globalExists = fs.existsSync(GLOBAL_INSTALL_DIR);
   const projectExists = fs.existsSync(PROJECT_INSTALL_DIR);
 
   if (globalExists || projectExists) {
-    const meta = await getLatestNpmMeta();
     if (globalExists) {
       const v = getInstalledVersion(GLOBAL_INSTALL_DIR);
-      if (meta && v !== meta.version) {
+      if (v !== meta.version) {
         console.log(`\nGlobal install found (v${v}). v${meta.version} available — run: npx ${NPM_PACKAGE} update\n`);
       } else {
         console.log(`\nGlobal install already up to date (v${v || "unknown"}).\n`);
@@ -328,7 +396,7 @@ async function install() {
     }
     if (projectExists) {
       const v = getInstalledVersion(PROJECT_INSTALL_DIR);
-      if (meta && v !== meta.version) {
+      if (v !== meta.version) {
         console.log(`\nProject install found (v${v}). v${meta.version} available — run: npx ${NPM_PACKAGE} update\n`);
       } else {
         console.log(`\nProject install already up to date (v${v || "unknown"}).\n`);
@@ -337,12 +405,6 @@ async function install() {
     return;
   }
 
-  const meta = await getLatestNpmMeta();
-  if (!meta) {
-    console.error("\nCould not fetch latest version from npm registry. Check your internet connection.\n");
-    process.exit(1);
-  }
-
   const { installDir, scope } = await resolveInstallTarget();
 
   console.log(`\nInstalling presentation-generator plugin...`);
@@ -352,7 +414,7 @@ async function install() {
   console.log(`\nInstalled v${meta.version} to: ${label}`);
 
   console.log("\nRegistering plugin with Claude Code...");
-  registerWithClaude(installDir, scope);
+  registerWithClaude(installDir, scope, meta.version);
   cleanOldCacheVersions(meta.version);
 
   const settingsLabel = scope === "project" ? ".claude/settings.json" : "~/.claude/settings.json";
@@ -390,7 +452,7 @@ async function update() {
     console.log(`\n${label}: updating v${before || "unknown"} → v${meta.version}...`);
     await downloadAndExtract(meta.version, meta.tarball, installDir);
     const updateScope = installDir === GLOBAL_INSTALL_DIR ? "user" : "project";
-    registerWithClaude(installDir, updateScope);
+    registerWithClaude(installDir, updateScope, meta.version);
     cleanOldCacheVersions(meta.version);
     console.log(`${label}: updated to v${meta.version} ✓`);
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ztffn/presentation-generator-plugin",
-  "version": "1.4.2",
+  "version": "1.4.4",
   "description": "Claude Code plugin for generating graph-based presentations",
   "bin": {
     "presentation-generator-plugin": "bin/index.js"