@zq-silk/yui 0.11.2 → 0.12.0

package/dist/commands/configCommands.js

@@ -1,11 +1,11 @@
 import { mkdirSync, realpathSync } from "node:fs";
 import { isAbsolute, relative, resolve } from "node:path";
 import { usageError } from "../errors/cliError.js";
-import { DEFAULT_CONTEXT_HARD_TOKENS, DEFAULT_CONTEXT_SOFT_TOKENS, DEFAULT_AGENT_LAUNCH_INACTIVITY_TIMEOUT_SECONDS, DEFAULT_CONTROLLER_TASK_CONCURRENCY, DEFAULT_DELIVERY_TIMEOUT_SECONDS, DEFAULT_LEADER_NEXT_ACTION_MODE, DEFAULT_LEADER_SEMANTIC_BUDGET_TURNS, DEFAULT_PROVIDER_RETRY_DELAYS_SECONDS, DEFAULT_PROVIDER_RETRY_MAX_WINDOW_SECONDS, DEFAULT_PROVIDER_RETRY_MODE, DEFAULT_RECONCILIATION_INTERVAL_SECONDS, DEFAULT_RESOURCES_GC_MODE, DEFAULT_RESOURCES_QUARANTINE_TTL_HOURS, DEFAULT_TMUX_HISTORY_LIMIT, LEADER_NEXT_ACTION_MODES, PROVIDER_RETRY_MODES, reconciliationIntervalMilliseconds, resolveAgentLaunchInactivityTimeoutSeconds, resolveControllerTaskConcurrency, resolveContextBudget, resolveDeliveryTimeoutSeconds, resolveLeaderNextActionMode, resolveLeaderSemanticBudgetTurns, resolveProviderRetryAdapters, resolveProviderRetryDelaysSeconds, resolveProviderRetryMaxWindowSeconds, resolveProviderRetryMode, resolveResourcesGcAutoQuarantine, resolveResourcesGcMode, resolveResourcesQuarantineTtlHours, resolveRuntimeHealth, resolveTelemetryEnabled, resolveTelemetryRunCap, resolveTelemetryTerminalKeep, resolveTmuxBin, resolveTmuxHistoryLimit } from "../config/yuiConfig.js";
+import { DEFAULT_AGENT_LAUNCH_INACTIVITY_TIMEOUT_SECONDS, DEFAULT_CONTROLLER_TASK_CONCURRENCY, DEFAULT_DELIVERY_TIMEOUT_SECONDS, DEFAULT_LEADER_NEXT_ACTION_MODE, DEFAULT_LEADER_SEMANTIC_BUDGET_TURNS, DEFAULT_PROVIDER_RETRY_DELAYS_SECONDS, DEFAULT_PROVIDER_RETRY_MAX_WINDOW_SECONDS, DEFAULT_PROVIDER_RETRY_MODE, DEFAULT_RECONCILIATION_INTERVAL_SECONDS, DEFAULT_RESOURCES_GC_MODE, DEFAULT_RESOURCES_QUARANTINE_TTL_HOURS, DEFAULT_TMUX_HISTORY_LIMIT, LEADER_NEXT_ACTION_MODES, PROVIDER_RETRY_MODES, reconciliationIntervalMilliseconds, resolveAgentLaunchInactivityTimeoutSeconds, resolveControllerTaskConcurrency, resolveContextBudget, resolveDeliveryTimeoutSeconds, resolveLeaderNextActionMode, resolveLeaderSemanticBudgetTurns, resolveProviderRetryAdapters, resolveProviderRetryDelaysSeconds, resolveProviderRetryMaxWindowSeconds, resolveProviderRetryMode, resolveResourcesGcAutoQuarantine, resolveResourcesGcMode, resolveResourcesQuarantineTtlHours, resolveRuntimeHealth, resolveTelemetryEnabled, resolveTelemetryRunCap, resolveTelemetryTerminalKeep, resolveTmuxBin, resolveTmuxHistoryLimit } from "../config/yuiConfig.js";
 import { CONFIG_DEFINITIONS, CONFIG_KEYS, configDefinition, configDefinitionsForDomain } from "../config/configCatalog.js";
 import { resolveTimeZone } from "../output/timePresentation.js";
 import { defaultTableWidth, renderTable } from "../output/table.js";
-import { DEFAULT_DELTA_RECHECK_MAX_CHANGED_FILES, DEFAULT_DELTA_RECHECK_MAX_CHANGED_LINES, REVIEW_FINDING_LEDGER_MODES, REVIEW_DELTA_RECHECK_MODES, REVIEW_TRIGGERS } from "../review/reviewConfig.js";
+import { REVIEW_FINDING_LEDGER_MODES, REVIEW_TRIGGERS } from "../review/reviewConfig.js";
 /**
  * One uniform key model for every durable setting. Each catalog domain uses
  * the same show/set/clear contract; strategy settings such as `review` and
@@ -23,8 +23,7 @@ const RESOURCES_GC_AUTO_QUARANTINE_SET_USAGE = "Resources config set usage: yui
 const LEADER_NEXT_ACTION_SET_USAGE = `Workflow config set usage: yui config workflow set leader-next-action <${LEADER_NEXT_ACTION_MODES.join("|")}>.`;
 const CONTEXT_BUDGET_SET_USAGE = "Workflow config set usage: yui config workflow set context-budget [--soft-tokens <n>] [--hard-tokens <n>].";
 const REVIEW_SET_USAGE = "Workflow config set usage: yui config workflow set review --role <global-role> --trigger <always|leader|final> "
-    + "[--finding-ledger <shadow|enforce>] [--delta-recheck <enabled|disabled>] "
-    + "[--delta-recheck-max-lines <n>] [--delta-recheck-max-files <n>].";
+    + "[--finding-ledger <shadow|enforce>].";
 export function runConfigCommand(domain, args, store) {
     const keys = configDefinitionsForDomain(domain).map(({ key }) => key);
     const usage = `${capitalize(domain)} config usage: yui config ${domain} show | yui config ${domain} set <key> <value...> | yui config ${domain} clear <key>.`;
@@ -97,12 +96,7 @@ export function effectiveConfigData(config, domain) {
             : {
                 roleName: config.review.roleName,
                 trigger: config.review.trigger,
-                findingLedger: config.review.findingLedger ?? "shadow",
-                deltaRecheck: config.review.deltaRecheck ?? "disabled",
-                deltaRecheckMaxChangedLines: config.review.deltaRecheckMaxChangedLines
-                    ?? DEFAULT_DELTA_RECHECK_MAX_CHANGED_LINES,
-                deltaRecheckMaxChangedFiles: config.review.deltaRecheckMaxChangedFiles
-                    ?? DEFAULT_DELTA_RECHECK_MAX_CHANGED_FILES
+                findingLedger: config.review.findingLedger ?? "shadow"
             },
         completionInstallations: config.completionInstallations ?? {}
     };
@@ -175,14 +169,6 @@ function parseReconciliationIntervalSeconds(value) {
 function parseBooleanConfigValue(value) {
     return value === "true" ? true : value === "false" ? false : value;
 }
-function parsePositiveIntegerOption(value, usage) {
-    if (value === undefined)
-        return undefined;
-    if (!/^\d+$/.test(value) || Number(value) < 1) {
-        throw usageError(usage);
-    }
-    return Number(value);
-}
 const CONFIG_KEY_HANDLERS = [
     {
         key: "default-agent",
@@ -313,10 +299,10 @@ const CONFIG_KEY_HANDLERS = [
     },
     {
         key: "context-budget",
-        showLabel: "Context budget",
+        showLabel: "Legacy context budget (inactive)",
         showValue: (config) => {
             const budget = resolveContextBudget(config.contextBudget);
-            return `soft ${budget.softTokens} / hard ${budget.hardTokens} tokens`;
+            return `inactive; legacy soft ${budget.softTokens} / hard ${budget.hardTokens} tokens`;
         },
         set(args, store) {
             if (args.length !== 2 && args.length !== 4)
@@ -343,14 +329,14 @@ const CONFIG_KEY_HANDLERS = [
             };
             const resolved = resolveContextBudget({ ...current, ...next });
             saveConfigKey(store, (config) => ({ ...config, contextBudget: resolved }));
-            return `Context budget set to soft ${resolved.softTokens} / hard ${resolved.hardTokens} tokens\n`;
+            return `Legacy context budget stored as soft ${resolved.softTokens} / hard ${resolved.hardTokens} tokens (inactive)\n`;
         },
         clear(store) {
             saveConfigKey(store, (config) => {
                 const { contextBudget: _removed, ...rest } = config;
                 return rest;
             });
-            return `Context budget reset to soft ${DEFAULT_CONTEXT_SOFT_TOKENS} / hard ${DEFAULT_CONTEXT_HARD_TOKENS} tokens\n`;
+            return "Legacy context budget cleared; Session Token metrics remain read-only\n";
         }
     },
     {
@@ -696,7 +682,7 @@ const CONFIG_KEY_HANDLERS = [
         showValue: (config) => (config.review === undefined
             ? "disabled"
             : `${config.review.roleName} (${config.review.trigger}; finding ledger: ${config.review.findingLedger ?? "shadow"}`
-                + `${config.review.deltaRecheck === "enabled" ? "; delta recheck: enabled" : ""})`),
+                + ")"),
         set(args, store) {
             if (args.length < 4 || args.length % 2 !== 0)
                 throw usageError(REVIEW_SET_USAGE);
@@ -704,8 +690,7 @@ const CONFIG_KEY_HANDLERS = [
             for (let index = 0; index < args.length; index += 2) {
                 const name = args[index];
                 const value = args[index + 1];
-                if (!["--role", "--trigger", "--finding-ledger", "--delta-recheck",
-                    "--delta-recheck-max-lines", "--delta-recheck-max-files"].includes(name)
+                if (!["--role", "--trigger", "--finding-ledger"].includes(name)
                     || value === undefined
                     || options.has(name)) {
                     throw usageError(REVIEW_SET_USAGE);
@@ -731,33 +716,15 @@ const CONFIG_KEY_HANDLERS = [
                 }
                 findingLedger = rawLedgerMode;
             }
-            const rawDeltaRecheck = options.get("--delta-recheck")?.trim();
-            let deltaRecheck;
-            if (rawDeltaRecheck !== undefined) {
-                if (!REVIEW_DELTA_RECHECK_MODES.includes(rawDeltaRecheck)) {
-                    throw usageError(REVIEW_SET_USAGE);
-                }
-                deltaRecheck = rawDeltaRecheck;
-            }
-            const deltaRecheckMaxChangedLines = parsePositiveIntegerOption(options.get("--delta-recheck-max-lines"), REVIEW_SET_USAGE);
-            const deltaRecheckMaxChangedFiles = parsePositiveIntegerOption(options.get("--delta-recheck-max-files"), REVIEW_SET_USAGE);
             saveConfigKey(store, (config) => ({
                 ...config,
                 review: {
                     roleName,
                     trigger,
-                    ...(findingLedger === undefined ? {} : { findingLedger }),
-                    ...(deltaRecheck === undefined ? {} : { deltaRecheck }),
-                    ...(deltaRecheckMaxChangedLines === undefined
-                        ? {}
-                        : { deltaRecheckMaxChangedLines }),
-                    ...(deltaRecheckMaxChangedFiles === undefined
-                        ? {}
-                        : { deltaRecheckMaxChangedFiles })
+                    ...(findingLedger === undefined ? {} : { findingLedger })
                 }
             }));
-            return `Review set to ${roleName} (${trigger}; finding ledger: ${findingLedger ?? "shadow"}; `
-                + `delta recheck: ${deltaRecheck ?? "disabled"})\n`;
+            return `Review set to ${roleName} (${trigger}; finding ledger: ${findingLedger ?? "shadow"})\n`;
         },
         clear(store) {
             saveConfigKey(store, (config) => {

package/dist/commands/executionAuditCommands.js

@@ -155,7 +155,7 @@ export function renderExecutionAudit(report, width = defaultTableWidth()) {
                 `Delta-rechecks: ${reviews.deltaRechecks.total} total · `
                     + `${reviews.deltaRechecks.equivalentAndAccepted} accepted · `
                     + `${reviews.deltaRechecks.finding} finding · `
-                    + `${reviews.deltaRechecks.requiresFullReview} escalated to full Review`
+                    + `${reviews.deltaRechecks.requiresFullReview} requiring Leader decision`
             ]));
     }
     else {

package/dist/commands/jobCommands.js

@@ -56,18 +56,14 @@ function collectJobs(store) {
             });
         }
         const failure = store.getLeaderFailure(task.id);
-        const notification = store.getOperatorNotification(task.id);
-        const recoveryNotification = notification?.type === "leader-recovery-failed"
-            ? notification
-            : null;
-        if (failure !== null || recoveryNotification !== null) {
+        if (failure !== null) {
             jobs.push({
                 id: `${RECOVERY_PREFIX}${task.id}`,
                 taskId: task.id,
                 kind: "leader-recovery",
                 status: "failed",
-                detail: failure?.message ?? recoveryNotification?.message ?? "Leader recovery failed.",
-                updatedAt: failure?.lastFailedAt ?? recoveryNotification?.updatedAt ?? task.updatedAt
+                detail: failure.message,
+                updatedAt: failure.lastFailedAt
             });
         }
     }
@@ -93,12 +89,10 @@ function retryJob(args, store, options) {
         if (task.status !== "active") {
             throw usageError(`Leader recovery can only be retried for an active Task: ${task.id}.`);
         }
-        if (tx.getLeaderFailure(task.id) === null
-            && tx.getOperatorNotification(task.id)?.type !== "leader-recovery-failed") {
+        if (tx.getLeaderFailure(task.id) === null) {
             throw usageError(`Job not found: ${id}.`);
         }
         tx.clearLeaderFailure(task.id);
-        tx.clearOperatorNotification(task.id);
         enqueueWork(tx, { kind: "role", taskId: task.id, roleName: "leader" }, "recovery-retry", now, [{ type: "task", id: task.id }]);
     });
     const target = { kind: "role", taskId, roleName: "leader" };