@zosmaai/pi-llm-wiki 0.9.3 → 0.10.1

package/CHANGELOG.md

@@ -3,6 +3,8 @@
 ## [Unreleased]
 
 ### Fixed
+- **`buildIngestedSourcePage` omits folder prefix on entity/concept wikilinks** (Issue #89): `buildIngestedSourcePage()` in `lib/ingest-worker.ts` generated entity and concept wikilinks in ingested source pages as `[[entity-name]]` instead of `[[entities/entity-name]]`. The bare target never matched the page ID (which carries the folder prefix, e.g. `entities/entity-name`), leaving every entity and concept with zero inbound links and producing 177 orphans out of 180 pages in real vaults. The concept/entity page templates already used the correct `[[sources/...]]` prefix — only the source page template was broken. Fixed by adding the `entities/` and `concepts/` prefix to the generated wikilinks.
+
 - **`wiki_watch` referred to a fictional `schedule_prompt` tool** (Issue #81): `wiki_watch` emitted instructions to run `schedule_prompt action=add ...` — a tool that doesn't exist in pi-coding-agent or any pi extension — so `/wiki-run --schedule weekly` printed a command the user couldn't execute. The emitted payload also contained the typo `/wiki:run` (real slash-command is `/wiki-run`), and the tool description claimed it scheduled jobs when it only ever printed instructions. Now emits a real, copy-pasteable **POSIX 5-field crontab line** wrapped in `/bin/bash -lc` (so npm-global / bun / nvm PATH is imported under cron's minimal env), with defensive `mkdir -p` of the log dir and a `# llm-wiki-autoupdate` removal tag. The tool description, output text, `prompts/wiki-run.md`, `docs/api.md` and all 10 i18n READMEs now explicitly say "prints — does not install". `details` now carries `cronLine` and `installed: false`. New `test/wiki-watch.test.ts` (10 tests) locks down all three regressions plus the portability contract (login-shell wrapper, defensive `mkdir`, quoted `$HOME`).
 - **Personal wiki created at doubled path `~/.llm-wiki/.llm-wiki/…`**: `getPersonalWikiRoot()` returned the dot-dir itself (`~/.llm-wiki`) while `getVaultPaths()` then appended another `.llm-wiki/` segment, so the personal vault was written to `~/.llm-wiki/.llm-wiki/wiki/…`. Fixed by aligning `getPersonalWikiRoot()` with the same "root = parent of `.llm-wiki/`" contract used by project vaults. `WIKI_HOME` continues to override the parent.
 

package/README.md

@@ -422,17 +422,17 @@ Thanks to everyone who has contributed! This list is regenerated automatically b
                 </a>
             </td>
             <td align="center">
-                <a href="https://github.com/jfraser">
-                    <img src="https://avatars.githubusercontent.com/u/165964?v=4" width="64;" alt="jfraser"/>
+                <a href="https://github.com/Shanvit7">
+                    <img src="https://avatars.githubusercontent.com/u/64424817?v=4" width="64;" alt="Shanvit7"/>
                     <br />
-                    <sub><b>James Fraser</b></sub>
+                    <sub><b>Shanvit S Shetty</b></sub>
                 </a>
             </td>
             <td align="center">
-                <a href="https://github.com/Shanvit7">
-                    <img src="https://avatars.githubusercontent.com/u/64424817?v=4" width="64;" alt="Shanvit7"/>
+                <a href="https://github.com/jfraser">
+                    <img src="https://avatars.githubusercontent.com/u/165964?v=4" width="64;" alt="jfraser"/>
                     <br />
-                    <sub><b>Shanvit S Shetty</b></sub>
+                    <sub><b>James Fraser</b></sub>
                 </a>
             </td>
             <td align="center">

package/extensions/llm-wiki/index.ts

@@ -2,7 +2,7 @@ import { existsSync, readFileSync, writeFileSync } from "node:fs";
 import { basename, join } from "node:path";
 import type { ExtensionAPI } from "@mariozechner/pi-coding-agent";
 import { installGuardrails } from "./lib/guardrails.js";
-import { appendWikiStatus } from "./lib/inject.js";
+import { buildAgentStartInjection } from "./lib/inject.js";
 import { registerWikiModelCommand } from "./lib/model-command.js";
 import {
   buildSessionNotice,
@@ -216,7 +216,14 @@ export default function (pi: ExtensionAPI) {
     }
 
     const prompt = event.prompt || "";
-    let injectedContext = event.systemPrompt || "";
+    // Volatile, per-turn content (recall results + one-time topic-inference
+    // directive) MUST NOT go into the system prompt (issue #92). The system
+    // prompt is the provider's primary cache prefix; rewriting it every turn
+    // (recall is keyed on event.prompt, so it differs each turn) invalidates
+    // the whole prompt cache, forcing a full re-prompt-fill every turn. Collect
+    // it here and deliver it as a tail conversation message instead, which
+    // leaves the cached system-prompt prefix stable.
+    let dynamicContext = "";
 
     // Topic inference on first turn after auto-creation
     if (needsTopicInference && prompt.trim()) {
@@ -238,7 +245,7 @@ export default function (pi: ExtensionAPI) {
         // ignore
       }
 
-      injectedContext += `
+      dynamicContext += `
 
 ## Wiki Setup Required
 The LLM Wiki was just auto-created but needs its topic and mode configured. Before responding to the user, analyze their prompt and this project's context to infer:
@@ -279,7 +286,7 @@ Then call wiki_bootstrap with the inferred topic and mode to finalize the setup.
           skillInlineMax: runtime.config?.recallSkillInlineMax,
         });
         if (recallContext) {
-          injectedContext += `\n\n${recallContext}`;
+          dynamicContext += `\n\n${recallContext}`;
         }
         // Recall-aware status line (issue #77): make it visible that recall
         // actually fired and how many pages matched. Purely a UI signal — no
@@ -294,11 +301,19 @@ Then call wiki_bootstrap with the inferred topic and mode to finalize the setup.
       }
     }
 
-    // Always inject a visible wiki status footer, even when empty
-    // This ensures the model knows the wiki is active and can use it
-    injectedContext = appendWikiStatus(injectedContext);
+    // Split into a cache-stable system prompt (static footer only) and a
+    // volatile tail message (issue #92). See lib/inject.ts for the contract.
+    const { systemPrompt, message } = buildAgentStartInjection(event.systemPrompt || "", [
+      dynamicContext,
+    ]);
 
-    if (injectedContext === event.systemPrompt) return;
-    return { systemPrompt: injectedContext };
+    // Only claim a systemPrompt change when the footer actually altered the
+    // string (a carry-forward turn already carries it, so this no-ops).
+    const systemPromptChanged = systemPrompt !== event.systemPrompt;
+    if (!systemPromptChanged && !message) return;
+    return {
+      ...(systemPromptChanged ? { systemPrompt } : {}),
+      ...(message ? { message } : {}),
+    };
   });
 }

package/extensions/llm-wiki/lib/ingest-worker.ts

@@ -116,11 +116,11 @@ export function buildIngestedSourcePage(
       : "- [None recorded]";
   const entities =
     data.entities.length > 0
-      ? data.entities.map((e) => `- [[${slugify(e.title)}]]`).join("\n")
+      ? data.entities.map((e) => `- [[entities/${slugify(e.title)}]]`).join("\n")
       : "- [None]";
   const concepts =
     data.concepts.length > 0
-      ? data.concepts.map((c) => `- [[${slugify(c.title)}]]`).join("\n")
+      ? data.concepts.map((c) => `- [[concepts/${slugify(c.title)}]]`).join("\n")
       : "- [None]";
   const quotes =
     data.quotes && data.quotes.length > 0

package/extensions/llm-wiki/lib/inject.ts

@@ -1,11 +1,18 @@
 /**
- * System-prompt context injection primitives (issue #87).
+ * System-prompt context injection primitives (issues #87, #92).
  *
  * The `before_agent_start` hook augments the chained system prompt with a
  * visible wiki-status footer. This module isolates that append so it can be
  * unit-tested for idempotency — a turn that aborts (network error / ESC) and is
  * retried can carry the prior injection forward, and a naive append stacks the
  * footer 2x, 3x, ...
+ *
+ * It also owns the cache-safety split (issue #92): VOLATILE per-turn context
+ * (recall results, one-time topic-inference directive) must never enter the
+ * system prompt — that is the provider's primary cache prefix, so per-turn
+ * variation there forces a full cache miss every turn. Volatile content is
+ * routed into a tail conversation message instead. `buildAgentStartInjection`
+ * is the single, pure decision point for that split.
  */
 
 /** The always-injected wiki-status footer (sans surrounding whitespace). */
@@ -25,3 +32,54 @@ export function appendWikiStatus(systemPrompt: string): string {
   const base = systemPrompt.split(`\n\n${WIKI_STATUS_BLOCK}`).join("");
   return `${base}\n\n${WIKI_STATUS_BLOCK}`;
 }
+
+/** customType of the hidden tail message carrying volatile per-turn context. */
+export const WIKI_RECALL_MESSAGE_TYPE = "wiki-recall-context";
+
+/** A hidden, LLM-visible tail message carrying volatile per-turn wiki context. */
+export interface WikiRecallMessage {
+  customType: typeof WIKI_RECALL_MESSAGE_TYPE;
+  content: string;
+  display: false;
+}
+
+/** Result of the cache-safe split for one `before_agent_start` turn. */
+export interface AgentStartInjection {
+  /**
+   * The system prompt to return. ONLY ever the base plus the static footer —
+   * never any volatile content — so it is byte-identical turn over turn and
+   * the provider's prompt cache stays warm (issue #92).
+   */
+  systemPrompt: string;
+  /** Volatile blocks, delivered as a tail message. Omitted when empty. */
+  message?: WikiRecallMessage;
+}
+
+/**
+ * Split a turn's injection into a cache-stable system prompt and a volatile
+ * tail message (issue #92).
+ *
+ * - `systemPrompt` is always `appendWikiStatus(baseSystemPrompt)` — the static
+ *   footer only. It carries NONE of `dynamicBlocks`, so it does not vary with
+ *   recall results and never breaks the provider cache prefix.
+ * - `dynamicBlocks` (recall context, topic-inference directive, ...) are
+ *   trimmed, emptied entries dropped, and joined with a blank line into the
+ *   message body. When nothing survives, no message is emitted.
+ *
+ * Pure and side-effect free — see test/agent-start-injection.test.ts.
+ */
+export function buildAgentStartInjection(
+  baseSystemPrompt: string,
+  dynamicBlocks: Array<string | undefined>,
+): AgentStartInjection {
+  const systemPrompt = appendWikiStatus(baseSystemPrompt);
+  const content = dynamicBlocks
+    .map((b) => b?.trim())
+    .filter((b): b is string => Boolean(b))
+    .join("\n\n");
+  if (!content) return { systemPrompt };
+  return {
+    systemPrompt,
+    message: { customType: WIKI_RECALL_MESSAGE_TYPE, content, display: false },
+  };
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zosmaai/pi-llm-wiki",
-  "version": "0.9.3",
+  "version": "0.10.1",
   "description": "Self-maintaining LLM Wiki for Pi — Karpathy-pattern knowledge base with immutable source capture, automated ingestion, search, linting, and Obsidian-compatible vault. auto-updating personal & company wiki.",
   "keywords": [
     "pi",
@@ -47,22 +47,16 @@
   "publishConfig": {
     "access": "public"
   },
-  "scripts": {
-    "test": "vitest run",
-    "test:watch": "vitest",
-    "test:coverage": "vitest run --coverage",
-    "typecheck": "tsc --noEmit",
-    "lint": "biome check .",
-    "lint:fix": "biome check --apply .",
-    "release:patch": "node scripts/release.js patch",
-    "release:minor": "node scripts/release.js minor",
-    "release:major": "node scripts/release.js major",
-    "release:push": "git push origin main --tags"
-  },
   "pi": {
-    "extensions": ["./extensions"],
-    "skills": ["./skills"],
-    "prompts": ["./prompts"],
+    "extensions": [
+      "./extensions"
+    ],
+    "skills": [
+      "./skills"
+    ],
+    "prompts": [
+      "./prompts"
+    ],
     "image": "https://raw.githubusercontent.com/zosmaai/pi-llm-wiki/main/assets/screenshot.png",
     "mcpservers": {
       "llm-wiki": "node ./mcp/index.js"
@@ -81,11 +75,26 @@
   },
   "devDependencies": {
     "@biomejs/biome": "^1.9.4",
+    "@mariozechner/pi-agent-core": "^0.70.2",
+    "@mariozechner/pi-ai": "^0.70.2",
     "@mariozechner/pi-coding-agent": "^0.70.2",
     "@mermaid-js/mermaid-cli": "^11.12.0",
+    "@types/node": "^22",
     "@vitest/coverage-v8": "^3.2.4",
     "typebox": "^1.1.34",
     "typescript": "^5.7.0",
     "vitest": "^3.0.0"
+  },
+  "scripts": {
+    "test": "vitest run",
+    "test:watch": "vitest",
+    "test:coverage": "vitest run --coverage",
+    "typecheck": "tsc --noEmit",
+    "lint": "biome check .",
+    "lint:fix": "biome check --apply .",
+    "release:patch": "node scripts/release.js patch",
+    "release:minor": "node scripts/release.js minor",
+    "release:major": "node scripts/release.js major",
+    "release:push": "git push origin main --tags"
   }
-}
+}