@zosmaai/pi-llm-wiki 0.9.0 → 0.9.2

package/extensions/llm-wiki/lib/task-config.ts

@@ -1,4 +1,4 @@
-import { existsSync, mkdirSync, readFileSync, writeFileSync } from "node:fs";
+import { mkdirSync, readFileSync, writeFileSync } from "node:fs";
 import { dirname, join } from "node:path";
 import { getAgentDir } from "@mariozechner/pi-coding-agent";
 
@@ -69,10 +69,58 @@ export interface TaskConfig {
    * previews inline. Clamped to a non-negative integer.
    */
   recallLinksThreshold?: number;
+
+  /**
+   * Max characters of a distilled `skill`/`case` body inlined directly into a
+   * recall block before truncation (recall-adherence fix). Skills/cases are
+   * meant to be APPLIED immediately, so links-first recall inlines their short
+   * body instead of a bare link the agent often skips. Set to 0 to DISABLE
+   * inlining entirely — skills/cases then fall back to the normal link/preview
+   * path (pure links-first), and no page body is read at format time. Only
+   * relevant when the trajectories feature is on (skill/case pages exist only
+   * then). Default 1600. Clamped to a non-negative integer. Mirrors the
+   * `recallLinksThreshold` knob — the other context-window lever for recall.
+   */
+  recallSkillInlineMax?: number;
+
+  /**
+   * Surface wiki activity in the UI (issue #77). When enabled (the default),
+   * the status line reflects recall hits and the periodic observe/retro
+   * reminder is shown to the user (`display: true`) instead of being injected
+   * silently. Set to `false` to restore the previous quiet behavior — a static
+   * status line and a hidden (`display: false`) reminder — for users who do
+   * not want any chat-level wiki notices.
+   */
+  notices?: boolean;
+
+  /**
+   * Agent-trajectory working-memory (capture → distill → recall), issue #80.
+   * OPT-IN, default OFF: only an explicit `trajectories: true` enables it.
+   * When off, the trajectory tools are never registered (see index.ts), so
+   * they cost nothing in the system prompt for the ~95% who don't use them.
+   */
+  trajectories?: boolean;
 }
 
 export const TASK_DEFAULTS: TaskConfig = {};
 
+/**
+ * Resolve whether user-facing wiki notices are enabled (issue #77). Defaults
+ * to `true`; only an explicit `notices: false` disables them.
+ */
+export function noticesEnabled(config: TaskConfig | undefined): boolean {
+  return config?.notices !== false;
+}
+
+/**
+ * Resolve whether agent-trajectory working-memory is enabled (issue #80).
+ * INVERSE polarity of `noticesEnabled`: defaults to `false`; only an explicit
+ * `trajectories: true` turns it on.
+ */
+export function trajectoriesEnabled(config: TaskConfig | undefined): boolean {
+  return config?.trajectories === true;
+}
+
 const SETTINGS_KEY = "llm-wiki";
 
 function readModelSpec(value: unknown): { provider: string; id: string } | undefined {
@@ -85,9 +133,8 @@ function readModelSpec(value: unknown): { provider: string; id: string } | undef
 }
 
 function readNamespacedConfig(path: string): Partial<TaskConfig> {
-  if (!existsSync(path)) return {};
   try {
-    const raw = JSON.parse(readFileSync(path, "utf-8")) as Record<string, unknown>;
+    const raw = readSettingsObject(path);
     const nested = raw[SETTINGS_KEY];
     if (!nested || typeof nested !== "object") return {};
     const section = nested as Record<string, unknown>;
@@ -115,6 +162,19 @@ function readNamespacedConfig(path: string): Partial<TaskConfig> {
     if (typeof threshold === "number" && Number.isFinite(threshold)) {
       out.recallLinksThreshold = Math.max(0, Math.floor(threshold));
     }
+
+    const inlineMax = section.recallSkillInlineMax;
+    if (typeof inlineMax === "number" && Number.isFinite(inlineMax)) {
+      out.recallSkillInlineMax = Math.max(0, Math.floor(inlineMax));
+    }
+
+    if (typeof section.notices === "boolean") {
+      out.notices = section.notices;
+    }
+
+    if (typeof section.trajectories === "boolean") {
+      out.trajectories = section.trajectories;
+    }
     return out;
   } catch {
     return {};
@@ -138,6 +198,22 @@ export function parseModelRef(ref: string): { provider: string; id: string } | u
   return { provider, id };
 }
 
+/**
+ * Read a settings JSON file as a plain object, or `{}` when it is absent or
+ * corrupt. Reads directly (no `existsSync` pre-check) so there is no
+ * check-then-use race: a missing file throws ENOENT, which the catch treats
+ * the same as an empty file.
+ */
+function readSettingsObject(path: string): Record<string, unknown> {
+  try {
+    const parsed = JSON.parse(readFileSync(path, "utf-8"));
+    if (parsed && typeof parsed === "object") return parsed as Record<string, unknown>;
+  } catch {
+    // Missing or corrupt settings file: start from an empty object.
+  }
+  return {};
+}
+
 /**
  * Persist (or clear) the wiki background `taskModel` in the PROJECT settings
  * file `<cwd>/.pi/settings.json` under the namespaced `llm-wiki` key (issue
@@ -151,16 +227,7 @@ export function persistTaskModel(
   model: { provider: string; id: string } | undefined,
 ): void {
   const settingsPath = join(cwd, ".pi", "settings.json");
-  let raw: Record<string, unknown> = {};
-  if (existsSync(settingsPath)) {
-    try {
-      const parsed = JSON.parse(readFileSync(settingsPath, "utf-8"));
-      if (parsed && typeof parsed === "object") raw = parsed as Record<string, unknown>;
-    } catch {
-      // Corrupt settings file: start from an empty object rather than throw.
-      raw = {};
-    }
-  }
+  const raw = readSettingsObject(settingsPath);
 
   const existing = raw[SETTINGS_KEY];
   const section: Record<string, unknown> =
@@ -178,6 +245,33 @@ export function persistTaskModel(
   writeFileSync(settingsPath, `${JSON.stringify(raw, null, 2)}\n`, "utf-8");
 }
 
+/**
+ * Persist the agent-trajectory flag in the PROJECT settings file
+ * `<cwd>/.pi/settings.json` under the namespaced `llm-wiki` key (issue #80).
+ * Mirrors `persistTaskModel`: project settings win in `loadTaskConfig`, other
+ * keys are preserved. `true` writes `trajectories: true`; `false` removes the
+ * key (reverting to the default-off behavior).
+ */
+export function persistTrajectoriesEnabled(cwd: string, enabled: boolean): void {
+  const settingsPath = join(cwd, ".pi", "settings.json");
+  const raw = readSettingsObject(settingsPath);
+
+  const existing = raw[SETTINGS_KEY];
+  const section: Record<string, unknown> =
+    existing && typeof existing === "object" ? { ...(existing as Record<string, unknown>) } : {};
+
+  if (enabled) {
+    section.trajectories = true;
+  } else {
+    // biome-ignore lint/performance/noDelete: one-off settings rewrite, not a hot path; removing the key keeps the JSON clean (default is off)
+    delete section.trajectories;
+  }
+  raw[SETTINGS_KEY] = section;
+
+  mkdirSync(dirname(settingsPath), { recursive: true });
+  writeFileSync(settingsPath, `${JSON.stringify(raw, null, 2)}\n`, "utf-8");
+}
+
 export function loadTaskConfig(cwd: string): TaskConfig {
   let globalPath: string;
   try {