@zoralabs/protocol-sdk 0.11.2 → 0.11.3-COMMENTS.1

package/.turbo/turbo-build.log

@@ -1,5 +1,5 @@
 
-> @zoralabs/protocol-sdk@0.11.2 build /home/runner/work/zora-protocol-private/zora-protocol-private/packages/protocol-sdk
+> @zoralabs/protocol-sdk@0.11.3-COMMENTS.1 build /home/runner/work/zora-protocol-private/zora-protocol-private/packages/protocol-sdk
 > pnpm tsup
 
 CLI Building entry: src/index.ts
@@ -10,9 +10,9 @@ CLI Target: es2021
 CLI Cleaning output folder
 CJS Build start
 ESM Build start
-CJS dist/index.cjs     224.10 KB
-CJS dist/index.cjs.map 454.19 KB
-CJS ⚡️ Build success in 322ms
 ESM dist/index.js     217.84 KB
 ESM dist/index.js.map 452.19 KB
-ESM ⚡️ Build success in 338ms
+ESM ⚡️ Build success in 294ms
+CJS dist/index.cjs     224.10 KB
+CJS dist/index.cjs.map 454.19 KB
+CJS ⚡️ Build success in 352ms

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # @zoralabs/protocol-sdk
 
+## 0.11.3-COMMENTS.1
+
+### Patch Changes
+
+- Updated dependencies [a8b21987]
+  - @zoralabs/protocol-deployments@0.3.5-COMMENTS.1
+
+## 0.11.3-COMMENTS.0
+
+### Patch Changes
+
+- Updated dependencies [7e285fb1]
+  - @zoralabs/protocol-deployments@0.3.5-COMMENTS.0
+
 ## 0.11.2
 
 ### Patch Changes

package/dist/create/1155-create-helper.test.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"1155-create-helper.test.d.ts","sourceRoot":"","sources":["../../src/create/1155-create-helper.test.ts"],"names":[],"mappings":"AAyBA,eAAO,MAAM,oBAAoB,uEACqC,CAAC;AACvE,eAAO,MAAM,uBAAuB,+BAA+B,CAAC"}
+{"version":3,"file":"1155-create-helper.test.d.ts","sourceRoot":"","sources":["../../src/create/1155-create-helper.test.ts"],"names":[],"mappings":"AA0BA,eAAO,MAAM,oBAAoB,uEACqC,CAAC;AACvE,eAAO,MAAM,uBAAuB,+BAA+B,CAAC"}

package/dist/test-utils.d.ts

@@ -1,5 +1,6 @@
 import { zoraCreator1155FactoryImplAddress } from "@zoralabs/protocol-deployments";
 import { Address, Hex, PublicClient } from "viem";
+import { NewContractParams } from "./create/types";
 export declare const waitForSuccess: (hash: Hex, publicClient: PublicClient) => Promise<void>;
 export declare const getFixedPricedMinter: ({ publicClient, chainId, }: {
     publicClient: PublicClient;
@@ -8,4 +9,5 @@ export declare const getFixedPricedMinter: ({ publicClient, chainId, }: {
 export declare const fixedPriceMinterMinterArguments: ({ mintRecipient, }: {
     mintRecipient: Address;
 }) => `0x${string}`;
+export declare function randomNewContract(): NewContractParams;
 //# sourceMappingURL=test-utils.d.ts.map

package/dist/test-utils.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"test-utils.d.ts","sourceRoot":"","sources":["../src/test-utils.ts"],"names":[],"mappings":"AAAA,OAAO,EAEL,iCAAiC,EAClC,MAAM,gCAAgC,CAAC;AACxC,OAAO,EACL,OAAO,EACP,GAAG,EACH,YAAY,EAGb,MAAM,MAAM,CAAC;AAGd,eAAO,MAAM,cAAc,SAAgB,GAAG,gBAAgB,YAAY,kBAMzE,CAAC;AAEF,eAAO,MAAM,oBAAoB,+BAG9B;IACD,YAAY,EAAE,YAAY,CAAC;IAC3B,OAAO,EAAE,MAAM,OAAO,iCAAiC,CAAC;CACzD,2BAKG,CAAC;AAEL,eAAO,MAAM,+BAA+B,uBAEzC;IACD,aAAa,EAAE,OAAO,CAAC;CACxB,kBAAwE,CAAC"}
+{"version":3,"file":"test-utils.d.ts","sourceRoot":"","sources":["../src/test-utils.ts"],"names":[],"mappings":"AAAA,OAAO,EAEL,iCAAiC,EAClC,MAAM,gCAAgC,CAAC;AACxC,OAAO,EACL,OAAO,EACP,GAAG,EACH,YAAY,EAGb,MAAM,MAAM,CAAC;AACd,OAAO,EAAE,iBAAiB,EAAE,MAAM,gBAAgB,CAAC;AAGnD,eAAO,MAAM,cAAc,SAAgB,GAAG,gBAAgB,YAAY,kBAMzE,CAAC;AAEF,eAAO,MAAM,oBAAoB,+BAG9B;IACD,YAAY,EAAE,YAAY,CAAC;IAC3B,OAAO,EAAE,MAAM,OAAO,iCAAiC,CAAC;CACzD,2BAKG,CAAC;AAEL,eAAO,MAAM,+BAA+B,uBAEzC;IACD,aAAa,EAAE,OAAO,CAAC;CACxB,kBAAwE,CAAC;AAI1E,wBAAgB,iBAAiB,IAAI,iBAAiB,CAKrD"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zoralabs/protocol-sdk",
-  "version": "0.11.2",
+  "version": "0.11.3-COMMENTS.1",
   "repository": "https://github.com/ourzora/zora-protocol",
   "license": "MIT",
   "type": "module",
@@ -17,7 +17,7 @@
   },
   "dependencies": {
     "abitype": "^1.0.2",
-    "@zoralabs/protocol-deployments": "^0.3.4"
+    "@zoralabs/protocol-deployments": "^0.3.5-COMMENTS.1"
   },
   "peerDependencies": {
     "viem": "^2.13.2"

package/src/comments/comments.test.ts

@@ -0,0 +1,223 @@
+import { describe, expect } from "vitest";
+import { forkUrls, makeAnvilTest, writeContractWithRetries } from "src/anvil";
+import { base, zoraSepolia } from "viem/chains";
+import {
+  commentsABI,
+  commentsAddress,
+  emptyCommentIdentifier,
+  PermitComment,
+  PermitSparkComment,
+  sparkValue,
+  CommentIdentifier,
+  permitSparkCommentTypedDataDefinition,
+} from "@zoralabs/protocol-deployments";
+import {
+  Address,
+  keccak256,
+  toBytes,
+  zeroAddress,
+  parseEther,
+  TransactionReceipt,
+  parseEventLogs,
+} from "viem";
+import { createCreatorClient } from "src/sdk";
+import { randomNewContract, waitForSuccess } from "src/test-utils";
+import { demoTokenMetadataURI } from "src/create/1155-create-helper.test";
+import { permitCommentTypedDataDefinition } from "@zoralabs/protocol-deployments";
+
+const getCommentIdentifierFromReceipt = (
+  receipt: TransactionReceipt,
+): CommentIdentifier => {
+  const logs = parseEventLogs({
+    abi: commentsABI,
+    logs: receipt.logs,
+    eventName: "Commented",
+  });
+
+  if (logs.length === 0) {
+    throw new Error("No Commented event found in receipt");
+  }
+
+  return logs[0]!.args.comment;
+};
+
+// todo: move this to protocol-deployments
+describe("comments", () => {
+  makeAnvilTest({
+    forkUrl: forkUrls.zoraSepolia,
+    forkBlockNumber: 14918747,
+    anvilChainId: zoraSepolia.id,
+  })(
+    "can sign and execute a cross-chain comment, and sign and execute a cross-chain spark comment",
+    async ({
+      viemClients: { publicClient, walletClient, chain, testClient },
+    }) => {
+      // Get the chain ID and set up addresses for different roles
+      const chainId = chain.id;
+      const [
+        collectorAddress,
+        creatorAddress,
+        executorAddress,
+        sparkerAddress,
+      ] = (await walletClient.getAddresses()!) as [
+        Address,
+        Address,
+        Address,
+        Address,
+      ];
+
+      // Create a creator client for interacting with the protocol
+      const creatorClient = createCreatorClient({
+        chainId,
+        publicClient,
+      });
+
+      // Step 1: Create a new 1155 contract and token
+      const { contractAddress, newTokenId, parameters, prepareMint } =
+        await creatorClient.create1155({
+          contract: randomNewContract(),
+          token: {
+            tokenMetadataURI: demoTokenMetadataURI,
+          },
+          account: creatorAddress,
+        });
+
+      // Deploy the new contract
+      const { request } = await publicClient.simulateContract(parameters);
+      await writeContractWithRetries({
+        request,
+        walletClient,
+        publicClient,
+      });
+
+      // Prepare to mint a token
+      const { parameters: collectParameters } = await prepareMint({
+        quantityToMint: 1n,
+        minterAccount: collectorAddress,
+      });
+
+      // Step 2: Mint an 1155 token on the new contract
+      const { request: mintRequest } =
+        await publicClient.simulateContract(collectParameters);
+      await writeContractWithRetries({
+        request: mintRequest,
+        walletClient,
+        publicClient,
+      });
+
+      // Set up cross-chain comment parameters
+      const sourceChainId = base.id; // The chain ID where the comment originates
+      const randomNonce = () =>
+        keccak256(toBytes(Math.round(Math.random() * 1000)));
+      const thirtySecondsFromNow =
+        BigInt(Math.round(new Date().getTime() / 1000)) + 30n;
+
+      // Step 3: Prepare a cross-chain comment
+      const permitComment: PermitComment = {
+        sourceChainId,
+        contractAddress,
+        destinationChainId: chainId,
+        tokenId: newTokenId,
+        commenter: collectorAddress,
+        text: "hello world",
+        deadline: thirtySecondsFromNow,
+        nonce: randomNonce(),
+        referrer: zeroAddress,
+        replyTo: emptyCommentIdentifier(),
+      };
+
+      // Generate typed data for signing
+      const typedData = permitCommentTypedDataDefinition(permitComment);
+
+      const commentsAddressForChainId =
+        commentsAddress[chainId as keyof typeof commentsAddress];
+
+      // Verify the typed data is correctly set up
+      expect(typedData.domain!.chainId).toEqual(sourceChainId);
+      expect(typedData.account).toEqual(collectorAddress);
+      expect(typedData.domain!.verifyingContract).toEqual(
+        commentsAddressForChainId,
+      );
+
+      // Ensure the commenter has enough balance for the spark value
+      await testClient.setBalance({
+        address: collectorAddress,
+        value: sparkValue(),
+      });
+
+      // Step 4: Sign the cross-chain comment
+      const signature = await walletClient.signTypedData(typedData);
+
+      // Ensure the executor has enough balance to execute the transaction
+      await testClient.setBalance({
+        address: executorAddress,
+        value: parseEther("1"),
+      });
+
+      // Step 5: Simulate and execute the cross-chain comment
+      const { request: commentRequest } = await publicClient.simulateContract({
+        abi: commentsABI,
+        address: commentsAddressForChainId,
+        functionName: "permitComment",
+        args: [permitComment, signature],
+        account: executorAddress,
+        value: sparkValue(),
+      });
+
+      const commentHash = await walletClient.writeContract(commentRequest);
+      const receipt = await publicClient.waitForTransactionReceipt({
+        hash: commentHash,
+      });
+
+      if (receipt.status !== "success") {
+        expect(receipt.status).toBe("success");
+      }
+
+      // Extract the comment identifier from the transaction receipt
+      const commentIdentifier = getCommentIdentifierFromReceipt(receipt);
+
+      // Step 6: Prepare a spark (like) for the comment
+      const sparkComment: PermitSparkComment = {
+        sparksQuantity: 3n,
+        sparker: sparkerAddress,
+        deadline: thirtySecondsFromNow,
+        nonce: randomNonce(),
+        referrer: zeroAddress,
+        sourceChainId,
+        destinationChainId: chainId,
+        comment: commentIdentifier,
+      };
+
+      const sparkTypedData =
+        permitSparkCommentTypedDataDefinition(sparkComment);
+
+      // Step 7: Sign the spark comment
+      const sparkSignature = await walletClient.signTypedData(sparkTypedData);
+
+      // Step 8: Simulate and execute the spark comment
+      const { request: sparkRequest } = await publicClient.simulateContract({
+        abi: commentsABI,
+        address: commentsAddressForChainId,
+        functionName: "permitSparkComment",
+        args: [sparkComment, sparkSignature],
+        account: executorAddress,
+        value: sparkValue() * sparkComment.sparksQuantity,
+      });
+
+      const sparkHash = await walletClient.writeContract(sparkRequest);
+
+      await waitForSuccess(sparkHash, publicClient);
+
+      // Step 9: Verify the spark count
+      const sparkCount = await publicClient.readContract({
+        abi: commentsABI,
+        address: commentsAddressForChainId,
+        functionName: "commentSparksQuantity",
+        args: [commentIdentifier],
+      });
+
+      expect(sparkCount).toEqual(sparkComment.sparksQuantity);
+    },
+    20_000,
+  );
+});

package/src/create/1155-create-helper.test.ts

@@ -5,6 +5,7 @@ import {
 } from "./1155-create-helper";
 import { createCreatorClient } from "src/sdk";
 import {
+  zoraCreator1155FactoryImplAddress,
   zoraCreator1155ImplABI,
   zoraTimedSaleStrategyABI,
   zoraTimedSaleStrategyAddress,
@@ -16,12 +17,12 @@ import { forkUrls, makeAnvilTest, writeContractWithRetries } from "src/anvil";
 import { zora } from "viem/chains";
 import { AllowList } from "src/allow-list/types";
 import { createAllowList } from "src/allow-list/allow-list-client";
-import { NewContractParams } from "./types";
 import { SubgraphContractGetter } from "./contract-getter";
 import {
   DEFAULT_MINIMUM_MARKET_ETH,
   DEFAULT_MARKET_COUNTDOWN,
 } from "./minter-defaults";
+import { randomNewContract } from "src/test-utils";
 
 export const demoTokenMetadataURI =
   "ipfs://bafkreice23maski3x52tsfqgxstx3kbiifnt5jotg3a5ynvve53c4soi2u";
@@ -56,13 +57,6 @@ const minterIsMinterOnToken = async ({
   });
 };
 
-function randomNewContract(): NewContractParams {
-  return {
-    name: `testContract-${Math.round(Math.random() * 1_000_000)}`,
-    uri: demoContractMetadataURI,
-  };
-}
-
 describe("create-helper", () => {
   anvilTest(
     "when no sales config is provided, it creates a new 1155 contract and token using the timed sale strategy",
@@ -101,7 +95,11 @@ describe("create-helper", () => {
         publicClient,
       });
       expect(receipt).not.toBeNull();
-      expect(receipt.to).to.equal("0x777777c338d93e2c7adf08d102d45ca7cc4ed021");
+      expect(receipt.to).to.equal(
+        zoraCreator1155FactoryImplAddress[
+          chain.id as keyof typeof zoraCreator1155FactoryImplAddress
+        ],
+      );
       expect(getTokenIdFromCreateReceipt(receipt)).to.be.equal(1n);
       expect(getContractAddressFromReceipt(receipt)).to.be.equal(
         contractAddress,
@@ -299,7 +297,11 @@ describe("create-helper", () => {
         walletClient,
         publicClient,
       });
-      expect(receipt.to).to.equal("0x777777c338d93e2c7adf08d102d45ca7cc4ed021");
+      expect(receipt.to).to.equal(
+        zoraCreator1155FactoryImplAddress[
+          chain.id as keyof typeof zoraCreator1155FactoryImplAddress
+        ],
+      );
       expect(getTokenIdFromCreateReceipt(receipt)).to.be.equal(newTokenId);
 
       expect(

package/src/rewards/rewards-client.test.ts

@@ -22,7 +22,7 @@ import { advanceToSaleAndAndLaunchMarket } from "src/secondary/secondary-client.
 
 describe("rewardsClient", () => {
   makeAnvilTest({
-    forkBlockNumber: 13914833,
+    forkBlockNumber: 14653556,
     forkUrl: forkUrls.zoraSepolia,
     anvilChainId: zoraSepolia.id,
   })(
@@ -117,7 +117,7 @@ describe("rewardsClient", () => {
     30_000,
   );
   makeAnvilTest({
-    forkBlockNumber: 13914833,
+    forkBlockNumber: 14653556,
     forkUrl: forkUrls.zoraSepolia,
     anvilChainId: zoraSepolia.id,
   })(

package/src/secondary/secondary-client.test.ts

@@ -80,7 +80,7 @@ export async function advanceToSaleAndAndLaunchMarket({
 
 describe("secondary", () => {
   makeAnvilTest({
-    forkBlockNumber: 13914833,
+    forkBlockNumber: 14653556,
     forkUrl: forkUrls.zoraSepolia,
     anvilChainId: zoraSepolia.id,
   })(
@@ -128,7 +128,7 @@ describe("secondary", () => {
   );
 
   makeAnvilTest({
-    forkBlockNumber: 13914833,
+    forkBlockNumber: 14653556,
     forkUrl: forkUrls.zoraSepolia,
     anvilChainId: zoraSepolia.id,
   })(
@@ -199,6 +199,13 @@ describe("secondary", () => {
         account: collectorAccount,
       });
 
+      const balanceBefore = await publicClient.readContract({
+        abi: zoraCreator1155ImplABI,
+        address: contractAddress,
+        functionName: "balanceOf",
+        args: [collectorAccount, newTokenId],
+      });
+
       // now get the price ot buy on secondary
       const quantityToBuy = 1000n;
 
@@ -236,7 +243,7 @@ describe("secondary", () => {
         args: [collectorAccount, newTokenId],
       });
 
-      expect(balance).toBe(quantityToBuy + quantityToMint);
+      expect(balance - balanceBefore).toBe(quantityToBuy);
 
       // now sell 10_000n tokens
       const quantityToSell = 10_000n;

package/src/test-utils.ts

@@ -9,6 +9,7 @@ import {
   encodeAbiParameters,
   parseAbiParameters,
 } from "viem";
+import { NewContractParams } from "./create/types";
 import { expect } from "vitest";
 
 export const waitForSuccess = async (hash: Hex, publicClient: PublicClient) => {
@@ -37,3 +38,12 @@ export const fixedPriceMinterMinterArguments = ({
 }: {
   mintRecipient: Address;
 }) => encodeAbiParameters(parseAbiParameters("address"), [mintRecipient]);
+
+const demoContractMetadataURI = "ipfs://DUMMY/contract.json";
+
+export function randomNewContract(): NewContractParams {
+  return {
+    name: `testContract-${Math.round(Math.random() * 1_000_000)}`,
+    uri: demoContractMetadataURI,
+  };
+}