@zoralabs/limit-orders 0.2.4 → 0.2.6

package/out/build-info/{68b2e124c4a02a45.json → b6efea4394bdeb7d.json}

@@ -1 +1 @@
-{"id":"68b2e124c4a02a45","source_id_to_path":{"0":"node_modules/@openzeppelin/contracts/access/Ownable.sol","1":"node_modules/@openzeppelin/contracts/access/Ownable2Step.sol","2":"node_modules/@openzeppelin/contracts/interfaces/IERC1363.sol","3":"node_modules/@openzeppelin/contracts/interfaces/IERC165.sol","4":"node_modules/@openzeppelin/contracts/interfaces/IERC20.sol","5":"node_modules/@openzeppelin/contracts/token/ERC20/IERC20.sol","6":"node_modules/@openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol","7":"node_modules/@openzeppelin/contracts/utils/Context.sol","8":"node_modules/@openzeppelin/contracts/utils/TransientSlot.sol","9":"node_modules/@openzeppelin/contracts/utils/introspection/IERC165.sol","10":"node_modules/@uniswap/permit2/src/interfaces/IAllowanceTransfer.sol","11":"node_modules/@uniswap/permit2/src/interfaces/IEIP712.sol","12":"node_modules/@uniswap/permit2/src/libraries/SafeCast160.sol","13":"node_modules/@uniswap/v4-core/src/interfaces/IExtsload.sol","14":"node_modules/@uniswap/v4-core/src/interfaces/IExttload.sol","15":"node_modules/@uniswap/v4-core/src/interfaces/IHooks.sol","16":"node_modules/@uniswap/v4-core/src/interfaces/IPoolManager.sol","17":"node_modules/@uniswap/v4-core/src/interfaces/IProtocolFees.sol","18":"node_modules/@uniswap/v4-core/src/interfaces/external/IERC20Minimal.sol","19":"node_modules/@uniswap/v4-core/src/interfaces/external/IERC6909Claims.sol","20":"node_modules/@uniswap/v4-core/src/libraries/BitMath.sol","21":"node_modules/@uniswap/v4-core/src/libraries/CurrencyReserves.sol","22":"node_modules/@uniswap/v4-core/src/libraries/CustomRevert.sol","23":"node_modules/@uniswap/v4-core/src/libraries/FixedPoint128.sol","24":"node_modules/@uniswap/v4-core/src/libraries/FullMath.sol","25":"node_modules/@uniswap/v4-core/src/libraries/LiquidityMath.sol","26":"node_modules/@uniswap/v4-core/src/libraries/Lock.sol","27":"node_modules/@uniswap/v4-core/src/libraries/NonzeroDeltaCount.sol","28":"node_modules/@uniswap/v4-core/src/libraries/Position.sol","29":"node_modules/@uniswap/v4-core/src/libraries/SafeCast.sol","30":"node_modules/@uniswap/v4-core/src/libraries/StateLibrary.sol","31":"node_modules/@uniswap/v4-core/src/libraries/TickBitmap.sol","32":"node_modules/@uniswap/v4-core/src/libraries/TickMath.sol","33":"node_modules/@uniswap/v4-core/src/libraries/TransientStateLibrary.sol","34":"node_modules/@uniswap/v4-core/src/types/BalanceDelta.sol","35":"node_modules/@uniswap/v4-core/src/types/BeforeSwapDelta.sol","36":"node_modules/@uniswap/v4-core/src/types/Currency.sol","37":"node_modules/@uniswap/v4-core/src/types/PoolId.sol","38":"node_modules/@uniswap/v4-core/src/types/PoolKey.sol","39":"node_modules/@uniswap/v4-core/src/types/PoolOperation.sol","40":"node_modules/@uniswap/v4-periphery/src/libraries/PathKey.sol","41":"node_modules/@zoralabs/coins/src/interfaces/ICoin.sol","42":"node_modules/@zoralabs/coins/src/interfaces/IDeployedCoinVersionLookup.sol","43":"node_modules/@zoralabs/coins/src/interfaces/IDopplerErrors.sol","44":"node_modules/@zoralabs/coins/src/interfaces/IERC7572.sol","45":"node_modules/@zoralabs/coins/src/interfaces/IHasRewardsRecipients.sol","46":"node_modules/@zoralabs/coins/src/interfaces/IMsgSender.sol","47":"node_modules/@zoralabs/coins/src/interfaces/ISupportsLimitOrderFill.sol","48":"node_modules/@zoralabs/coins/src/interfaces/ISwapPathRouter.sol","49":"node_modules/@zoralabs/coins/src/interfaces/ISwapRouter.sol","50":"node_modules/@zoralabs/coins/src/interfaces/IUpgradeableV4Hook.sol","51":"node_modules/@zoralabs/coins/src/interfaces/IWETH.sol","52":"node_modules/@zoralabs/coins/src/interfaces/IZoraHookRegistry.sol","53":"node_modules/@zoralabs/coins/src/interfaces/IZoraLimitOrderBookCoinsInterface.sol","54":"node_modules/@zoralabs/coins/src/interfaces/IZoraV4CoinHook.sol","55":"node_modules/@zoralabs/coins/src/libs/CoinCommon.sol","56":"node_modules/@zoralabs/coins/src/libs/CoinConfigurationVersions.sol","57":"node_modules/@zoralabs/coins/src/libs/CoinConstants.sol","58":"node_modules/@zoralabs/coins/src/libs/DopplerMath.sol","59":"node_modules/@zoralabs/coins/src/libs/UniV4SwapToCurrency.sol","60":"node_modules/@zoralabs/coins/src/libs/V3ToV4SwapLib.sol","61":"node_modules/@zoralabs/coins/src/types/LpPosition.sol","62":"node_modules/@zoralabs/coins/src/types/PoolConfiguration.sol","63":"node_modules/@zoralabs/coins/src/utils/uniswap/BitMath.sol","64":"node_modules/@zoralabs/coins/src/utils/uniswap/CustomRevert.sol","65":"node_modules/@zoralabs/coins/src/utils/uniswap/FixedPoint96.sol","66":"node_modules/@zoralabs/coins/src/utils/uniswap/FullMath.sol","67":"node_modules/@zoralabs/coins/src/utils/uniswap/LiquidityAmounts.sol","68":"node_modules/@zoralabs/coins/src/utils/uniswap/SafeCast.sol","69":"node_modules/@zoralabs/coins/src/utils/uniswap/SqrtPriceMath.sol","70":"node_modules/@zoralabs/coins/src/utils/uniswap/TickMath.sol","71":"node_modules/@zoralabs/coins/src/utils/uniswap/UnsafeMath.sol","72":"node_modules/@zoralabs/shared-contracts/src/interfaces/uniswap/ISwapRouter.sol","73":"node_modules/@zoralabs/shared-contracts/src/interfaces/uniswap/IUniswapV3SwapCallback.sol","74":"node_modules/@zoralabs/shared-contracts/src/libs/UniswapV3/BytesLib.sol","75":"node_modules/@zoralabs/shared-contracts/src/libs/UniswapV3/Path.sol","76":"src/IZoraLimitOrderBook.sol","77":"src/ZoraLimitOrderBook.sol","78":"src/access/PermittedCallers.sol","79":"src/libs/LimitOrderBitmap.sol","80":"src/libs/LimitOrderCommon.sol","81":"src/libs/LimitOrderCreate.sol","82":"src/libs/LimitOrderFill.sol","83":"src/libs/LimitOrderLiquidity.sol","84":"src/libs/LimitOrderQueues.sol","85":"src/libs/LimitOrderStorage.sol","86":"src/libs/LimitOrderTypes.sol","87":"src/libs/LimitOrderViews.sol","88":"src/libs/LimitOrderWithdraw.sol","89":"src/libs/Permit2Payments.sol","90":"src/libs/SwapLimitOrders.sol","91":"src/router/ISetLimitOrderConfig.sol","92":"src/router/SwapWithLimitOrders.sol"},"language":"Solidity"}
+{"id":"b6efea4394bdeb7d","source_id_to_path":{"0":"node_modules/@openzeppelin/contracts/access/Ownable.sol","1":"node_modules/@openzeppelin/contracts/access/Ownable2Step.sol","2":"node_modules/@openzeppelin/contracts/interfaces/IERC1363.sol","3":"node_modules/@openzeppelin/contracts/interfaces/IERC165.sol","4":"node_modules/@openzeppelin/contracts/interfaces/IERC20.sol","5":"node_modules/@openzeppelin/contracts/token/ERC20/IERC20.sol","6":"node_modules/@openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol","7":"node_modules/@openzeppelin/contracts/utils/Context.sol","8":"node_modules/@openzeppelin/contracts/utils/TransientSlot.sol","9":"node_modules/@openzeppelin/contracts/utils/introspection/IERC165.sol","10":"node_modules/@uniswap/permit2/src/interfaces/IAllowanceTransfer.sol","11":"node_modules/@uniswap/permit2/src/interfaces/IEIP712.sol","12":"node_modules/@uniswap/permit2/src/libraries/SafeCast160.sol","13":"node_modules/@uniswap/v4-core/src/interfaces/IExtsload.sol","14":"node_modules/@uniswap/v4-core/src/interfaces/IExttload.sol","15":"node_modules/@uniswap/v4-core/src/interfaces/IHooks.sol","16":"node_modules/@uniswap/v4-core/src/interfaces/IPoolManager.sol","17":"node_modules/@uniswap/v4-core/src/interfaces/IProtocolFees.sol","18":"node_modules/@uniswap/v4-core/src/interfaces/external/IERC20Minimal.sol","19":"node_modules/@uniswap/v4-core/src/interfaces/external/IERC6909Claims.sol","20":"node_modules/@uniswap/v4-core/src/libraries/BitMath.sol","21":"node_modules/@uniswap/v4-core/src/libraries/CurrencyReserves.sol","22":"node_modules/@uniswap/v4-core/src/libraries/CustomRevert.sol","23":"node_modules/@uniswap/v4-core/src/libraries/FixedPoint128.sol","24":"node_modules/@uniswap/v4-core/src/libraries/FullMath.sol","25":"node_modules/@uniswap/v4-core/src/libraries/LiquidityMath.sol","26":"node_modules/@uniswap/v4-core/src/libraries/Lock.sol","27":"node_modules/@uniswap/v4-core/src/libraries/NonzeroDeltaCount.sol","28":"node_modules/@uniswap/v4-core/src/libraries/Position.sol","29":"node_modules/@uniswap/v4-core/src/libraries/SafeCast.sol","30":"node_modules/@uniswap/v4-core/src/libraries/StateLibrary.sol","31":"node_modules/@uniswap/v4-core/src/libraries/TickBitmap.sol","32":"node_modules/@uniswap/v4-core/src/libraries/TickMath.sol","33":"node_modules/@uniswap/v4-core/src/libraries/TransientStateLibrary.sol","34":"node_modules/@uniswap/v4-core/src/types/BalanceDelta.sol","35":"node_modules/@uniswap/v4-core/src/types/BeforeSwapDelta.sol","36":"node_modules/@uniswap/v4-core/src/types/Currency.sol","37":"node_modules/@uniswap/v4-core/src/types/PoolId.sol","38":"node_modules/@uniswap/v4-core/src/types/PoolKey.sol","39":"node_modules/@uniswap/v4-core/src/types/PoolOperation.sol","40":"node_modules/@uniswap/v4-periphery/src/libraries/PathKey.sol","41":"node_modules/@zoralabs/coins/src/interfaces/ICoin.sol","42":"node_modules/@zoralabs/coins/src/interfaces/IDeployedCoinVersionLookup.sol","43":"node_modules/@zoralabs/coins/src/interfaces/IDopplerErrors.sol","44":"node_modules/@zoralabs/coins/src/interfaces/IERC7572.sol","45":"node_modules/@zoralabs/coins/src/interfaces/IHasRewardsRecipients.sol","46":"node_modules/@zoralabs/coins/src/interfaces/IMsgSender.sol","47":"node_modules/@zoralabs/coins/src/interfaces/ISupportsLimitOrderFill.sol","48":"node_modules/@zoralabs/coins/src/interfaces/ISwapPathRouter.sol","49":"node_modules/@zoralabs/coins/src/interfaces/ISwapRouter.sol","50":"node_modules/@zoralabs/coins/src/interfaces/IUpgradeableV4Hook.sol","51":"node_modules/@zoralabs/coins/src/interfaces/IWETH.sol","52":"node_modules/@zoralabs/coins/src/interfaces/IZoraHookRegistry.sol","53":"node_modules/@zoralabs/coins/src/interfaces/IZoraLimitOrderBookCoinsInterface.sol","54":"node_modules/@zoralabs/coins/src/interfaces/IZoraV4CoinHook.sol","55":"node_modules/@zoralabs/coins/src/libs/CoinCommon.sol","56":"node_modules/@zoralabs/coins/src/libs/CoinConfigurationVersions.sol","57":"node_modules/@zoralabs/coins/src/libs/CoinConstants.sol","58":"node_modules/@zoralabs/coins/src/libs/DopplerMath.sol","59":"node_modules/@zoralabs/coins/src/libs/UniV4SwapToCurrency.sol","60":"node_modules/@zoralabs/coins/src/libs/V3ToV4SwapLib.sol","61":"node_modules/@zoralabs/coins/src/types/LpPosition.sol","62":"node_modules/@zoralabs/coins/src/types/PoolConfiguration.sol","63":"node_modules/@zoralabs/coins/src/utils/uniswap/BitMath.sol","64":"node_modules/@zoralabs/coins/src/utils/uniswap/CustomRevert.sol","65":"node_modules/@zoralabs/coins/src/utils/uniswap/FixedPoint96.sol","66":"node_modules/@zoralabs/coins/src/utils/uniswap/FullMath.sol","67":"node_modules/@zoralabs/coins/src/utils/uniswap/LiquidityAmounts.sol","68":"node_modules/@zoralabs/coins/src/utils/uniswap/SafeCast.sol","69":"node_modules/@zoralabs/coins/src/utils/uniswap/SqrtPriceMath.sol","70":"node_modules/@zoralabs/coins/src/utils/uniswap/TickMath.sol","71":"node_modules/@zoralabs/coins/src/utils/uniswap/UnsafeMath.sol","72":"node_modules/@zoralabs/shared-contracts/src/interfaces/IVersionedContract.sol","73":"node_modules/@zoralabs/shared-contracts/src/interfaces/uniswap/ISwapRouter.sol","74":"node_modules/@zoralabs/shared-contracts/src/interfaces/uniswap/IUniswapV3SwapCallback.sol","75":"node_modules/@zoralabs/shared-contracts/src/libs/UniswapV3/BytesLib.sol","76":"node_modules/@zoralabs/shared-contracts/src/libs/UniswapV3/Path.sol","77":"src/IZoraLimitOrderBook.sol","78":"src/ZoraLimitOrderBook.sol","79":"src/access/PermittedCallers.sol","80":"src/libs/LimitOrderBitmap.sol","81":"src/libs/LimitOrderCommon.sol","82":"src/libs/LimitOrderCreate.sol","83":"src/libs/LimitOrderFill.sol","84":"src/libs/LimitOrderLiquidity.sol","85":"src/libs/LimitOrderQueues.sol","86":"src/libs/LimitOrderStorage.sol","87":"src/libs/LimitOrderTypes.sol","88":"src/libs/LimitOrderViews.sol","89":"src/libs/LimitOrderWithdraw.sol","90":"src/libs/Permit2Payments.sol","91":"src/libs/SwapLimitOrders.sol","92":"src/router/SwapWithLimitOrders.sol","93":"src/version/ContractVersionBase.sol"},"language":"Solidity"}

package/package/wagmiGenerated.ts

@@ -66,6 +66,13 @@ export const swapWithLimitOrdersABI = [
     outputs: [],
     stateMutability: 'nonpayable',
   },
+  {
+    type: 'function',
+    inputs: [],
+    name: 'contractVersion',
+    outputs: [{ name: '', internalType: 'string', type: 'string' }],
+    stateMutability: 'pure',
+  },
   {
     type: 'function',
     inputs: [],
@@ -431,6 +438,13 @@ export const zoraLimitOrderBookABI = [
     outputs: [{ name: '', internalType: 'uint256', type: 'uint256' }],
     stateMutability: 'view',
   },
+  {
+    type: 'function',
+    inputs: [],
+    name: 'contractVersion',
+    outputs: [{ name: '', internalType: 'string', type: 'string' }],
+    stateMutability: 'pure',
+  },
   {
     type: 'function',
     inputs: [

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zoralabs/limit-orders",
-  "version": "0.2.4",
+  "version": "0.2.6",
   "type": "module",
   "main": "./dist/index.cjs",
   "module": "./dist/index.js",
@@ -34,7 +34,7 @@
     "tsup": "^7.2.0",
     "tsx": "^3.13.0",
     "typescript": "^5.2.2",
-    "viem": "^2.21.18",
+    "viem": "2.22.12",
     "@zoralabs/shared-contracts": "^0.0.5",
     "@zoralabs/shared-scripts": "^0.0.0",
     "@zoralabs/coins": "^2.5.0",

package/src/ZoraLimitOrderBook.sol

@@ -21,8 +21,9 @@ import {LimitOrderWithdraw} from "./libs/LimitOrderWithdraw.sol";
 import {LimitOrderViews} from "./libs/LimitOrderViews.sol";
 import {LimitOrderTypes} from "./libs/LimitOrderTypes.sol";
 import {PermittedCallers} from "./access/PermittedCallers.sol";
+import {ContractVersionBase} from "./version/ContractVersionBase.sol";
 
-contract ZoraLimitOrderBook is IZoraLimitOrderBook, PermittedCallers {
+contract ZoraLimitOrderBook is IZoraLimitOrderBook, ContractVersionBase, PermittedCallers {
     IPoolManager public immutable poolManager;
     IDeployedCoinVersionLookup public immutable zoraCoinVersionLookup;
     IZoraHookRegistry public immutable zoraHookRegistry;
@@ -38,6 +39,8 @@ contract ZoraLimitOrderBook is IZoraLimitOrderBook, PermittedCallers {
         zoraCoinVersionLookup = IDeployedCoinVersionLookup(zoraCoinVersionLookup_);
         zoraHookRegistry = IZoraHookRegistry(zoraHookRegistry_);
         weth = weth_;
+
+        LimitOrderStorage.layout().maxFillCount = 50;
     }
 
     /// @inheritdoc IZoraLimitOrderBook

package/src/router/SwapWithLimitOrders.sol

@@ -18,7 +18,6 @@ import {IERC20} from "@openzeppelin/contracts/token/ERC20/IERC20.sol";
 
 import {IZoraLimitOrderBook} from "../IZoraLimitOrderBook.sol";
 import {SwapLimitOrders, LimitOrderConfig, Orders} from "../libs/SwapLimitOrders.sol";
-import {ISetLimitOrderConfig} from "./ISetLimitOrderConfig.sol";
 import {ISwapRouter} from "@zoralabs/shared-contracts/interfaces/uniswap/ISwapRouter.sol";
 import {ISupportsLimitOrderFill} from "@zoralabs/coins/src/interfaces/ISupportsLimitOrderFill.sol";
 import {IMsgSender} from "@zoralabs/coins/src/interfaces/IMsgSender.sol";
@@ -29,6 +28,7 @@ import {V3ToV4SwapLib} from "@zoralabs/coins/src/libs/V3ToV4SwapLib.sol";
 import {Ownable} from "@openzeppelin/contracts/access/Ownable.sol";
 import {Ownable2Step} from "@openzeppelin/contracts/access/Ownable2Step.sol";
 import {IAllowanceTransfer} from "permit2/src/interfaces/IAllowanceTransfer.sol";
+import {ContractVersionBase} from "../version/ContractVersionBase.sol";
 
 /// @title SwapWithLimitOrders
 /// @notice Standalone router contract that executes swaps with automatic limit order placement and filling.
@@ -37,7 +37,7 @@ import {IAllowanceTransfer} from "permit2/src/interfaces/IAllowanceTransfer.sol"
 ///      Users call swapWithLimitOrders() directly, which triggers the unlock callback flow.
 ///      Uses Permit2 for token approvals, matching the universal-router pattern.
 /// @author oveddan
-contract SwapWithLimitOrders is ISetLimitOrderConfig, Ownable2Step, IMsgSender {
+contract SwapWithLimitOrders is ContractVersionBase, Ownable2Step, IMsgSender {
     using SafeERC20 for IERC20;
     using BalanceDeltaLibrary for BalanceDelta;
     using CurrencyLibrary for Currency;

package/src/version/ContractVersionBase.sol

@@ -0,0 +1,14 @@
+// This file is automatically generated by code; do not manually update
+// SPDX-License-Identifier: MIT
+pragma solidity ^0.8.23;
+
+import {IVersionedContract} from "@zoralabs/shared-contracts/interfaces/IVersionedContract.sol";
+
+/// @title ContractVersionBase
+/// @notice Base contract for versioning contracts
+contract ContractVersionBase is IVersionedContract {
+    /// @notice The version of the contract
+    function contractVersion() external pure override returns (string memory) {
+        return "0.2.6";
+    }
+}

package/test/LimitOrderAccessControl.t.sol

@@ -332,9 +332,15 @@ contract LimitOrderAccessControlTest is BaseTest {
         payable(address(limitOrderBook)).transfer(1 wei);
     }
 
+    // Test: maxFillCount defaults to 50 after construction
+    function test_maxFillCount_defaultsTo50() public {
+        // Max fill count should be initialized to 50 in constructor
+        assertEq(limitOrderBook.getMaxFillCount(), 50);
+    }
+
     // Test: setMaxFillCount - owner can set
     function test_setMaxFillCount_ownerCanSet() public {
-        // Initially max fill count should be 50 (set in BaseTest)
+        // Initially max fill count should be 50 (set in constructor)
         assertEq(limitOrderBook.getMaxFillCount(), 50);
 
         // Owner (this contract) should be able to set it
@@ -350,7 +356,7 @@ contract LimitOrderAccessControlTest is BaseTest {
         vm.expectRevert(abi.encodeWithSelector(Ownable.OwnableUnauthorizedAccount.selector, unauthorizedUser));
         limitOrderBook.setMaxFillCount(20);
 
-        // Verify value hasn't changed (still 50 from BaseTest)
+        // Verify value hasn't changed (still 50 from constructor)
         assertEq(limitOrderBook.getMaxFillCount(), 50);
     }
 

package/AUDIT_RFP.md

@@ -1,408 +0,0 @@
-# Zora Protocol Limit Orders (aka "Autosell") - Audit Scope Document
-
-**Version**: 1.2
-**Date**: 2025-12-12
-**Branch**: `autosell`
-**Purpose**: Audit scope and technical reference for engaged auditors
-
----
-
-## Executive Summary
-
-Zora has implemented a limit orders system that enables users to create onchain
-orders that automatically execute when Uniswap V4 pool prices reach
-predetermined ticks. This document provides complete scope, technical analysis,
-and security considerations for the audit engagement.
-
-**Scope**: ~2,758 lines of Solidity across 16 new files
-**Focus Areas**: Linked list integrity, epoch-based execution isolation, bitmap optimization, access control
-**Ideal Auditor Profile**: Strong familiarity with DeFi protocols and Uniswap V4 architecture (liquidity positions, hook patterns, unlock callbacks, transient storage)
-
----
-
-## Technical Architecture Reference
-
-**Supporting docs**
-
-- [`README.md`](./README.md) — architecture, diagrams, execution paths
-- [`SPEC.md`](./SPEC.md) — normative behavior and invariants (“what must be true”)
-- [`AUDIT_NOTES.md`](./AUDIT_NOTES.md) — threat model + audit checklist
-
-This RFP focuses on audit scope, security considerations, and deliverables.
-
----
-
-## Quick Navigation
-
-### Part 1: Audit Scope & Process
-
-- [Audit Scope](#part-1-audit-scope) - What's in/out of scope
-- [Areas of Technical Complexity](#areas-of-technical-complexity) - Implementation details
-- [Audit Deliverables](#audit-deliverables)
-- [Timeline & Process](#timeline-and-process)
-- [Clarifications Needed](#clarifications-needed)
-
-### Part 2: Technical Implementation
-
-- [File Structure](#file-structure) - All 15 files documented
-- [Data Structures](#data-structures) - LimitOrder, Queue, Order IDs
-- [Storage Organization](#storage-organization) - Storage layout
-- [External Functions](#external-functions) - create, fill, withdraw
-
-### Part 3: Additional Information
-
-- [Known Limitations](#known-limitations)
-
----
-
-# PART 1: AUDIT SCOPE
-
-## Overview
-
-_For detailed architecture, see [README: Overview](./README.md#1-overview) and [Limit Orders Architecture](./README.md#3-limit-orders-architecture-overview)_
-
-The limit orders system allows users to:
-
-1. **Create orders** by adding Uniswap V4 liquidity positions across a one-tick-spacing range
-2. **Fill orders** automatically when pool price crosses into the order's range
-3. **Withdraw orders** by cancelling specific orders by ID and withdrawing the resulting funds to a recipient.
-   - The call cancels orders in the order provided until `minAmountOut` is reached (or cancels all provided orders if `minAmountOut == 0`).
-   - Cancellation is whole-order only (no proportional/partial cancellation).
-
-**Key Innovation**: Implements limit orders as single-sided Uniswap V4 liquidity positions, providing a completely native onchain approach that keeps liquidity in the pools for improved trading. Uses linked list queues, bitmap optimization, and epoch-based execution isolation for efficient order matching.
-
-## In-Scope Contracts
-
-### Primary Package: `packages/limit-orders/src/`
-
-#### Core Contracts (2 files, ~418 LOC)
-
-**ZoraLimitOrderBook.sol** (229 lines)
-
-- Main contract implementing the order book
-- Manages pool manager unlock/callback patterns
-- Delegates to library contracts for execution
-- Access control via SimpleAccessManaged
-
-**IZoraLimitOrderBook.sol** (189 lines)
-
-- Public API interface and event definitions
-- 3 callback types: CREATE, FILL, WITHDRAW_ORDERS
-- 21 error types for validation
-- Data structure definitions for callbacks
-
-#### Access Control (2 files, ~345 LOC)
-
-**access/SimpleAccessManaged.sol** (76 lines)
-
-- Lightweight fork of OpenZeppelin's [AccessManaged](https://docs.openzeppelin.com/contracts/5.x/api/access#AccessManaged) contract, reduced in complexity to minimize code size
-- Uses the same security architecture (authority-based permissions via `IAuthority.canCall()`)
-- Removes time-based permissions methodology (no delays, no scheduled operations)
-- Controls `create()` and `setMaxFillCount()` functions
-
-**access/SimpleAccessManager.sol** (268 lines)
-
-- Full role-based access manager implementation
-- Provides complete `IAuthority` interface implementation
-- Supports role-based permissions with admin delegation
-- `PUBLIC_ROLE` support for unrestricted functions
-- Function selector mapping to specific roles
-
-#### Type Definitions & Storage (2 files, ~79 LOC)
-
-**LimitOrderTypes.sol** (44 lines)
-
-- OrderStatus enum: INACTIVE, OPEN, FILLED
-- LimitOrder struct (224 bytes / 7 storage slots with linked list pointers)
-- Queue struct (96 bytes / 3 storage slots with head/tail/length/balance)
-
-**LimitOrderStorage.sol** (35 lines)
-
-- Storage slot derived from `keccak256("zora.limit.order.book.storage")`
-- Storage slot: `0x98b43bb10ca7bc310641b07883d9e14c04b3983640df6b07dd1c99d10a3c6cec`
-- Layout with 6 mappings for orders, queues, epochs, bitmaps, nonces, and maker balances
-
-#### Order Lifecycle Libraries (3 files, ~722 LOC)
-
-**LimitOrderCreate.sol** (277 lines)
-
-- Order creation with validation
-- Calls `poolManager.modifyLiquidity()` with positive `liquidityDelta` to add liquidity
-- Manages callback data and execution
-- Handles residual amount refunds
-- Implementation details: Input validation, liquidity calculations, nonce management
-
-**LimitOrderFill.sol** (345 lines)
-
-- Core fill execution logic
-- Epoch-based execution isolation mechanism
-- Two fill modes: tick range-based and order ID-based
-- Bitmap-based tick iteration optimization
-- Assembly optimizations in tight loops
-- Implementation details: Epoch checks, bitmap manipulation, linked list traversal
-
-**LimitOrderWithdraw.sol** (100 lines)
-
-- Cancellation and withdrawal logic
-- Order-specific withdrawal (cancels provided order ids sequentially until `minAmountOut` is reached)
-- Burns liquidity and issues refunds
-- Implementation details: Owner validation, balance accounting, liquidity burning
-
-#### Support Libraries (6 files, ~648 LOC)
-
-**LimitOrderCommon.sol** (91 lines)
-
-- Order metadata extraction helpers
-- Records orders in queues and bitmaps
-- Removes orders from queues and bitmaps
-- Tick determination logic
-
-**LimitOrderQueues.sol** (101 lines)
-
-- Linked list implementation
-- Single tick queue system
-- Operations: enqueue, unlink, clearLinks
-- Direct storage slot manipulation for gas optimization
-- Implementation details: Linked list integrity, concurrent modifications
-
-**LimitOrderBitmap.sol** (84 lines)
-
-- Bitmap management for tick activation tracking
-- Sets/clears bits when ticks become active/inactive
-- `getExecutableTicks()` for efficient range queries
-- Implementation details: Bit manipulation correctness, boundary conditions
-
-**LimitOrderLiquidity.sol** (222 lines)
-
-- Uniswap V4 liquidity management
-- Helper functions for adding liquidity during order creation (`_mintLiquidity()`)
-- Removes liquidity during fills/cancels (`burnAndPayout()`, `burnAndRefund()`)
-- Handles fee distribution and swap paths
-- Supports alternative payout currencies
-- Implementation details: Liquidity calculations, fee distribution, swap execution
-
-**SwapLimitOrders.sol** (209 lines)
-
-- Configuration for automatic order creation post-swap
-- Validates multiples and percentages
-- Computes order ladders from price multiples
-- Square root math for price alignment
-
-**Permit2Payments.sol** (41 lines)
-
-- Abstract contract for Permit2 token transfers
-- Based on Uniswap's universal-router module
-- Enables gasless token approvals
-
-#### Router Contract (1 file, ~454 LOC)
-
-_See [README: SwapWithLimitOrders Router](./README.md#2-swapwithlimitorders-router) for detailed architecture_
-
-**router/SwapWithLimitOrders.sol** (454 lines)
-
-- Standalone router for combined operations
-- Executes V3→V4 swaps + order creation + fills
-- Implements pool manager callback pattern
-- Attempts to fill orders if price crosses
-
-### Integration Points: `packages/coins/src/`
-
-_For Zora Coins platform architecture, see [README: Coins Platform Architecture](./README.md#2-coins-platform-architecture)_
-
-#### Modified Hook Contract
-
-**hooks/ZoraV4CoinHook.sol** (modifications only)
-
-- Integration point for automatic limit order fills during swaps
-- Calls `limitOrderBook.fill()` in `afterSwap` hook
-- Passes fill referral information
-
-**Related Support Libraries**:
-
-- `libs/V3ToV4SwapLib.sol` - V3 migration support
-- `libs/CoinRewardsV4.sol` - Reward distribution
-
-## Out-of-Scope
-
-### Explicitly Excluded
-
-**Deployment Scripts**:
-
-- `packages/coins/src/deployment/CoinsDeployerBase.sol`
-- All files in `script/` directories across all packages
-- All deployment infrastructure and tooling
-
-**Test Files**:
-
-- All files in `test/` directories (except as behavioral reference)
-- Test utilities and mocks
-
-**Legacy Code**:
-
-- `legacy/` directory contents
-- Deprecated contracts from previous versions
-
-**Documentation & Tooling**:
-
-- `docs/` and `nft-docs/` directories
-- Build scripts and configuration files
-- SDK packages (`coins-sdk`, `protocol-deployments`)
-
-**External Dependencies** (auditing the dependencies themselves is out of scope, but integration risks are a key focus):
-
-- Uniswap V4 core contracts (`@uniswap/v4-core`) - **Integration analysis is critical**: how we interact with pool manager, liquidity operations, unlock callbacks, and balance settlements
-- OpenZeppelin contracts (`@openzeppelin/contracts`) - Used for IAuthority, IERC20, SafeERC20, TransientSlot
-
-**Critical Integration Patterns to Audit**:
-
-We are particularly interested in identifying risks in how our code interacts with Uniswap V4:
-
-- **Unlock callback patterns**: nested unlock handling when orders are created during fills (see `LimitOrderCreate.sol:44`), potential reentrancy through callbacks, unlock state verification
-- **Liquidity position management**: salt-based position isolation using orderIds as salts (see `LimitOrderCreate.sol:200`, `LimitOrderLiquidity.sol:64`), tick range calculations, liquidity delta correctness
-- **Balance accounting**: settle/take/sync patterns (see `LimitOrderLiquidity.sol`), currency delta tracking via `TransientStateLibrary.currencyDelta`, ETH vs ERC20 handling
-- **Transient storage usage**: `isUnlocked` checks for access control (see `ZoraLimitOrderBook.sol:90`), currency delta reading for settlement verification
-- **Position lifecycle**: `modifyLiquidity` calls with positive delta (mint) and negative delta (burn), fee accumulation via `feesDelta` and distribution to makers/referrals
-
-## Areas of Technical Complexity
-
-**Linked List Implementation** ([`LimitOrderQueues.sol`](src/libs/LimitOrderQueues.sol), [`LimitOrderCommon.sol`](src/libs/LimitOrderCommon.sol)) - See [README: Tick Queue System](./README.md#tick-queue-system): Tick-based linked lists enable O(1) insertion/removal when order ID is known. Orders are indexed by `(poolKeyHash, coin, tick)` for efficient fill operations.
-
-**Epoch-Based Execution Isolation** ([`LimitOrderFill.sol`](src/libs/LimitOrderFill.sol), [`LimitOrderStorage.sol`](src/libs/LimitOrderStorage.sol)) - See [README: Epoch-Based Protection](./README.md#epoch-based-protection): Orders cannot be filled in the same epoch they were created. Each pool maintains an independent epoch counter (uint256) that increments at the start of each fill. Orders store uint32 createdEpoch and are skipped if `createdEpoch >= currentEpoch`. This ensures orders created during fill execution wait for the next fill operation.
-
-**Bitmap Optimization** ([`LimitOrderBitmap.sol`](src/libs/LimitOrderBitmap.sol), [`LimitOrderCommon.sol`](src/libs/LimitOrderCommon.sol)) - See [README: Tick Discovery](./README.md#tick-discovery-bitmap-implementation): Active ticks tracked via bitmap structure for gas-efficient iteration. One bitmap per (poolKeyHash, coin) combination with word-based storage (256 ticks per uint256). Uses Uniswap's TickBitmap library for word-boundary traversal.
-
-**Access Control** ([`SimpleAccessManaged.sol`](src/access/SimpleAccessManaged.sol)) - See [README: Access Control](./README.md#access-control-via-simpleaccessmanaged): Lightweight fork of OpenZeppelin's [AccessManaged](https://docs.openzeppelin.com/contracts/5.x/api/access#AccessManaged) that removes time-based permissions. Protects `create()` and `setMaxFillCount()` via authority contract's `canCall()` interface. Fill operations have additional restrictions during pool unlock (only registered hooks).
-
-**Liquidity Management** ([`LimitOrderLiquidity.sol`](src/libs/LimitOrderLiquidity.sol), [`LimitOrderCreate.sol`](src/libs/LimitOrderCreate.sol), [`LimitOrderWithdraw.sol`](src/libs/LimitOrderWithdraw.sol)) - See [README: Single-Sided Liquidity](./README.md#single-sided-liquidity): Orders implemented as Uniswap V4 liquidity positions across one-tick-spacing ranges using orderID as salt. Supports ERC20 and ETH, alternative payout currencies via swap paths, residual refunds, and fee distribution to makers/referrals.
-
-**Unlock Callback Pattern** ([`ZoraLimitOrderBook.sol`](src/ZoraLimitOrderBook.sol)) - See [README: Component Interaction Flows](./README.md#component-interaction-flows): All state-changing operations occur within Uniswap V4's unlock callback mechanism. Three callback types: CREATE, FILL, WITHDRAW_ORDERS. All balance changes must be settled atomically before unlock completes.
-
-**Token Accounting** ([`LimitOrderLiquidity.sol`](src/libs/LimitOrderLiquidity.sol)) - See [README: Component Interaction Flows](./README.md#component-interaction-flows): Handles ERC20 and native ETH transfers through pool manager's sync/settle/take pattern with balance verification before and after transfers.
-
-**Gas Optimization** ([`LimitOrderFill.sol`](src/libs/LimitOrderFill.sol)): `maxFillCount` parameter limits orders processed per call. Bitmap optimization skips empty ticks. Assembly optimizations in hot loops. Multiple fill calls may be needed for large queues (100+ orders).
-
-**Security Model** - See [README: Security Model & Guarantees](./README.md#5-security-model--guarantees): Documents protocol security guarantees, actor analysis, admin capabilities/limitations, and why `create()` is access controlled.
-
-**DOS Prevention** - See [README: Gas Limits & DOS Prevention](./README.md#6-gas-limits--dos-prevention): Details on `maxFillCount` parameter, gas analysis from testing, and Fusaka/future hard fork considerations.
-
-**Fill Execution Paths** - See [README: Fill Execution Paths](./README.md#4-fill-execution-paths): Documents the three distinct fill paths (auto-fill from hook, router fill, third-party fill), hook migration requirements, and universal Uniswap V4 compatibility.
-
-## Code Statistics
-
-**Solidity Code**:
-
-- Core implementation: ~2,758 lines
-- Primary contract: 220 lines
-- Libraries: ~1,689 lines
-- Interface: 195 lines
-- Access control: 344 lines (SimpleAccessManaged + SimpleAccessManager)
-- Router: 454 lines
-
-**Test Files**: 6 test contracts in `packages/limit-orders/test/`
-
-**Modified Existing Code**:
-
-- ZoraV4CoinHook.sol: ~50-100 lines modified for integration
-- Supporting libraries: TBD based on actual changes
-
-**Note for Auditors**: Understanding the integration points will require familiarity with the existing Zora Coins protocol architecture (hooks, reward distribution, coin versioning). Auditors should account for time to review relevant portions of `packages/coins/` in their proposals.
-
-## Audit Deliverables
-
-We are looking for a comprehensive security assessment that includes:
-
-- **Security findings** with severity classifications, impact analysis, and remediation recommendations
-- **Integration risk assessment** focusing on Uniswap V4 interactions and Zora Coins protocol integration
-- **Code quality analysis** including gas optimization opportunities and best practices
-- **Testing artifacts** such as custom test cases, fuzzing results, or static analysis outputs developed during the audit
-
----
-
-# PART 2: TECHNICAL IMPLEMENTATION
-
-## File Structure
-
-### Complete Package Organization
-
-```
-packages/limit-orders/src/
-├── ZoraLimitOrderBook.sol          (220 lines) - Main contract
-├── IZoraLimitOrderBook.sol         (195 lines) - Interface
-├── access/
-│   ├── SimpleAccessManaged.sol     (76 lines)  - Access control base
-│   └── SimpleAccessManager.sol     (268 lines) - Role-based access manager
-├── libs/
-│   ├── LimitOrderCreate.sol        (277 lines) - Creation logic
-│   ├── LimitOrderFill.sol          (345 lines) - Fill logic (MOST COMPLEX)
-│   ├── LimitOrderWithdraw.sol      (100 lines) - Withdrawal logic
-│   ├── LimitOrderStorage.sol       (34 lines)  - Storage layout
-│   ├── LimitOrderTypes.sol         (41 lines)  - Type definitions
-│   ├── LimitOrderCommon.sol        (91 lines)  - Common utilities
-│   ├── LimitOrderQueues.sol        (101 lines) - Linked list ops
-│   ├── LimitOrderBitmap.sol        (84 lines)  - Bitmap tracking
-│   ├── LimitOrderLiquidity.sol     (222 lines) - Liquidity management
-│   ├── SwapLimitOrders.sol         (209 lines) - Config helper
-│   └── Permit2Payments.sol         (41 lines)  - Permit2 support
-└── router/
-    └── SwapWithLimitOrders.sol     (454 lines) - Router contract
-```
-
-## Data Structures
-
-For detailed documentation of data structures (LimitOrder struct, Queue struct, OrderStatus enum) and the tick queue system, see the [README.md](./README.md#tick-queue-system).
-
-**Order ID Generation**: Deterministic hash of `keccak256(abi.encode(poolKeyHash, coin, tick, maker, nonce))` where nonce increments per maker.
-(_Implementation detail_: `LimitOrderCreate.sol` hashes 5x 32-byte words, equivalent to `abi.encode(...)` rather than `abi.encodePacked(...)`.)
-
-**Callback Data Structures** ([`IZoraLimitOrderBook.sol`](src/IZoraLimitOrderBook.sol)): OrderBatch, CreateCallbackData, FillCallbackData, WithdrawOrdersCallbackData
-
-## Storage Organization
-
-Uses diamond storage pattern at slot `0x98b43bb10ca7bc310641b07883d9e14c04b3983640df6b07dd1c99d10a3c6cec`. For details on storage layout and the diamond pattern implementation, see [`LimitOrderStorage.sol`](src/libs/LimitOrderStorage.sol) and [README.md](./README.md#diamond-storage-pattern).
-
-## External Functions
-
-_See [README: Order Creation Flow](./README.md#order-creation-flow) and [Withdrawal Flow](./README.md#withdrawal-flow) for detailed interaction diagrams_
-
-See [`IZoraLimitOrderBook.sol`](src/IZoraLimitOrderBook.sol) for full signatures and documentation.
-
-**`create()`** ([ZoraLimitOrderBook.sol:73-82](src/ZoraLimitOrderBook.sol#L73-L82)): Creates new limit order(s) by adding liquidity via `poolManager.modifyLiquidity()`. Requires authorization via SimpleAccessManaged. Generates order IDs, records in queues, sets bitmap bits, handles residual refunds.
-
-**`fill()` - Range-based** ([ZoraLimitOrderBook.sol:85-127](src/ZoraLimitOrderBook.sol#L85-L127)): Fills orders within a tick range. Anyone can call; restricted to registered hooks during pool unlock. Bumps epoch, traverses bitmap for active ticks, processes orders, burns liquidity, distributes payouts.
-
-**`fill()` - Order-specific** ([ZoraLimitOrderBook.sol:129-142](src/ZoraLimitOrderBook.sol#L129-L142)): Fills specific orders by ID. Operates on explicit order ID batches.
-
-**`withdraw()`** ([ZoraLimitOrderBook.sol:141-147](src/ZoraLimitOrderBook.sol#L141-L147)): Cancel specific orders by ID. Takes `orderIds`, `coin`, `minAmountOut`, and `recipient` parameters. Validates ownership and status, burns liquidity, issues refunds.
-
----
-
-# PART 3: ADDITIONAL INFORMATION
-
-## Known Limitations
-
-1. **Multi-block scenarios**: Epochs only prevent same-transaction, not cross-block
-2. **Gas Limits**: Large queues (100s/1000s of orders) may need multiple fills
-3. **No Partial Fills**: Orders fill completely or not at all
-4. **Tick Spacing**: Limited by pool's tick spacing
-
----
-
-# CONCLUSION
-
-The Zora Limit Orders implementation uses sophisticated data structures (linked lists, bitmaps) to provide an onchain order book integrated with Uniswap V4.
-
-## Next Steps for Auditors
-
-1. Review this document and supporting docs ([README.md](./README.md), [SPEC.md](./SPEC.md), [AUDIT_NOTES.md](./AUDIT_NOTES.md))
-2. Familiarize yourself with Uniswap V4 architecture if needed
-3. Begin review with code hotspots identified in [AUDIT_NOTES.md](./AUDIT_NOTES.md#1-code-hotspots-fast-path)
-4. Submit questions or clarifications as needed
-
----
-
-**Document Version**: 1.2
-**Last Updated**: 2025-12-12
-**Based On**: Actual implementation in `packages/limit-orders/`
-**Branch**: `autosell`
-
-For questions or clarifications, please contact [Will Binns](mailto:will.binns@ourzora.com).

package/abis/ISetLimitOrderConfig.json

@@ -1,27 +0,0 @@
-[
-  {
-    "type": "function",
-    "name": "setLimitOrderConfig",
-    "inputs": [
-      {
-        "name": "config",
-        "type": "tuple",
-        "internalType": "struct LimitOrderConfig",
-        "components": [
-          {
-            "name": "multiples",
-            "type": "uint256[]",
-            "internalType": "uint256[]"
-          },
-          {
-            "name": "percentages",
-            "type": "uint256[]",
-            "internalType": "uint256[]"
-          }
-        ]
-      }
-    ],
-    "outputs": [],
-    "stateMutability": "nonpayable"
-  }
-]