@zoralabs/comments-contracts 0.0.3 → 0.1.0

package/.turbo/turbo-build.log

@@ -1,13 +1,13 @@
 
-> @zoralabs/comments-contracts@0.0.3 build /home/runner/work/zora-protocol-private/zora-protocol-private/packages/comments
+> @zoralabs/comments-contracts@0.1.0 build /home/runner/work/zora-protocol-private/zora-protocol-private/packages/comments
 > pnpm run wagmi:generate && pnpm run copy-abis && pnpm run prettier:write && tsup
 
 
-> @zoralabs/comments-contracts@0.0.3 wagmi:generate /home/runner/work/zora-protocol-private/zora-protocol-private/packages/comments
+> @zoralabs/comments-contracts@0.1.0 wagmi:generate /home/runner/work/zora-protocol-private/zora-protocol-private/packages/comments
 > FOUNDRY_PROFILE=dev forge build && wagmi generate && pnpm exec rename-generated-abi-casing ./package/wagmiGenerated.ts
 
 Compiling 121 files with Solc 0.8.23
-Solc 0.8.23 finished in 65.77s
+Solc 0.8.23 finished in 85.76s
 Compiler run successful!
 - Validating plugins
 ✔ Validating plugins
@@ -22,63 +22,63 @@ Compiler run successful!
 ✅ Updated ./package/wagmiGenerated.ts (2 replacements)
 ✨ All files processed successfully!
 
-> @zoralabs/comments-contracts@0.0.3 copy-abis /home/runner/work/zora-protocol-private/zora-protocol-private/packages/comments
+> @zoralabs/comments-contracts@0.1.0 copy-abis /home/runner/work/zora-protocol-private/zora-protocol-private/packages/comments
 > pnpm exec bundle-abis
 
 
-> @zoralabs/comments-contracts@0.0.3 prettier:write /home/runner/work/zora-protocol-private/zora-protocol-private/packages/comments
+> @zoralabs/comments-contracts@0.1.0 prettier:write /home/runner/work/zora-protocol-private/zora-protocol-private/packages/comments
 > prettier --write 'src/**/*.sol' 'test/**/*.sol' 'script/**/*.sol'
 
-src/CommentsImpl.sol 828ms (unchanged)
-src/CommentsImplConstants.sol 23ms (unchanged)
-src/interfaces/ICallerAndCommenter.sol 30ms (unchanged)
-src/interfaces/ICoinComments.sol 5ms (unchanged)
-src/interfaces/IComments.sol 35ms (unchanged)
+src/CommentsImpl.sol 1550ms (unchanged)
+src/CommentsImplConstants.sol 17ms (unchanged)
+src/interfaces/ICallerAndCommenter.sol 50ms (unchanged)
+src/interfaces/ICoinComments.sol 8ms (unchanged)
+src/interfaces/IComments.sol 70ms
 src/interfaces/IMultiOwnable.sol 2ms (unchanged)
-src/interfaces/ISecondarySwap.sol 15ms (unchanged)
-src/interfaces/IZoraCreator1155.sol 4ms (unchanged)
-src/interfaces/IZoraCreator1155TypesV1.sol 14ms (unchanged)
-src/interfaces/IZoraTimedSaleStrategy.sol 4ms (unchanged)
-src/proxy/CallerAndCommenter.sol 8ms (unchanged)
-src/proxy/Comments.sol 13ms (unchanged)
-src/utils/CallerAndCommenterImpl.sol 140ms (unchanged)
-src/utils/EIP712UpgradeableWithChainId.sol 13ms (unchanged)
-src/version/ContractVersionBase.sol 2ms (unchanged)
-test/CallerAndCommenter_mintAndComment.t copy.sol 129ms (unchanged)
-test/CallerAndCommenter_swapAndComment.t.sol 272ms (unchanged)
-test/CallerAndCommenterTestBase.sol 50ms (unchanged)
-test/Comments_delegateComment.t.sol 86ms (unchanged)
-test/Comments_permit.t.sol 194ms (unchanged)
-test/Comments_smartWallet.t.sol 89ms (unchanged)
-test/Comments.t.sol 411ms (unchanged)
-test/CommentsTestBase.sol 66ms (unchanged)
-test/mocks/Mock1155.sol 29ms (unchanged)
-test/mocks/Mock1155NoCreatorRewardRecipient.sol 19ms (unchanged)
-test/mocks/Mock1155NoOwner.sol 14ms (unchanged)
-test/mocks/MockCoin.sol 14ms (unchanged)
-test/mocks/MockDelegateCommenter.sol 25ms (unchanged)
-test/mocks/MockIZoraCreator1155.sol 3ms (unchanged)
-test/mocks/MockSecondarySwap.sol 20ms (unchanged)
-test/mocks/MockZoraTimedSale.sol 26ms (unchanged)
-test/mocks/ProtocolRewards.sol 362ms (unchanged)
+src/interfaces/ISecondarySwap.sol 24ms (unchanged)
+src/interfaces/IZoraCreator1155.sol 8ms (unchanged)
+src/interfaces/IZoraCreator1155TypesV1.sol 28ms (unchanged)
+src/interfaces/IZoraTimedSaleStrategy.sol 9ms (unchanged)
+src/proxy/CallerAndCommenter.sol 33ms (unchanged)
+src/proxy/Comments.sol 17ms (unchanged)
+src/utils/CallerAndCommenterImpl.sol 476ms (unchanged)
+src/utils/EIP712UpgradeableWithChainId.sol 22ms (unchanged)
+src/version/ContractVersionBase.sol 1ms (unchanged)
+test/CallerAndCommenter_mintAndComment.t copy.sol 394ms (unchanged)
+test/CallerAndCommenter_swapAndComment.t.sol 841ms (unchanged)
+test/CallerAndCommenterTestBase.sol 146ms (unchanged)
+test/Comments_delegateComment.t.sol 222ms (unchanged)
+test/Comments_permit.t.sol 747ms (unchanged)
+test/Comments_smartWallet.t.sol 302ms (unchanged)
+test/Comments.t.sol 823ms (unchanged)
+test/CommentsTestBase.sol 58ms (unchanged)
+test/mocks/Mock1155.sol 34ms (unchanged)
+test/mocks/Mock1155NoCreatorRewardRecipient.sol 24ms (unchanged)
+test/mocks/Mock1155NoOwner.sol 16ms (unchanged)
+test/mocks/MockCoin.sol 27ms (unchanged)
+test/mocks/MockDelegateCommenter.sol 21ms (unchanged)
+test/mocks/MockIZoraCreator1155.sol 2ms (unchanged)
+test/mocks/MockSecondarySwap.sol 22ms (unchanged)
+test/mocks/MockZoraTimedSale.sol 24ms (unchanged)
+test/mocks/ProtocolRewards.sol 553ms (unchanged)
 script/AddDelegateCommenterRole.s.sol 10ms (unchanged)
-script/CommentsDeployerBase.sol 60ms (unchanged)
-script/Deploy.s.sol 7ms (unchanged)
+script/CommentsDeployerBase.sol 92ms (unchanged)
+script/Deploy.s.sol 6ms (unchanged)
 script/DeployCallerAndCommenterImpl.s.sol 16ms (unchanged)
-script/DeployImpl.s.sol 16ms (unchanged)
-script/DeployNonDeterministic.s.sol 21ms (unchanged)
-script/GenerateDeterministicParams.s.sol 25ms (unchanged)
-CLI Building entry: package/index.ts
-CLI Using tsconfig: tsconfig.json
-CLI tsup v7.3.0
-CLI Using tsup config: /home/runner/work/zora-protocol-private/zora-protocol-private/packages/comments/tsup.config.ts
-CLI Target: es2021
-CLI Cleaning output folder
-CJS Build start
-ESM Build start
-ESM dist/index.js     47.94 KB
-ESM dist/index.js.map 83.57 KB
-ESM ⚡️ Build success in 23ms
-CJS dist/index.cjs     49.03 KB
-CJS dist/index.cjs.map 83.85 KB
-CJS ⚡️ Build success in 25ms
+script/DeployImpl.s.sol 15ms (unchanged)
+script/DeployNonDeterministic.s.sol 27ms (unchanged)
+script/GenerateDeterministicParams.s.sol 33ms (unchanged)
+CLI Building entry: package/index.ts
+CLI Using tsconfig: tsconfig.json
+CLI tsup v8.4.0
+CLI Using tsup config: /home/runner/work/zora-protocol-private/zora-protocol-private/packages/comments/tsup.config.ts
+CLI Target: es2021
+CLI Cleaning output folder
+CJS Build start
+ESM Build start
+ESM dist/index.js     47.88 KB
+ESM dist/index.js.map 83.45 KB
+ESM ⚡️ Build success in 41ms
+CJS dist/index.cjs     48.96 KB
+CJS dist/index.cjs.map 83.73 KB
+CJS ⚡️ Build success in 41ms

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # @zoralabs/comments-contracts
 
+## 0.1.0
+
+### Minor Changes
+
+- e4938846: Remove token holding requirement for commenting
+
+  Users can now comment on any coin without holding the token. Non-admin users must still send 1 spark to comment, but token ownership is no longer required. Delegate commenters can still comment with 0 sparks.
+
 ## 0.0.3
 
 ### Patch Changes

package/abis/CommentsImpl.json

@@ -1830,11 +1830,6 @@
     "name": "NotSmartWalletOwner",
     "inputs": []
   },
-  {
-    "type": "error",
-    "name": "NotTokenHolderOrAdmin",
-    "inputs": []
-  },
   {
     "type": "error",
     "name": "OnlySparksContract",

package/abis/CommentsPermitTest.json

@@ -247,14 +247,14 @@
   },
   {
     "type": "function",
-    "name": "testPermitComment_NonceUsedTwice",
+    "name": "testPermitComment_Non1155HolderCanCommentWithSpark",
     "inputs": [],
     "outputs": [],
     "stateMutability": "nonpayable"
   },
   {
     "type": "function",
-    "name": "testPermitComment_Not1155Holder",
+    "name": "testPermitComment_NonceUsedTwice",
     "inputs": [],
     "outputs": [],
     "stateMutability": "nonpayable"

package/abis/CommentsTest.json

@@ -425,49 +425,49 @@
   },
   {
     "type": "function",
-    "name": "testReplyToCommentThatAddressDoesNotMatch",
+    "name": "testNonCoinHolderCanCommentWithSpark",
     "inputs": [],
     "outputs": [],
     "stateMutability": "nonpayable"
   },
   {
     "type": "function",
-    "name": "testReplyToExistingComment",
+    "name": "testNonHolderCanCommentWithSpark",
     "inputs": [],
     "outputs": [],
     "stateMutability": "nonpayable"
   },
   {
     "type": "function",
-    "name": "testReplyToNonExistentComment",
+    "name": "testReplyToCommentThatAddressDoesNotMatch",
     "inputs": [],
     "outputs": [],
     "stateMutability": "nonpayable"
   },
   {
     "type": "function",
-    "name": "testRevertCommentAsCoinHolderWithoutSparks",
+    "name": "testReplyToExistingComment",
     "inputs": [],
     "outputs": [],
     "stateMutability": "nonpayable"
   },
   {
     "type": "function",
-    "name": "testRevertCommentAsNonCoinHolder",
+    "name": "testReplyToNonExistentComment",
     "inputs": [],
     "outputs": [],
     "stateMutability": "nonpayable"
   },
   {
     "type": "function",
-    "name": "testRevertOnEmptyComment",
+    "name": "testRevertCommentAsCoinHolderWithoutSparks",
     "inputs": [],
     "outputs": [],
     "stateMutability": "nonpayable"
   },
   {
     "type": "function",
-    "name": "testRevertOnNotTokenHolderOrAdmin",
+    "name": "testRevertOnEmptyComment",
     "inputs": [],
     "outputs": [],
     "stateMutability": "nonpayable"

package/abis/Comments_mintAndCommentTest.json

@@ -226,7 +226,14 @@
   },
   {
     "type": "function",
-    "name": "test_delegateComment_revertsWhenNotOwnerOrCreator",
+    "name": "test_delegateComment_canCommentWithZeroSparks",
+    "inputs": [],
+    "outputs": [],
+    "stateMutability": "nonpayable"
+  },
+  {
+    "type": "function",
+    "name": "test_delegateComment_nonOwnerCanCommentWithSpark",
     "inputs": [],
     "outputs": [],
     "stateMutability": "nonpayable"

package/abis/Comments_smartWallet.json

@@ -212,28 +212,28 @@
   },
   {
     "type": "function",
-    "name": "test_commentWithSmartWalletOwner_revertsWhenNotCoinHolder",
+    "name": "test_commentWithSmartWalletOwner_canCommentWithSpark",
     "inputs": [],
     "outputs": [],
     "stateMutability": "nonpayable"
   },
   {
     "type": "function",
-    "name": "test_commentWithSmartWalletOwner_revertsWhenNotCoinSmartWallet",
+    "name": "test_commentWithSmartWalletOwner_nonCoinHolderCanCommentWithSpark",
     "inputs": [],
     "outputs": [],
     "stateMutability": "nonpayable"
   },
   {
     "type": "function",
-    "name": "test_commentWithSmartWalletOwner_revertsWhenNotCoinSmartWalletOwner",
+    "name": "test_commentWithSmartWalletOwner_revertsWhenNotCoinSmartWallet",
     "inputs": [],
     "outputs": [],
     "stateMutability": "nonpayable"
   },
   {
     "type": "function",
-    "name": "test_commentWithSmartWalletOwner_revertsWhenNotHolder",
+    "name": "test_commentWithSmartWalletOwner_revertsWhenNotCoinSmartWalletOwner",
     "inputs": [],
     "outputs": [],
     "stateMutability": "nonpayable"

package/abis/IComments.json

@@ -1240,11 +1240,6 @@
     "name": "NotSmartWalletOwner",
     "inputs": []
   },
-  {
-    "type": "error",
-    "name": "NotTokenHolderOrAdmin",
-    "inputs": []
-  },
   {
     "type": "error",
     "name": "OnlySparksContract",