@zohodesk/testinglibrary 0.0.84-n20-experimental → 0.0.86-n20-experimental

package/build/core/playwright/constants/failureTagConstants.js

@@ -3,17 +3,15 @@
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
-exports.FAILURE_TAG_SUFFIX = exports.FAILURE_TAG_METADATA_SCHEMA_VERSION = exports.FAILURE_TAG_METADATA_ATTACHMENT = exports.FAILURE_TAGS = void 0;
+exports.FAILURE_TAG_SUFFIX = exports.FAILURE_TAG_METADATA_ATTACHMENT = exports.FAILURE_TAGS = void 0;
 const FAILURE_TAGS = exports.FAILURE_TAGS = {
   CASE: 'CASE',
   CODE: 'CODE',
   ENVIRONMENT: 'ENVIRONMENT',
-  FLAKY: 'FLAKY',
   TOOL: 'TOOL'
 };
 
 // Suffix appended to a category when merging into the existing spec.tags array,
-// e.g. "CODE" -> "CODE_failure". The flaky category is emitted as-is ("FLAKY").
+// e.g. "CODE" -> "CODE_failure".
 const FAILURE_TAG_SUFFIX = exports.FAILURE_TAG_SUFFIX = '_failure';
-const FAILURE_TAG_METADATA_ATTACHMENT = exports.FAILURE_TAG_METADATA_ATTACHMENT = 'failure-tag-metadata';
-const FAILURE_TAG_METADATA_SCHEMA_VERSION = exports.FAILURE_TAG_METADATA_SCHEMA_VERSION = 1;
+const FAILURE_TAG_METADATA_ATTACHMENT = exports.FAILURE_TAG_METADATA_ATTACHMENT = 'failure-tag-metadata';

package/build/core/playwright/helpers/failureTagClassifier.js

@@ -16,19 +16,20 @@ var _failureTagConstants = require("../constants/failureTagConstants");
 var _patterns = require("../patterns");
 var _readConfigFile = require("../readConfigFile");
 var _runtimeLogReader = require("./runtimeLogReader");
-// A failing test is tagged purely on presence: if its runtime log contains an
-// environment pattern it gets `ENVIRONMENT`, if it contains a code pattern it
-// gets `CODE`, and if its stdout/stderr contains a tool pattern it gets `TOOL`
-// or a case pattern it gets `CASE` (any may apply). A `CASE` match also adds
-// `CODE` for now via case-implied metadata. `FLAKY` comes from the Playwright
-// retry outcome, not the log.
+// A failing test resolves to a SINGLE category tag by strict priority:
+// CODE > CASE > TOOL > ENVIRONMENT. If several categories match, only the
+// highest-priority one is emitted (e.g. CODE + ENVIRONMENT -> CODE only).
+// CODE/ENVIRONMENT patterns are matched against the runtime log; TOOL/CASE
+// patterns against stdout/stderr. If a failure matches no category at all it
+// defaults to CODE. Retry-passed (flaky) outcomes are not tagged.
 
 const FAILING_RESULT_STATUSES = new Set(['failed', 'timedOut', 'interrupted']);
 const UNEXPECTED_OUTCOME = 'unexpected';
-const FLAKY_OUTCOME = 'flaky';
 const RUNTIME_LOG_SOURCE = 'runtime-log';
 const MAX_MATCH_TEXT_LENGTH = 500;
-const TAG_ORDER = [_failureTagConstants.FAILURE_TAGS.FLAKY, _failureTagConstants.FAILURE_TAGS.ENVIRONMENT, _failureTagConstants.FAILURE_TAGS.CASE, _failureTagConstants.FAILURE_TAGS.CODE, _failureTagConstants.FAILURE_TAGS.TOOL];
+
+// Single-tag priority: the highest-ranked matched category wins.
+const CATEGORY_PRIORITY = [_failureTagConstants.FAILURE_TAGS.CODE, _failureTagConstants.FAILURE_TAGS.CASE, _failureTagConstants.FAILURE_TAGS.TOOL, _failureTagConstants.FAILURE_TAGS.ENVIRONMENT];
 const RUNTIME_LOG_RULES = [{
   tag: _failureTagConstants.FAILURE_TAGS.ENVIRONMENT,
   patterns: _patterns.ENVIRONMENT_PATTERNS
@@ -41,13 +42,9 @@ const STDIO_RULES = [{
   patterns: _patterns.TOOL_PATTERNS
 }, {
   tag: _failureTagConstants.FAILURE_TAGS.CASE,
-  patterns: _patterns.CASE_PATTERNS,
-  impliesCode: true
+  patterns: _patterns.CASE_PATTERNS
 }];
-function resolveLogsDir(logsDir) {
-  if (logsDir) {
-    return logsDir;
-  }
+function resolveLogsDir() {
   const {
     uatDirectory
   } = (0, _readConfigFile.generateConfigFromFile)();
@@ -147,33 +144,18 @@ function collectRuntimeLogMatches(events, matches) {
 function collectStdioMatches(stdio, matches) {
   for (const rule of STDIO_RULES) {
     const match = findStdioMatch(stdio, rule.patterns, rule.tag);
-    if (!match) {
-      continue;
-    }
-    matches.push(match);
-    if (rule.impliesCode) {
-      implyCodeFromCase(matches, match);
+    if (match) {
+      matches.push(match);
     }
   }
 }
-function implyCodeFromCase(matches, caseMatch) {
-  if (matches.some(match => match.tag === _failureTagConstants.FAILURE_TAGS.CODE)) {
-    return;
-  }
-  matches.push({
-    tag: _failureTagConstants.FAILURE_TAGS.CODE,
-    pattern: null,
-    source: 'case-implied',
-    text: caseMatch.text
-  });
-}
 function classifyFailureDetailsFromEvents(events = []) {
   const matches = [];
   collectRuntimeLogMatches(events, matches);
   return buildFailureTagMetadata(matches);
 }
-function classifyFailureDetailsFromResult(result, testTitle, logsDir) {
-  const resolvedLogsDir = resolveLogsDir(logsDir);
+function classifyFailureDetailsFromResult(result, testTitle) {
+  const resolvedLogsDir = resolveLogsDir();
   const events = (0, _runtimeLogReader.readRuntimeLogEventsForResult)(result, testTitle, resolvedLogsDir);
   const matches = [];
   collectRuntimeLogMatches(events, matches);
@@ -181,26 +163,24 @@ function classifyFailureDetailsFromResult(result, testTitle, logsDir) {
   return buildFailureTagMetadata(matches);
 }
 function buildFailureTagMetadata(matches = []) {
-  const tags = TAG_ORDER.filter(tag => matches.some(match => match.tag === tag));
+  const tags = [];
+
+  // Collapse the matched categories to the single highest-priority winner.
+  // When a failure matched no category, fall back to CODE.
+  const winningCategory = CATEGORY_PRIORITY.find(tag => matches.some(match => match.tag === tag));
+  if (winningCategory) {
+    tags.push(winningCategory);
+  } else {
+    tags.push(_failureTagConstants.FAILURE_TAGS.CODE);
+  }
   return {
-    schemaVersion: _failureTagConstants.FAILURE_TAG_METADATA_SCHEMA_VERSION,
     tags,
     matches
   };
 }
-function classifyFailureDetails(testDetails = [], testTitle = 'test', logsDir) {
-  const resolvedLogsDir = resolveLogsDir(logsDir);
+function classifyFailureDetails(testDetails = [], testTitle = 'test') {
   const matches = [];
   for (const detail of testDetails) {
-    if (detail.status === FLAKY_OUTCOME) {
-      matches.push({
-        tag: _failureTagConstants.FAILURE_TAGS.FLAKY,
-        pattern: null,
-        source: 'retry-outcome',
-        text: null
-      });
-      continue;
-    }
     if (detail.status !== UNEXPECTED_OUTCOME) {
       continue;
     }
@@ -208,7 +188,7 @@ function classifyFailureDetails(testDetails = [], testTitle = 'test', logsDir) {
     if (!failingResult) {
       continue;
     }
-    const resultDetails = classifyFailureDetailsFromResult(failingResult, testTitle, resolvedLogsDir);
+    const resultDetails = classifyFailureDetailsFromResult(failingResult, testTitle);
     matches.push(...resultDetails.matches);
   }
   const uniqueMatches = [];
@@ -217,10 +197,16 @@ function classifyFailureDetails(testDetails = [], testTitle = 'test', logsDir) {
       uniqueMatches.push(match);
     }
   }
+  if (!testDetails.some(detail => detail.status === UNEXPECTED_OUTCOME)) {
+    return {
+      tags: [],
+      matches: uniqueMatches
+    };
+  }
   return buildFailureTagMetadata(uniqueMatches);
 }
-function classifyFailureTags(testDetails = [], testTitle = 'test', logsDir) {
-  return classifyFailureDetails(testDetails, testTitle, logsDir).tags;
+function classifyFailureTags(testDetails = [], testTitle = 'test') {
+  return classifyFailureDetails(testDetails, testTitle).tags;
 }
 function pickFailingResult(results = []) {
   const failing = results.filter(result => FAILING_RESULT_STATUSES.has(result.status));
@@ -230,9 +216,6 @@ function pickFailingResult(results = []) {
   return failing[failing.length - 1];
 }
 function formatFailureTag(tag) {
-  if (tag === _failureTagConstants.FAILURE_TAGS.FLAKY) {
-    return tag;
-  }
   return `${tag}${_failureTagConstants.FAILURE_TAG_SUFFIX}`;
 }
 function mergeFailureTags(existingTags = [], failureTags = []) {

package/build/core/playwright/patterns/toolPatterns.js

@@ -20,15 +20,7 @@ const TOOL_PATTERNS = exports.TOOL_PATTERNS = [/Error during login/i, /fetch fai
 /Error while parsing cookies/i,
 // FileMutex
 /Watch timeout exceeded/i,
-// Runner
-/Method 'run\(\)' must be implemented\./i, /Invalid runner type/i,
-// Process
-/Child Process Exited with Code/i, /Terminating Playwright Process\.\.\./i, /Cleaning up\.\.\./i,
-// TestData
-/Error appending or creating the test data file:/i, /Error\(err\)/i, /Error while deleting the test data file:/i,
-// FeatureFile
-/Error while parsing feature files\. Please fix the above issues before running test cases/i,
 // RPC
-/Error: HTTP /i, /Invalid payload\. It must be a non-null object\./i, /Invalid payload\.arguments\.entityId\./i,
+/Invalid payload\. It must be a non-null object\./i, /Invalid payload\.arguments\.entityId\./i,
 // Search
 /Invalid or missing data in dataTable/i, /JSONPath query/i];

package/build/test/core/playwright/helpers/__tests__/failureTagClassifier.test.js

@@ -6,18 +6,25 @@ var _os = _interopRequireDefault(require("os"));
 var _path = _interopRequireDefault(require("path"));
 var toolPatterns = _interopRequireWildcard(require("../../../../../core/playwright/patterns/toolPatterns"));
 var casePatterns = _interopRequireWildcard(require("../../../../../core/playwright/patterns/casePatterns"));
+var _readConfigFile = require("../../../../../core/playwright/readConfigFile");
 var _runtimeLogPath = require("../../../../../core/playwright/helpers/runtimeLogPath");
 var _failureTagClassifier = require("../../../../../core/playwright/helpers/failureTagClassifier");
 var _failureTagConstants = require("../../../../../core/playwright/constants/failureTagConstants");
 function _interopRequireWildcard(e, t) { if ("function" == typeof WeakMap) var r = new WeakMap(), n = new WeakMap(); return (_interopRequireWildcard = function (e, t) { if (!t && e && e.__esModule) return e; var o, i, f = { __proto__: null, default: e }; if (null === e || "object" != typeof e && "function" != typeof e) return f; if (o = t ? n : r) { if (o.has(e)) return o.get(e); o.set(e, f); } for (const t in e) "default" !== t && {}.hasOwnProperty.call(e, t) && ((i = (o = Object.defineProperty) && Object.getOwnPropertyDescriptor(e, t)) && (i.get || i.set) ? o(f, t, i) : f[t] = e[t]); return f; })(e, t); }
+jest.mock('../../../../../core/playwright/readConfigFile', () => ({
+  generateConfigFromFile: jest.fn()
+}));
 const TEST_TITLE = 'environment-abort-test';
 let tempDir;
+function runtimeLogsDir() {
+  return _path.default.join(tempDir, 'runtime-logs');
+}
 function writeRuntimeLog(events, {
   workerIndex = 0,
   retry = 0,
   title = TEST_TITLE
 } = {}) {
-  const file = (0, _runtimeLogPath.resolveRuntimeLogFilePath)(tempDir, {
+  const file = (0, _runtimeLogPath.resolveRuntimeLogFilePath)(runtimeLogsDir(), {
     workerIndex,
     retry,
     title
@@ -55,6 +62,9 @@ function failingDetailWithStdio({
 }
 beforeEach(() => {
   tempDir = _fs.default.mkdtempSync(_path.default.join(_os.default.tmpdir(), 'failure-tag-'));
+  _readConfigFile.generateConfigFromFile.mockReturnValue({
+    uatDirectory: tempDir
+  });
 });
 afterEach(() => {
   _fs.default.rmSync(tempDir, {
@@ -63,12 +73,12 @@ afterEach(() => {
   });
 });
 describe('classifyFailureTags', () => {
-  test('returns flaky and skips log analysis for flaky outcome', () => {
+  test('leaves retry-passed (flaky) outcomes untagged', () => {
     const tags = (0, _failureTagClassifier.classifyFailureTags)([{
       status: 'flaky',
       results: []
-    }], TEST_TITLE, tempDir);
-    expect(tags).toEqual(['FLAKY']);
+    }], TEST_TITLE);
+    expect(tags).toEqual([]);
   });
   test('tags environment when a document abort is present', () => {
     const tags = (0, _failureTagClassifier.classifyFailureTags)([failingDetail([{
@@ -76,7 +86,7 @@ describe('classifyFailureTags', () => {
       url: 'https://app/events/list/commentsubtabevent',
       failure: 'net::ERR_ABORTED',
       resourceType: 'document'
-    }])], TEST_TITLE, tempDir);
+    }])], TEST_TITLE);
     expect(tags).toEqual(['ENVIRONMENT']);
   });
   test('tags environment for a network/cert failure', () => {
@@ -87,7 +97,7 @@ describe('classifyFailureTags', () => {
       resourceType: 'script'
     }], {
       title: 'cert-test'
-    })], 'cert-test', tempDir);
+    })], 'cert-test');
     expect(tags).toEqual(['ENVIRONMENT']);
   });
   test('tags code when an app undefined-property error is present', () => {
@@ -97,10 +107,10 @@ describe('classifyFailureTags', () => {
       message: "Cannot read properties of undefined (reading 'id')"
     }], {
       title: 'code-test'
-    })], 'code-test', tempDir);
+    })], 'code-test');
     expect(tags).toEqual(['CODE']);
   });
-  test('does not tag a non-document (xhr) abort as environment', () => {
+  test('defaults to code (not environment) for a non-document xhr abort', () => {
     const tags = (0, _failureTagClassifier.classifyFailureTags)([failingDetail([{
       kind: 'requestfailed',
       url: 'https://app/api/tickets',
@@ -108,17 +118,17 @@ describe('classifyFailureTags', () => {
       resourceType: 'xhr'
     }], {
       title: 'xhr-test'
-    })], 'xhr-test', tempDir);
-    expect(tags).toEqual([]);
+    })], 'xhr-test');
+    expect(tags).toEqual(['CODE']);
   });
-  test('tags case and code when stderr reports DATA_GENERATION_ERROR', () => {
+  test('tags case when stderr reports DATA_GENERATION_ERROR', () => {
     const detail = failingDetailWithStdio({
       stderr: [{
         text: 'status : DATA_GENERATION_ERROR\n generator: comments'
       }]
     });
-    const tags = (0, _failureTagClassifier.classifyFailureTags)([detail], TEST_TITLE, tempDir);
-    expect(tags).toEqual(['CASE', 'CODE']);
+    const tags = (0, _failureTagClassifier.classifyFailureTags)([detail], TEST_TITLE);
+    expect(tags).toEqual(['CASE']);
   });
   test('tags tool for a known tool pattern in base64 stdout', () => {
     const detail = failingDetailWithStdio({
@@ -126,10 +136,10 @@ describe('classifyFailureTags', () => {
         buffer: Buffer.from('Error during login').toString('base64')
       }]
     });
-    const tags = (0, _failureTagClassifier.classifyFailureTags)([detail], TEST_TITLE, tempDir);
+    const tags = (0, _failureTagClassifier.classifyFailureTags)([detail], TEST_TITLE);
     expect(tags).toEqual(['TOOL']);
   });
-  test('tags case and code when stderr matches a case pattern', () => {
+  test('tags case when stderr matches a case pattern', () => {
     const originalCasePatterns = casePatterns.CASE_PATTERNS.slice();
     try {
       casePatterns.CASE_PATTERNS.push(/expect\(received\)\.toBe/i);
@@ -138,22 +148,37 @@ describe('classifyFailureTags', () => {
           text: 'Error: expect(received).toBe(expected)'
         }]
       });
-      const tags = (0, _failureTagClassifier.classifyFailureTags)([detail], TEST_TITLE, tempDir);
-      expect(tags).toEqual(['CASE', 'CODE']);
+      const tags = (0, _failureTagClassifier.classifyFailureTags)([detail], TEST_TITLE);
+      expect(tags).toEqual(['CASE']);
     } finally {
       casePatterns.CASE_PATTERNS.length = 0;
       casePatterns.CASE_PATTERNS.push(...originalCasePatterns);
     }
   });
-  test('does not tag tool for benign stdout/stderr', () => {
+  test('emits only the highest-priority tag (CODE) when CODE and ENVIRONMENT both match', () => {
+    const tags = (0, _failureTagClassifier.classifyFailureTags)([failingDetail([{
+      kind: 'requestfailed',
+      url: 'https://app/events/list/commentsubtabevent',
+      failure: 'net::ERR_ABORTED',
+      resourceType: 'document'
+    }, {
+      kind: 'pageerror',
+      name: 'TypeError',
+      message: "Cannot read properties of undefined (reading 'id')"
+    }], {
+      title: 'code-over-env-test'
+    })], 'code-over-env-test');
+    expect(tags).toEqual(['CODE']);
+  });
+  test('defaults to code (not tool) for benign stdout/stderr', () => {
     const detail = failingDetailWithStdio({
       stdout: [{
         text: 'Generated 5 records successfully'
       }],
       stderr: []
     });
-    const tags = (0, _failureTagClassifier.classifyFailureTags)([detail], TEST_TITLE, tempDir);
-    expect(tags).toEqual([]);
+    const tags = (0, _failureTagClassifier.classifyFailureTags)([detail], TEST_TITLE);
+    expect(tags).toEqual(['CODE']);
   });
   test('does not throw for malformed stdio chunk entries', () => {
     const detail = failingDetailWithStdio({
@@ -162,10 +187,10 @@ describe('classifyFailureTags', () => {
       }],
       stderr: [false]
     });
-    expect(() => (0, _failureTagClassifier.classifyFailureTags)([detail], TEST_TITLE, tempDir)).not.toThrow();
-    expect((0, _failureTagClassifier.classifyFailureTags)([detail], TEST_TITLE, tempDir)).toEqual([]);
+    expect(() => (0, _failureTagClassifier.classifyFailureTags)([detail], TEST_TITLE)).not.toThrow();
+    expect((0, _failureTagClassifier.classifyFailureTags)([detail], TEST_TITLE)).toEqual(['CODE']);
   });
-  test('leaves untagged when no environment or code pattern is present', () => {
+  test('defaults to code when a failure matches no pattern', () => {
     const tags = (0, _failureTagClassifier.classifyFailureTags)([failingDetail([{
       kind: 'response',
       status: 200,
@@ -180,7 +205,18 @@ describe('classifyFailureTags', () => {
       }
     }], {
       title: 'neutral-test'
-    })], 'neutral-test', tempDir);
+    })], 'neutral-test');
+    expect(tags).toEqual(['CODE']);
+  });
+  test('leaves a passing spec untagged (no default code)', () => {
+    const tags = (0, _failureTagClassifier.classifyFailureTags)([{
+      status: 'expected',
+      results: [{
+        status: 'passed',
+        workerIndex: 0,
+        retry: 0
+      }]
+    }], 'passing-test');
     expect(tags).toEqual([]);
   });
 });
@@ -191,7 +227,7 @@ describe('classifyFailureDetails', () => {
       url: 'https://app/events/list/commentsubtabevent',
       failure: 'net::ERR_ABORTED',
       resourceType: 'document'
-    }])], TEST_TITLE, tempDir);
+    }])], TEST_TITLE);
     expect(details.tags).toEqual(['ENVIRONMENT']);
     expect(details.matches).toHaveLength(1);
     expect(details.matches[0]).toMatchObject({
@@ -214,25 +250,17 @@ describe('classifyFailureDetails', () => {
       source: 'runtime-log'
     });
   });
-  test('records flaky outcome without a regex pattern', () => {
-    const details = (0, _failureTagClassifier.classifyFailureDetails)([{
-      status: 'flaky',
-      results: []
-    }], TEST_TITLE, tempDir);
-    expect(details.tags).toEqual(['FLAKY']);
-    expect(details.matches[0]).toEqual({
-      tag: 'FLAKY',
-      pattern: null,
-      source: 'retry-outcome',
-      text: null
-    });
+  test('defaults to code with no matches when events carry no recognised pattern', () => {
+    const details = (0, _failureTagClassifier.classifyFailureDetailsFromEvents)([]);
+    expect(details.tags).toEqual(['CODE']);
+    expect(details.matches).toEqual([]);
   });
   test('records tool pattern from stdio', () => {
     const details = (0, _failureTagClassifier.classifyFailureDetails)([failingDetailWithStdio({
       stderr: [{
         text: 'Error during login for actor admin'
       }]
-    })], TEST_TITLE, tempDir);
+    })], TEST_TITLE);
     expect(details.tags).toEqual(['TOOL']);
     expect(details.matches[0]).toMatchObject({
       tag: 'TOOL',
@@ -240,7 +268,7 @@ describe('classifyFailureDetails', () => {
       source: 'stdio'
     });
   });
-  test('records case pattern from stdio and implies code', () => {
+  test('records case pattern from stdio without implying code', () => {
     const originalCasePatterns = casePatterns.CASE_PATTERNS.slice();
     try {
       casePatterns.CASE_PATTERNS.push(/expect\(received\)\.toBe/i);
@@ -248,26 +276,20 @@ describe('classifyFailureDetails', () => {
         stderr: [{
           text: 'Error: expect(received).toBe(expected)'
         }]
-      })], TEST_TITLE, tempDir);
-      expect(details.tags).toEqual(['CASE', 'CODE']);
-      expect(details.matches).toHaveLength(2);
+      })], TEST_TITLE);
+      expect(details.tags).toEqual(['CASE']);
+      expect(details.matches).toHaveLength(1);
       expect(details.matches[0]).toMatchObject({
         tag: 'CASE',
         pattern: 'expect\\(received\\)\\.toBe',
         source: 'stdio'
       });
-      expect(details.matches[1]).toMatchObject({
-        tag: 'CODE',
-        pattern: null,
-        source: 'case-implied'
-      });
-      expect(details.matches[1].text).toContain('expect(received).toBe(expected)');
     } finally {
       casePatterns.CASE_PATTERNS.length = 0;
       casePatterns.CASE_PATTERNS.push(...originalCasePatterns);
     }
   });
-  test('keeps runtime-log code match when case also matches', () => {
+  test('resolves to CODE when a runtime-log code match outranks a stdio case match', () => {
     const originalCasePatterns = casePatterns.CASE_PATTERNS.slice();
     try {
       casePatterns.CASE_PATTERNS.push(/expect\(received\)\.toBe/i);
@@ -288,8 +310,10 @@ describe('classifyFailureDetails', () => {
             text: 'Error: expect(received).toBe(expected)'
           }]
         }]
-      }], 'case-with-runtime-code', tempDir);
-      expect(details.tags).toEqual(['CASE', 'CODE']);
+      }], 'case-with-runtime-code');
+
+      // CODE outranks CASE, so only CODE surfaces as the tag; both remain as evidence.
+      expect(details.tags).toEqual(['CODE']);
       expect(details.matches).toHaveLength(2);
       expect(details.matches.find(match => match.tag === 'CASE')).toMatchObject({
         source: 'stdio'
@@ -303,7 +327,7 @@ describe('classifyFailureDetails', () => {
       casePatterns.CASE_PATTERNS.push(...originalCasePatterns);
     }
   });
-  test('implies code from case when no runtime log is present', () => {
+  test('keeps case as the tag and does not add code when no runtime log is present', () => {
     const originalCasePatterns = casePatterns.CASE_PATTERNS.slice();
     try {
       casePatterns.CASE_PATTERNS.push(/Timed out \d+ms waiting for/i);
@@ -311,12 +335,9 @@ describe('classifyFailureDetails', () => {
         stderr: [{
           text: 'Timed out 5000ms waiting for locator("#save")'
         }]
-      })], TEST_TITLE, tempDir);
-      expect(details.tags).toEqual(['CASE', 'CODE']);
-      expect(details.matches.find(match => match.tag === 'CODE')).toMatchObject({
-        source: 'case-implied',
-        pattern: null
-      });
+      })], TEST_TITLE);
+      expect(details.tags).toEqual(['CASE']);
+      expect(details.matches.find(match => match.tag === 'CODE')).toBeUndefined();
     } finally {
       casePatterns.CASE_PATTERNS.length = 0;
       casePatterns.CASE_PATTERNS.push(...originalCasePatterns);
@@ -376,8 +397,8 @@ describe('mergeFailureTags', () => {
   test('places suffixed failure tags first, then existing tags', () => {
     expect((0, _failureTagClassifier.mergeFailureTags)(['@comments', '@calls'], ['CODE', 'ENVIRONMENT'])).toEqual(['CODE_failure', 'ENVIRONMENT_failure', '@comments', '@calls']);
   });
-  test('emits the flaky category as FLAKY without a suffix', () => {
-    expect((0, _failureTagClassifier.mergeFailureTags)([], ['FLAKY', 'CODE'])).toEqual(['FLAKY', 'CODE_failure']);
+  test('formats all failure tags with suffix', () => {
+    expect((0, _failureTagClassifier.mergeFailureTags)([], ['CODE', 'TOOL'])).toEqual(['CODE_failure', 'TOOL_failure']);
   });
   test('does not duplicate an already-present failure tag', () => {
     expect((0, _failureTagClassifier.mergeFailureTags)(['CODE_failure'], ['CODE'])).toEqual(['CODE_failure']);
@@ -399,8 +420,8 @@ describe('regex safety', () => {
           text: 'status : DATA_GENERATION_ERROR'
         }]
       });
-      const first = (0, _failureTagClassifier.classifyFailureTags)([detail], TEST_TITLE, tempDir);
-      const second = (0, _failureTagClassifier.classifyFailureTags)([detail], TEST_TITLE, tempDir);
+      const first = (0, _failureTagClassifier.classifyFailureTags)([detail], TEST_TITLE);
+      const second = (0, _failureTagClassifier.classifyFailureTags)([detail], TEST_TITLE);
       expect(first).toEqual(['TOOL']);
       expect(second).toEqual(['TOOL']);
     } finally {