@zohodesk/react-cli 1.1.5-exp.3 → 1.1.5-exp.5

package/README.md

@@ -44,8 +44,15 @@ Now to run app
 
 # Change Logs
 
+# 1.1.5-exp.5
+- fixed the issues regarding custom chunks base config schema.
+
+# 1.1.5-exp.4
+- added support for using regex expression to get group of chunks chunkId via Resource Hint plugin prefetch/preload hook.
+
 # 1.1.5-exp.3
-- efficient chunk split related features update 
+- added options to split chunks base config
+- added support for passing custom chunks split logic as function.
 
 **Issue Fix**
 

package/docs/CustomChunks.md

@@ -4,7 +4,7 @@ In react-cli we provide options to create custom chunks.
 This Custom Chunk Option is array of Object
 that Object keys are
 
-- `pattern` **{ String | Function }** regex pattern as string and
+- `pattern` **{ String | Function }** regex pattern as string and custom logic to split chunks can be defined using function
 - `name` **{ String }** chunk name
 - `size` **{ Number }** is count which is minimum chunk duplicated or need in chunks
 

package/lib/common/splitChunks.js

@@ -59,7 +59,7 @@ function rulesMatcher(pattern) {
 }
 
 const baseSplitChunkConfig = Object.assign({
-  minSize: 12000
+  minSize: 15000
 }, customChunksBaseConfig);
 const specificCacheGroupConfig = {
   'react.vendor': {
@@ -125,11 +125,11 @@ customChunks.map((obj, index) => ({
     obj.maxSize = maxSize;
   }
 
-  if (name) {
+  if (name !== undefined) {
     obj.name = name;
   }
 
-  if (reuseExistingChunk) {
+  if (reuseExistingChunk !== undefined) {
     obj.reuseExistingChunk = reuseExistingChunk;
   }
 

package/lib/plugins/ResourceHintsPlugin.js

@@ -19,7 +19,7 @@ class ResourceHintsPlugin {
       mainTemplate.hooks.requireExtensions.tap(pluginName, (source, chunk, hash) => {
         const idNameMap = chunk.getChunkMaps().name;
         const nameIdMap = {};
-        let needsMap = false;
+        let needsMap = true;
 
         for (const key in idNameMap) {
           if (Object.prototype.hasOwnProperty.call(idNameMap, key)) {
@@ -32,7 +32,9 @@ class ResourceHintsPlugin {
           }
         }
 
-        return Template.asString([source, '', `${mainTemplate.requireFn}.getChunkId = function getChunkId(chunkId) {`, Template.indent((needsMap ? [`chunkId = ${JSON.stringify(nameIdMap)}[chunkId]||chunkId;`] : []).concat(['return chunkId;'])), '}', `// Prefetch a chunk (${pluginName})`, `${mainTemplate.requireFn}.pfc = function prefetchChunk(chunkId) {`, Template.indent([`chunkId = ${mainTemplate.requireFn}.getChunkId(chunkId)`, `${mainTemplate.requireFn}.e(chunkId);`]), '};',
+        return Template.asString([source, '', `${mainTemplate.requireFn}.getChunkIds = function getChunkIds(chunkId) {`, Template.indent((needsMap ? [`const nameToChunkIdMap = ${JSON.stringify(nameIdMap)}`, 'const chunkNames = Object.keys(nameToChunkIdMap)'] : []).concat(['return chunkNames.filter(chunkName => chunkId.test(chunkName)).map(chunkName => nameToChunkIdMap[chunkName]);'])), '}', `// Prefetch a chunk (${pluginName})`, `${mainTemplate.requireFn}.pfc = function prefetchChunk(chunkId) {`, Template.indent([`let chunkIds = ${mainTemplate.requireFn}.getChunkIds(new RegExp(chunkId, 'i'))`, `chunkIds.forEach(idOfAChunk => {
+                ${mainTemplate.requireFn}.e(idOfAChunk);
+              })`]), '};',
         /*
           (needsMap
             ? [`chunkId = ${JSON.stringify(nameIdMap)}[chunkId]||chunkId;`]
@@ -53,7 +55,7 @@ class ResourceHintsPlugin {
         ),
         '}',
         */
-        `// Preload a chunk (${pluginName})`, `${mainTemplate.requireFn}.plc = function preloadChunk(chunkId) {`, Template.indent([`chunkId = ${mainTemplate.requireFn}.getChunkId(chunkId)`, 'if(installedChunks[chunkId] === undefined) {', Template.indent(['installedChunks[chunkId] = null;', mainTemplate.hooks.linkPreload.call('', chunk, hash), 'document.head.appendChild(link);', `${mainTemplate.requireFn}.e(chunkId);` // 'var head = document.getElementsByTagName(\'head\')[0];',
+        `// Preload a chunk (${pluginName})`, `${mainTemplate.requireFn}.plc = function preloadChunk(chunkId) {`, Template.indent([`chunkId = ${mainTemplate.requireFn}.getChunkIds(new RegExp('^' + chunkId + '$'))[0]`, 'if(installedChunks[chunkId] === undefined) {', Template.indent(['installedChunks[chunkId] = null;', mainTemplate.hooks.linkPreload.call('', chunk, hash), 'document.head.appendChild(link);', `${mainTemplate.requireFn}.e(chunkId);` // 'var head = document.getElementsByTagName(\'head\')[0];',
         // mainTemplate.hooks.jsonpScript.call('', chunk, hash),
         // 'head.appendChild(script);'
         ]), '}']), '};']);

package/lib/schemas/index.js

@@ -333,7 +333,7 @@ var _default = {
       inject: true
     },
     removePropTypes: false,
-    customChunksBaseConfig: {},
+    customChunksBaseConfig: null,
     customChunks: [{
       name: 'styles',
       pattern: '\\.css$'