@zohodesk/react-cli 1.1.4 → 1.1.5-exp.1

package/docs/patternFiltering.md

@@ -1,57 +1,57 @@
-# Pattern filtering 
-
-As replacement for exclude we now have patterns in place of exclude to include or exclude a file based on its name in package.json.
-
-
-# Example for patterns : 
-
-**Old System** : 
-To exclude `node_modules` folder from convertion for the `cssVariableReplacement` plugin, we used to have :
-
-`react-cli > app > exclude > cssVariableReplacement` as ['node_modules'] in `package.json`
-
-Example : 
-
-"exclude": {
-    "cssVariableReplacement": [
-        "node_modules"
-    ]
-},
-
-**New System** : 
-
-To include all files for convertion for the `valueReplacer` plugin, we now have : 
-
-`react-cli > app > patterns > valueReplacer` as ['*'] in `package.json`
-
-To include `src` files for convertion for the `cssVariableReplacement` plugin, we now have : 
-
-`react-cli > app > patterns > hoverActive` as ['src'] in `package.json`
-
-To exclude `node_modules` files for convertion for the `hoverActive` plugin, we now have : 
-
-`react-cli > app > patterns > cssVariableReplacement` as ['!node_modules'] in `package.json`
-Here the `!` denotes that the folder structure/file is not to be converted.
-
-Example : 
-
-"patterns": {
-    "valueReplacer": [
-        "*"
-    ],
-    "hoverActive": [
-        "src"
-    ],
-    "cssVariableReplacement": [
-        "!node_modules"
-    ],
-},
-
-Note : 
-`patterns` also added support for cssUniqueness to be applied to selective files.
-
-"patterns" : {
-    "cssUniqueness": [
-        "*"
-    ],
+# Pattern filtering 
+
+As replacement for exclude we now have patterns in place of exclude to include or exclude a file based on its name in package.json.
+
+
+# Example for patterns : 
+
+**Old System** : 
+To exclude `node_modules` folder from convertion for the `cssVariableReplacement` plugin, we used to have :
+
+`react-cli > app > exclude > cssVariableReplacement` as ['node_modules'] in `package.json`
+
+Example : 
+
+"exclude": {
+    "cssVariableReplacement": [
+        "node_modules"
+    ]
+},
+
+**New System** : 
+
+To include all files for convertion for the `valueReplacer` plugin, we now have : 
+
+`react-cli > app > patterns > valueReplacer` as ['*'] in `package.json`
+
+To include `src` files for convertion for the `cssVariableReplacement` plugin, we now have : 
+
+`react-cli > app > patterns > hoverActive` as ['src'] in `package.json`
+
+To exclude `node_modules` files for convertion for the `hoverActive` plugin, we now have : 
+
+`react-cli > app > patterns > cssVariableReplacement` as ['!node_modules'] in `package.json`
+Here the `!` denotes that the folder structure/file is not to be converted.
+
+Example : 
+
+"patterns": {
+    "valueReplacer": [
+        "*"
+    ],
+    "hoverActive": [
+        "src"
+    ],
+    "cssVariableReplacement": [
+        "!node_modules"
+    ],
+},
+
+Note : 
+`patterns` also added support for cssUniqueness to be applied to selective files.
+
+"patterns" : {
+    "cssUniqueness": [
+        "*"
+    ],
 }

package/docs/warnings_while_install.txt

@@ -1,35 +1,35 @@
-npm WARN deprecated babel-eslint@10.1.0: babel-eslint is now @babel/eslint-parser. This package will no longer receive updates.
-npm WARN deprecated eslint-loader@4.0.2: This loader has been deprecated. Please use eslint-webpack-plugin
-npm WARN deprecated gitlab@14.2.2: The gitlab package has found a new home in the @gitbeaker organization. For the latest gitlab node library, check out @gitbeaker/node. A full list of the features can be found here: https://github.com/jdalrymple/gitbeaker#readme
-npm WARN deprecated chokidar@2.1.8: Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies.
-npm WARN deprecated fsevents@1.2.13: fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.
-npm WARN deprecated webdriverio@4.14.4: outdated version, please use @next
-npm WARN deprecated mkdirp@0.3.5: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)
-npm WARN deprecated cross-spawn-async@1.0.1: cross-spawn no longer requires a build toolchain, use it instead
-npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
-npm WARN deprecated core-js@2.6.12: core-js@<3.3 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Please, upgrade your dependencies to the actual version of core-js.
-npm WARN deprecated har-validator@5.1.5: this library is no longer supported
-npm WARN deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
-npm WARN deprecated querystring@0.2.0: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
-npm WARN deprecated sane@4.1.0: some dependency vulnerabilities fixed, support for node < 10 dropped, and newer ECMAScript syntax/features added
-npm WARN deprecated request-promise-native@1.0.9: request-promise-native has been deprecated because it extends the now deprecated request package, see https://github.com/request/request/issues/3142
-npm WARN deprecated flatten@1.0.3: flatten is deprecated in favor of utility frameworks such as lodash.
-npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@^1.2.7 (node_modules/chokidar/node_modules/fsevents):
-npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.13: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
-npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@^2.1.2 (node_modules/jest-haste-map/node_modules/fsevents):
-npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.3.2: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
-npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@~2.3.2 (node_modules/nodemon/node_modules/chokidar/node_modules/fsevents):
-npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.3.2: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
-npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@~2.3.2 (node_modules/watchpack/node_modules/chokidar/node_modules/fsevents):
-npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.3.2: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
-npm WARN check2@1.0.0 No description
-npm WARN check2@1.0.0 No repository field.
-
-+ @zohodesk/react-cli@0.0.1-beta.165
-updated 1 package and audited 1899 packages in 51.509s
-
-21 packages are looking for funding
-  run `npm fund` for details
-
-found 42 vulnerabilities (2 low, 20 moderate, 8 high, 12 critical)
-  run `npm audit fix` to fix them, or `npm audit` for details
+npm WARN deprecated babel-eslint@10.1.0: babel-eslint is now @babel/eslint-parser. This package will no longer receive updates.
+npm WARN deprecated eslint-loader@4.0.2: This loader has been deprecated. Please use eslint-webpack-plugin
+npm WARN deprecated gitlab@14.2.2: The gitlab package has found a new home in the @gitbeaker organization. For the latest gitlab node library, check out @gitbeaker/node. A full list of the features can be found here: https://github.com/jdalrymple/gitbeaker#readme
+npm WARN deprecated chokidar@2.1.8: Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies.
+npm WARN deprecated fsevents@1.2.13: fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.
+npm WARN deprecated webdriverio@4.14.4: outdated version, please use @next
+npm WARN deprecated mkdirp@0.3.5: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)
+npm WARN deprecated cross-spawn-async@1.0.1: cross-spawn no longer requires a build toolchain, use it instead
+npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
+npm WARN deprecated core-js@2.6.12: core-js@<3.3 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Please, upgrade your dependencies to the actual version of core-js.
+npm WARN deprecated har-validator@5.1.5: this library is no longer supported
+npm WARN deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
+npm WARN deprecated querystring@0.2.0: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
+npm WARN deprecated sane@4.1.0: some dependency vulnerabilities fixed, support for node < 10 dropped, and newer ECMAScript syntax/features added
+npm WARN deprecated request-promise-native@1.0.9: request-promise-native has been deprecated because it extends the now deprecated request package, see https://github.com/request/request/issues/3142
+npm WARN deprecated flatten@1.0.3: flatten is deprecated in favor of utility frameworks such as lodash.
+npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@^1.2.7 (node_modules/chokidar/node_modules/fsevents):
+npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.13: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
+npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@^2.1.2 (node_modules/jest-haste-map/node_modules/fsevents):
+npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.3.2: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
+npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@~2.3.2 (node_modules/nodemon/node_modules/chokidar/node_modules/fsevents):
+npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.3.2: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
+npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@~2.3.2 (node_modules/watchpack/node_modules/chokidar/node_modules/fsevents):
+npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.3.2: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
+npm WARN check2@1.0.0 No description
+npm WARN check2@1.0.0 No repository field.
+
++ @zohodesk/react-cli@0.0.1-beta.165
+updated 1 package and audited 1899 packages in 51.509s
+
+21 packages are looking for funding
+  run `npm fund` for details
+
+found 42 vulnerabilities (2 low, 20 moderate, 8 high, 12 critical)
+  run `npm audit fix` to fix them, or `npm audit` for details

package/files/eslintrc.js

@@ -1,62 +1,62 @@
-const [off, , error] = ['off', 'warn', 'error'];
-
-module.exports = {
-  env: {
-    browser: true,
-    es2021: true,
-  },
-  extends: [
-    'plugin:react/recommended',
-    'plugin:react-hooks/recommended',
-    'airbnb',
-    'prettier',
-  ],
-  parserOptions: {
-    ecmaFeatures: {
-      jsx: true,
-    },
-    ecmaVersion: 12,
-    sourceType: 'module',
-  },
-  plugins: [
-    'react',
-    'css-modules',
-    '@zohodesk/zsecurity',
-    '@zohodesk/react-performance',
-  ],
-  rules: {
-    // Internal Rules
-    '@zohodesk/react-performance/no-ref-mapstatetoprops': error,
-    '@zohodesk/zsecurity/no-unsecure-html': error,
-    '@zohodesk/zsecurity/no-protocol-check': error,
-
-    // CSS Module Rules
-    'css-modules/no-unused-class': [error, { camelCase: true }],
-    'css-modules/no-undef-class': [error, { camelCase: 'only' }],
-
-    'import/no-unresolved': off,
-    'import/no-extraneous-dependencies': off,
-
-    // As redux used
-    'no-shadow': off, // As we import the action files and use the same name in getting from props built from connect.
-    'react/jsx-filename-extension': off,
-
-    // As we don't follow
-    'react/require-default-props': off,
-    'react/jsx-props-no-spreading': off,
-
-    // As we didn't update
-    'react/jsx-fragments': off,
-
-    // Not needed
-    'no-plusplus': off,
-    'no-unused-expressions': [
-      error,
-      {
-        allowShortCircuit: true,
-        allowTernary: true,
-      },
-    ],
-    'react/jsx-no-target-blank': error,
-  },
-};
+const [off, , error] = ['off', 'warn', 'error'];
+
+module.exports = {
+  env: {
+    browser: true,
+    es2021: true,
+  },
+  extends: [
+    'plugin:react/recommended',
+    'plugin:react-hooks/recommended',
+    'airbnb',
+    'prettier',
+  ],
+  parserOptions: {
+    ecmaFeatures: {
+      jsx: true,
+    },
+    ecmaVersion: 12,
+    sourceType: 'module',
+  },
+  plugins: [
+    'react',
+    'css-modules',
+    '@zohodesk/zsecurity',
+    '@zohodesk/react-performance',
+  ],
+  rules: {
+    // Internal Rules
+    '@zohodesk/react-performance/no-ref-mapstatetoprops': error,
+    '@zohodesk/zsecurity/no-unsecure-html': error,
+    '@zohodesk/zsecurity/no-protocol-check': error,
+
+    // CSS Module Rules
+    'css-modules/no-unused-class': [error, { camelCase: true }],
+    'css-modules/no-undef-class': [error, { camelCase: 'only' }],
+
+    'import/no-unresolved': off,
+    'import/no-extraneous-dependencies': off,
+
+    // As redux used
+    'no-shadow': off, // As we import the action files and use the same name in getting from props built from connect.
+    'react/jsx-filename-extension': off,
+
+    // As we don't follow
+    'react/require-default-props': off,
+    'react/jsx-props-no-spreading': off,
+
+    // As we didn't update
+    'react/jsx-fragments': off,
+
+    // Not needed
+    'no-plusplus': off,
+    'no-unused-expressions': [
+      error,
+      {
+        allowShortCircuit: true,
+        allowTernary: true,
+      },
+    ],
+    'react/jsx-no-target-blank': error,
+  },
+};

package/files/prettierrc.js

@@ -1,3 +1,3 @@
-module.exports = {
-  trailingComma: 'none',
-};
+module.exports = {
+  trailingComma: 'none',
+};

package/lib/common/splitChunks.js

@@ -22,15 +22,20 @@ let {
   app: {
     vendorExclude,
     customChunks,
-    vendorInclude
+    vendorInclude,
+    effectiveChunkSplitting
   }
 } = options;
+let reactBundle = ['react', 'react-dom', 'react-redux', 'react-transition-group', 'scheduler', // what is scheduler
+'prop-types', // why protypes needed
+'use-subscription' // 'what is it'
+];
 
 let isVendor = function isVendor(module) {
   let {
     userRequest
   } = module;
-  let excludeList = ['script-loader', 'raw-loader', 'react', 'react-dom'];
+  let excludeList = ['script-loader', 'raw-loader', ...reactBundle];
   excludeList = [...excludeList, ...vendorExclude];
   return userRequest && (vendorInclude.some(item => userRequest.indexOf(item) !== -1) || userRequest.indexOf('node_modules') >= 0 && userRequest.endsWith('.css') === false && userRequest.endsWith('publicPathConfig.js') === false && excludeList.every(item => userRequest.indexOf(`node_modules${ps}${item}${ps}`) === -1));
 };
@@ -39,11 +44,13 @@ let isReact = module => {
   let {
     userRequest
   } = module;
-  let reactBundle = ['react', 'react-dom'];
   return userRequest && reactBundle.some(pkg => userRequest.indexOf(`node_modules${ps}${pkg}${ps}`) >= 0);
 };
 
-let defaultChunks = {
+let baseSplitChunkConfig = {
+  minSize: 12000
+};
+let specificCacheGroupConfig = {
   'react.vendor': {
     name: 'react.vendor',
     chunks: 'all',
@@ -116,11 +123,21 @@ customChunks.map((obj, index) => ({
 
   return customChunksConfig[name] = obj;
 });
-var _default = {
-  minSize: 12000,
+const isEnableChunkSplitting = effectiveChunkSplitting.enable;
+
+if (isEnableChunkSplitting) {
+  const config = require(_path.default.join(process.cwd(), effectiveChunkSplitting.configFilePath));
+
+  console.log('config', config);
+  specificCacheGroupConfig = Object.assign(specificCacheGroupConfig, config.getAdditionalCacheGroupConfig());
+  baseSplitChunkConfig = Object.assign(baseSplitChunkConfig, config.getAdditionalBaseChunkSplitConfig());
+}
+
+const splitChunkConfig = { ...baseSplitChunkConfig,
   cacheGroups: Object.assign({
     default: false,
     vendors: false
-  }, defaultChunks, customChunksConfig)
+  }, specificCacheGroupConfig, customChunksConfig)
 };
+var _default = splitChunkConfig;
 exports.default = _default;

package/lib/configs/webpack.css.umd.config.js

@@ -67,10 +67,10 @@ module.exports = {
       }],
       include: _path.default.join(appPath, 'src')
     }
-    /*,
-    {
-    test: /\.css$/,
-    use: [MiniCssExtractPlugin.loader, 'css-loader']
+    /*,
+    {
+    test: /\.css$/,
+    use: [MiniCssExtractPlugin.loader, 'css-loader']
     }*/
     , {
       test: /(\.module)?\.css$/,

package/lib/loaderUtils/configsAssetsLoaders.js

@@ -79,39 +79,39 @@ function createNameTemplate(enableChunkHash) {
   const ext = `${enableChunkHash ? '.[hash:20]' : ''}.[ext]`;
   return `[name]${ext}`;
 }
-/*
-export function createImageAndFontsAndSVGLoaders(enableChunkHash) {
-  const nameTemplate = createNameTemplate(enableChunkHash);
-  return [
-    configImageLoader(nameTemplate),
-    configFontLoader(nameTemplate),
-    configSVGLoader(nameTemplate),
-    configAudioLoader(nameTemplate)
-  ];
-}
+/*
+export function createImageAndFontsAndSVGLoaders(enableChunkHash) {
+  const nameTemplate = createNameTemplate(enableChunkHash);
+  return [
+    configImageLoader(nameTemplate),
+    configFontLoader(nameTemplate),
+    configSVGLoader(nameTemplate),
+    configAudioLoader(nameTemplate)
+  ];
+}
 */
 
-/*
-export function createLoaderOptionObject(
-  loaderName,
-  nameTemplate,
-  fallback,
-  limit = 1000
-) {
-  return {
-    loader: loaderName,
-    options: {
-      limit,
-      name: nameTemplate,
-      fallback
-    }
-  };
-}
-
-function configLoaderObject(filter, loaderAndOptions) {
-  return {
-    test: filter,
-    use: loaderAndOptions
-  };
-}
+/*
+export function createLoaderOptionObject(
+  loaderName,
+  nameTemplate,
+  fallback,
+  limit = 1000
+) {
+  return {
+    loader: loaderName,
+    options: {
+      limit,
+      name: nameTemplate,
+      fallback
+    }
+  };
+}
+
+function configLoaderObject(filter, loaderAndOptions) {
+  return {
+    test: filter,
+    use: loaderAndOptions
+  };
+}
 */

package/lib/loaderUtils/getCSSLoaders.js

@@ -62,7 +62,10 @@ const getCSSLoaders = optionsObj => {
 
       return `${prefix} ${selector}`; // Make selectors like [dir=rtl] > .selector
     }
-  }), plugins.combinerMediaQuery && require('postcss-combine-media-query')(), plugins.hoverActive && require('../postcss-plugins/hoverActivePlugin')(mediaQueryHoverActiveString), plugins.cssVariableReplacement && fs.existsSync(cssVariableReplacementConfig) && require('../postcss-plugins/variableModificationPlugin/index').plugin(cssVariableReplacementConfig)].filter(Boolean);
+  }), plugins.combinerMediaQuery && require('postcss-combine-media-query')(), plugins.hoverActive && require('../postcss-plugins/hoverActivePlugin')(mediaQueryHoverActiveString), plugins.cssVariableReplacement && fs.existsSync(cssVariableReplacementConfig) && require('../postcss-plugins/variableModificationPlugin/index').plugin(cssVariableReplacementConfig) // ,
+  // plugins.composeMinification &&
+  //   require('../postcss-plugins/composePlugin')()
+  ].filter(Boolean);
   return [cssSelectorZipPath && {
     loader: require.resolve('../loaders/selectorMappingLoader')
   }, {
@@ -86,56 +89,56 @@ const getCSSLoaders = optionsObj => {
         // console.log('check here : ', params.resourcePath);
         // getCSSLoaders for all postcss filtering
 
-        /*
-        input : 
-        params.resourcePath : 'D:/MyWork/..../desk_client_app/supportapp/src/components/Avatar/Avatar.module.css,
-        patterns : [
-            // include all files
-           "valueReplacer": [ 
-              "*"
-            ],
-            // include all files
-            "selectorReplace": [
-              "*"
-            ],
-            // include src folder, include deskapp folder, exclude node modules
-            "hoverActive": [
-              "src",
-              "deskapp",
-              "!node_modules"
-            ],
-            // include src folder, include deskapp folder, exclude node modules
-            "combinerMediaQuery": [
-              "src",
-              "deskapp",
-              "!node_modules"
-            ],
-            // include src folder, include deskapp folder, exclude node modules
-            "hasRTL": [
-              "src",
-              "deskapp",
-              "!node_modules"
-            ],
-            // include src folder, include deskapp folder, exclude node modules
-            "cssVariableReplacement": [
-              "src",
-              "deskapp",
-              "!node_modules"
-            ],
-            // include src folder, include deskapp folder, exclude node modules
-            "selectorWeight": [
-              "src",
-              "deskapp",
-              "!node_modules"
-            ],
-            // include all files
-            "cssUniqueness": [
-              "*"
-            ]
-        ],
-        
-        [ postcssPlugins that are implemented ]
-          */
+        /*
+        input : 
+        params.resourcePath : 'D:/MyWork/..../desk_client_app/supportapp/src/components/Avatar/Avatar.module.css,
+        patterns : [
+            // include all files
+           "valueReplacer": [ 
+              "*"
+            ],
+            // include all files
+            "selectorReplace": [
+              "*"
+            ],
+            // include src folder, include deskapp folder, exclude node modules
+            "hoverActive": [
+              "src",
+              "deskapp",
+              "!node_modules"
+            ],
+            // include src folder, include deskapp folder, exclude node modules
+            "combinerMediaQuery": [
+              "src",
+              "deskapp",
+              "!node_modules"
+            ],
+            // include src folder, include deskapp folder, exclude node modules
+            "hasRTL": [
+              "src",
+              "deskapp",
+              "!node_modules"
+            ],
+            // include src folder, include deskapp folder, exclude node modules
+            "cssVariableReplacement": [
+              "src",
+              "deskapp",
+              "!node_modules"
+            ],
+            // include src folder, include deskapp folder, exclude node modules
+            "selectorWeight": [
+              "src",
+              "deskapp",
+              "!node_modules"
+            ],
+            // include all files
+            "cssUniqueness": [
+              "*"
+            ]
+        ],
+        
+        [ postcssPlugins that are implemented ]
+            */
         //  console.log(params.resourcePath);
         //  console.log(postcssPlugins);
         const finalpostcssPlugins = (0, _fileHandling.isFileNameMatchingPattern)({