@zohodesk/react-cli 1.1.4-exp.2 → 1.1.5

package/lib/plugins/I18nSplitPlugin/index.js

@@ -21,23 +21,23 @@ function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { de
 
 // #region initial
 
-/**
- * @TODO:
- *  [?] add comment line options for properties file and get all keys form property file do right way to genarate them
- *  [?] need to discuss with collectI18n Keys with js comment need to conform "what is the comment? "
+/**
+ * @TODO:
+ *  [?] add comment line options for properties file and get all keys form property file do right way to genarate them
+ *  [?] need to discuss with collectI18n Keys with js comment need to conform "what is the comment? "
  */
 
-/**
- * Notes: this plugin has done below works
- *  1. collect I18n Keys from js files and make it as Depenencies
- *  2. we create file(asset) for chunk specific i18nChunk Files
- *  3. create hash for the specific i18nChunk Files
- *  4. write logic to requireEnsure method for dowlod I18n chunk download dynamicaly
- *  5. create manifest.json file which has the mapping of  chunk-locales-i18nChunkFile
- *       for the external referrece.
- * Hints :-
- *   - file  means your machine files
- *   - asset means that also  file but that will create by webpack after build
+/**
+ * Notes: this plugin has done below works
+ *  1. collect I18n Keys from js files and make it as Depenencies
+ *  2. we create file(asset) for chunk specific i18nChunk Files
+ *  3. create hash for the specific i18nChunk Files
+ *  4. write logic to requireEnsure method for dowlod I18n chunk download dynamicaly
+ *  5. create manifest.json file which has the mapping of  chunk-locales-i18nChunkFile
+ *       for the external referrece.
+ * Hints :-
+ *   - file  means your machine files
+ *   - asset means that also  file but that will create by webpack after build
  */
 // const getI18nLocales = require('./utils/getI18nLocales');
 // const { ConcatSource, SourceMapSource, OriginalSource } = sources;
@@ -49,16 +49,16 @@ const MODULE_TYPE = 'json/i18n';
 const i18ntype = locale => `${MODULE_TYPE}/${locale}`;
 
 const pluginName = 'i18n-plugin';
-/**
- * @typedef I18nPluginOptions
- * @property {String} filenameTemplate this was template for i18n chunk
- * @property {String} jsResource this was path for jsResource i18n file
- * @property {String} propertiesFolder this was path for propertiesFolder i18n file
- * @property {Boolean} disableDefault this option for disable defulat value  for i18n keys, means if the language file does not have some key we don't give jsResource value
- * @property {String} i18nManifestFileName this was ouput path for i18n manifest.
- * @property {String} jsonpFunc this was function name, we will  call  that function everytime i18n chunk download.
- * @property {String} localeVarName this was variable name, we will call that function everytime i18n chunk download.
- * 
+/**
+ * @typedef I18nPluginOptions
+ * @property {String} filenameTemplate this was template for i18n chunk
+ * @property {String} jsResource this was path for jsResource i18n file
+ * @property {String} propertiesFolder this was path for propertiesFolder i18n file
+ * @property {Boolean} disableDefault this option for disable defulat value  for i18n keys, means if the language file does not have some key we don't give jsResource value
+ * @property {String} i18nManifestFileName this was ouput path for i18n manifest.
+ * @property {String} jsonpFunc this was function name, we will  call  that function everytime i18n chunk download.
+ * @property {String} localeVarName this was variable name, we will call that function everytime i18n chunk download.
+ * 
  */
 
 class I18nPlugin {
@@ -104,13 +104,13 @@ class I18nPlugin {
   }
 
   maintainHashForAllI18nAssets(compilation) {
-    /**
-     * we write chunkHash logic inside of our plugin Because we only add Dependency not Module.
-     *  So we need to update chunkHash for our assets
-     *  and we not able tell with just Modules.
-     *  Because, if we add Module for the Depenentcy then that module must has some hash.
-     *  But our I18n Hash is no module specific it was chunk specific,
-     *  that's why we do the stuf in the chunkHash hook.
+    /**
+     * we write chunkHash logic inside of our plugin Because we only add Dependency not Module.
+     *  So we need to update chunkHash for our assets
+     *  and we not able tell with just Modules.
+     *  Because, if we add Module for the Depenentcy then that module must has some hash.
+     *  But our I18n Hash is no module specific it was chunk specific,
+     *  that's why we do the stuf in the chunkHash hook.
      */
     compilation.hooks.chunkHash.tap(pluginName, (chunk, chunkHash) => {
       const {
@@ -154,31 +154,31 @@ class I18nPlugin {
   }
 
 }
-/*
-        // TODO:  need to reimplement this logic
-        // NOTE:  this logic for split all content hash per mani chunk
-        // like add chunk content hash to  main locale i18n file
-
-        // let isEntry = chunk.name === this.options.mainChunkName;
-        // if (chunk.name === 'main' && chunk.hasEntryModule()) {
-        if (isEntry) {
-          const hashSource = new ConcatSource();
-        const dummyChunk = new chunk.constructor();
-          hashSource.add('// it wil be I18N file hash');
-          const templateHooks = compilation.chunkTemplate.hooks;
-          let c = templateHooks.render.call(
-            templateHooks.module.call(
-              hashSource,
-              dummyChunk,
-              compilation.moduleTemplate.javascript,
-              compilation.dependencyTemplates
-            ),
-            dummyChunk,
-            compilation.moduleTemplate.javascript,
-            compilation.dependencyTemplates
-          );
-          
-        }
+/*
+        // TODO:  need to reimplement this logic
+        // NOTE:  this logic for split all content hash per mani chunk
+        // like add chunk content hash to  main locale i18n file
+
+        // let isEntry = chunk.name === this.options.mainChunkName;
+        // if (chunk.name === 'main' && chunk.hasEntryModule()) {
+        if (isEntry) {
+          const hashSource = new ConcatSource();
+        const dummyChunk = new chunk.constructor();
+          hashSource.add('// it wil be I18N file hash');
+          const templateHooks = compilation.chunkTemplate.hooks;
+          let c = templateHooks.render.call(
+            templateHooks.module.call(
+              hashSource,
+              dummyChunk,
+              compilation.moduleTemplate.javascript,
+              compilation.dependencyTemplates
+            ),
+            dummyChunk,
+            compilation.moduleTemplate.javascript,
+            compilation.dependencyTemplates
+          );
+          
+        }
         */
 
 

package/lib/plugins/ResourceHintsPlugin.js

@@ -33,25 +33,25 @@ class ResourceHintsPlugin {
         }
 
         return Template.asString([source, '', `${mainTemplate.requireFn}.getChunkId = function getChunkId(chunkId) {`, Template.indent((needsMap ? [`chunkId = ${JSON.stringify(nameIdMap)}[chunkId]||chunkId;`] : []).concat(['return chunkId;'])), '}', `// Prefetch a chunk (${pluginName})`, `${mainTemplate.requireFn}.pfc = function prefetchChunk(chunkId) {`, Template.indent([`chunkId = ${mainTemplate.requireFn}.getChunkId(chunkId)`, `${mainTemplate.requireFn}.e(chunkId);`]), '};',
-        /*
-          (needsMap
-            ? [`chunkId = ${JSON.stringify(nameIdMap)}[chunkId]||chunkId;`]
-            : []
-          ).concat([
-            'var promises = [];',
-            'if(installedChunks[chunkId] === undefined) {',
-            Template.indent([
-              'installedChunks[chunkId] = null;',
-              /* mainTemplate.hooks.linkPrefetch.call('', chunk, hash),
+        /*
+          (needsMap
+            ? [`chunkId = ${JSON.stringify(nameIdMap)}[chunkId]||chunkId;`]
+            : []
+          ).concat([
+            'var promises = [];',
+            'if(installedChunks[chunkId] === undefined) {',
+            Template.indent([
+              'installedChunks[chunkId] = null;',
+              /* mainTemplate.hooks.linkPrefetch.call('', chunk, hash),
               'document.head.appendChild(link);', */
 
-        /*
-              mainTemplate.hooks.requireEnsure.call('', chunk, hash)
-            ]),
-            '}'
-          ])
-        ),
-        '}',
+        /*
+              mainTemplate.hooks.requireEnsure.call('', chunk, hash)
+            ]),
+            '}'
+          ])
+        ),
+        '}',
         */
         `// Preload a chunk (${pluginName})`, `${mainTemplate.requireFn}.plc = function preloadChunk(chunkId) {`, Template.indent([`chunkId = ${mainTemplate.requireFn}.getChunkId(chunkId)`, 'if(installedChunks[chunkId] === undefined) {', Template.indent(['installedChunks[chunkId] = null;', mainTemplate.hooks.linkPreload.call('', chunk, hash), 'document.head.appendChild(link);', `${mainTemplate.requireFn}.e(chunkId);` // 'var head = document.getElementsByTagName(\'head\')[0];',
         // mainTemplate.hooks.jsonpScript.call('', chunk, hash),

package/lib/plugins/RtlSplitPlugin/RtlCssPlugin.js

@@ -24,12 +24,12 @@ const isCss = filename => _path.default.extname(filename) === '.css'; // this  p
 
 class RtlCssPlugin {
   constructor(options = {}) {
-    /**
-     * @typedef {Object} Options
-     * @property  {String} filename [not used]
-     * @property  {String} dirVarName
-     * @property  {Boolean} sourcemap
-     * @property  {Object} config
+    /**
+     * @typedef {Object} Options
+     * @property  {String} filename [not used]
+     * @property  {String} dirVarName
+     * @property  {Boolean} sourcemap
+     * @property  {Object} config
      */
     this.options = {
       filename: options.filename || '[name].rtl.css',

package/lib/plugins/RtlSplitPlugin/RtrSplit.md

@@ -1,30 +1,30 @@
-# RTL Split 
-
-we are doing in build time generating  rtl related css code  by using @zohodesk/postcss-rt npm.
-It was automated, That postcss plugin create rtl reacted css and put them into same file, with css selector [dir=rtl] and ltr realted css with [dir=ltr].
-Here is problem mostly no one need rtl and ltr related css at the same time in browser, 
-we are try to split them  by [dir] and load which type of css is needed.
-For this purpose  we created RTL Split Plugin 
-
-
-# To Try it  out  rtl-ltr split
-### how to use this feature?
-
-  to use this feature use have give the below oprtions
-  `package.json`
-  ```json
-  {
-    /// ...some things
-    "react-cli": {
-      //  ...some things
-      "css": {
-        "enableRTLSplit": true,
-        "templateLabel": "{{--dir}}",// this is for html template css file path dir template
-        "disableMiniFiySelector": false,
-        "dirVarName": "document.dir" // this will be used for download css based on dir  
-      },
-      //  ...some things
-    }
-  }
-  ```
-
+# RTL Split 
+
+we are doing in build time generating  rtl related css code  by using @zohodesk/postcss-rt npm.
+It was automated, That postcss plugin create rtl reacted css and put them into same file, with css selector [dir=rtl] and ltr realted css with [dir=ltr].
+Here is problem mostly no one need rtl and ltr related css at the same time in browser, 
+we are try to split them  by [dir] and load which type of css is needed.
+For this purpose  we created RTL Split Plugin 
+
+
+# To Try it  out  rtl-ltr split
+### how to use this feature?
+
+  to use this feature use have give the below oprtions
+  `package.json`
+  ```json
+  {
+    /// ...some things
+    "react-cli": {
+      //  ...some things
+      "css": {
+        "enableRTLSplit": true,
+        "templateLabel": "{{--dir}}",// this is for html template css file path dir template
+        "disableMiniFiySelector": false,
+        "dirVarName": "document.dir" // this will be used for download css based on dir  
+      },
+      //  ...some things
+    }
+  }
+  ```
+

package/lib/plugins/SelectorPlugin.js

@@ -86,20 +86,20 @@ class SelectorPlugin {
           const rootOriginal = _postcss.default.parse(module.content);
 
           const filename = module.issuer.resource;
-          /*
-              input : 
-              filename : 'D:/MyWork/..../desk_client_app/supportapp/src/components/Avatar/Avatar.module.css,
-            
-                patterns.cssVariableReplacement: 
-              // include src folder, include deskapp folder, exclude node modules
-              "selectorWeight": [
-                "src",
-                "deskapp",
-                "!node_modules"
-              ]
-                
-              output : 
-              true or false
+          /*
+              input : 
+              filename : 'D:/MyWork/..../desk_client_app/supportapp/src/components/Avatar/Avatar.module.css,
+            
+               patterns.cssVariableReplacement: 
+              // include src folder, include deskapp folder, exclude node modules
+              "selectorWeight": [
+                "src",
+                "deskapp",
+                "!node_modules"
+              ]
+               
+              output : 
+              true or false
             */
 
           if (!(0, _fileHandling.isFileNameMatchingPluginPattern)({
@@ -108,21 +108,21 @@ class SelectorPlugin {
           })) {
             return;
           }
-          /*
-           
-          filename : Deskapp.module.css ?
-            data : 
-          {
-              "DeskApp.module.css": {"defaultSelector" : ".desk_app_ui "}
-          }
-              selectorWeightConfig : 
-            defaultSelector : .zoho_desk_ui
-          
-          case filename = 'DeskApp.module.css' ? 
-          data[filename].defaultSelector = '.desk_app_ui' 
-            case filename is different ?
-          defaultSelector = '.zoho_desk_ui'
-            */
+          /*
+           
+          filename : Deskapp.module.css ?
+           data : 
+          {
+              "DeskApp.module.css": {"defaultSelector" : ".desk_app_ui "}
+          }
+             selectorWeightConfig : 
+           defaultSelector : .zoho_desk_ui
+          
+          case filename = 'DeskApp.module.css' ? 
+          data[filename].defaultSelector = '.desk_app_ui' 
+           case filename is different ?
+          defaultSelector = '.zoho_desk_ui'
+           */
 
 
           module.content = selectorWeightPrefixAdder(rootOriginal, data[filename] ? data[filename].defaultSelector : defaultSelector, excludeStrings).toString();

package/lib/plugins/ServiceWorkerPlugin.js

@@ -51,11 +51,11 @@ class ServiceWorkerPlugin {
         if (err) {
           throw new Error(err);
         } else {
-          /* const extractedChunks = compilation.chunks.filter(chunk => {
-            if ('canBeInitial' in chunk) {
-              return chunk.canBeInitial();
-            }
-            return chunk.isInitial();
+          /* const extractedChunks = compilation.chunks.filter(chunk => {
+            if ('canBeInitial' in chunk) {
+              return chunk.canBeInitial();
+            }
+            return chunk.isInitial();
           }); */
           // let [js, css, , , i18nPublicPath] = this.publicPaths;
           // let initialChunkUrls = [];
@@ -64,10 +64,10 @@ class ServiceWorkerPlugin {
           let entrypoint = compilation.entrypoints.get('main');
           let initialChunkUrls = entrypoint.getFiles();
           const cssDirTemplate = '@dir@';
-          /**
-           * NOTE:
-           *  if chunkSplitEnable is false means,
-           *    serviceWorker will get i18n files path for html
+          /**
+           * NOTE:
+           *  if chunkSplitEnable is false means,
+           *    serviceWorker will get i18n files path for html
            */
 
           let initalI18nAssets = chunkSplitEnable ? entrypoint.chunks.filter(chunk => _I18nKeysIdentifer.default.isChunkHasI18n(chunk)).map(chunk => (0, _getI18nFileUrlPathTemplate.getI18nFileUrlPathTemplate)(compilation, chunk, this.i18nFileNameTemplate, '@locale@')) : [];

package/lib/plugins/TPHashMappingPlugin.js

@@ -15,10 +15,10 @@ var _crypto = _interopRequireDefault(require("crypto"));
 
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 
-/**
- * Plugin that generates hash for the provided list of third party files
- * Map the provided key with the file hash and add it to the list of exisiting global constants.
- * Plugin in turn uses the defineplugin to generate global constants. 
+/**
+ * Plugin that generates hash for the provided list of third party files
+ * Map the provided key with the file hash and add it to the list of exisiting global constants.
+ * Plugin in turn uses the defineplugin to generate global constants. 
  */
 class TPHashMappingPlugin {
   constructor(options) {

package/lib/plugins/VariableConversionCollector.js

@@ -28,14 +28,14 @@ const {
 
 const supportedProps = ['font-size', 'margin', 'margin-top', 'margin-bottom', 'margin-left', 'margin-right', 'padding', 'padding-top', 'padding-bottom', 'padding-left', 'padding-right', '^top', '^right', '^bottom', '^left', '^width', 'min-width', 'max-width', '^height', 'min-height', 'max-height', 'text-indent', 'clip', 'flex-basis', 'row-gap', 'gap', 'column-gap', 'flex']; // -- to convert the hyphen values to values --
 
-/*
-input : 
-var(--zdt_uploadlist_default_width)
-output : 
---zdt_uploadlist_default_width
-
-comment : 
-to make the variable object using the output as key and decl.prop such as font-size as value 
+/*
+input : 
+var(--zdt_uploadlist_default_width)
+output : 
+--zdt_uploadlist_default_width
+
+comment : 
+to make the variable object using the output as key and decl.prop such as font-size as value 
 */
 
 function createFolderIfNonExistant(path) {
@@ -95,13 +95,13 @@ class VariableConversionCollector {
         }
       };
     }
-    /* 
-    purpose of tap : to create a variable object such as:
-    {
-      --zdt_uploadlist_default_width : width,
-      --zdt_uploadlist_default_height : height,
-    }
-    which will help in the conversion further
+    /* 
+    purpose of tap : to create a variable object such as:
+    {
+      --zdt_uploadlist_default_width : width,
+      --zdt_uploadlist_default_height : height,
+    }
+    which will help in the conversion further
     */
 
 
@@ -153,19 +153,19 @@ class VariableConversionCollector {
                 });
               });
             });
-            /*
-             current value example: 
-             {
-                --zdt_uploadlist_default_width : --zd_upload_width,
-                --zd_upload_width : width
-             }
-             expected value : 
-             {
-               --zdt_uploadlist_default_width : width,
-               --zd_upload_width : width
-             }
-            
-             conversion is done in the while loop below
+            /*
+             current value example: 
+             {
+                --zdt_uploadlist_default_width : --zd_upload_width,
+                --zd_upload_width : width
+             }
+             expected value : 
+             {
+               --zdt_uploadlist_default_width : width,
+               --zd_upload_width : width
+             }
+            
+             conversion is done in the while loop below
             */
 
             Object.keys(variables).forEach(key => {
@@ -177,37 +177,37 @@ class VariableConversionCollector {
         });
       }); // -- conversion for the root using variableConvertor --
 
-      /* 
-      input : 
-      .a{
-        padding : 20px 
-      }
-      output :
-      // on settingObject file : 
-      { padding : { replacements : { px : 'zd_size$$' }}} 
-      .a{
-        padding : zd_size20;
-      }
+      /* 
+      input : 
+      .a{
+        padding : 20px 
+      }
+      output :
+      // on settingObject file : 
+      { padding : { replacements : { px : 'zd_size$$' }}} 
+      .a{
+        padding : zd_size20;
+      }
       */
 
       compilation.hooks.optimizeModules.tap('VariableConversionCollector', modules => {
         const mods = modules.filter(x => x.type.includes('css'));
         mods.forEach(module => {
           const filename = module.issuer.resource;
-          /*
-            input : 
-            filename : 'D:/MyWork/..../desk_client_app/supportapp/src/components/Avatar/Avatar.module.css,
-          
-              patterns.cssVariableReplacement: 
-            // include src folder, include deskapp folder, exclude node modules
-            "cssVariableReplacement": [
-              "src",
-              "deskapp",
-              "!node_modules"
-            ]
-              
-            output : 
-            true or false
+          /*
+            input : 
+            filename : 'D:/MyWork/..../desk_client_app/supportapp/src/components/Avatar/Avatar.module.css,
+          
+             patterns.cssVariableReplacement: 
+            // include src folder, include deskapp folder, exclude node modules
+            "cssVariableReplacement": [
+              "src",
+              "deskapp",
+              "!node_modules"
+            ]
+             
+            output : 
+            true or false
           */
 
           if (!(0, _fileHandling.isFileNameMatchingPluginPattern)({
@@ -223,12 +223,12 @@ class VariableConversionCollector {
         });
       });
     });
-    /*
-      purpose of tap : to display the errors encountered so far 
-      input : 
-      all css files 
-      output : 
-      all errors that are present in the errTable arr
+    /*
+      purpose of tap : to display the errors encountered so far 
+      input : 
+      all css files 
+      output : 
+      all errors that are present in the errTable arr
     */
 
     compiler.hooks.afterEmit.tap('error-display', () => {

package/lib/plugins/utils/fileHandling.js

@@ -23,10 +23,10 @@ let aliasNames = {
   cssVariableReplacement: 'postcss-variable-report',
   composeMinification: 'postcss-compose-plugin'
 };
-/*
-
-unique scenario
-
+/*
+
+unique scenario
+
 */
 // export function filterFileCssUniqueness(filename, filterObj) {
 //   let rootDir = 'supportapp';
@@ -50,34 +50,20 @@ function isFileNameMatchingPattern({
   filterObject,
   plugins
 }) {
-  const finalPlugins = []; // console.log(rootDir);
-  // const regex = `^(.+?)${rootDir}?\\\\`;
-
-  const newFilename = path.relative(path.parse(process.cwd()).base, filename); //windowsModificationFile(filename).replace(
-  //   new RegExp(regex, 'gi'),
-  //   ''
-  // );
-  // path.relative('supportapp', 'd:\')
-
+  const finalPlugins = [];
   Object.keys(filterObject).forEach(key => {
     plugins.forEach(x => {
-      // console.log(key, x.postcssPlugin);
       if (aliasNames[key] === x.postcssPlugin) {
         const ig = (0, _ignore.default)({
           allowRelativePaths: true
-        }).add(filterObject[key]); // console.log(key, filterObject[key], ig);
+        }).add(filterObject[key]);
 
-        if (ig.ignores(newFilename)) {
-          // console.log(newFilename);
+        if (ig.ignores(filename)) {
           finalPlugins.push(x);
         }
       }
     });
   }); // console.log(filename);
-  // console.log(finalPlugins);
-  // console.log(
-  //   '----------------------------------------------------------------------'
-  // );
 
   return finalPlugins; // console.log(filename, filterObject);
 }

package/lib/plugins/variableConvertorUtils.js

@@ -12,15 +12,15 @@ var _classHandling = require("./utils/classHandling");
 const ignoreVals = ['--zd_size', '--zd_font_size', '--size', '--size_']; // const avoidProps = [];
 // -- is issue IO --
 
-/*
-issues eg : 
-issues = ['--zd_size', '--zd_font_size', '--size', '--size_'];
-input : 
---zd_size
-output : 
-true
-comment : 
-do not execute when --zd_size comes as prop 
+/*
+issues eg : 
+issues = ['--zd_size', '--zd_font_size', '--size', '--size_'];
+input : 
+--zd_size
+output : 
+true
+comment : 
+do not execute when --zd_size comes as prop 
 */
 
 exports.ignoreVals = ignoreVals;

package/lib/postcss-plugins/RTLSplitPlugin.js

@@ -37,11 +37,11 @@ function selectorMinifySameDir(selector, direction) {
   const regex = getRegex(direction);
   return selector.replace(regex, '').trim();
 }
-/**
- * this funtion will remove given rule,
- *  if given selector and it's previous sibiling rule selector  are same
- * current rule properties will move to previous sibiling rule.
- * @param {Rule} rule current rule
+/**
+ * this funtion will remove given rule,
+ *  if given selector and it's previous sibiling rule selector  are same
+ * current rule properties will move to previous sibiling rule.
+ * @param {Rule} rule current rule
  */
 
 
@@ -56,11 +56,11 @@ function mergeIfSameSelector(rule) {
     rule.remove();
   }
 }
-/**
- * this funtion will remove given rule,
- *  if given selector and it's previous sibiling rule selector  are same
- * current rule properties will move to previous sibiling rule.
- * @param {Rule} rule current rule
+/**
+ * this funtion will remove given rule,
+ *  if given selector and it's previous sibiling rule selector  are same
+ * current rule properties will move to previous sibiling rule.
+ * @param {Rule} rule current rule
  */