@zohodesk/react-cli 1.1.20 → 1.1.22-exp.1

package/README.md

@@ -44,7 +44,44 @@ Now to run app
 
 # Change Logs
 
-# 1.1.19 (27-5-2024)
+# 1.1.21 (4-6-2024)
+
+- TypeScript support has been added for the application, library, and Jest.
+
+- The `enable_typescript` option has been added in the react-cli.config.js. Set it to true to enable TypeScript
+
+- Support for adding plugins is now available. To use this, configure your react-cli.config.js file as follows:
+
+   ```
+      babelCustomizationForLibrary: {
+        babelPlugins: [<`your plugins`>]
+      },
+   ```
+- The Memory leak issue while downloading i18n and CSS files has been fixed
+
+
+# 1.1.20-exp.1
+
+**Changes**
+
+- Added memory leak fixes for script, links tags
+
+**Feature**
+- Custom Script loading strategy support for initial html script tags.
+
+# 1.1.19-exp.18
+
+**Changes**
+
+- To do further build size optimization by utilizing webpack provided config.
+
+```
+  innerGraph: true,
+  usedExports: true,
+  sideEffects: true
+```
+
+# 1.1.20 (27-5-2024)
 
 **Feature**
 

package/bin/cli.js

@@ -300,6 +300,8 @@ switch (option) {
         'src',
         '-d',
         'lib',
+        '--extensions',
+        '.js,.ts,.tsx',
         `--presets=${require.resolve('../lib/babel/cmjs-plugins-presets.js')}`,
         '--copy-files'
       ].concat(args),
@@ -316,6 +318,8 @@ switch (option) {
         'src',
         '--out-dir',
         'es',
+        '--extensions',
+        '.js,.ts,.tsx',
         `--presets=${require.resolve('../lib/babel/es-plugins-presets.js')}`,
         '--copy-files'
       ].concat(args),

package/lib/babel/cmjs-plugins-presets.js

@@ -11,20 +11,35 @@ var _babelPresetReactOption = _interopRequireDefault(require("./babel-option-uti
 
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 
-let {
+const {
   module: {
     mode
-  }
+  },
+  babelCustomizationForLibrary: {
+    babelPlugins
+  },
+  enableTypeScript
 } = (0, _utils.getOptions)();
-let isProd = mode.toLowerCase() === 'prod';
+const isProd = mode.toLowerCase() === 'prod';
+const defaultPlugins = [[require.resolve('babel-plugin-transform-define'), isProd ? {
+  __DOCS__: false
+} : {}], require.resolve('@babel/plugin-syntax-dynamic-import')];
+const resolvedPlugins = [];
+babelPlugins.forEach(plugin => {
+  resolvedPlugins.push(require.resolve(plugin));
+});
+const plugins = [...defaultPlugins, ...resolvedPlugins];
+const presets = [require.resolve('@babel/preset-env'), (0, _babelPresetReactOption.default)({
+  disableES5Transpile: false
+})];
+
+if (enableTypeScript) {
+  presets.push(require.resolve('@babel/preset-typescript'));
+}
 
 var _default = () => ({
-  presets: [require.resolve('@babel/preset-env'), (0, _babelPresetReactOption.default)({
-    disableES5Transpile: false
-  })],
-  plugins: [[require.resolve('babel-plugin-transform-define'), isProd ? {
-    __DOCS__: false
-  } : {}]]
+  presets: presets,
+  plugins: plugins
 });
 
 exports.default = _default;

package/lib/babel/es-plugins-presets.js

@@ -11,30 +11,45 @@ var _babelPresetReactOption = _interopRequireDefault(require("./babel-option-uti
 
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 
-let {
+const {
   module: {
     mode,
     disableES5Transpile
-  }
+  },
+  babelCustomizationForLibrary: {
+    babelPlugins
+  },
+  enableTypeScript
 } = (0, _utils.getOptions)();
-let isProd = mode.toLowerCase() === 'prod';
+const isProd = mode.toLowerCase() === 'prod';
+const defaultPlugins = [[require.resolve('babel-plugin-transform-define'), isProd ? {
+  __DOCS__: false
+} : {}], require.resolve('@babel/plugin-syntax-dynamic-import')];
+const resolvedPlugins = [];
+babelPlugins.forEach(plugin => {
+  resolvedPlugins.push(require.resolve(plugin));
+});
+const plugins = [...defaultPlugins, ...resolvedPlugins];
+const presets = [[require.resolve('@babel/preset-env'), disableES5Transpile ? {
+  modules: false,
+  useBuiltIns: 'usage',
+  corejs: 3,
+  targets: {
+    browsers: ['last 3 Chrome versions', 'last 3 Firefox versions', 'last 3 Edge versions', 'last 3 Safari versions']
+  }
+} : {
+  modules: false
+}], (0, _babelPresetReactOption.default)({
+  disableES5Transpile
+})];
+
+if (enableTypeScript) {
+  presets.push(require.resolve('@babel/preset-typescript'));
+}
 
 var _default = () => ({
-  presets: [[require.resolve('@babel/preset-env'), disableES5Transpile ? {
-    modules: false,
-    useBuiltIns: 'usage',
-    corejs: 3,
-    targets: {
-      browsers: ['last 3 Chrome versions', 'last 3 Firefox versions', 'last 3 Edge versions', 'last 3 Safari versions']
-    }
-  } : {
-    modules: false
-  }], (0, _babelPresetReactOption.default)({
-    disableES5Transpile
-  })],
-  plugins: [[require.resolve('babel-plugin-transform-define'), isProd ? {
-    __DOCS__: false
-  } : {}], require.resolve('@babel/plugin-syntax-dynamic-import')]
+  presets: presets,
+  plugins: plugins
 });
 
 exports.default = _default;

package/lib/configs/jest.config.js

@@ -17,7 +17,7 @@ const commonConfig = {
   collectCoverage: true,
   moduleDirectories: [_path.default.resolve(__dirname, '..', '..', 'node_modules'), 'node_modules'],
   transform: {
-    '^.+\\.(js|jsx)$': _path.default.resolve(__dirname, '..', 'jest', 'preProcessors', 'jsPreprocessor.js'),
+    '^.+\\.(js|jsx|ts|tsx)$': _path.default.resolve(__dirname, '..', 'jest', 'preProcessors', 'jsPreprocessor.js'),
     '^.+\\.css$': _path.default.resolve(__dirname, '..', 'jest', 'preProcessors', 'cssPreprocessor.js'),
     '^(?!.*\\.(js|jsx|css|json)$)': _path.default.resolve(__dirname, '..', 'jest', 'preProcessors', 'otherFilesPreprocessor.js')
   },
@@ -28,7 +28,7 @@ const commonConfig = {
   // },
   transformIgnorePatterns: ['/node_modules/(?!(@zohodesk)/)'],
   // transformIgnorePatterns: ['/node_modules.*?.js$'],
-  moduleFileExtensions: ['js'],
+  moduleFileExtensions: ['js', 'ts', 'tsx'],
   setupFiles: [(0, _fs.existsSync)(appGlobals) && appGlobals, _path.default.resolve(__dirname, '..', 'jest', 'setup.js')].filter(Boolean),
   globals: {
     __DEVELOPMENT__: true,
@@ -52,7 +52,7 @@ module.exports = (...args) => {
     testPathIgnorePatterns: ['/node_modules/', 'docs'],
     unmockedModulePathPatterns: ['__tests__', 'node_modules', '.*'],
     roots: [`<rootDir>/${appFolder}/`],
-    testRegex: '(/__tests__/.*|\\.(test|spec))\\.(jsx|js|json|node)$',
+    testRegex: '(/__tests__/.*|\\.(test|spec))\\.(jsx|js|json|node|ts|tsx)$',
     testResultsProcessor: _path.default.resolve(__dirname, '..', 'jest', 'result.js')
   });
 };

package/lib/configs/resolvers.js

@@ -33,6 +33,7 @@ function moduleResolver(options) {
 
   const nodeModulesPath = required ? required.nodeModulesPath : _client_packages_group.nodeModulesPath;
   return {
+    extensions: ['.js', '.jsx', '.ts', '.tsx'],
     modules: [nodeModulesPath, _constants.cliNodeModulesPath, 'node_modules'].filter(Boolean),
     alias: disableES5Transpile ? _libAlias.libAlias : {} // alias: { ...libAlias, ...clientDependenies }
 

package/lib/configs/webpack.dev.config.js

@@ -44,7 +44,8 @@ const {
     postCssPluginOrder,
     externals,
     enableMjsLoader
-  }
+  },
+  enableTypeScript
 } = options;
 const {
   disableContextURL
@@ -146,7 +147,11 @@ module.exports = {
           minimize: true
         }
       }]
-    }, {
+    }, enableTypeScript ? {
+      test: /\.ts$|\.tsx$/,
+      use: 'ts-loader',
+      include: _path.default.join(appPath, folder)
+    } : null, {
       test: /\.worker.js$/,
       use: {
         loader: require.resolve('../loaders/workerLoader.js'),

package/lib/configs/webpack.prod.config.js

@@ -50,7 +50,8 @@ const {
     crossorigin,
     postCssPluginOrder,
     externals
-  }
+  },
+  enableTypeScript
 } = options;
 let {
   enableChunkHash
@@ -102,7 +103,10 @@ module.exports = {
     //     exclude: /\/smap/
     //   })
     // ],
-    moduleIds: 'named'
+    moduleIds: 'named',
+    usedExports: true,
+    // innerGraph: true, // this property present on webpack 5
+    sideEffects: true
   },
   stats: {
     children: false,
@@ -131,7 +135,7 @@ module.exports = {
             modules: false
           }], (0, _babelPresetReactOption.default)({
             disableES5Transpile
-          })],
+          }), enableTypeScript ? require.resolve('@babel/preset-typescript') : null].filter(Boolean),
           plugins: disableES5Transpile ? [removeAttribute ? require.resolve('../utils/removeAttributes') : false, require.resolve('@babel/plugin-syntax-dynamic-import'), require.resolve('babel-plugin-lodash'), // require.resolve(
           //   '@babel/plugin-proposal-object-rest-spread'
           // ), REMOVING IT, BECAUSE WE ALREADY SUPPORT SPREAD SYNTAX FROM LIBRARIES.
@@ -237,7 +241,11 @@ module.exports = {
           minimize: false
         }
       }]
-    }, {
+    }, enableTypeScript ? {
+      test: /\.ts$|\.tsx$/,
+      use: 'ts-loader',
+      include: _path.default.join(appPath, folder)
+    } : null, {
       test: /\.worker.js$/,
       use: {
         loader: require.resolve('../loaders/workerLoader.js'),

package/lib/jest/preProcessors/jsPreprocessor.js

@@ -4,7 +4,28 @@ var _babelJest = _interopRequireDefault(require("babel-jest"));
 
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 
+const getOptions = require('../../../lib/utils/getOptions').default;
+
+const {
+  enableTypeScript,
+  babelCustomizationForLibrary
+} = getOptions();
+const {
+  babelPlugins
+} = babelCustomizationForLibrary;
+const resolvedPlugins = [];
+babelPlugins.forEach(plugin => {
+  resolvedPlugins.push(require.resolve(plugin));
+});
+const presets = [require.resolve('@babel/preset-env'), require.resolve('@babel/preset-react')];
+
+if (enableTypeScript) {
+  presets.push(require.resolve('@babel/preset-typescript'));
+}
+
+const defaultPlugins = [require.resolve('babel-plugin-transform-dynamic-import')];
+const plugins = [...defaultPlugins, ...resolvedPlugins];
 module.exports = _babelJest.default.createTransformer({
-  presets: [require.resolve('@babel/preset-env'), require.resolve('@babel/preset-react')],
-  plugins: [require.resolve('babel-plugin-transform-dynamic-import')]
+  presets: presets,
+  plugins: plugins
 });

package/lib/loaderUtils/getDevJsLoaders.js

@@ -18,6 +18,7 @@ let getDevJsLoaders = options => {
       instrumentScript,
       devConsoleExculde
     },
+    enableTypeScript,
     esLint: {
       enable: enableEslint
     }
@@ -44,7 +45,7 @@ let getDevJsLoaders = options => {
         modules: false
       }], (0, _babelPresetReactOption.default)({
         disableES5Transpile
-      })],
+      }), enableTypeScript ? require.resolve('@babel/preset-typescript') : null].filter(Boolean),
       plugins: disableES5Transpile ? [require.resolve('@babel/plugin-syntax-dynamic-import'), require.resolve('babel-plugin-lodash'), // require.resolve('@babel/plugin-proposal-object-rest-spread'),
       devConsoleExculde ? [require.resolve('babel-plugin-transform-remove-console'), {
         exclude: ['error', 'log']

package/lib/loaders/workerLoader.js

@@ -19,32 +19,32 @@ function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { de
 /* import WebWorkerTemplatePlugin from 'webpack/lib/webworker/WebWorkerTemplatePlugin';
 import ExternalsPlugin from 'webpack/lib/ExternalsPlugin'; */
 const schema = {
-  'type': 'object',
-  'properties': {
-    'publicPath': {
-      'anyOf': [{
-        'type': 'string'
+  type: 'object',
+  properties: {
+    publicPath: {
+      anyOf: [{
+        type: 'string'
       }, {
-        'instanceof': 'Function'
+        instanceof: 'Function'
       }]
     },
-    'filename': {
-      'anyOf': [{
-        'type': 'string',
-        'minLength': 1
+    filename: {
+      anyOf: [{
+        type: 'string',
+        minLength: 1
       }, {
-        'instanceof': 'Function'
+        instanceof: 'Function'
       }]
     },
-    'chunkFilename': {
-      'type': 'string',
-      'minLength': 1
+    chunkFilename: {
+      type: 'string',
+      minLength: 1
     },
-    'esModule': {
-      'type': 'boolean'
+    esModule: {
+      type: 'boolean'
     }
   },
-  'additionalProperties': false
+  additionalProperties: false
 }; // eslint-disable-next-line
 
 function loader() {}
@@ -112,25 +112,40 @@ function pitch(request) {
     }
 
     function workerCode() {
+      if (this.workerInstance) {
+        return this.workerInstance;
+      }
+
       let blob;
 
       try {
         blob = new Blob([`importScripts('${this.workerUrl}');`], {
-          'type': 'application/javascript'
+          type: 'application/javascript'
         });
       } catch (e1) {
         throw new Error(e1);
       }
 
-      let url = window.URL || window.webkitURL;
-      let blobUrl = url.createObjectURL(blob);
-      let worker = new Worker(blobUrl);
-      return worker;
+      const url = window.URL || window.webkitURL;
+      const blobUrl = url.createObjectURL(blob);
+      this.workerInstance = new Worker(blobUrl);
+      return this.workerInstance;
     }
 
-    return cb(null, `${options.esModule ? 'export default' : 'module.exports ='} {\n
+    return cb(null, `const workerObj ={\n
+      workerInstance: null, \n
 			workerUrl: __webpack_public_path__ + ${JSON.stringify(entry)}, \n
 			getInstance: ${workerCode} \n
-		}`);
+		};\n
+    workerObj.getInstance();
+    ${options.esModule ? 'export default' : 'module.exports ='} workerObj;
+    `); // return cb(
+    //   null,
+    //   `${options.esModule ? 'export default' : 'module.exports ='} {\n
+    //   workerInstance: null, \n
+    // 	workerUrl: __webpack_public_path__ + ${JSON.stringify(entry)}, \n
+    // 	getInstance: ${workerCode} \n
+    // }`
+    // );
   });
 }

package/lib/pluginUtils/configHtmlWebpackPlugins.js

@@ -13,6 +13,10 @@ var _htmlWebpackInjectAttributesPlugin = _interopRequireDefault(require("html-we
 
 var _common = require("../common");
 
+var _utils = require("../utils");
+
+var _CustomScriptLoadingStrategyPlugin = _interopRequireDefault(require("../plugins/CustomScriptLoadingStrategyPlugin"));
+
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 
 const defaultHTMLMiniFyOption = {
@@ -26,6 +30,47 @@ const defaultHTMLMiniFyOption = {
   removeStyleLinkTypeAttributes: true,
   useShortDoctype: true
 };
+const defaultScriptLoadingStrategy = 'defer';
+const allowedScriptLoadingStrategies = ['blocking', 'defer', 'async', 'module'];
+
+function isAllowedScriptLoadingStrategyUsed(scriptLoadingStategey) {
+  return allowedScriptLoadingStrategies.includes(scriptLoadingStategey);
+}
+
+function getScriptLoadingStrategyForStringType(scriptLoadingStategey) {
+  if (isAllowedScriptLoadingStrategyUsed(scriptLoadingStategey)) {
+    return scriptLoadingStategey;
+  }
+
+  return defaultScriptLoadingStrategy;
+}
+
+function getScriptLoadingStrategyForObject(scriptLoadingStategey) {
+  if (Object.keys(scriptLoadingStategey).length === 0) {
+    return defaultScriptLoadingStrategy;
+  }
+
+  const isAllowedScriptLoadingStrategy = Object.keys(scriptLoadingStategey).every(key => isAllowedScriptLoadingStrategyUsed(key));
+
+  if (isAllowedScriptLoadingStrategy) {
+    return Object.assign({}, scriptLoadingStategey);
+  }
+
+  console.warn('un supported script loading strategy used', scriptLoadingStategey);
+  return defaultScriptLoadingStrategy;
+}
+
+function getScriptLoadingStrategy(scriptLoadingStategey) {
+  if ((0, _utils.getTypeOf)(scriptLoadingStategey) === 'string') {
+    return getScriptLoadingStrategyForStringType(scriptLoadingStategey);
+  }
+
+  if ((0, _utils.getTypeOf)(scriptLoadingStategey) === 'object') {
+    return getScriptLoadingStrategyForObject(scriptLoadingStategey);
+  }
+
+  return 'defer';
+}
 
 function configHtmlWebpackPlugins(plugins, {
   enableChunkHash = false,
@@ -33,7 +78,8 @@ function configHtmlWebpackPlugins(plugins, {
   inject,
   crossorigin,
   hasEFC,
-  minify: minifyHtmlOptions = false
+  minify: minifyHtmlOptions = false,
+  customScriptLoadingStrategey = {}
 }) {
   const optionsHtmlWebpack = {
     chunksSortMode: 'none',
@@ -56,4 +102,14 @@ function configHtmlWebpackPlugins(plugins, {
   crossorigin && plugins.push(new _htmlWebpackInjectAttributesPlugin.default({
     crossorigin: 'anonymous'
   }));
+
+  if (customScriptLoadingStrategey.enable) {
+    const currentScriptLoadingStrategy = getScriptLoadingStrategy(customScriptLoadingStrategey.options);
+
+    if ((0, _utils.getTypeOf)(currentScriptLoadingStrategy) === 'object') {
+      plugins.push(new _CustomScriptLoadingStrategyPlugin.default({
+        scriptLoadingStategey: currentScriptLoadingStrategy
+      }));
+    }
+  }
 }

package/lib/pluginUtils/getDevPlugins.js

@@ -37,6 +37,8 @@ var _configHtmlWebpackPlugins = require("./configHtmlWebpackPlugins");
 
 var _EfcResourceCleanupPlugin = _interopRequireDefault(require("../plugins/EfcResourceCleanupPlugin"));
 
+var _EventsHandlingPlugin = require("../plugins/EventsHandlingPlugin");
+
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 
 // import { windowsModification } from '../loaderUtils/windowsModification';
@@ -60,7 +62,8 @@ const getDevPlugins = (options, publicPath) => {
         mode
       },
       htmlTemplate: {
-        inject
+        inject,
+        customScriptLoadingStrategey
       },
       crossorigin
     },
@@ -166,7 +169,8 @@ const getDevPlugins = (options, publicPath) => {
     minify: false,
     inject,
     crossorigin,
-    hasEFC
+    hasEFC,
+    customScriptLoadingStrategey
   });
 
   if (hasEFC) {
@@ -217,12 +221,13 @@ const getDevPlugins = (options, publicPath) => {
       exclude: exclude.selectorWeight,
       patterns
     }));
-  } // if (pluginObject.minifier) {
+  }
+
+  pluginsArr.push(new _EventsHandlingPlugin.EventsHandlingPlugin()); // if (pluginObject.minifier) {
   //   // console.log('minifier active');
   //   pluginsArr.push(new MinifierPlugin());
   // }
 
-
   return pluginsArr.filter(Boolean);
 };
 

package/lib/pluginUtils/getProdPlugins.js

@@ -27,6 +27,8 @@ var _VariableConversionCollector = _interopRequireDefault(require("../plugins/Va
 
 var _SelectorPlugin = _interopRequireDefault(require("../plugins/SelectorPlugin"));
 
+var _EventsHandlingPlugin = require("../plugins/EventsHandlingPlugin");
+
 var _plugins = require("../plugins");
 
 var _CustomAttributePlugin = require("../plugins/CustomAttributePlugin");
@@ -78,7 +80,8 @@ const getProdPlugins = (options, publicPath = '') => {
   } = options.app;
   const {
     inject,
-    minify: minifyHtmlOptions
+    minify: minifyHtmlOptions,
+    customScriptLoadingStrategey
   } = htmlTemplate;
   const {
     i18n
@@ -176,6 +179,7 @@ const getProdPlugins = (options, publicPath = '') => {
     folder,
     inject,
     minify: minifyHtmlOptions,
+    customScriptLoadingStrategey,
     crossorigin,
     hasEFC
   });
@@ -306,6 +310,7 @@ const getProdPlugins = (options, publicPath = '') => {
     statsOutputExcludeKeys,
     statsFileName
   }));
+  pluginsArr.push(new _EventsHandlingPlugin.EventsHandlingPlugin());
   return pluginsArr;
 };