@zohodesk/react-cli 1.1.14-exp.4 → 1.1.14-exp.6

package/README.md

@@ -44,6 +44,19 @@ Now to run app
 
 # Change Logs
 
+# 1.1.14-exp.1 (20-9-2023)
+
+**Feature:-**
+
+- externals was added to  Prevent bundling of certain imported packages and instead retrieve these external dependencies at runtime.
+- to use externals, we use the following pattern in `app > externals` :
+
+For example
+```
+   externals: {
+    <key> : <value>
+   }
+```
 # 1.1.14 (11-9-2023)
 
 **Feature:-**

package/lib/plugins/I18nSplitPlugin/I18nDownlodLogic.js

@@ -184,15 +184,15 @@ class I18nDownlodLogic {
 
       const buf = [];
       /*
-      if (REGEXP_HASH.test(filenameTemplate)) {
-        buf.push(
-          `var hash = ${mainTemplate.renderCurrentHashCode(hash)};`
-        );
-      }
-      if (REGEXP_CHUNKHASH.test(filenameTemplate)) {
-        buf.push(`var chunkHashes = ${JSON.stringify(chunkMaps.hash)};`);
-      }
-      */
+        if (REGEXP_HASH.test(filenameTemplate)) {
+          buf.push(
+            `var hash = ${mainTemplate.renderCurrentHashCode(hash)};`
+          );
+        }
+        if (REGEXP_CHUNKHASH.test(filenameTemplate)) {
+          buf.push(`var chunkHashes = ${JSON.stringify(chunkMaps.hash)};`);
+        }
+        */
 
       if ((0, _hashUtils.hasContentHash)(filenameTemplate)) {
         const hashLength = getContentHashMaxLength(filenameTemplate);
@@ -205,19 +205,12 @@ class I18nDownlodLogic {
 
       const publicPath = this.publicPath ? JSON.stringify(this.publicPath) : `${mainTemplate.requireFn}.p`;
       return _webpack.Template.asString([source, `
-function downloadScriptTagForI18nDynamicChunks(chunkName = '', language = '') {
+(function() {
   // ${pluginName} I18N loading
   var i18nChunks = ${JSON.stringify(chunkMap)};
   var locale = ${localeVarName};
   // ${pluginName} I18N hasehes
   ${hashUtils}
-  if(chunkName) {
-    chunkId = chunkName;
-  }
-  if (language) {
-    window.userLangCode = language;
-    locale = language;
-  }
   if(installedI18nChunks[chunkId]) {
     promises.push(installedI18nChunks[chunkId]);
   } else if(installedI18nChunks[chunkId] !== 0 && i18nChunks[chunkId]) {
@@ -252,31 +245,10 @@ function downloadScriptTagForI18nDynamicChunks(chunkName = '', language = '') {
         }` : ''}
       document.body.appendChild(scriptTag);
     }).then(function() {
-      installedI18nChunks[chunkId] = 0;  
+      installedI18nChunks[chunkId] = 0;
     }));
   }
-  return installedI18nChunks[chunkId];
-};
-downloadScriptTagForI18nDynamicChunks();      
-${mainTemplate.requireFn}.changeLanguage = function changeLanguage(language) {
-  window.change(language);
-  return new Promise((resolve, reject) => {
-    const chunkPromises = Object.keys(installedI18nChunks).map(chunks => {
-      if (chunks !== './runtime~main' && installedI18nChunks[chunks] == 0) {
-        installedI18nChunks[chunks] = null;
-        return downloadScriptTagForI18nDynamicChunks(chunks, language);
-      }
-    });
-
-    Promise.all(chunkPromises)
-      .then(() => {
-        resolve();
-      })
-      .catch(error => {
-        reject(error);
-      });
-  });
-};`]);
+})()`]);
     });
   }
 
@@ -284,8 +256,7 @@ ${mainTemplate.requireFn}.changeLanguage = function changeLanguage(language) {
     compiler.hooks.thisCompilation.tap(pluginName, compilation => {
       const {
         mainTemplate
-      } = compilation; // this.createChangeLanguageFunction(mainTemplate);
-
+      } = compilation;
       this.addDownloadLogicOfI18nInMainTemplate(mainTemplate);
     });
   }

package/lib/schemas/index.js

@@ -125,6 +125,7 @@ var _default = {
     cssDirStatement: null
   },
   app: {
+    externals: null,
     moduleResolvePath: {
       value: '@zohodesk/client_packages_group',
       cli: 'module_resolve_path'
@@ -732,7 +733,6 @@ var _default = {
     fileName: null,
     options: null,
     excludeKeys: null
-  },
-  externals: null
+  }
 };
 exports.default = _default;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zohodesk/react-cli",
-  "version": "1.1.14-exp.4",
+  "version": "1.1.14-exp.6",
   "description": "A CLI tool for build modern web application and libraries",
   "scripts": {
     "init": "node ./lib/utils/init.js",