@zohodesk/react-cli 1.1.12 → 1.1.13

package/README.md

@@ -44,50 +44,24 @@ Now to run app
 
 # Change Logs
 
-# 1.1.12
-
-**Features**
--  Generating stats.json file for the build assets only in production mode. To use this feature we need to add `stats > enable` or cli flags `enable_stats`.
-- Added Resource Cleanup plugin to cleanup resource retained by build tool. this plugin is controlled by custom attributes enable flag.
+# 1.1.13 (4-9-2023)
 
 **Changes**
-- Added a new config `stats` to control stats file generation.
-- Using Existing custom attributes flag, we can control resource cleanup plugin.
 
-# 1.1.11-exp.6 (31-8-2023)
+- Fixed the issue related to the resource cleanup plugin. (EfcResouceCleanupPlugin)
 
-**Features**
 
-- Added Resource Cleanup plugin to cleanup resource retained by build tool. this plugin is controlled by custom attributes enable flag.
-
-**Changes**
-
-- For stats plugin, added the separation of object manipulation method with converting object to string.
-
-# 1.1.11-exp.3 (22-8-2023)
-
-**Changes**
+# 1.1.12 (1-9-2023)
 
-- Changed the default name of stats file to `build-report-integrity.json`
-- Added optimization to reduce the stats file creation time. like streaming.
-- Added support to exclude keys suggested
-
-# 1.1.11-exp.2 (11-8-2023)
-
-**Changes**
-
-- Added more customization support for `stats.json` output.
-- Disabling `bundle-analyser` stats report for our customized stats output based on a flag.
+**Features**
 
-# 1.1.11-exp.1 (8-8-2023)
+- Generating stats.json file for the build assets only in production mode. To use this feature we need to add `stats > enable` or cli flags `enable_stats`.
+- Added Resource Cleanup plugin to cleanup resource retained by build tool. this plugin is controlled by custom attributes enable flag.
 
 **Changes**
 
 - Added a new config `stats` to control stats file generation.
-
-**Features:-**
-
-- Generating stats.json file for the build assets only in production mode. To use this feature we need to add `stats > enable` or cli flags `enable_stats`.
+- Using Existing custom attributes flag, we can control resource cleanup plugin.
 
 # 1.1.11 (4-8-2023)
 

package/lib/pluginUtils/getDevPlugins.js

@@ -193,7 +193,9 @@ const getDevPlugins = (options, publicPath) => {
   }));
   instrumentScript && pluginsArr.push(new _plugins.ScriptInstrumentPlugin());
   customAttributes.enable && pluginsArr.push(new _CustomAttributePlugin.CustomAttributePlugin(customAttributes));
-  customAttributes.enable && pluginsArr.push(new _EfcResourceCleanupPlugin.default(customAttributes));
+  customAttributes.enable && pluginsArr.push(new _EfcResourceCleanupPlugin.default(Object.assign({}, customAttributes, {
+    globalCacheObj: context
+  })));
   hasShadowDOM && pluginsArr.push(new _plugins.ShadowDOMSupportPlugin());
 
   if (devCssFileBountry) {

package/lib/pluginUtils/getProdPlugins.js

@@ -298,7 +298,9 @@ const getProdPlugins = (options, publicPath = '') => {
 
 
   customAttributes.enable && pluginsArr.push(new _CustomAttributePlugin.CustomAttributePlugin(customAttributes));
-  customAttributes.enable && pluginsArr.push(new _EfcResourceCleanupPlugin.default(customAttributes));
+  customAttributes.enable && pluginsArr.push(new _EfcResourceCleanupPlugin.default(Object.assign({}, customAttributes, {
+    globalCacheObj: context
+  })));
   enableStats && pluginsArr.push(new _StatsPlugin.default({
     statsOptions,
     statsOutputExcludeKeys,

package/lib/plugins/EfcResourceCleanupPlugin.js

@@ -15,10 +15,14 @@ module.exports = class EfcResouceCleanupPlugin {
       mainTemplate
     }) => {
       mainTemplate.hooks.afterStartup.tap(plugInName, source => {
-        const attributesArr = Object.entries(this.options.attributes);
+        const {
+          attributes,
+          globalCacheObj
+        } = this.options;
+        const attributesArr = Object.entries(attributes);
         const [[attributekey, attributeValue]] = attributesArr;
         const resourceSelector = `[${attributekey}="${attributeValue}"]`;
-        return Template.asString([source, Template.indent([`     jsonpArray.unInstall = function() {
+        return Template.asString([source, Template.indent([`     window['${globalCacheObj}Jsonp'].unInstall = function() {
                   Object.keys(installedModules).forEach(installedModulesKey => installedModules[installedModulesKey] = null);
                   Object.keys(modules).forEach(moduleKey => modules[moduleKey] = null);
                  `, `
@@ -27,11 +31,11 @@ module.exports = class EfcResouceCleanupPlugin {
                  __webpack_require__.m = null;
                  __webpack_require__.c = null;
               
-                 `, `   
-                const addedResources = document.querySelectorAll('${resourceSelector}');
-                addedResources.forEach(addedResource => addedResource.remove());
-            }
-                `])]);
+                 `, attributekey && attributeValue ? `    
+          const addedResources = document.querySelectorAll('${resourceSelector}');
+          addedResources.forEach(addedResource => addedResource.remove());
+      }
+          ` : ''])]);
       });
     });
   }

package/lib/plugins/StatsPlugin.js

@@ -20,13 +20,13 @@ const statsSchema = {
 
 class StatsPlugin {
   constructor({
-    statsOptions = {},
-    statsOutputExcludeKeys = [],
-    statsFileName = 'bundle-report-integrity.json'
+    statsOptions,
+    statsOutputExcludeKeys,
+    statsFileName
   }) {
-    this.excludeKeysInStat = statsOutputExcludeKeys;
-    this.statsOptions = Object.assign({}, statsSchema, statsOptions);
-    this.statsFileName = statsFileName;
+    this.excludeKeysInStat = statsOutputExcludeKeys || [];
+    this.statsFileName = statsFileName || 'bundle-report-integrity.json';
+    this.statsOptions = Object.assign({}, statsSchema, statsOptions || {});
   }
 
   apply(compiler) {

package/lib/schemas/index.js

@@ -729,9 +729,9 @@ var _default = {
       value: false,
       cli: 'enable_stats'
     },
-    fileName: undefined,
-    options: undefined,
-    excludeKeys: undefined
+    fileName: null,
+    options: null,
+    excludeKeys: null
   }
 };
 exports.default = _default;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zohodesk/react-cli",
-  "version": "1.1.12",
+  "version": "1.1.13",
   "description": "A CLI tool for build modern web application and libraries",
   "scripts": {
     "init": "node ./lib/utils/init.js",