@zohodesk/react-cli 1.0.2 → 1.0.3

package/README.md

@@ -44,6 +44,16 @@ Now to run app
 
 # Change Logs
 
+# 1.0.3
+
+**Feature Update**
+- Support for global httpsCerts usage
+- Support for global client_packages_group usage
+- custom attribute for dynamically loading chunks, In this version we merged changes from [0.0.1-beta.167.1](#0.0.1-beta.167.1). 
+**Package Update**
+- @zohodesk/client_packages_group@**1.0.1** ==>  @zohodesk/client_packages_group@**1.0.2**  
+
+
 # 1.0.2
 
 **Feature Update**
@@ -264,6 +274,10 @@ Features:-
 
 - In docs we have added `Description` for Component Props- check out it in `PropTypes` tab
 
+# 0.0.1-beta.167.1
+In this version we merged changes from [0.0.1-betaa.138.1](#0.0.1-betaa.138.1).  
+and with [0.0.1-beta.167](#0.0.1-beta.167) version changes.  
+
 # 0.0.1-beta.167
 
 SSL certificate update
@@ -525,6 +539,11 @@ impact servise related changes:-
 - babel runtime plugin issue fix in prod config
 - few enhancements
 
+# 0.0.1-betaa.138.1
+- new feature added for custom extra attribute for dynamically added tags by webpack.
+- To enable this feature you need to enable "react-cli" => "app" => "customAttributes" => "enable"
+- For more [details](https://zgit.csez.zohocorpin.com/zohodesk/react-cli/-/blob/9eea8df14e55584b2114b5e484ca8b751a4ba191/src/plugins/CustomAttributePlugin.md)
+
 # 0.0.1-beta.138
 
 - sstest library version updated

package/lib/common/testPattern.js

@@ -62,8 +62,6 @@ const isRelatedPackage = (req, item) => isRelated(req, `node_modules${_path.sep}
 exports.isRelatedPackage = isRelatedPackage;
 
 function isDependency(m, excludeList) {
-  // let reasons = m.reasons.map(r => r.module.userRequest);
-  // m.reasons.some(r => !r.module || !r.module.userRequest) && console.log(m.reasons);
   return m.reasons.some(r => excludeList.some(item => r.module && isRelated(r.module.userRequest, item)));
 } // export function queryHandler(conditions, pattern) {
 // }

package/lib/common/valueReplacer.js

@@ -32,11 +32,9 @@ if (!_fs.default.existsSync(dist)) {
 }
 
 (0, _folderIterator.default)(src, dist, docopy ? false : ['.css'], false, (fromPath, toPath) => {
-  //console.log({ fromPath: fromPath, toPath: toPath });
-  let css = _fs.default.readFileSync(fromPath);
+  const css = _fs.default.readFileSync(fromPath);
 
   if (docopy && !fromPath.endsWith('.css')) {
-    //console.log(toPath,'....');
     _fs.default.writeFileSync(toPath, css);
 
     return;

package/lib/configs/resolvers.js

@@ -8,6 +8,10 @@ exports.moduleResolver = moduleResolver;
 
 var _constants = require("../constants");
 
+var _logger = require("../logger");
+
+var _requireLocalOrGlobal = require("../servers/requireLocalOrGlobal");
+
 var _libAlias = require("./libAlias");
 
 var _client_packages_group = require("@zohodesk/client_packages_group");
@@ -17,10 +21,17 @@ function moduleResolver(options) {
     moduleResolvePath,
     disableES5Transpile
   } = options.app;
-  const nodeModulesPath = moduleResolvePath ? require(require.resolve(moduleResolvePath, {
-    paths: [options.cwd]
-  })).nodeModulesPath : _client_packages_group.nodeModulesPath; // const {unstableDepsInverse} = options;
+  let required = moduleResolvePath && (0, _requireLocalOrGlobal.requireLocal)(moduleResolvePath);
+
+  if (!required) {
+    required = (0, _requireLocalOrGlobal.requireGlobal)('@zohodesk/client_packages_group');
+
+    if (required) {
+      (0, _logger.messageLogger)('global `@zohodesk/client_packages_group` package taken as client_packages_group');
+    }
+  }
 
+  const nodeModulesPath = required ? required.nodeModulesPath : _client_packages_group.nodeModulesPath;
   return {
     modules: [nodeModulesPath, _constants.cliNodemodulesPath, 'node_modules'].filter(Boolean),
     alias: disableES5Transpile ? _libAlias.libAlias : {} // alias: { ...libAlias, ...clientDependenies }

package/lib/loaderUtils/getCSSLoaders.js

@@ -41,11 +41,7 @@ const getCSSLoaders = optionsObj => {
     selectorReplace,
     cssHashSelectors,
     classNamePrefix
-  } = optionsObj; // console.log('plugins:')
-  // console.log(plugins)
-  // console.log('exclude:')
-  // console.log(exclude)
-
+  } = optionsObj;
   const {
     devCssFileBountry
   } = options.app;
@@ -70,8 +66,7 @@ const getCSSLoaders = optionsObj => {
     cssLoaderOptions.modules.localIdentName = classNameBlob;
   } else {
     cssLoaderOptions.modules.getLocalIdent = (0, _cssClassNameGenerate.default)(cssUniqueness, cssHashSelectors, classNamePrefix);
-  } // console.log('selector weight config : ', selectorWeightConfig);
-
+  }
 
   const postcssPlugins = [valueReplacer && require('../postcss-plugins/ValueReplacer')(valueReplacer), selectorReplace && require('../postcss-plugins/SelectorReplace')(selectorReplace), ...excludeEmptyCheckPlugin({
     enable: plugins.hasRTL,

package/lib/loaders/selectorMappingLoader.js

@@ -6,25 +6,25 @@ var _fs = _interopRequireDefault(require("fs"));
 
 var _utils = require("../utils");
 
+var _logger = require("../logger");
+
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 
-let options = (0, _utils.getOptions)();
+const options = (0, _utils.getOptions)();
 const {
   cssSelectorZipPath
 } = options.impactService;
 
-const zipname = _path.default.parse(cssSelectorZipPath).name; // console.log({ cssSelectorZipPath, zipname });
-// TODO:NOTE: need to check about .. path related files creation 
+const zipname = _path.default.parse(cssSelectorZipPath).name; // TODO:NOTE: need to check about .. path related files creation 
 // for now  no css files have given  form react-cli need to make sure about it.  
 
 
-let zippath = _path.default.join(process.cwd(), cssSelectorZipPath);
+const zippath = _path.default.join(process.cwd(), cssSelectorZipPath);
 
 if (_fs.default.existsSync(_path.default.join(process.cwd(), cssSelectorZipPath))) {
   _fs.default.rmSync(zippath);
 
-  console.log('zip file deleted', zippath); // fs.rmSync(zippath, {force:true})
-  // console.log('created folder ==> ', dpath);
+  (0, _logger.messageLogger)('zip file deleted', zippath); // fs.rmSync(zippath, {force:true})
 } // const minicssComment =
 //   '// extracted by mini-css-extract-plugin\n';
 
@@ -39,15 +39,15 @@ module.exports = function (source) {
 
   const relativePath = _path.default.relative(rootContext, resourcePath);
 
-  let fpath = _path.default.join(rootContext, zipname, relativePath);
+  const fpath = _path.default.join(rootContext, zipname, relativePath);
 
-  let originalpath = _path.default.join(rootContext, relativePath);
+  const originalpath = _path.default.join(rootContext, relativePath);
 
   if (relativePath.startsWith('..')) {
     throw `unexpected path ${relativePath}`;
   }
 
-  let dpath = fpath.slice(0, fpath.lastIndexOf(_path.default.sep));
+  const dpath = fpath.slice(0, fpath.lastIndexOf(_path.default.sep));
 
   if (!_fs.default.existsSync(originalpath)) {
     throw `originalpath not exixt ${originalpath}`;

package/lib/logger.js

@@ -0,0 +1,20 @@
+"use strict";
+
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.errorLogger = errorLogger;
+exports.messageLogger = messageLogger;
+exports.warnLogger = warnLogger;
+
+function messageLogger(...args) {
+  console.log(...args);
+}
+
+function errorLogger(...args) {
+  console.error(...args);
+}
+
+function warnLogger(...args) {
+  console.warn(...args);
+}

package/lib/pluginUtils/getDevPlugins.js

@@ -25,6 +25,8 @@ var _webpack = _interopRequireDefault(require("webpack"));
 
 var _plugins = require("../plugins");
 
+var _CustomAttributePlugin = require("../plugins/CustomAttributePlugin");
+
 var _RtlCssPlugin = require("../plugins/RtlSplitPlugin/RtlCssPlugin");
 
 var _VariableConversionCollector = _interopRequireDefault(require("../plugins/VariableConversionCollector"));
@@ -42,6 +44,7 @@ const getDevPlugins = (options, publicPath) => {
       tpFolder,
       folder,
       instrumentScript,
+      customAttributes,
       devCssFileBountry,
       context,
       hasEFC: prevOptionForEnableEFC,
@@ -86,6 +89,7 @@ const getDevPlugins = (options, publicPath) => {
       NODE_ENV: JSON.stringify(mode === 'dev-no-warn' ? 'production' : 'development')
     }
   }), new _miniCssExtractPlugin.default({
+    attributes: customAttributes.cssAttributes,
     filename: cssLTRFileNameTempalte,
     // ignoreOrder: true,
     chunkFilename: cssLTRFileNameTempalte
@@ -184,6 +188,7 @@ const getDevPlugins = (options, publicPath) => {
     mainChunkName: 'main'
   }));
   instrumentScript && pluginsArr.push(new _plugins.ScriptInstrumentPlugin());
+  customAttributes.enable && pluginsArr.push(new _CustomAttributePlugin.CustomAttributePlugin(customAttributes));
   hasShadowDOM && pluginsArr.push(new _plugins.ShadowDOMSupportPlugin());
 
   if (devCssFileBountry) {

package/lib/pluginUtils/getProdPlugins.js

@@ -29,6 +29,8 @@ var _SelectorPlugin = _interopRequireDefault(require("../plugins/SelectorPlugin"
 
 var _plugins = require("../plugins");
 
+var _CustomAttributePlugin = require("../plugins/CustomAttributePlugin");
+
 var _RtlCssPlugin = require("../plugins/RtlSplitPlugin/RtlCssPlugin");
 
 var _configHtmlWebpackPlugins = require("./configHtmlWebpackPlugins");
@@ -63,6 +65,7 @@ const getProdPlugins = (options, publicPath = '') => {
     resourceHints,
     serviceWorker,
     htmlTemplate,
+    customAttributes,
     tpHashMapping,
     cdnMapping,
     crossorigin
@@ -279,6 +282,7 @@ const getProdPlugins = (options, publicPath = '') => {
   } // plugins.push(new VariableConversionCollector({}));
 
 
+  customAttributes.enable && pluginsArr.push(new _CustomAttributePlugin.CustomAttributePlugin(customAttributes));
   return pluginsArr;
 };
 

package/lib/plugins/CustomAttributePlugin.js

@@ -0,0 +1,82 @@
+"use strict";
+
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.CustomAttributePlugin = void 0;
+
+var _Template = _interopRequireDefault(require("webpack/lib/Template"));
+
+var _htmlWebpackInjectAttributesPlugin = _interopRequireDefault(require("html-webpack-inject-attributes-plugin"));
+
+function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
+
+/* eslint-disable no-use-before-define */
+class CustomAttributePlugin {
+  constructor(options) {
+    this.options = {
+      attributes: options.attributes,
+      useHTMLAttribute: options.attributes && !options.jsAttributes && !options.cssAttributes && !options.i18nAttributes,
+      jsAttributes: options.jsAttributes || options.attributes || {},
+      cssAttributes: options.cssAttributes || options.attributes || {},
+      i18nAttributes: options.i18nAttributes || options.attributes || {}
+    };
+  }
+
+  addCustomAttributeToDynamicScriptTags(mainTemplate) {
+    const {
+      jsAttributes,
+      cssAttributes,
+      i18nAttributes
+    } = this.options; // NOTE: To add custom Attributes to js Script tags
+
+    mainTemplate.hooks.jsonpScript.tap('CustomAttributePlugin', source => {
+      const str = attributeSetTemplate(jsAttributes, 'script');
+      return _Template.default.asString([source, ...str]);
+    }); // NOTE: To add custom Attributes to css link tags
+
+    mainTemplate.hooks.requireEnsure.tap('CustomAttributePlugin', source => {
+      const str = attributeSetTemplate(cssAttributes, 'linkTag');
+      const replacedStr = source.replace('head.appendChild(linkTag);', `${str.join('')}head.appendChild(linkTag);`); //   console.log({ s: source, r: replacedStr });
+
+      return replacedStr;
+    }); // NOTE: To add custom Attributes to i18n split js Script tags
+
+    mainTemplate.hooks.requireEnsure.tap('CustomAttributePlugin', source => {
+      const str = attributeSetTemplate(i18nAttributes, 'scriptTag');
+      const replacedStr = source.replace('document.body.appendChild(scriptTag);', `${str.join('')}document.body.appendChild(scriptTag);`); //   console.log({ s: source, r: replacedStr });
+
+      return replacedStr;
+    });
+  }
+
+  apply(compiler) {
+    // NOTE: we not using this, Reason currently this option is only need for EFC,
+    // So it do not needed.
+    const {
+      attributes,
+      useHTMLAttribute
+    } = this.options;
+    useHTMLAttribute && new _htmlWebpackInjectAttributesPlugin.default(attributes).apply(compiler);
+    compiler.hooks.thisCompilation.tap({
+      name: 'CustomAttributePlugin',
+      stage: 1,
+      fn: compilation => {
+        this.addCustomAttributeToDynamicScriptTags(compilation.mainTemplate);
+      }
+    });
+  }
+
+}
+
+exports.CustomAttributePlugin = CustomAttributePlugin;
+
+function attributeSetTemplate(jsAttributes, variableName) {
+  let str = [];
+  Object.keys(jsAttributes).forEach(key => {
+    const val = jsAttributes[key];
+    str.push(`${variableName}.setAttribute(${JSON.stringify(key)}, ${JSON.stringify(val)});`);
+  }); //   console.log({ str });
+
+  return str;
+}

package/lib/plugins/CustomAttributePlugin.md

@@ -0,0 +1,35 @@
+# CustomAttributePlugin
+ In this plugin we added all dynamic chunks tags (like js script tags , css script tags, i18n split script tags) to extra custom attribute
+
+## Options
+
+```json
+{
+  "name": "some",
+  "react-cli": {
+    "app": {
+      "customAttributes": {// this is the all options
+        "enable": false,
+        "attributes": null,
+        "jsAttributes": null,
+        "cssAttributes": null,
+        "i18nAttributes": null
+      }
+  }
+}
+```
+
+### enable   [Boolean]
+this decides is this plugin or feature needs to be enabled of not.
+
+
+### attributes   [Object] 
+It  was object of key value pairs Example Given Option {"data-app-name":"myapp"}  
+Then all dynamically (js script tags , css script tags, i18n split script tags) added tags via webpack 
+
+### jsAttributes   [Object] 
+same as [attributes] but only for js script tags
+### cssAttributes   [Object] 
+same as [attributes] but only for css script tags
+### i18nAttributes   [Object] 
+same as [attributes] but only for i18n split script tags

package/lib/plugins/EFCPlugin.js

@@ -19,6 +19,8 @@ var _replaceCssDirTemplate = require("./RtlSplitPlugin/replaceCssDirTemplate");
 
 var _EFCTemplatePlugin = _interopRequireDefault(require("./EFCTemplatePlugin"));
 
+var _logger = require("../logger");
+
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 
 // import { getShortI18nAssets } from './I18nSplitPlugin/utils/hashUtils';
@@ -85,18 +87,18 @@ class EFCPlugin {
   getI18nAssetsStr(entryPoint, compilation) {
     if (!chunkSplitEnable) {
       let i18nAsstes = {};
-      let i18nFiles = Object.keys(compilation.assets).filter(assert => assert.indexOf(`i18n${_path.default.sep}`) !== -1); //hook for i18n url contains i18n/ may cause problem
+      const i18nFiles = Object.keys(compilation.assets).filter(assert => assert.indexOf(`i18n${_path.default.sep}`) !== -1); //hook for i18n url contains i18n/ may cause problem
 
       i18nAsstes = i18nFiles.reduce((res, i18nFilePath) => {
-        let fileName = i18nFilePath.replace(`i18n${_path.default.sep}`, '');
-        let splittedFileName = fileName.split('.');
+        const fileName = i18nFilePath.replace(`i18n${_path.default.sep}`, '');
+        const splittedFileName = fileName.split('.');
         res[splittedFileName[0]] = i18nFilePath;
         return res;
       }, {});
       return `[${JSON.stringify(i18nAsstes)}[lang]]`;
     }
 
-    let initalI18nAssets = entryPoint.chunks.filter(chunk => _I18nKeysIdentifer.default.isChunkHasI18n(chunk)).map(chunk => (0, _getI18nFileUrlPathTemplate.getI18nFileUrlPathTemplate)(compilation, chunk, this.i18nFileNameTemplate, '@locale@'));
+    const initalI18nAssets = entryPoint.chunks.filter(chunk => _I18nKeysIdentifer.default.isChunkHasI18n(chunk)).map(chunk => (0, _getI18nFileUrlPathTemplate.getI18nFileUrlPathTemplate)(compilation, chunk, this.i18nFileNameTemplate, '@locale@'));
     return `${JSON.stringify(initalI18nAssets)}.map(urlpath => urlpath.replace(/@locale@/g, lang))`;
   }
 
@@ -205,8 +207,7 @@ class EFCPlugin {
   apply(compiler) {
     if (!createSDkFile) {
       return;
-    } //console.log('this.templateFilePath', this.templateFilePath, this.options);
-
+    }
 
     if (this.templateFilePath) {
       new _EFCTemplatePlugin.default({
@@ -230,9 +231,8 @@ class EFCPlugin {
       }
 
       const source = new _webpackSources.RawSource(this.createFileContent(compilation));
-      compilation.assets[outputFile] = source; // eslint-disable-next-line no-console
-
-      console.log('The EFC embedded code was created successfully..!!!');
+      compilation.assets[outputFile] = source;
+      (0, _logger.messageLogger)('The EFC embedded code was created successfully..!!!');
     });
   }
 

package/lib/plugins/EFCTemplatePlugin.js

@@ -19,6 +19,8 @@ var _I18nKeysIdentifer = _interopRequireDefault(require("./I18nSplitPlugin/I18nK
 
 var _replaceCssDirTemplate = require("./RtlSplitPlugin/replaceCssDirTemplate");
 
+var _logger = require("../logger");
+
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 
 // import { getShortI18nAssets } from './I18nSplitPlugin/utils/hashUtils';
@@ -40,9 +42,7 @@ const {
 
 class EFCTemplatePlugin {
   constructor(options = {}) {
-    // console.log(' templateFilePath ', process.cwd(), options.templateFilePath, templateFilePath);
-    this.templateFilePath = _path.default.join(process.cwd(), options.templateFilePath); // console.log(' templateFilePath ', this.templateFilePath);
-
+    this.templateFilePath = _path.default.join(process.cwd(), options.templateFilePath);
     this.i18nFileNameTemplate = options.i18nFileNameTemplate;
     this.publicPath = options.publicPath; // NOTE: this logic may be needed for i18n splited file name with contenthash cases
     // this.i18nManifestFileName = options.i18nManifestFileName;
@@ -68,18 +68,18 @@ class EFCTemplatePlugin {
     // NOTE: we have used lang variable inside
     if (!chunkSplitEnable) {
       let i18nAsstes = {};
-      let i18nFiles = Object.keys(compilation.assets).filter(assert => assert.indexOf(`i18n${_path.default.sep}`) !== -1); //hook for i18n url contains i18n/ may cause problem
+      const i18nFiles = Object.keys(compilation.assets).filter(assert => assert.indexOf(`i18n${_path.default.sep}`) !== -1); //hook for i18n url contains i18n/ may cause problem
 
       i18nAsstes = i18nFiles.reduce((res, i18nFilePath) => {
-        let fileName = i18nFilePath.replace(`i18n${_path.default.sep}`, '');
-        let splittedFileName = fileName.split('.');
+        const fileName = i18nFilePath.replace(`i18n${_path.default.sep}`, '');
+        const splittedFileName = fileName.split('.');
         res[splittedFileName[0]] = i18nFilePath;
         return res;
       }, {});
       return `[${JSON.stringify(i18nAsstes)}[lang]]`;
     }
 
-    let initalI18nAssets = entryPoint.chunks.filter(chunk => _I18nKeysIdentifer.default.isChunkHasI18n(chunk)).map(chunk => (0, _getI18nFileUrlPathTemplate.getI18nFileUrlPathTemplate)(compilation, chunk, this.i18nFileNameTemplate, '@locale@'));
+    const initalI18nAssets = entryPoint.chunks.filter(chunk => _I18nKeysIdentifer.default.isChunkHasI18n(chunk)).map(chunk => (0, _getI18nFileUrlPathTemplate.getI18nFileUrlPathTemplate)(compilation, chunk, this.i18nFileNameTemplate, '@locale@'));
     return `${JSON.stringify(initalI18nAssets)}.map(urlpath => urlpath.replace(/@locale@/g, lang))`;
   }
 
@@ -102,7 +102,7 @@ class EFCTemplatePlugin {
 
     const initalI18nAssets = this.getI18nAssetsStr(entryPoint, compilation, '' // i18nJsPath
     );
-    let templateStr = (0, _fs.readFileSync)(this.templateFilePath).toString();
+    const templateStr = (0, _fs.readFileSync)(this.templateFilePath).toString();
     return templateStr.replace('((\'getInitalAssets\'))', `function getInitalAssets(assetsType, lang) {
           if (assetsType === "js") {
             return ${JSON.stringify(initialJsFiles)}
@@ -139,10 +139,8 @@ class EFCTemplatePlugin {
       }
 
       const source = new _webpackSources.RawSource(this.templateReplacer(entryPoint, compilation));
-      compilation.assets[outputFile] = source; // console.log('EFCTemplatePlugin working');
-      // eslint-disable-next-line no-console
-
-      console.log('The EFC embedded code was created successfully..!!!');
+      compilation.assets[outputFile] = source;
+      (0, _logger.messageLogger)('The EFC embedded code was created successfully..!!!');
     });
   }
 

package/lib/plugins/I18NInjectIntoIndexPlugin.js

@@ -22,7 +22,7 @@ var _getI18nFileUrlPathTemplate = require("./I18nSplitPlugin/utils/getI18nFileUr
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 
 let i18nObj = null;
-let options = (0, _utils.getOptions)();
+const options = (0, _utils.getOptions)();
 
 function newAssign(target, data) {
   return Object.assign({}, target, data);
@@ -43,7 +43,7 @@ class I18NInjectIntoIndexPlugin {
   }
 
   getI18nFileUrlPath(chunk, compilation) {
-    let urlpath = (0, _getI18nFileUrlPathTemplate.getI18nFileUrlPathTemplate)(compilation, chunk, this.i18nFileNameTemplate, this.templateLabel);
+    const urlpath = (0, _getI18nFileUrlPathTemplate.getI18nFileUrlPathTemplate)(compilation, chunk, this.i18nFileNameTemplate, this.templateLabel);
     return (0, _urlConcat.urlConcat)(this.publicPath, urlpath);
   }
 
@@ -81,7 +81,6 @@ class I18NInjectIntoIndexPlugin {
   withI18nSpitHandling(compiler) {
     compiler.hooks.make.tap('I18NInjectIntoIndexPlugin', compilation => {
       // let cdns = Object.keys(this.publicPaths);
-      // console.log('compilation.assets', Object.keys(compilation.assets).filter(a => a.includes('i18n')));
       if (!(0, _hashUtils.hasContentHash)(this.i18nFileNameTemplate)) {
         this.injectI18nURLsToHTML(compilation);
         return;
@@ -91,7 +90,7 @@ class I18NInjectIntoIndexPlugin {
         // Manipulate the content
         const i18nManifest = this.getI18nManifest(compilation);
         const entryPoint = compilation.entrypoints.get(this.entryPointName);
-        let i18nAssets = (0, _hashUtils.getShortI18nAssets)(entryPoint.chunks, i18nManifest, this.publicPath);
+        const i18nAssets = (0, _hashUtils.getShortI18nAssets)(entryPoint.chunks, i18nManifest, this.publicPath);
         data.html = data.html.replace(new RegExp('<!--I18nInfoToServer(.*?)I18nInfoToServer-->', 'g'), (match, arg) => match.replace(arg, JSON.stringify(i18nAssets))); // Tell webpack to move on
 
         cb(null, data);
@@ -111,11 +110,11 @@ class I18NInjectIntoIndexPlugin {
     compiler.hooks.emit.tap('I18NInjectIntoIndexPlugin', compilation => {
       // let cdns = Object.keys(this.publicPaths);
       if (i18nObj === null) {
-        let i18nFiles = Object.keys(compilation.assets).filter(assert => assert.indexOf(`i18n${_path.default.sep}`) !== -1); //hook for i18n url contains i18n/ may cause problem
+        const i18nFiles = Object.keys(compilation.assets).filter(assert => assert.indexOf(`i18n${_path.default.sep}`) !== -1); //hook for i18n url contains i18n/ may cause problem
 
         i18nObj = i18nFiles.reduce((res, next) => {
-          let fileName = next.replace(`i18n${_path.default.sep}`, '');
-          let splittedFileName = fileName.split('.');
+          const fileName = next.replace(`i18n${_path.default.sep}`, '');
+          const splittedFileName = fileName.split('.');
           /* if (this.isDevelopment) {
             res[splittedFileName[0]] = `${this.publicPath}/i18n/${fileName}`;
           } else {
@@ -127,10 +126,10 @@ class I18NInjectIntoIndexPlugin {
         }, {});
       }
 
-      let [indexFile] = Object.keys(compilation.assets).filter(filename => /\.html$/g.test(filename));
+      const [indexFile] = Object.keys(compilation.assets).filter(filename => /\.html$/g.test(filename));
 
       if (indexFile) {
-        let source = compilation.assets[indexFile].source();
+        const source = compilation.assets[indexFile].source();
         compilation.assets[indexFile] = new _webpackSources.RawSource(source.replace(new RegExp('<!--I18nInfoToServer(.*)I18nInfoToServer-->', 'g'), (match, arg) => match.replace(arg, JSON.stringify(i18nObj))));
       }
     });

package/lib/plugins/I18nSplitPlugin/I18nDebugPlugin.js

@@ -24,10 +24,9 @@ class I18nDebugPlugin {
     compiler.hooks.normalModuleFactory.tap(pluginName, factory => {
       if (!this.compilationParams || this.compilationParams.normalModuleFactory === factory) {
         return;
-      } // console.log('skiped');
+      }
 
-
-      let handler = parser => {
+      const handler = parser => {
         parser.hooks.program.tap(pluginName, (ast, commmets) => {
           const {
             module

package/lib/plugins/I18nSplitPlugin/I18nKeysIdentifer.js

@@ -40,7 +40,7 @@ class I18nKeysIdentifer {
       identifier,
       i18nKeys
     }, module.context, 0);
-    module.addDependency(dep); // console.log('module', i18nKeys, identifier);
+    module.addDependency(dep);
   }
 
   apply(compiler) {
@@ -50,7 +50,7 @@ class I18nKeysIdentifer {
       // and we must define how  it  import statement look like I18nDependencyTemplate
       this.defineConfigarationForI18nDependency(compilation); // handler for parser
 
-      let handler = parser => {
+      const handler = parser => {
         parser.hooks.program.tap(pluginName, (ast, commmets) => {
           const {
             module
@@ -66,11 +66,6 @@ class I18nKeysIdentifer {
           (0, _utils.collectI18nKeysfromComments)(commmets, this.jsResourceI18nKeys));
 
           if (i18nKeys.length) {
-            // console.log(
-            //   'i18nKeys.length',
-            //   module.resource,
-            //   i18nKeys.length < 5 ? i18nKeys : i18nKeys.length
-            // );
             this.addI18nDependency(module, i18nKeys);
           }
         });

package/lib/plugins/I18nSplitPlugin/index.js

@@ -177,7 +177,7 @@ class I18nPlugin {
             compilation.moduleTemplate.javascript,
             compilation.dependencyTemplates
           );
-          console.log('entry, ', c, hashSource.toString());
+          
         }
         */
 

package/lib/plugins/I18nSplitPlugin/utils/propertiesUtils.js

@@ -11,6 +11,8 @@ var _fs = require("fs");
 
 var _path = require("path");
 
+var _logger = require("../../../logger");
+
 function isComment(line) {
   return line[0] === '#';
 }
@@ -18,7 +20,7 @@ function isComment(line) {
 function getPropertiesAsJSON(filePath) {
   try {
     const data = (0, _fs.readFileSync)(filePath);
-    let source = data.toString();
+    const source = data.toString();
     const i18nObj = {};
     source.split(/\r?\n\r?/).forEach(fline => {
       const line = fline.trim();
@@ -42,7 +44,7 @@ function getPropertiesAsJSON(filePath) {
 }
 
 function getLang(file) {
-  let underScoreIndex = file.indexOf('_');
+  const underScoreIndex = file.indexOf('_');
   let language = 'en_US';
 
   if (underScoreIndex !== -1) {
@@ -68,26 +70,24 @@ function getAllI18n({
       const filePath = (0, _path.join)(context, file);
 
       if (exclude.test(filePath) || !include.test(filePath)) {
-        // console.log('exclude', filePath);
         return;
-      } // console.log('include', filePath);
-
+      }
 
       const i18n = getPropertiesAsJSON(filePath);
       allLangI18n[getLang(file)] = disableDefault ? i18n : Object.assign({}, jsResourceI18nKeys, i18n);
     });
     return allLangI18n;
   } catch (err) {
-    // console.log(err);
+    (0, _logger.errorLogger)(err);
     return {};
   }
 }
 
 function jsonToString(json, keySeperator) {
   let str = '{';
-  let keys = Object.keys(json);
+  const keys = Object.keys(json);
   keys.forEach((key, i) => {
-    let value = json[key];
+    const value = json[key];
 
     if (!value) {
       return;