@zohodesk/react-cli 0.0.1-exp.175.0 → 0.0.1-exp.176.1

package/lib/loaderUtils/getCSSLoaders.js

@@ -11,16 +11,13 @@ var _cssClassNameGenerate = _interopRequireDefault(require("../utils/cssClassNam
 
 var _utils = require("../utils");
 
+var _windowsModification = require("./windowsModification");
+
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 
 const fs = require('fs');
 
 const options = (0, _utils.getOptions)();
-const isWin = process.platform === 'win32';
-
-function windowsModification(array) {
-  return isWin ? array.map(r => r.replace(/\//g, '\\')) : array;
-}
 
 function excludeEmptyCheckPlugin({
   enable,
@@ -33,7 +30,22 @@ function excludeEmptyCheckPlugin({
   })] : [];
 }
 
-const getCSSLoaders = (plugins, exclude, mediaQueryHoverActiveString, cssVariableReplacementConfig, classNameBlob, cssUniqueness, selectorReplace, cssHashSelectors, classNamePrefix) => {
+const getCSSLoaders = optionsObj => {
+  const {
+    plugins,
+    exclude,
+    mediaQueryHoverActiveString,
+    cssVariableReplacementConfig,
+    classNameBlob,
+    cssUniqueness,
+    selectorReplace,
+    cssHashSelectors,
+    classNamePrefix
+  } = optionsObj; // console.log('plugins:')
+  // console.log(plugins)
+  // console.log('exclude:')
+  // console.log(exclude)
+
   const {
     devCssFileBountry
   } = options.app;
@@ -43,10 +55,10 @@ const getCSSLoaders = (plugins, exclude, mediaQueryHoverActiveString, cssVariabl
   const {
     cssSelectorZipPath
   } = options.impactService;
-  const rtlExcludeLocal = windowsModification(exclude.rtl);
-  const hoverActiveExcludeLocal = windowsModification(exclude.hoverActive);
-  const combinerMediaQueryExcludeLocal = windowsModification(exclude.combinerMediaQuery);
-  const cssVariableReplacementExcludeLocal = windowsModification(exclude.cssVariableReplacement);
+  const rtlExcludeLocal = (0, _windowsModification.windowsModification)(exclude.rtl);
+  const hoverActiveExcludeLocal = (0, _windowsModification.windowsModification)(exclude.hoverActive);
+  const combinerMediaQueryExcludeLocal = (0, _windowsModification.windowsModification)(exclude.combinerMediaQuery);
+  const cssVariableReplacementExcludeLocal = (0, _windowsModification.windowsModification)(exclude.cssVariableReplacement);
   const cssLoaderOptions = {
     // importLoaders: hasRTL||hoverActive ? 1 : 0,
     importLoaders: 1,
@@ -58,14 +70,10 @@ const getCSSLoaders = (plugins, exclude, mediaQueryHoverActiveString, cssVariabl
     cssLoaderOptions.modules.localIdentName = classNameBlob;
   } else {
     cssLoaderOptions.modules.getLocalIdent = (0, _cssClassNameGenerate.default)(cssUniqueness, cssHashSelectors, classNamePrefix);
-  }
-
-  const postcssPlugins = [valueReplacer && require('../postcss-plugins/ValueReplacer')(valueReplacer), selectorReplace && require('postcss-selector-replace')(selectorReplace), // ...excludeEmptyCheckPlugin({
-  //   enable: true,
-  //   ignore: [],
-  //   plugins: [require('../postcss-plugins/variablePropertiesCollector').default()]
-  // }),
-  ...excludeEmptyCheckPlugin({
+  } // console.log('selector weight config : ', selectorWeightConfig);
+
+
+  const postcssPlugins = [valueReplacer && require('../postcss-plugins/ValueReplacer')(valueReplacer), selectorReplace && require('postcss-selector-replace')(selectorReplace), ...excludeEmptyCheckPlugin({
     enable: plugins.hasRTL,
     ignore: rtlExcludeLocal,
     plugins: [require('@zohodesk/postcss-rtl')({
@@ -88,7 +96,7 @@ const getCSSLoaders = (plugins, exclude, mediaQueryHoverActiveString, cssVariabl
   }), ...excludeEmptyCheckPlugin({
     enable: plugins.cssVariableReplacement,
     ignore: cssVariableReplacementExcludeLocal,
-    plugins: [fs.existsSync(cssVariableReplacementConfig) && require('../postcss-plugins/variableModificationPlugin/index')(cssVariableReplacementConfig)]
+    plugins: [fs.existsSync(cssVariableReplacementConfig) && require('../postcss-plugins/variableModificationPlugin/index').plugin(cssVariableReplacementConfig)]
   })].filter(Boolean);
   return [cssSelectorZipPath && {
     loader: require.resolve('../loaders/selectorMappingLoader')

package/lib/loaderUtils/windowsModification.js

@@ -0,0 +1,11 @@
+"use strict";
+
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.windowsModification = windowsModification;
+const isWin = process.platform === 'win32';
+
+function windowsModification(array) {
+  return isWin ? array && Array.isArray(array) && array.map(r => r.replace(/\//g, '\\')) : array;
+}

package/lib/loaders/workerLoader.js

@@ -16,7 +16,7 @@ var _SingleEntryPlugin = _interopRequireDefault(require("webpack/lib/SingleEntry
 
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 
-/* import WebWorkerTemplatePlugin from 'webpack/lib/webworker/WebWorkerTemplatePlugin';
+/* import WebWorkerTemplatePlugin from 'webpack/lib/webworker/WebWorkerTemplatePlugin';
 import ExternalsPlugin from 'webpack/lib/ExternalsPlugin'; */
 const schema = {
   'type': 'object',
@@ -80,14 +80,14 @@ function pitch(request) {
     globalObject: 'self'
   };
   workerContext.compiler = this._compilation.createChildCompiler(`worker-loader ${request}`, workerContext.options);
-  /* 
-  new WebWorkerTemplatePlugin().apply(workerContext.compiler);
-  
-  if (compilerOptions.externals) {
-    new ExternalsPlugin(
-      getExternalsType(compilerOptions),
-      compilerOptions.externals
-    ).apply(workerContext.compiler);
+  /* 
+  new WebWorkerTemplatePlugin().apply(workerContext.compiler);
+  
+  if (compilerOptions.externals) {
+    new ExternalsPlugin(
+      getExternalsType(compilerOptions),
+      compilerOptions.externals
+    ).apply(workerContext.compiler);
   } */
 
   new _SingleEntryPlugin.default(this.context, `!!${request}`, _path.default.parse(this.resourcePath).name).apply(workerContext.compiler);

package/lib/pluginUtils/getDevPlugins.js

@@ -27,10 +27,15 @@ var _plugins = require("../plugins");
 
 var _RtlCssPlugin = require("../plugins/RtlSplitPlugin/RtlCssPlugin");
 
+var _VariableConversionCollector = _interopRequireDefault(require("../plugins/VariableConversionCollector"));
+
+var _SelectorPlugin = _interopRequireDefault(require("../plugins/SelectorPlugin"));
+
 var _configHtmlWebpackPlugins = require("./configHtmlWebpackPlugins");
 
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 
+// import { windowsModification } from '../loaderUtils/windowsModification';
 const getDevPlugins = (options, publicPath) => {
   const {
     app: {
@@ -41,6 +46,10 @@ const getDevPlugins = (options, publicPath) => {
       context,
       hasEFC: prevOptionForEnableEFC,
       hasShadowDOM,
+      cssVariableReplacementConfig,
+      plugins: pluginObject,
+      // exclude,
+      selectorWeightConfig,
       server: {
         mode
       },
@@ -63,8 +72,9 @@ const getDevPlugins = (options, publicPath) => {
   } = options;
   const hasEFC = newOptionForEnableEFC || prevOptionForEnableEFC;
   const cssLTRFileNameTempalte = enableRTLSplit ? 'css/[name].ltr.css' : 'css/[name].css';
-  const cssRTLFileNameTempalte = 'css/[name].rtl.css';
-  const plugins = [new _plugins.CleanUpStatsPlugin(), new _caseSensitivePathsWebpackPlugin.default(), new _webpack.default.IgnorePlugin(/^\.\/domain$/, /moment$/), new _webpack.default.DefinePlugin({
+  const cssRTLFileNameTempalte = 'css/[name].rtl.css'; // const selectorWeightLocal = windowsModification(exclude.selectorWeight);
+
+  const pluginsArr = [new _plugins.CleanUpStatsPlugin(), new _caseSensitivePathsWebpackPlugin.default(), new _webpack.default.IgnorePlugin(/^\.\/domain$/, /moment$/), new _webpack.default.DefinePlugin({
     __CLIENT__: true,
     __TEST__: false,
     __SERVER__: false,
@@ -82,7 +92,7 @@ const getDevPlugins = (options, publicPath) => {
   }), new _plugins.ResourceHintsPlugin()];
 
   if (enableRTLSplit) {
-    plugins.push(new _RtlCssPlugin.RtlCssPlugin({
+    pluginsArr.push(new _RtlCssPlugin.RtlCssPlugin({
       templateLabel: options.css.templateLabel,
       dirVarName: options.css.dirVarName,
       disableMiniFiySelector: options.css.disableMiniFiySelector,
@@ -93,24 +103,24 @@ const getDevPlugins = (options, publicPath) => {
   }
 
   if (unusedFiles.enable) {
-    plugins.push(new _plugins.UnusedFilesFindPlugin(Object.assign(unusedFiles, {
+    pluginsArr.push(new _plugins.UnusedFilesFindPlugin(Object.assign(unusedFiles, {
       origin: _path.default.join(process.cwd(), folder)
     })));
   }
 
   const i18nManifestFileName = 'i18n-manifest.json';
-  /**
-   * NOTE:
-   *  this file name ext .i18n.js added
-   *  Because, in service worker they maintain cache as file name based
-   *  So, to make differce we added .i18n.js ext.
+  /**
+   * NOTE:
+   *  this file name ext .i18n.js added
+   *  Because, in service worker they maintain cache as file name based
+   *  So, to make differce we added .i18n.js ext.
    */
 
   const i18nFileNameTemplate = 'i18n-chunk/[locale]/[name].i18n.js';
   const i18nPublicPath = publicPath || '';
 
   if (i18n.chunkSplitEnable) {
-    plugins.push(new _I18nSplitPlugin.default({
+    pluginsArr.push(new _I18nSplitPlugin.default({
       jsResource: i18n.jsResource,
       localeVarName: i18n.localeVarName,
       jsonpFunc: i18n.jsonpFunc,
@@ -125,7 +135,7 @@ const getDevPlugins = (options, publicPath) => {
     const i18nPath = _path.default.join(process.cwd(), context, 'i18n');
 
     if (_fs.default.existsSync(i18nPath)) {
-      plugins.push(new _copyWebpackPlugin.default([{
+      pluginsArr.push(new _copyWebpackPlugin.default([{
         from: `${i18nPath}/`,
         to: './i18n/[name].[ext]',
         toType: 'template'
@@ -133,16 +143,16 @@ const getDevPlugins = (options, publicPath) => {
     }
   }
 
-  tpFolder && plugins.push(new _copyWebpackPlugin.default([{
+  tpFolder && pluginsArr.push(new _copyWebpackPlugin.default([{
     from: `${_path.default.join(process.cwd(), context, tpFolder)}/`,
     to: `./${tpFolder}/`,
     toType: 'dir'
   }]));
-  plugins.push(new _lodashWebpackPlugin.default({
+  pluginsArr.push(new _lodashWebpackPlugin.default({
     collections: true,
     shorthands: true
   }));
-  (0, _configHtmlWebpackPlugins.configHtmlWebpackPlugins)(plugins, {
+  (0, _configHtmlWebpackPlugins.configHtmlWebpackPlugins)(pluginsArr, {
     enableChunkHash: false,
     folder,
     minify: false,
@@ -152,7 +162,7 @@ const getDevPlugins = (options, publicPath) => {
   });
 
   if (hasEFC) {
-    plugins.push(new _plugins.EFCPlugin({
+    pluginsArr.push(new _plugins.EFCPlugin({
       isDevelopment: true,
       i18nManifestFileName,
       templateFilePath,
@@ -165,7 +175,7 @@ const getDevPlugins = (options, publicPath) => {
     }));
   }
 
-  plugins.push(new _plugins.I18NInjectIntoIndexPlugin({
+  pluginsArr.push(new _plugins.I18NInjectIntoIndexPlugin({
     publicPath: i18nPublicPath,
     isDevelopment: true,
     templateLabel: i18n.templateLabel || '{{--user-locale}}',
@@ -173,16 +183,28 @@ const getDevPlugins = (options, publicPath) => {
     i18nManifestFileName,
     mainChunkName: 'main'
   }));
-  instrumentScript && plugins.push(new _plugins.ScriptInstrumentPlugin());
-  hasShadowDOM && plugins.push(new _plugins.ShadowDOMSupportPlugin());
+  instrumentScript && pluginsArr.push(new _plugins.ScriptInstrumentPlugin());
+  hasShadowDOM && pluginsArr.push(new _plugins.ShadowDOMSupportPlugin());
 
   if (devCssFileBountry) {
-    plugins.push(new _RequireVariablePublicPlugin.default({
+    pluginsArr.push(new _RequireVariablePublicPlugin.default({
       requireFuncName: 'require'
     }));
   }
 
-  return plugins.filter(Boolean);
+  if (pluginObject.cssVariableReplacement) {
+    pluginsArr.push(new _VariableConversionCollector.default({
+      cssVariableReplacementConfig
+    }));
+  }
+
+  if (pluginObject.selectorWeight) {
+    pluginsArr.push(new _SelectorPlugin.default({
+      selectorWeightConfig
+    }));
+  }
+
+  return pluginsArr.filter(Boolean);
 };
 
 var _default = getDevPlugins;

package/lib/pluginUtils/getProdPlugins.js

@@ -23,6 +23,10 @@ var _I18nSplitPlugin = _interopRequireDefault(require("../plugins/I18nSplitPlugi
 
 var _copyWebpackPlugin = _interopRequireDefault(require("copy-webpack-plugin"));
 
+var _VariableConversionCollector = _interopRequireDefault(require("../plugins/VariableConversionCollector"));
+
+var _SelectorPlugin = _interopRequireDefault(require("../plugins/SelectorPlugin"));
+
 var _plugins = require("../plugins");
 
 var _RtlCssPlugin = require("../plugins/RtlSplitPlugin/RtlCssPlugin");
@@ -52,6 +56,10 @@ const getProdPlugins = (options, publicPath = '') => {
       mode
     },
     hasShadowDOM,
+    cssVariableReplacementConfig,
+    plugins: pluginObject,
+    // exclude,
+    selectorWeightConfig,
     resourceHints,
     serviceWorker,
     htmlTemplate,
@@ -81,7 +89,7 @@ const getProdPlugins = (options, publicPath = '') => {
   const cssRTLFileNameTempalte = `css/[name]${hashTempalate}.rtl.css`;
   const isDevelopment = mode === 'prod' || mode === 'dev' || mode === 'dev-no-warn';
   enableChunkHash = !isDevelopment && enableChunkHash;
-  const plugins = [new _caseSensitivePathsWebpackPlugin.default(), new _webpack.default.IgnorePlugin(/^\.\/locale$/, /moment$/), new _webpack.default.DefinePlugin({
+  const pluginsArr = [new _caseSensitivePathsWebpackPlugin.default(), new _webpack.default.IgnorePlugin(/^\.\/locale$/, /moment$/), new _webpack.default.DefinePlugin({
     __TEST__: false,
     __DEVELOPMENT__: false,
     __LOCAL_PRODUCTION__: isDevelopment,
@@ -97,7 +105,7 @@ const getProdPlugins = (options, publicPath = '') => {
   }), new _plugins.ResourceHintsPlugin(), new _plugins.UglifyCSSPlugin()];
 
   if (enableRTLSplit) {
-    plugins.push(new _RtlCssPlugin.RtlCssPlugin({
+    pluginsArr.push(new _RtlCssPlugin.RtlCssPlugin({
       templateLabel: options.css.templateLabel,
       disableMiniFiySelector: options.css.disableMiniFiySelector,
       dirVarName: options.css.dirVarName,
@@ -108,11 +116,11 @@ const getProdPlugins = (options, publicPath = '') => {
   }
 
   const i18nManifestFileName = 'i18n-manifest.json';
-  /**
-   * NOTE:
-   *  this file name ext .i18n.js added
-   *  Because, in service worker they maintain cache as file name based
-   *  So, to make differce we added .i18n.js ext.
+  /**
+   * NOTE:
+   *  this file name ext .i18n.js added
+   *  Because, in service worker they maintain cache as file name based
+   *  So, to make differce we added .i18n.js ext.
    */
 
   const i18nFileNameTemplate = 'i18n-chunk/[locale]/[name].[chunkhash].i18n.js';
@@ -120,7 +128,7 @@ const getProdPlugins = (options, publicPath = '') => {
   // const  i18nFileNameTemplate = 'i18n-chunk/[locale]/[name]_.js';
 
   if (i18n.chunkSplitEnable) {
-    plugins.push(new _I18nSplitPlugin.default({
+    pluginsArr.push(new _I18nSplitPlugin.default({
       jsResource: i18n.jsResource,
       localeVarName: i18n.localeVarName,
       jsonpFunc: i18n.jsonpFunc,
@@ -135,7 +143,7 @@ const getProdPlugins = (options, publicPath = '') => {
     const i18nPath = _path.default.join(process.cwd(), context, 'i18n');
 
     if (_fs.default.existsSync(i18nPath)) {
-      plugins.push(new _copyWebpackPlugin.default([{
+      pluginsArr.push(new _copyWebpackPlugin.default([{
         from: `${i18nPath}/`,
         to: enableChunkHash ? './i18n/[name].[hash:20]_.[ext]' : './i18n/[name]_.[ext]',
         toType: 'template'
@@ -143,12 +151,12 @@ const getProdPlugins = (options, publicPath = '') => {
     }
   }
 
-  tpFolder && plugins.push(new _copyWebpackPlugin.default([{
+  tpFolder && pluginsArr.push(new _copyWebpackPlugin.default([{
     from: `${_path.default.join(process.cwd(), context, tpFolder)}/`,
     to: `./${tpFolder}/`,
     toType: 'dir'
   }]));
-  (0, _configHtmlWebpackPlugins.configHtmlWebpackPlugins)(plugins, {
+  (0, _configHtmlWebpackPlugins.configHtmlWebpackPlugins)(pluginsArr, {
     enableChunkHash,
     folder,
     inject,
@@ -158,7 +166,7 @@ const getProdPlugins = (options, publicPath = '') => {
   });
 
   if (hasEFC) {
-    plugins.push(new _plugins.EFCPlugin({
+    pluginsArr.push(new _plugins.EFCPlugin({
       isDevelopment,
       serverUrl: publicPath,
       i18nFileNameTemplate,
@@ -172,7 +180,7 @@ const getProdPlugins = (options, publicPath = '') => {
     }));
   }
 
-  plugins.push(new _plugins.I18NInjectIntoIndexPlugin({
+  pluginsArr.push(new _plugins.I18NInjectIntoIndexPlugin({
     // Because we  will handle cdn url in CdnChangePlugin
     publicPath: cdnMapping.isCdnEnabled ? '' : i18nPublicPath,
     isDevelopment,
@@ -186,7 +194,7 @@ const getProdPlugins = (options, publicPath = '') => {
     const {
       callback
     } = publicPaths;
-    plugins.push(callback ? new _plugins.PublicPathCallbackPlugin({
+    pluginsArr.push(callback ? new _plugins.PublicPathCallbackPlugin({
       callback
     }) : new _plugins.PublicPathChangePlugin({
       publicPaths,
@@ -195,24 +203,24 @@ const getProdPlugins = (options, publicPath = '') => {
   }
 
   if (cdnMapping.isCdnEnabled) {
-    plugins.push(new _plugins.CdnChangePlugin(cdnMapping));
+    pluginsArr.push(new _plugins.CdnChangePlugin(cdnMapping));
   }
 
-  plugins.push(new _lodashWebpackPlugin.default({
+  pluginsArr.push(new _lodashWebpackPlugin.default({
     collections: true,
     shorthands: true
   }));
-  hasShadowDOM && plugins.push(new _plugins.ShadowDOMSupportPlugin());
+  hasShadowDOM && pluginsArr.push(new _plugins.ShadowDOMSupportPlugin());
 
   if (!isDevelopment) {
-    enableSMap && enableSMapHook && plugins.push(new _plugins.SourceMapHookPlugin());
-    optimize && plugins.push(new _plugins.OptimizeJSPlugin());
-    plugins.push(new _plugins.ManifestPlugin({
+    enableSMap && enableSMapHook && pluginsArr.push(new _plugins.SourceMapHookPlugin());
+    optimize && pluginsArr.push(new _plugins.OptimizeJSPlugin());
+    pluginsArr.push(new _plugins.ManifestPlugin({
       fileName: manifestFileName
     }));
 
     if (bundleAnalyze) {
-      plugins.push(new _webpackBundleAnalyzer.BundleAnalyzerPlugin({
+      pluginsArr.push(new _webpackBundleAnalyzer.BundleAnalyzerPlugin({
         analyzerMode: 'static',
         generateStatsFile: true,
         openAnalyzer: false,
@@ -229,7 +237,7 @@ const getProdPlugins = (options, publicPath = '') => {
     }
 
     if (tpHashMapping && tpHashMapping.length > 0) {
-      plugins.push(new _plugins.TPHashMappingPlugin({
+      pluginsArr.push(new _plugins.TPHashMappingPlugin({
         fileMappings: tpHashMapping,
         tpFolder: `${_path.default.join(process.cwd(), context, tpFolder)}/`
       }));
@@ -248,7 +256,7 @@ const getProdPlugins = (options, publicPath = '') => {
       throw new Error('File Path required for service worker plugin');
     }
 
-    plugins.push(new _plugins.ServiceWorkerPlugin({
+    pluginsArr.push(new _plugins.ServiceWorkerPlugin({
       filePath: _path.default.join(process.cwd(), filePath),
       i18nFileNameTemplate,
       fileName: fileName,
@@ -258,7 +266,20 @@ const getProdPlugins = (options, publicPath = '') => {
     }));
   }
 
-  return plugins;
+  if (pluginObject.cssVariableReplacement) {
+    pluginsArr.push(new _VariableConversionCollector.default({
+      cssVariableReplacementConfig
+    }));
+  }
+
+  if (pluginObject.selectorWeight) {
+    pluginsArr.push(new _SelectorPlugin.default({
+      selectorWeightConfig
+    }));
+  } // plugins.push(new VariableConversionCollector({}));
+
+
+  return pluginsArr;
 };
 
 var _default = getProdPlugins;

package/lib/plugins/EFCPlugin.md

@@ -1,6 +1,6 @@
-# EFC Plugin
-
-In EFC plugin we are create sdk file for efc related purpose
-
-
-# document will be soon
+# EFC Plugin
+
+In EFC plugin we are create sdk file for efc related purpose
+
+
+# document will be soon

package/lib/plugins/I18NInjectIntoIndexPlugin.js

@@ -116,10 +116,10 @@ class I18NInjectIntoIndexPlugin {
         i18nObj = i18nFiles.reduce((res, next) => {
           let fileName = next.replace(`i18n${_path.default.sep}`, '');
           let splittedFileName = fileName.split('.');
-          /* if (this.isDevelopment) {
-            res[splittedFileName[0]] = `${this.publicPath}/i18n/${fileName}`;
-          } else {
-            res[splittedFileName[0]] = fileName;
+          /* if (this.isDevelopment) {
+            res[splittedFileName[0]] = `${this.publicPath}/i18n/${fileName}`;
+          } else {
+            res[splittedFileName[0]] = fileName;
           } */
 
           res[splittedFileName[0]] = `${this.publicPath}/i18n/${fileName}`;

package/lib/plugins/I18nSplitPlugin/I18nDownlodLogic.js

@@ -13,23 +13,23 @@ var _hashUtils = require("./utils/hashUtils");
 
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 
-/**
- * this plugin for the download i18n files
- * So, if need to downoad i18n in browser this plugin handle that
- *
- *
- * this plugin works
- * how it works?
- *  this plugin hook the requireEnsure method and we write logic for current compiled file download logic
- *
- * hinds:-
- *  requireEnsure method was loader for all js chunk's ,
- *  which means if we use dynamic import then this function will create script tag for that dynamic resource
- *  so every dynamic js chunk will load by this function,
- *  So we update this function with when  dynamic jschunk call the nour code also execute
- *
- * some thing  missing  in this definetion
- *
+/**
+ * this plugin for the download i18n files
+ * So, if need to downoad i18n in browser this plugin handle that
+ *
+ *
+ * this plugin works
+ * how it works?
+ *  this plugin hook the requireEnsure method and we write logic for current compiled file download logic
+ *
+ * hinds:-
+ *  requireEnsure method was loader for all js chunk's ,
+ *  which means if we use dynamic import then this function will create script tag for that dynamic resource
+ *  so every dynamic js chunk will load by this function,
+ *  So we update this function with when  dynamic jschunk call the nour code also execute
+ *
+ * some thing  missing  in this definetion
+ *
  */
 // import { REGEXP_HASH, REGEXP_CHUNKHASH } from './utils/hashUtils';
 const pluginName = 'DownloadLogicOfI18n'; // const pluginName = 'i18n-plugin';
@@ -126,20 +126,20 @@ class I18nDownlodLogic {
       return _webpack.Template.asString([source, '', '// object to store loaded I18N chunks', 'var installedI18nChunks = {', _webpack.Template.indent(mainChunk.ids.map(id => `${JSON.stringify(id)}: 0`).join(',\n')), '};']);
     });
     mainTemplate.hooks.requireEnsure.tap(pluginName, (source, mainChunk, hash) => {
-      /**
-       * for Information this is tapped in mainTemplate ,
-       * So this hooks argument chunk is main chunk means entry chunk mostly.
-       * if any chunk has i18n then we must write our download  i18n logic,
+      /**
+       * for Information this is tapped in mainTemplate ,
+       * So this hooks argument chunk is main chunk means entry chunk mostly.
+       * if any chunk has i18n then we must write our download  i18n logic,
        */
       const chunkMap = this.getI18nChunkObject(mainChunk);
 
       if (!Object.keys(chunkMap).length) {
         return source;
       }
-      /**
-       *   chunkMaps has
-       *  @property  {Object} hash  [it has key  as chunk id and value as chunkHash ]
-       *  @property  {Object} name  [it has key  as chunk id and value as chunk name ]
+      /**
+       *   chunkMaps has
+       *  @property  {Object} hash  [it has key  as chunk id and value as chunkHash ]
+       *  @property  {Object} name  [it has key  as chunk id and value as chunk name ]
        */
 
 
@@ -176,22 +176,22 @@ class I18nDownlodLogic {
         },
         contentHashType: MODULE_TYPE
       });
-      /** IDEA:
-       *      as my suggestion ignore this `jsop` approch,
-       *      Because json parse is faster then js parse.
-       *      my suggestion  is make ajax or fetch request
+      /** IDEA:
+       *      as my suggestion ignore this `jsop` approch,
+       *      Because json parse is faster then js parse.
+       *      my suggestion  is make ajax or fetch request
        */
 
       const buf = [];
-      /*
-        if (REGEXP_HASH.test(filenameTemplate)) {
-          buf.push(
-            `var hash = ${mainTemplate.renderCurrentHashCode(hash)};`
-          );
-        }
-        if (REGEXP_CHUNKHASH.test(filenameTemplate)) {
-          buf.push(`var chunkHashes = ${JSON.stringify(chunkMaps.hash)};`);
-        }
+      /*
+        if (REGEXP_HASH.test(filenameTemplate)) {
+          buf.push(
+            `var hash = ${mainTemplate.renderCurrentHashCode(hash)};`
+          );
+        }
+        if (REGEXP_CHUNKHASH.test(filenameTemplate)) {
+          buf.push(`var chunkHashes = ${JSON.stringify(chunkMaps.hash)};`);
+        }
         */
 
       if ((0, _hashUtils.hasContentHash)(filenameTemplate)) {