@zohodesk/react-cli 0.0.1-exp.167.1 → 0.0.1-exp.167.2

package/lib/loaderUtils/configsAssetsLoaders.js

@@ -0,0 +1,117 @@
+"use strict";
+
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.configAudioLoader = configAudioLoader;
+exports.configFontLoader = configFontLoader;
+exports.configImageLoader = configImageLoader;
+exports.configSVGLoader = configSVGLoader;
+exports.configVideoLoader = configVideoLoader;
+exports.configVideoLoaderObj = configVideoLoaderObj;
+exports.createNameTemplate = createNameTemplate;
+
+var _path = _interopRequireDefault(require("path"));
+
+function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
+
+// function getLoaderOptionQueryString(params) {
+const ImageExtRegex = /\.jpe?g$|\.gif$|\.png$/;
+const FontExtRegex = /\.woff2|\.woff$|\.ttf$|\.eot$/;
+const SVGExtRegex = /\.svg$/;
+const AudioExtRegex = /\.ogg$/;
+const VidioExtRegex = /\.mp4$/;
+
+function createLoaderOptionQueryString(loaderName, nameTemplate, limit = 1000) {
+  return `${loaderName}?limit=${limit}&name=${nameTemplate}`;
+}
+
+function configImageLoader(nameTemplate) {
+  return {
+    test: ImageExtRegex,
+    use: createLoaderOptionQueryString('url-loader', `./images/${nameTemplate}`)
+  };
+}
+
+function configFontLoader(nameTemplate) {
+  return {
+    test: FontExtRegex,
+    use: createLoaderOptionQueryString('url-loader', `./fonts/${nameTemplate}`)
+  };
+}
+
+function configSVGLoader(nameTemplate) {
+  return {
+    test: SVGExtRegex,
+    use: createLoaderOptionQueryString('url-loader', `./fonts/${nameTemplate}`, 1)
+  };
+}
+
+function configAudioLoader(nameTemplate) {
+  return {
+    test: AudioExtRegex,
+    use: createLoaderOptionQueryString('file-loader', `./fonts/${nameTemplate}`, 1)
+  };
+}
+
+function configVideoLoader(nameTemplate) {
+  return {
+    test: VidioExtRegex,
+    use: createLoaderOptionQueryString('url-loader', `./images/${nameTemplate}`, 1)
+  };
+}
+
+function configVideoLoaderObj(nameTemplate) {
+  return {
+    test: VidioExtRegex,
+    use: {
+      loader: 'url-loader',
+      options: {
+        limit: 1000,
+        name: nameTemplate,
+        fallback: _path.default.join(__dirname, '..', 'loaders', 'fileLoader.js')
+      }
+    }
+  };
+}
+
+function createNameTemplate(enableChunkHash) {
+  const ext = `${enableChunkHash ? '.[hash:20]' : ''}.[ext]`;
+  return `[name]${ext}`;
+}
+/*
+export function createImageAndFontsAndSVGLoaders(enableChunkHash) {
+  const nameTemplate = createNameTemplate(enableChunkHash);
+  return [
+    configImageLoader(nameTemplate),
+    configFontLoader(nameTemplate),
+    configSVGLoader(nameTemplate),
+    configAudioLoader(nameTemplate)
+  ];
+}
+*/
+
+/*
+export function createLoaderOptionObject(
+  loaderName,
+  nameTemplate,
+  fallback,
+  limit = 1000
+) {
+  return {
+    loader: loaderName,
+    options: {
+      limit,
+      name: nameTemplate,
+      fallback
+    }
+  };
+}
+
+function configLoaderObject(filter, loaderAndOptions) {
+  return {
+    test: filter,
+    use: loaderAndOptions
+  };
+}
+*/

package/lib/loaderUtils/getCSSLoaders.js

@@ -13,10 +13,31 @@ var _utils = require("../utils");
 
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 
-let options = (0, _utils.getOptions)();
-let isWin = process.platform === 'win32';
+const fs = require('fs');
 
-let getCSSLoaders = (hasRTL, rtlExclude, classNameBlob, cssUniqueness, selectorReplace, cssHashSelectors, classNamePrefix) => {
+const options = (0, _utils.getOptions)();
+const isWin = process.platform === 'win32';
+
+function windowsModification(array) {
+  return isWin ? array.map(r => r.replace(/\//g, '\\')) : array;
+}
+
+function excludeEmptyCheckPlugin({
+  enable,
+  ignore,
+  plugins
+}) {
+  return enable ? ignore.length === 0 ? plugins : [require('../postcss-plugins/ExcludePlugin')({
+    ignore,
+    plugins
+  })] : [];
+}
+
+const getCSSLoaders = (plugins, exclude, mediaQueryHoverActiveString, cssVariableReplacementConfig, classNameBlob, cssUniqueness, selectorReplace, cssHashSelectors, classNamePrefix) => {
+  // console.log('plugins:')
+  // console.log(plugins)
+  // console.log('exclude:')
+  // console.log(exclude)
   const {
     devCssFileBountry
   } = options.app;
@@ -26,9 +47,14 @@ let getCSSLoaders = (hasRTL, rtlExclude, classNameBlob, cssUniqueness, selectorR
   const {
     cssSelectorZipPath
   } = options.impactService;
-  let rtlExcludeLocal = isWin ? rtlExclude.map(r => r.replace(/\//g, '\\')) : rtlExclude;
-  let cssLoaderOptions = {
-    importLoaders: hasRTL ? 1 : 0,
+  fs.writeFileSync('./css_error.log', '');
+  const rtlExcludeLocal = windowsModification(exclude.rtl);
+  const hoverActiveExcludeLocal = windowsModification(exclude.hoverActive);
+  const combinerMediaQueryExcludeLocal = windowsModification(exclude.combinerMediaQuery);
+  const cssVariableReplacementExcludeLocal = windowsModification(exclude.cssVariableReplacement);
+  const cssLoaderOptions = {
+    // importLoaders: hasRTL||hoverActive ? 1 : 0,
+    importLoaders: 1,
     modules: {},
     sourceMap: true
   };
@@ -39,7 +65,13 @@ let getCSSLoaders = (hasRTL, rtlExclude, classNameBlob, cssUniqueness, selectorR
     cssLoaderOptions.modules.getLocalIdent = (0, _cssClassNameGenerate.default)(cssUniqueness, cssHashSelectors, classNamePrefix);
   }
 
-  const postcssPlugins = [valueReplacer && require('../postcss-plugins/ValueReplacer')(valueReplacer), selectorReplace && require('postcss-selector-replace')(selectorReplace), hasRTL && require('../postcss-plugins/ExcludeRTLPlugin')({
+  const postcssPlugins = [valueReplacer && require('../postcss-plugins/ValueReplacer')(valueReplacer), selectorReplace && require('postcss-selector-replace')(selectorReplace), // ...excludeEmptyCheckPlugin({
+  //   enable: true,
+  //   ignore: [],
+  //   plugins: [require('../postcss-plugins/variablePropertiesCollector').default()]
+  // }),
+  ...excludeEmptyCheckPlugin({
+    enable: plugins.hasRTL,
     ignore: rtlExcludeLocal,
     plugins: [require('@zohodesk/postcss-rtl')({
       addPrefixToSelector: function addPrefixToSelector(selector, prefix) {
@@ -50,6 +82,18 @@ let getCSSLoaders = (hasRTL, rtlExclude, classNameBlob, cssUniqueness, selectorR
         return `${prefix} ${selector}`; // Make selectors like [dir=rtl] > .selector
       }
     })]
+  }), ...excludeEmptyCheckPlugin({
+    enable: plugins.combinerMediaQuery,
+    ignore: combinerMediaQueryExcludeLocal,
+    plugins: [require('postcss-combine-media-query')]
+  }), ...excludeEmptyCheckPlugin({
+    enable: plugins.hoverActive,
+    ignore: hoverActiveExcludeLocal,
+    plugins: [require('../postcss-plugins/hoverActivePlugin')(mediaQueryHoverActiveString)]
+  }), ...excludeEmptyCheckPlugin({
+    enable: plugins.cssVariableReplacement,
+    ignore: cssVariableReplacementExcludeLocal,
+    plugins: [fs.existsSync(cssVariableReplacementConfig) && require('../postcss-plugins/variableModificationPlugin/index')(cssVariableReplacementConfig)]
   })].filter(Boolean);
   return [cssSelectorZipPath && {
     loader: require.resolve('../loaders/selectorMappingLoader')

package/lib/plugins/I18nSplitPlugin/I18nSplit.md

@@ -3,84 +3,93 @@
 generaly we have manage our all I18n keys and values as language specific i18n files and then we download all i18n in initial page load.
 
 ### what is the problem with this?.
+
 the problem is i18n file keep get's grown it will affect the the inital page load and critial rendering path.
 So, We have decide to create a plugin for split i18n per chunk's of js vise.
 
 ### what is i18n split?
-  it is like code split for i18n.
-  we will collect i18n from js chunk and we will create separate i18n chunk per js chunk,
-   with this we already load Js chunks are on demand and now we also download i18n also ondemand with this the initial and forthere actions.
-  when js download's we will download i18n with it.  
 
-###  How to we going to i18n split?
-  we will read the js chunk and collect I18n keys form it,
-  then we will create i18n chunk files with these used keys.
+it is like code split for i18n.
+we will collect i18n from js chunk and we will create separate i18n chunk per js chunk,  
+ with this we already load Js chunks are on demand and now we also download i18n also ondemand with this the initial and forthere actions.  
+ when js download's we will download i18n with it.
+
+### How to we going to i18n split?
+
+we will read the js chunk and collect I18n keys form it,  
+ then we will create i18n chunk files with these used keys.
 
 ### how do you collect i18n keys from js files?
-  we will traverse the js file's AST (static analysis) and find i18 keys,
-  we will concider all string which is in jsResource file as i18n keys.
-  and you can tell dynamic i18n key by js comments,
-  Like Below:- 
-  ```js
-  fetch("tickets?view=view1").then(data => {
-    // I18n support.ticketsEmpty
-    // I18n support.viewNotFount
-    // I18n support.permissionDenied
-    let text = getI18nValue(data.i18nkey);
-  })
-  ```
+
+we will traverse the js file's AST (static analysis) and find i18 keys,  
+ we will concider all string which is in jsResource file as i18n keys.  
+ and you can tell dynamic i18n key by js comments,  
+ Like Below:-
+
+```js
+fetch('tickets?view=view1').then(data => {
+  // I18n support.ticketsEmpty
+  // I18n support.viewNotFount
+  // I18n support.permissionDenied
+  let text = getI18nValue(data.i18nkey);
+});
+```
 
 ### is there any posiblity for unwanted keys in some chunk?
-  Yes, there is two posiblity
-  1. js comment , if you write js comment but it is  not needed then it will be add into i18n chunk
-    `To Resolve` we currently do not have perfect idea for this, But we can check this  by chunk size limit.
-    `idea's will be welcome`
-  2. like we said "we will concider all string which is in jsResource file as i18n keys",
-     So if you use string not for i18n but it was in jsResource then it will be add into i18n chunk.
-     `To Resolve` this  problem we can use some  kinda prefix or something. 
+
+Yes, there is two posiblity
+
+1. js comment , if you write js comment but it is not needed then it will be add into i18n chunk  
+   `To Resolve` we currently do not have perfect idea for this, But we can check this by chunk size limit.  
+   `idea's will be welcome`
+2. like we said "we will concider all string which is in jsResource file as i18n keys",  
+   So if you use string not for i18n but it was in jsResource then it will be add into i18n chunk.  
+   `To Resolve` this problem we can use some kinda prefix or something.
 
 ### how do we downlowd and give to app?
-  we have over write defualt webpack requireEnsure (every dynamic chunk requests are done by that function) function.
-  and we parlarly dowload i18n files. and we ask jsonFunction, to our plugin.
-So we send i18nkeys , when it was download,
-you must store all i18n keys, we give asycrnsly by that function download in that patticular.
+
+we have over write defualt webpack requireEnsure (every dynamic chunk requests are done by that function) function.  
+ and we parlarly dowload i18n files. and we ask jsonFunction, to our plugin.  
+So we send i18nkeys , when it was download,  
+you must store all i18n keys, we give asycrnsly by that function download in that patticular.  
 so you must store and update (like append or assign) everytime that function call.
 
 ### how to use this feature?
-  to use this feature use have give the below oprtions
-  `package.json`
-  ```json
-  {
-    /// ...some things
-    "react-cli": {
-      //  ...some things
-      "i18n": {   
-        "chunkSplitEnable": true,
-        "jsResource": "./deskapp/properties/JSResources.properties",
-        "localeVarName": "window.userInfo.langCode",
-        "jsonpFunc": "window.loadI18nChunk",
-        "templateLabel": "{{--user-locale}}",// this is  for html template i18n file path locate template
-        "propertiesFolder": "./deskapp/properties"
-      },
-      //  ...some things
+
+to use this feature use have give the below oprtions  
+ `package.json`
+
+```json
+{
+  /// ...some things
+  "react-cli": {
+    //  ...some things
+    "i18n": {
+      "chunkSplitEnable": true,
+      "jsResource": "./deskapp/properties/JSResources.properties",
+      "localeVarName": "window.userInfo.langCode",
+      "jsonpFunc": "window.loadI18nChunk",
+      "templateLabel": "{{--user-locale}}", // this is  for html template i18n file path locate template
+      "propertiesFolder": "./deskapp/properties"
     }
+    //  ...some things
   }
-  ```
-
+}
+```
 
 <!-- not need below -->
-<!-- 
+<!--we have added new feature for css to write logic to how hover related css work in hoverhover and a
 
 ### is there any problems with static analysis?
-  Yes, 
+  Yes,
 
 ### how do we use dynamic i18n key?
 
-  and we will download i18n file with 
+  and we will download i18n file with
 
   and when js chunk download's then we will download i18n as need.
   we all know in our app we loading i18n as one single big file for each locale(language).
-  we are going to split i18n as per js chunk, and when js chunk download's then we will download i18n as need. 
-  
-  
+  we are going to split i18n as per js chunk, and when js chunk download's then we will download i18n as need.
+
+
   -->

package/lib/postcss-plugins/{ExcludeRTLPlugin.js → ExcludePlugin.js}

@@ -4,7 +4,7 @@ var _postcss = _interopRequireDefault(require("postcss"));
 
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 
-module.exports = _postcss.default.plugin('postcss-exclude-rtl-files', opts => {
+module.exports = _postcss.default.plugin('postcss-exclude-files', opts => {
   const {
     plugins
   } = opts;

package/lib/postcss-plugins/__test__/hoverActivePlugin.spec.js

@@ -0,0 +1,22 @@
+"use strict";
+
+const fs = require('fs');
+
+const postcss = require('postcss');
+
+function expectRunPostCss(inputFile, outputfile, cb) {
+  const inputStr = fs.readFileSync(inputFile, 'utf-8');
+  postcss(plugins).process(inputStr, {
+    from,
+    to
+  }).then(result => {
+    expect(result.css).toBe(fs.readFileSync(outputfile, 'utf-8'));
+    cb();
+  });
+}
+
+describe('To Check Hover active postcss Plugin  ', () => {
+  test('should handle normal rule hover', cb => {
+    expectRunPostCss('test1Input.css', 'test1Output.css', cb);
+  });
+});

package/lib/postcss-plugins/__test__/test1Input.css

@@ -0,0 +1,39 @@
+/*Hover_active:ignore*/
+g,a:hover{
+	color : red
+}
+/*Hover:ignore*/
+h:hover{
+background : yellow
+}
+
+/* Hover_active:ignore */
+g,d+e:hover{
+	color : black
+}
+
+g,d e:hover{
+	color : black
+}
+
+@media screen and (max-width:61.25em){
+  /* Hover_active:ignore */
+  a,b,a:hover, b:hover{
+  background-color : blue
+  }
+  a + b,a:hover + b:hover{
+  background-color : blue
+  }
+  a b:hover{
+  background-color : blue
+  }
+  
+  .cc:hover {
+    color: red;
+  }
+
+  c:hover{
+  color : red
+  }
+  
+}

package/lib/postcss-plugins/__test__/test1Output.css

@@ -0,0 +1,39 @@
+/*Hover_active:ignore*/
+g,a:hover{
+	color : red
+}
+/*Hover:ignore*/
+h:hover{
+background : yellow
+}
+
+/* Hover_active:ignore */
+g,d+e:hover{
+	color : black
+}
+
+g,d e:hover{
+	color : black
+}
+
+@media screen and (max-width:61.25em){
+  /* Hover_active:ignore */
+  a,b,a:hover, b:hover{
+  background-color : blue
+  }
+  a + b,a:hover + b:hover{
+  background-color : blue
+  }
+  a b:hover{
+  background-color : blue
+  }
+  
+  .cc:hover {
+    color: red;
+  }
+
+  c:hover{
+  color : red
+  }
+  
+}