@zohodesk/codestandard-validator 1.4.0 → 1.4.2

package/build/hooks/Precommit/lint.js

@@ -45,9 +45,10 @@ async function lintFiles(filePath) {
   return [];
 }
 async function findEslintErrors(file) {
-  const nodeModulesPath = getNodeModulesPath();
+  const nodeModulesPath = path.resolve(getNodeModulesPath());
   const eslintPath = getEslintExecutablePath();
-  const eslintConfig = `${nodeModulesPath}/.eslintrc.js`;
+  const eslintConfig = path.join(nodeModulesPath, '.eslintrc.js');
+  const resolvePluginsPath = path.join(nodeModulesPath, 'node_modules');
   if (!fs.existsSync(nodeModulesPath)) {
     Logger.log(Logger.INFO_TYPE, 'node_modules not found');
     return [];
@@ -56,7 +57,7 @@ async function findEslintErrors(file) {
     Logger.log(Logger.INFO_TYPE, 'Eslint executable not found. Make sure eslint plugin is installed');
     return [];
   }
-  return execSync(`npx --ignore-existing "${eslintPath}" --config "${eslintConfig}" --no-inline-config --resolve-plugins-relative-to="${nodeModulesPath}/node_modules" ${path.resolve(getRootDirectory(), file)}`).then(({
+  return execSync(`npx --ignore-existing "${eslintPath}" --config "${eslintConfig}" --no-inline-config --resolve-plugins-relative-to="${resolvePluginsPath}" ${path.resolve(getRootDirectory(), file)}`).then(({
     stderr
   }) => stderr ? stderr.toString().trim().split('\n') : []).catch(err => {
     Logger.log(Logger.FAILURE_TYPE, err);

package/build/hooks/Precommit/pre-commit-default.js

@@ -113,15 +113,16 @@ async function lintFiles(filePath) {
  */
 
 function findEslintErrors(file) {
-  let nodeModulesPathOfProject = `${getNodeModulesPath()}`;
+  let nodeModulesPathOfProject = path.resolve(getNodeModulesPath());
   let eslintExecutablePath = getEslintExecutablePath();
-  let eslintConfigurationFilePath = `${nodeModulesPathOfProject}/.eslintrc.js`;
+  let eslintConfigurationFilePath = path.join(nodeModulesPathOfProject, '.eslintrc.js');
+  let resolvePluginsPath = path.join(nodeModulesPathOfProject, 'node_modules');
   let isEslintExecutablePresent = fs.existsSync(eslintExecutablePath) ? true : false;
   let isNodeModulesPresent = fs.existsSync(nodeModulesPathOfProject);
   if (isNodeModulesPresent) {
     if (isEslintExecutablePresent) {
       return new Promise((resolve, reject) => {
-        exec(`npx --ignore-existing "${eslintExecutablePath}" --config "${eslintConfigurationFilePath}" --no-inline-config --resolve-plugins-relative-to="${nodeModulesPathOfProject}/node_modules" ${path.resolve(getRootDirectory(), file)}`, (error, stderr, stdout) => {
+        exec(`npx --ignore-existing "${eslintExecutablePath}" --config "${eslintConfigurationFilePath}" --no-inline-config --resolve-plugins-relative-to="${resolvePluginsPath}" ${path.resolve(getRootDirectory(), file)}`, (error, stderr, stdout) => {
           if (stderr) {
             resolve(stderr.trim().split('\n'));
           } else if (error) {

package/build/hooks/hook.js

@@ -54,8 +54,13 @@ async function hooks() {
   }
 }
 (async function () {
-  await initConfig(getConfigPathExecute());
-  postInstallExecution();
-  await require("../chunk/chunk_Restriction");
-  hooks();
+  try {
+    await initConfig(getConfigPathExecute());
+    await Promise.resolve(postInstallExecution());
+    require("../chunk/chunk_Restriction");
+    await hooks();
+  } catch (error) {
+    Logger.log(Logger.FAILURE_TYPE, `Pre-commit initialization failed: ${error.message}`);
+    process.exit(1);
+  }
 })();

package/build/utils/ConfigFileUtils/getEslintExecutablePath.js

@@ -13,12 +13,18 @@ const {
 const {
   getLibraryInstalledLocation
 } = require('../General/getLibraryInstalledLocation');
+function getProjectNodeModulesPath(projectPath) {
+  const normalizedPath = path.resolve(projectPath);
+  return path.basename(normalizedPath) === 'node_modules' ? normalizedPath : path.join(normalizedPath, 'node_modules');
+}
 function getEslintExecutablePath() {
   let eslintLibraryName = 'eslint';
-  let librariesInNodeModulesOfProject = executeSynchronizedCommands(readdirSync, [path.join(getNodeModulesPath(), 'node_modules')], '', 'Unable to get the plugins inside node_modules', true, false);
+  let nodeModulesPath = getProjectNodeModulesPath(getNodeModulesPath());
+  let librariesInNodeModulesOfProject = executeSynchronizedCommands(readdirSync, [nodeModulesPath], '', 'Unable to get the plugins inside node_modules', true, false);
   let isEslintInstalledinProject = librariesInNodeModulesOfProject.some(library => library === eslintLibraryName);
-  return isEslintInstalledinProject ? path.join(getNodeModulesPath(), 'node_modules', eslintLibraryName, 'bin', 'eslint.js') : path.join(getLibraryInstalledLocation(), 'node_modules', eslintLibraryName, 'bin', 'eslint.js');
+  return isEslintInstalledinProject ? path.join(nodeModulesPath, eslintLibraryName, 'bin', 'eslint.js') : path.join(getLibraryInstalledLocation(), 'node_modules', eslintLibraryName, 'bin', 'eslint.js');
 }
 module.exports = {
-  getEslintExecutablePath
+  getEslintExecutablePath,
+  getProjectNodeModulesPath
 };

package/build/utils/General/getGeneralInfo.js

@@ -103,7 +103,11 @@ function getRunningEnv() {
 function getLastCommitHash() {
   try {
     const cmd = `curl --header "PRIVATE-TOKEN: ${process.env.TOOL_TOKEN}" --url ${commitHashEndPoint}`;
-    return JSON.parse(execSync(cmd))[0]?.id;
+    const response = execSync(cmd, {
+      encoding: 'utf-8',
+      timeout: 10000
+    });
+    return JSON.parse(response)[0]?.id;
   } catch (err) {
     Logger.log(Logger.FAILURE_TYPE, err);
     return null;
@@ -129,7 +133,9 @@ function updateJsonFile(filePath, modifier) {
     const rawData = fs.readFileSync(absolutePath, "utf-8");
     const jsonData = JSON.parse(rawData);
     const updatedData = modifier(jsonData);
-    fs.writeFileSync(absolutePath, JSON.stringify(updatedData, null, 2), "utf-8");
+    const tempPath = `${absolutePath}.${process.pid}.${Date.now()}.tmp`;
+    fs.writeFileSync(tempPath, JSON.stringify(updatedData, null, 2), "utf-8");
+    fs.renameSync(tempPath, absolutePath);
   } catch (error) {
     Logger.log(Logger.FAILURE_TYPE, "Error updating JSON file");
   }

package/build/utils/General/writeProjectDetailsToJson.js

@@ -10,13 +10,24 @@ const {
 const {
   getLastCommitHash
 } = require('./getGeneralInfo');
+function getProjectRootFromInstallPath(currentPath) {
+  const isWindowsAbsolutePath = /^[A-Za-z]:[\\/]/.test(String(currentPath));
+  const normalizedPath = (isWindowsAbsolutePath ? String(currentPath) : path.resolve(currentPath)).replace(/\\/g, '/');
+  const packageSuffix = '/node_modules/@zohodesk/codestandard-validator';
+  const suffixIndex = normalizedPath.lastIndexOf(packageSuffix);
+  if (suffixIndex !== -1) {
+    return path.normalize(normalizedPath.slice(0, suffixIndex));
+  }
+  return path.resolve(currentPath, '..', '..', '..');
+}
 function writeFsPaths() {
   var fileContent = {
-    nodeModulesPath: path.resolve(process.cwd(), '..', '..', '..'),
+    nodeModulesPath: getProjectRootFromInstallPath(process.cwd()),
     commitHash: getLastCommitHash()
   };
   return executeSynchronizedCommands(writeFileSync, [path.join(process.cwd(), 'jsonUtils', 'fsUtils.json'), JSON.stringify(fileContent), 'utf-8'], 'node_modules path updated in json file', 'Unable to write node_modules path to json file', false, true);
 }
 module.exports = {
-  writeFsPaths
+  writeFsPaths,
+  getProjectRootFromInstallPath
 };

package/build/utils/PluginsInstallation/checkIfPluginsAreInstalled.js

@@ -1,7 +1,8 @@
 "use strict";
 
 const {
-  existsSync
+  existsSync,
+  readFileSync
 } = require('fs');
 const path = require('path');
 const {
@@ -59,7 +60,8 @@ function checkIfPluginsAreInstalled() {
       isPluginPresent,
       pluginPath
     } = checkPluginsPresentInNodemodules(packageName); // circular installation loop so comment out
-    if (isPluginPresent && checkPluginHasProperVersion(packageName, pluginPath, version)) {
+    // checkPluginHasProperVersion(packageName,pluginPath,version) remove version check due to unnecess
+    if (isPluginPresent) {
       return false;
     }
     return `${packageName}@${version}`;
@@ -110,7 +112,7 @@ function getPluginsToInstall() {
  * @returns {string} - which represents exactPluginVersion
  */
 function returnExactPluginVersion(pluginVersion) {
-  return pluginVersion.replace(/[\^~]/, '');
+  return String(pluginVersion || '').replace(/[\^~]/, '');
 }
 
 /**
@@ -120,16 +122,24 @@ function returnExactPluginVersion(pluginVersion) {
  */
 function checkPluginsPresentInNodemodules(rulePluginName) {
   try {
-    const pluginPath = require.resolve(rulePluginName.toString());
+    const pluginPath = require.resolve(path.join(rulePluginName.toString(), 'package.json'));
     return {
       pluginPath: pluginPath,
       isPluginPresent: existsSync(pluginPath)
     };
   } catch (error) {
-    return {
-      pluginPath: "",
-      isPluginPresent: false
-    };
+    try {
+      const pluginPath = require.resolve(rulePluginName.toString());
+      return {
+        pluginPath: path.join(path.dirname(pluginPath), 'package.json'),
+        isPluginPresent: existsSync(pluginPath)
+      };
+    } catch (_innerError) {
+      return {
+        pluginPath: "",
+        isPluginPresent: false
+      };
+    }
   }
 }
 
@@ -142,11 +152,15 @@ function checkPluginsPresentInNodemodules(rulePluginName) {
  */
 
 function checkPluginHasProperVersion(rulePluginName, installationPath, remotePluginVersion) {
-  const pluginPathArray = installationPath.toString().split(rulePluginName);
-  const rulePluginPackageJSONPath = path.join(pluginPathArray[0], rulePluginName, 'package.json');
-  const remotePluginExactVersion = returnExactPluginVersion(remotePluginVersion);
-  const packageJsonPluginExactVersion = returnExactPluginVersion(require(rulePluginPackageJSONPath).version);
-  return remotePluginExactVersion == packageJsonPluginExactVersion ? true : false;
+  try {
+    const rulePluginPackageJSONPath = installationPath || require.resolve(path.join(rulePluginName.toString(), 'package.json'));
+    const remotePluginExactVersion = returnExactPluginVersion(remotePluginVersion);
+    const packageJsonPluginExactVersion = returnExactPluginVersion(JSON.parse(readFileSync(rulePluginPackageJSONPath, 'utf-8')).version);
+    return remotePluginExactVersion === packageJsonPluginExactVersion;
+  } catch (error) {
+    Logger.log(Logger.FAILURE_TYPE, `Unable to check plugin version for ${rulePluginName}`);
+    return false;
+  }
 }
 module.exports = {
   getPluginsToInstall,

package/build/utils/PluginsInstallation/installPlugins.js

@@ -29,7 +29,7 @@ async function installPlugins(pluginsToBeInstalled) {
     Logger.log(Logger.INFO_TYPE, `Install command being executed: npm ${args.join(' ')}`);
     const result = spawnSync('npm', args, {
       cwd: getNodeModulesPath(),
-      shell: false,
+      shell: true,
       encoding: 'utf8'
     });
     if (result.stdout) {

package/changeLog.md

@@ -72,3 +72,14 @@
  4. Add `.feature` file support in `getSupportedLanguage()` and include feature files in pre-commit hook linting
  5. Update `@zohodesk/codestandard-analytics` dependency to `1.1.6-node-18`
  6. Update unit tests for mutation modules to match refactored API
+
+# 1.4.1 - Windows Path and Pre-commit Stability Fixes
+
+ 1. Fix plugin discovery path handling for scoped packages by resolving `package.json` directly, preventing malformed module paths on Windows.
+ 2. Improve plugin version parsing and error handling to avoid hard failures during plugin validation when metadata is unavailable.
+ 3. Harden pre-commit initialization flow by adding deterministic async ordering and centralized startup error handling.
+ 4. Add timeout protection for remote commit-hash fetch to prevent long blocking in hook execution.
+ 5. Improve fsUtils update safety using temporary file write + rename to reduce partial-write risk.
+ 6. Derive project root from install path suffix instead of fixed directory traversal for cross-platform compatibility.
+ 7. Normalize ESLint config and plugin resolution paths in pre-commit lint flows for Windows/macOS/Linux parity.
+ 8. Add and update unit tests for plugin checks, install-path derivation, JSON update flow, and ESLint path resolution.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zohodesk/codestandard-validator",
-  "version": "1.4.0",
+  "version": "1.4.2",
   "description": "library to enforce code standard using eslint",
   "main": "index.js",
   "scripts": {