@zohodesk/codestandard-validator 1.1.3 → 1.1.4

package/bin/cliCI.js

@@ -0,0 +1,8 @@
+#!/usr/bin/env node
+
+/**
+ *  @author rajasekar 17710
+ *  @fileoverview This script is a Node.js executable that imports and runs the module `runner` from the `../build/lib/` directory.
+ */
+
+require("@zohodesk/codestandard-analytics/build/lib/runner")

package/build/hooks/Precommit/lint.js

@@ -102,14 +102,7 @@ async function runLintWorkflow(files, branch) {
   const execute = new Execution(EsLint, SonarQube, cliobj);
   await execute.executeLintHandler().finally(async () => {
     await execute.executeMetricHandler();
-    /**
-     *  global.analytics.totalIssues = global.analytics.totalIssues + 1;
-        global.analytics.status = "FAILURE";
-        global.analytics.message = 'Issues are detected, please review and resolve the errors'
-     */
-    // const { issues, hasIssue, totalIssues } = fetchProjectIssuesViaCurl("projectName");
   });
-  // Logger.log(Logger.INFO_TYPE,global.analytics)
   return global.analytics.status == 'FAILURE' ? true : false;
 }
 module.exports = {

package/build/hooks/Precommit/pre-commit-default.js

@@ -17,9 +17,6 @@ const {
 const {
   Logger
 } = require('../../utils/Logger/Logger');
-const {
-  checkIfPluginsAreInstalled
-} = require('../../utils/PluginsInstallation/checkIfPluginsAreInstalled');
 const {
   getBranchName
 } = require('../../utils/GitActions/gitActions');
@@ -189,15 +186,6 @@ async function calculateGitDiffForFile(branch_name, file) {
     });
   });
 }
-/**
- * @function {areAllPluginsInstalled} -  method whether plugin is installed or not
- * @returns {Boolean} - return boolean based on plugin installed or not
- */
-
-function areAllPluginsInstalled() {
-  let unInstalledPlugins = checkIfPluginsAreInstalled().uninstalledPlugins;
-  return unInstalledPlugins.length === 0 ? true : false;
-}
 
 /**
  * @function {isOnlyWarningsPresentInFile} - method that checks if only eslint warnings are present in a file
@@ -226,143 +214,136 @@ async function preCommitHook_default() {
     Logger.log(Logger.INFO_TYPE, 'Looks like you have merged. So skipping pre commit check');
     process.exit(0);
   } catch (error) {
-    if (areAllPluginsInstalled()) {
-      let staged_files = [];
-      let eslintConfigFiles = ['.eslintrc.js'];
-      let exemptionFiles = [];
-      let current_branch = '';
-      let hasEslintErrorsInChangedLines = false;
-      let hasEslintErrorsInFiles = false;
-      let areFilesStaged = false;
-      let shouldAbortCommit = false;
-      try {
-        current_branch = await getBranchName();
-      } catch {
-        Logger.log(Logger.INFO_TYPE, "Error fetching current branch");
-      }
-      try {
-        staged_files = await getStagedFiles();
-        if (!staged_files.length == 0) {
-          const {
-            JsFiles: staged_filesJS,
-            CssFiles
-          } = filterFiles(staged_files, eslintConfigFiles, true);
+    let staged_files = [];
+    let eslintConfigFiles = ['.eslintrc.js'];
+    let exemptionFiles = [];
+    let current_branch = '';
+    let hasEslintErrorsInChangedLines = false;
+    let hasEslintErrorsInFiles = false;
+    let areFilesStaged = false;
+    let shouldAbortCommit = false;
+    try {
+      current_branch = await getBranchName();
+    } catch {
+      Logger.log(Logger.INFO_TYPE, "Error fetching current branch");
+    }
+    try {
+      staged_files = await getStagedFiles();
+      if (!staged_files.length == 0) {
+        const {
+          JsFiles: staged_filesJS,
+          CssFiles
+        } = filterFiles(staged_files, eslintConfigFiles, true);
 
-          // staged_filesJS = filterFiles(staged_filesJS,exemptionFiles) //this is the code for giving exemption to a file during pre commit
-          // if(staged_filesJS.length === 0){
-          //     Logger.log(Logger.SUCCESS_TYPE,`Commit Successful`)
-          //     process.exit(0)
-          // }
+        // staged_filesJS = filterFiles(staged_filesJS,exemptionFiles) //this is the code for giving exemption to a file during pre commit
+        // if(staged_filesJS.length === 0){
+        //     Logger.log(Logger.SUCCESS_TYPE,`Commit Successful`)
+        //     process.exit(0)
+        // }
 
-          // CssFiles not Enabled For while 
-          areFilesStaged = true;
-          var stagedFiles = [...staged_filesJS];
-          for (let file in stagedFiles) {
-            let currentFileName = stagedFiles[file];
-            let changedLinesArray = [];
-            let eslintErrorsInChangedLines = new Set();
-            let isOnlyEslintWarningsPresentInFile = false;
-            if (getSupportedLanguage().includes(path.extname(stagedFiles[file]))) {
-              try {
-                var errorsInFile = await lintFiles(stagedFiles[file]);
-                // eslintErrorsInFile = impactBasedPrecommit == false ? filterWarningInFile(errorsInFile) : errorsInFile
-                if (stagedFiles[file] && typeof stagedFiles[file] == 'string') {
-                  if (!errorsInFile.length == 0) {
-                    //Calculating changed lines in a file and storing them in respective arrays
-                    if (impactBasedPrecommit) {
-                      //git diff is computed and stored in an array
-                      let git_diff = await calculateGitDiffForFile(current_branch, stagedFiles[file]);
-                      changedLinesArray = git_diff.filter(line => line.startsWith('@@'));
-                      let changedLinesStartArray = [];
-                      let changedLinesEndArray = [];
-                      for (let number of changedLinesArray) {
-                        let changesStartLine = parseInt(number.split(' ')[2].split(',')[0]);
-                        changedLinesStartArray.push(changesStartLine);
-                        let changesEndLine = number.split(' ')[2].split(',')[1];
-                        if (changesEndLine === undefined) {
-                          changedLinesEndArray.push(changesStartLine);
-                        } else {
-                          changedLinesEndArray.push(changesStartLine + parseInt(changesEndLine) - 1);
-                        }
+        // CssFiles not Enabled For while 
+        areFilesStaged = true;
+        var stagedFiles = [...staged_filesJS];
+        for (let file in stagedFiles) {
+          let currentFileName = stagedFiles[file];
+          let changedLinesArray = [];
+          let eslintErrorsInChangedLines = new Set();
+          let isOnlyEslintWarningsPresentInFile = false;
+          if (getSupportedLanguage().includes(path.extname(stagedFiles[file]))) {
+            try {
+              var errorsInFile = await lintFiles(stagedFiles[file]);
+              // eslintErrorsInFile = impactBasedPrecommit == false ? filterWarningInFile(errorsInFile) : errorsInFile
+              if (stagedFiles[file] && typeof stagedFiles[file] == 'string') {
+                if (!errorsInFile.length == 0) {
+                  //Calculating changed lines in a file and storing them in respective arrays
+                  if (impactBasedPrecommit) {
+                    //git diff is computed and stored in an array
+                    let git_diff = await calculateGitDiffForFile(current_branch, stagedFiles[file]);
+                    changedLinesArray = git_diff.filter(line => line.startsWith('@@'));
+                    let changedLinesStartArray = [];
+                    let changedLinesEndArray = [];
+                    for (let number of changedLinesArray) {
+                      let changesStartLine = parseInt(number.split(' ')[2].split(',')[0]);
+                      changedLinesStartArray.push(changesStartLine);
+                      let changesEndLine = number.split(' ')[2].split(',')[1];
+                      if (changesEndLine === undefined) {
+                        changedLinesEndArray.push(changesStartLine);
+                      } else {
+                        changedLinesEndArray.push(changesStartLine + parseInt(changesEndLine) - 1);
                       }
-                      for (let error = 1; error < errorsInFile.length - 2; error++) {
-                        //errorsInFile[error].trim() - 69:26  error => Do not hardcode content. Use I18N key instead  no-hardcoding/no-hardcoding, 
-                        //errorsInFile[error].trim().split(' ')[0] => 69:26
-                        //errorsInFile[error].trim().split(' ')[0].split(':')[0] => 69
+                    }
+                    for (let error = 1; error < errorsInFile.length - 2; error++) {
+                      //errorsInFile[error].trim() - 69:26  error => Do not hardcode content. Use I18N key instead  no-hardcoding/no-hardcoding, 
+                      //errorsInFile[error].trim().split(' ')[0] => 69:26
+                      //errorsInFile[error].trim().split(' ')[0].split(':')[0] => 69
 
-                        let eslintErrorLineNumber = errorsInFile[error].trim().split(' ')[0].split(':')[0];
-                        if (MandatoryListRules.some(ruleId => errorsInFile[error].trim().includes(ruleId))) {
+                      let eslintErrorLineNumber = errorsInFile[error].trim().split(' ')[0].split(':')[0];
+                      if (MandatoryListRules.some(ruleId => errorsInFile[error].trim().includes(ruleId))) {
+                        eslintErrorsInChangedLines.add(errorsInFile[error]);
+                      }
+                      for (let lineNumber in changedLinesStartArray) {
+                        if (eslintErrorLineNumber >= changedLinesStartArray[lineNumber] && eslintErrorLineNumber <= changedLinesEndArray[lineNumber]) {
                           eslintErrorsInChangedLines.add(errorsInFile[error]);
                         }
-                        for (let lineNumber in changedLinesStartArray) {
-                          if (eslintErrorLineNumber >= changedLinesStartArray[lineNumber] && eslintErrorLineNumber <= changedLinesEndArray[lineNumber]) {
-                            eslintErrorsInChangedLines.add(errorsInFile[error]);
-                          }
-                        }
                       }
-                      if (eslintErrorsInChangedLines.size > 0) {
-                        isOnlyEslintWarningsPresentInFile = isOnlyWarningsPresentInFile(Array.from(eslintErrorsInChangedLines));
-                        Logger.log(Logger.FAILURE_TYPE, `\x1b[1m${currentFileName}\x1b[0m`);
-                        for (let eslintError of Array.from(eslintErrorsInChangedLines)) {
-                          Logger.log(Logger.FAILURE_TYPE, `\x1b[37m${eslintError.trimEnd()}\x1b[0m`);
-                        }
-                        if (shouldWarningsAbortCommit) {
-                          hasEslintErrorsInChangedLines = true;
-                          shouldAbortCommit = true;
-                        } else if (!shouldWarningsAbortCommit && isOnlyEslintWarningsPresentInFile) {
-                          hasEslintErrorsInChangedLines = false;
-                        } else if (!shouldWarningsAbortCommit && !isOnlyEslintWarningsPresentInFile) {
-                          hasEslintErrorsInChangedLines = true;
-                          shouldAbortCommit = true;
-                        }
+                    }
+                    if (eslintErrorsInChangedLines.size > 0) {
+                      isOnlyEslintWarningsPresentInFile = isOnlyWarningsPresentInFile(Array.from(eslintErrorsInChangedLines));
+                      Logger.log(Logger.FAILURE_TYPE, `\x1b[1m${currentFileName}\x1b[0m`);
+                      for (let eslintError of Array.from(eslintErrorsInChangedLines)) {
+                        Logger.log(Logger.FAILURE_TYPE, `\x1b[37m${eslintError.trimEnd()}\x1b[0m`);
                       }
-                    } else {
-                      if (errorsInFile.length > 0) {
-                        let startIndex = 1;
-                        let endIndex = errorsInFile.length - 2;
-                        let listOsEslintErrors = errorsInFile.slice(startIndex, endIndex);
-                        isOnlyEslintWarningsPresentInFile = isOnlyWarningsPresentInFile(listOsEslintErrors);
-                        Logger.log(Logger.FAILURE_TYPE, `\x1b[1m${currentFileName}\x1b[0m`);
-                        for (let eslintError of listOsEslintErrors) {
-                          Logger.log(Logger.FAILURE_TYPE, `\x1b[37m${eslintError.trimEnd()}\x1b[0m`);
-                        }
-                        if (shouldWarningsAbortCommit) {
-                          hasEslintErrorsInFiles = true;
-                          shouldAbortCommit = true;
-                        } else if (!shouldWarningsAbortCommit && isOnlyEslintWarningsPresentInFile) {
-                          hasEslintErrorsInFiles = false;
-                        } else if (!shouldWarningsAbortCommit && !isOnlyEslintWarningsPresentInFile) {
-                          hasEslintErrorsInFiles = true;
-                          shouldAbortCommit = true;
-                        }
+                      if (shouldWarningsAbortCommit) {
+                        hasEslintErrorsInChangedLines = true;
+                        shouldAbortCommit = true;
+                      } else if (!shouldWarningsAbortCommit && isOnlyEslintWarningsPresentInFile) {
+                        hasEslintErrorsInChangedLines = false;
+                      } else if (!shouldWarningsAbortCommit && !isOnlyEslintWarningsPresentInFile) {
+                        hasEslintErrorsInChangedLines = true;
+                        shouldAbortCommit = true;
+                      }
+                    }
+                  } else {
+                    if (errorsInFile.length > 0) {
+                      let startIndex = 1;
+                      let endIndex = errorsInFile.length - 2;
+                      let listOsEslintErrors = errorsInFile.slice(startIndex, endIndex);
+                      isOnlyEslintWarningsPresentInFile = isOnlyWarningsPresentInFile(listOsEslintErrors);
+                      Logger.log(Logger.FAILURE_TYPE, `\x1b[1m${currentFileName}\x1b[0m`);
+                      for (let eslintError of listOsEslintErrors) {
+                        Logger.log(Logger.FAILURE_TYPE, `\x1b[37m${eslintError.trimEnd()}\x1b[0m`);
+                      }
+                      if (shouldWarningsAbortCommit) {
+                        hasEslintErrorsInFiles = true;
+                        shouldAbortCommit = true;
+                      } else if (!shouldWarningsAbortCommit && isOnlyEslintWarningsPresentInFile) {
+                        hasEslintErrorsInFiles = false;
+                      } else if (!shouldWarningsAbortCommit && !isOnlyEslintWarningsPresentInFile) {
+                        hasEslintErrorsInFiles = true;
+                        shouldAbortCommit = true;
                       }
                     }
                   }
                 }
-              } catch (err) {
-                Logger.log(Logger.FAILURE_TYPE, err);
-                Logger.log(Logger.FAILURE_TYPE, "Error in executing lint command");
               }
+            } catch (err) {
+              Logger.log(Logger.FAILURE_TYPE, err);
+              Logger.log(Logger.FAILURE_TYPE, "Error in executing lint command");
             }
           }
-        } else if (staged_files.length === 0) {
-          Logger.log(Logger.INFO_TYPE, 'No files have been staged. Stage your files before committing');
         }
-      } catch {
-        Logger.log(Logger.INFO_TYPE, 'Error executing pre commit hook');
-      }
-      if (shouldAbortCommit) {
-        Logger.log(Logger.FAILURE_TYPE, `There are linter errors/warnings present. So commit is aborted.`);
-        process.exit(1);
-      } else if (shouldAbortCommit === false && staged_files.length !== 0) {
-        Logger.log(Logger.SUCCESS_TYPE, `Commit Successful`);
-        process.exit(0);
+      } else if (staged_files.length === 0) {
+        Logger.log(Logger.INFO_TYPE, 'No files have been staged. Stage your files before committing');
       }
-    } else {
-      Logger.log(Logger.FAILURE_TYPE, 'Commit failed since some lint plugins are not installed');
-      Logger.log(Logger.INFO_TYPE, `Kindly execute the command \x1b[37mnpx ZDPrecommit setupPlugins \x1b[33mfrom the location where package.json is present to install the plugins`);
-      Logger.log(Logger.INFO_TYPE, 'Execute the command and kindly try committing again.');
+    } catch {
+      Logger.log(Logger.INFO_TYPE, 'Error executing pre commit hook');
+    }
+    if (shouldAbortCommit) {
+      Logger.log(Logger.FAILURE_TYPE, `There are linter errors/warnings present. So commit is aborted.`);
       process.exit(1);
+    } else if (shouldAbortCommit === false && staged_files.length !== 0) {
+      Logger.log(Logger.SUCCESS_TYPE, `Commit Successful`);
+      process.exit(0);
     }
   }
 }

package/build/hooks/hook.js

@@ -47,10 +47,10 @@ async function hooks() {
     } = getPluginsToInstall();
     await executeMethodsThatReturnBooleanValue('Some issue occurred in installing plugins', installPlugins, uninstalledPlugins);
   }
-  if (process.env.CLIPRECOMMIT && Boolean(process.env.CLIPRECOMMIT) == true) {
-    require('./Precommit/pre-commit-default');
-  } else {
+  if (process.env.PUSHTOSONARQUBE && Boolean(process.env.PUSHTOSONARQUBE) == true) {
     require('./Precommit/commit');
+  } else {
+    require('./Precommit/pre-commit-default');
   }
 }
 hooks();

package/build/utils/General/Hash.js

@@ -1,9 +1,5 @@
 "use strict";
 
-Object.defineProperty(exports, "__esModule", {
-  value: true
-});
-exports.encrypt = exports.decrypt = void 0;
 const caesarCipher = (str, shift) => {
   return str.split("").map(char => {
     let code = char.charCodeAt();
@@ -16,6 +12,8 @@ const caesarCipher = (str, shift) => {
   }).join("");
 };
 const encrypt = (plaintext, shift) => caesarCipher(plaintext, shift);
-exports.encrypt = encrypt;
 const decrypt = (ciphertext, shift) => caesarCipher(ciphertext, 26 - shift);
-exports.decrypt = decrypt;
+module.exports = {
+  encrypt,
+  decrypt
+};

package/changeLog.md

@@ -41,4 +41,9 @@
 
 # 1.1.3 - SonarQube Enable
 
-1. Remote Installtion flow moved to before and handled process.exit removed
+1. Remote Installtion flow moved to before and handled process.exit removed
+
+# 1.1.4 - Minor Bug Fixes
+
+1. ProjectId api revamp
+2. code standard analytics bin bind to code standard validator bin

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zohodesk/codestandard-validator",
-  "version": "1.1.3",
+  "version": "1.1.4",
   "description": "library to enforce code standard using eslint",
   "main": "index.js",
   "scripts": {
@@ -11,12 +11,13 @@
   "author": "",
   "license": "ISC",
   "bin": {
-    "ZDPrecommit": "./bin/cli.js"
+    "ZDPrecommit": "./bin/cli.js",
+    "ZDLintFramework": "./bin/cliCI.js"
   },
   "type": "commonjs",
   "dependencies": {
     "@zohodesk-private/client_deployment_tool": "0.0.5",
-    "@zohodesk/codestandard-analytics": "1.1.4",
+    "@zohodesk/codestandard-analytics": "1.1.4-exp-2",
     "eslint": "8.26.0",
     "stylelint": "16.23.0"
   },