@zohodesk/codestandard-validator 1.0.0-exp-9 → 1.0.0-exp-11

package/build/hooks/Precommit/pre-commit-default.js

@@ -30,6 +30,7 @@ const {
 const {
   getRootDirectory
 } = require('../../utils/General/RootDirectoryUtils/getRootDirectory');
+const MandatoryListRules = require('../../../jsonUtils/MandatoryListRules');
 const {
   impactBasedPrecommit,
   shouldWarningsAbortCommit
@@ -259,7 +260,7 @@ async function preCommitHook_default() {
           for (let file in stagedFiles) {
             let currentFileName = stagedFiles[file];
             let changedLinesArray = [];
-            let eslintErrorsInChangedLines = [];
+            let eslintErrorsInChangedLines = new Set();
             let isOnlyEslintWarningsPresentInFile = false;
             if (getSupportedLanguage().includes(path.extname(stagedFiles[file]))) {
               try {
@@ -290,16 +291,19 @@ async function preCommitHook_default() {
                         //errorsInFile[error].trim().split(' ')[0].split(':')[0] => 69
 
                         let eslintErrorLineNumber = errorsInFile[error].trim().split(' ')[0].split(':')[0];
+                        if (MandatoryListRules.some(ruleId => errorsInFile[error].trim().includes(ruleId))) {
+                          eslintErrorsInChangedLines.add(errorsInFile[error]);
+                        }
                         for (let lineNumber in changedLinesStartArray) {
                           if (eslintErrorLineNumber >= changedLinesStartArray[lineNumber] && eslintErrorLineNumber <= changedLinesEndArray[lineNumber]) {
-                            eslintErrorsInChangedLines.push(errorsInFile[error]);
+                            eslintErrorsInChangedLines.add(errorsInFile[error]);
                           }
                         }
                       }
-                      if (eslintErrorsInChangedLines.length > 0) {
-                        isOnlyEslintWarningsPresentInFile = isOnlyWarningsPresentInFile(eslintErrorsInChangedLines);
+                      if (eslintErrorsInChangedLines.size > 0) {
+                        isOnlyEslintWarningsPresentInFile = isOnlyWarningsPresentInFile(Array.from(eslintErrorsInChangedLines));
                         Logger.log(Logger.FAILURE_TYPE, `\x1b[1m${currentFileName}\x1b[0m`);
-                        for (let eslintError of eslintErrorsInChangedLines) {
+                        for (let eslintError of Array.from(eslintErrorsInChangedLines)) {
                           Logger.log(Logger.FAILURE_TYPE, `\x1b[37m${eslintError.trimEnd()}\x1b[0m`);
                         }
                         if (shouldWarningsAbortCommit) {

package/build/lib/postinstall.js

@@ -24,6 +24,13 @@ const {
 const {
   writeFsPaths
 } = require("../utils/General/writeProjectDetailsToJson");
+const {
+  getNodeModulesPath
+} = require("../utils/General/getNodeModulesPath");
+const config = require(path.join(getNodeModulesPath(), 'lint.config.js'));
+process.env.SONARQUBE_EXTERNAL = config.metric_token;
+process.env.SONARQUBE = config.meticHandler_api_token;
+process.env.ZGIT_TOKEN = config.token;
 
 /**
  *  @function {postInstall} -  This methods setup husky and configuration for executing project
@@ -36,7 +43,7 @@ async function postInstall() {
     await executeMethodsThatReturnBooleanValue("Make sure zgit.csez.zohocorpin.com is accessible", cloneViaCdt, null);
     await executeMethodsThatReturnBooleanValue("Some issue occurred in creating eslint config file.", createConfigFile, null);
     Logger.log(Logger.SUCCESS_TYPE, "Pre commit setup successfull");
-    arePluginsInstalled();
+    // arePluginsInstalled();
   } catch (error) {
     Logger.log(Logger.FAILURE_TYPE, `Kindly retry npm install. & ${error.message}`);
   }

package/build/utils/General/SonarQubeUtil.js

@@ -18,9 +18,9 @@ const {
 
 function buildIssuesSearchUrl(componentKey) {
   const {
-    metricServerHost
+    metricServerHost = "https://client-linters.zdesk.csez.zohocorpin.com"
   } = (0, _getGeneralInfo.getConfigurationPrecommit)();
-  const base = `${"https://client-linters.zdesk.csez.zohocorpin.com" || metricServerHost}/api/issues/search`;
+  const base = `${metricServerHost}/api/issues/search`;
   const params = new URLSearchParams({
     componentKeys: componentKey,
     s: 'FILE_LINE',

package/build/utils/PluginsInstallation/installPlugins.js

@@ -14,7 +14,8 @@ const {
 } = require('../General/getNodeModulesPath');
 const path = require('path');
 const {
-  spawnSync
+  spawnSync,
+  spawn
 } = require('child_process');
 
 /**
@@ -24,7 +25,7 @@ const {
 async function installPlugins(pluginsToBeInstalled) {
   if (pluginsToBeInstalled.length > 0) {
     let packageJsonBeforePluginsInstallation = getPackageJsonContentBeforeInstallingPlugins();
-    Logger.log(Logger.INFO_TYPE, 'Installing plugins ....');
+    Logger.log(Logger.SUCCESS_TYPE, 'Installing rule plugins; this may take some time.');
     const args = ['install', '--save-dev', ...pluginsToBeInstalled, '--legacy-peer-deps'];
     Logger.log(Logger.INFO_TYPE, `Install command being executed: npm ${args.join(' ')}`);
     const result = spawnSync('npm', args, {
@@ -49,20 +50,6 @@ async function installPlugins(pluginsToBeInstalled) {
     }
     Logger.log(Logger.SUCCESS_TYPE, 'Plugins installation successful');
     return restorePackageJsonContent(packageJsonBeforePluginsInstallation);
-    // const installCommand = `npm install --save-dev ${pluginsToBeInstalled.join(' ')} --legacy-peer-deps`
-    // Logger.log(Logger.INFO_TYPE,`Install command being executed: ${installCommand}`)
-    // try{ 
-    //     let stdout = execSync(installCommand,{cwd:getNodeModulesPath(),shell:true}).toString()
-    //     if(stdout){
-    //         Logger.logger(stdout)
-    //     }
-    //     Logger.log(Logger.SUCCESS_TYPE,'Plugins installation successful')
-    //     return restorePackageJsonContent(packageJsonBeforePluginsInstallation)
-    // } catch(error) {
-    //     Logger.log(Logger.FAILURE_TYPE,"Unable to install plugins. Kindly retry the command")
-    //     Logger.log(Logger.FAILURE_TYPE,error)
-    //     return false
-    // }
   } else {
     Logger.log(Logger.INFO_TYPE, 'Plugins are already installed');
     return true;

package/index.js

@@ -1,60 +1,10 @@
 const { getLintConfigurationUtil } = require("./build/utils/ConfigFileUtils/getLintConfiguration");
 const { rulesConfig, plugins, extendPlugins } = getLintConfigurationUtil();
 
+
+
 module.exports = {
   rulesConfig,
   plugins,
   extendPlugins
-};
-
-
-
-function config() {
-  return {
-    addConfig(conf){
-      return conf
-    },
-    addRule(){
-
-    }
-  };
-}
-
-
-
-const rule =  {
-  meta: {
-    type: "problem",
-    docs:{
-      description: "Disallow the use of 'debugger' statements",
-      category: "Possible Errors",
-      recommended: true,
-    },
-    schema: [], // No options for this rule
-    messages: {
-      noDebugger: "Unexpected 'debugger' statement.",
-    },
-  },
-  create(){
-    return {
-      DebuggerStatement(node) {
-        context.report({
-          node,
-          messageId: "noDebugger",
-        });
-      },
-    };
-  }
-};
-
-
-const { addConfig, addRule } = config()
-
-addRule([{name:"dummyrule",conf:rule}])
-
-addConfig([{
-  files: ["config/*.js"], 
-  rules: {
-    "no-console": "off",
-  },
-}])
+};

package/jsonUtils/MandatoryListRules.js

@@ -0,0 +1,3 @@
+const MandatoryListRules = [ "@zohodesk/fitnessfunction/chunk-size"]
+
+module.exports = MandatoryListRules

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zohodesk/codestandard-validator",
-  "version": "1.0.0-exp-9",
+  "version": "1.0.0-exp-11",
   "description": "library to enforce code standard using eslint",
   "main": "index.js",
   "scripts": {
@@ -15,7 +15,7 @@
   },
   "type": "commonjs",
   "dependencies": {
-    "@zohodesk/codestandard-analytics": "1.0.2-exp-12",
+    "@zohodesk/codestandard-analytics": "1.0.2-exp-14",
     "@zohodesk-private/client_deployment_tool": "0.0.5",
     "eslint": "8.26.0",
     "stylelint": "16.23.0"