@zohodesk/codestandard-validator 0.0.7-exp-9 → 0.0.7-exp-10

package/build/hooks/Precommit/pre-commit.js

@@ -8,7 +8,7 @@ const fs = require('fs');
 const path = require('path');
 const {
   getEslintExecutablePath
-} = require('../../utils/EslintConfigFileUtils/getEslintExecutablePath');
+} = require('../../utils/ConfigFileUtils/getEslintExecutablePath');
 const {
   getNodeModulesPath
 } = require('../../utils/General/getNodeModulesPath');
@@ -152,16 +152,15 @@ function findStyleLintErrors(filePath) {
         cwd: getNodeModulesPath()
       }, (error, stderr, stdout) => {
         if (stdout) {
-          resolve(stderr.trim().split('\n'));
+          resolve(stdout.trim().split('\n'));
         }
-        if (stderr) {
-          resolve(stderr.trim().split('\n'));
-        }
-        // else if(error){
-        //     Logger.log(Logger.FAILURE_TYPE,error)
-        //     reject("Error executing eslint command")
+        // if(stderr){
+        //     resolve(stderr.trim().split('\n'))
         // }
-        else {
+        else if (error) {
+          Logger.log(Logger.FAILURE_TYPE, error);
+          reject("Error executing stylelint command");
+        } else {
           resolve([]);
         }
       });

package/build/utils/PluginsInstallation/checkIfPluginsAreInstalled.js

@@ -51,13 +51,10 @@ function checkIfPluginsAreInstalled() {
       packageName,
       version
     } = plugin;
-    const {
-      isPluginPresent,
-      pluginPath
-    } = checkPluginsPresentInNodemodules(packageName);
-    if (isPluginPresent && checkPluginHasProperVersion(packageName, pluginPath, version)) {
-      return false;
-    }
+    // const { isPluginPresent, pluginPath } = checkPluginsPresentInNodemodules(packageName) // circular installation loop so comment out
+    // if( isPluginPresent && checkPluginHasProperVersion(packageName,pluginPath,version)){
+    // return false
+    // }
     return `${packageName}@${version}`;
   }).filter(Boolean);
   if (uninstalledPlugins.length > 0) {

package/build/utils/PluginsInstallation/installPlugins.js

@@ -30,21 +30,12 @@ function installPlugins(pluginsToBeInstalled) {
   if (pluginsToBeInstalled.length > 0) {
     let packageJsonBeforePluginsInstallation = getPackageJsonContentBeforeInstallingPlugins();
     Logger.log(Logger.INFO_TYPE, 'Installing plugins ....');
+    const installCommand = `npm install --save-dev ${pluginsToBeInstalled.join(' ')} --legacy-peer-deps`;
     Logger.log(Logger.INFO_TYPE, `Install command being executed: ${installCommand}`);
     let arePluginsInstalledSuccessfully = executeSynchronizedCommands(execSync, [installCommand, {
       stdio: 'inherit',
       cwd: getNodeModulesPath()
     }], '', 'Some issue occured while installing plugins', false, true);
-    const installCommand = ['install', '--save-dev', ...pluginsToBeInstalled, '--legacy-peer-deps'];
-    const result = spawn('npm', installCommand, {
-      stdio: 'inherit',
-      shell: true,
-      cwd: getNodeModulesPath()
-    });
-    if (result.error) {
-      Logger.log('Error running npm install:', result.error);
-      process.exit(1);
-    }
     if (arePluginsInstalledSuccessfully) {
       Logger.log(Logger.SUCCESS_TYPE, 'Plugins installation successful');
       let isPackageJsonRestored = restorePackageJsonContent(packageJsonBeforePluginsInstallation);

package/index.js

@@ -1,4 +1,4 @@
-const { getLintConfigurationUtil } = require("./build/utils/EslintConfigFileUtils/getLintConfiguration");
+const { getLintConfigurationUtil } = require("./build/utils/ConfigFileUtils/getLintConfiguration");
 const { rulesConfig, plugins, extendPlugins } = getLintConfigurationUtil();
 
 module.exports = {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zohodesk/codestandard-validator",
-  "version": "0.0.7-exp-9",
+  "version": "0.0.7-exp-10",
   "description": "library to enforce code standard using eslint",
   "main": "index.js",
   "scripts": {