@zohodesk/codestandard-validator 0.0.6-exp-18 → 0.0.6-exp-21

package/build/utils/PluginsInstallation/Worker/installPluginsByWoker.js

@@ -3,15 +3,18 @@
 const {
   Worker
 } = require('worker_threads');
+const {
+  Logger
+} = require('../../Logger/Logger');
 async function installPluginsByWorker(plugins) {
   try {
     const results = await Promise.all(plugins.map(pkg => runWorker({
       packageName: pkg.packageName,
       version: pkg.version
     })));
-    console.log('Package are installed By from workers:', results.join('\n'));
+    Logger.log(Logger.SUCCESS_TYPE, 'Package are installed By from workers:', results.join('\n'));
   } catch (error) {
-    console.error('Error:', error);
+    Logger.log(Logger.FAILURE_TYPE, 'Error:', error);
   }
 }
 function runWorker(data) {

package/build/utils/PluginsInstallation/arePluginsInstalled.js

@@ -1,20 +1,24 @@
 "use strict";
 
-const {
-  executeMethodsThatReturnBooleanValue
-} = require('../General/wrapperFunctionToExecuteAFunction');
 const {
   checkIfPluginsAreInstalled
 } = require('./checkIfPluginsAreInstalled');
+const {
+  printUninstalledPlugins
+} = require('./printUninstalledPlugins');
 const {
   installPlugins
 } = require('./installPlugins');
-async function arePluginsInstalled() {
+function arePluginsInstalled() {
   let {
     uninstalledPlugins,
     noPluginMessage
   } = checkIfPluginsAreInstalled();
-  await executeMethodsThatReturnBooleanValue("Some issue occurred in installing plugins", installPlugins, uninstalledPlugins);
+  let areAllPluginsInstalled = uninstalledPlugins.length === 0 ? true : false;
+  if (!areAllPluginsInstalled) {
+    installPlugins(uninstalledPlugins);
+  }
+  // printUninstalledPlugins(uninstalledPlugins,noPluginMessage)
 }
 module.exports = {
   arePluginsInstalled

package/build/utils/PluginsInstallation/checkIfPluginsAreInstalled.js

@@ -1,15 +1,22 @@
 "use strict";
 
 const {
+  readdirSync,
   existsSync
 } = require('fs');
 const path = require('path');
+const {
+  getNodeModulesPath
+} = require('../General/getNodeModulesPath');
 const {
   Logger
 } = require('../Logger/Logger');
 const {
   getLibraryInstalledLocation
 } = require('../General/getLibraryInstalledLocation');
+const {
+  executeSynchronizedCommands
+} = require('../General/executeSyncCommands');
 const {
   endPoint,
   commonLinterRepoName
@@ -20,6 +27,32 @@ const {
 const {
   getServicePathElseCommon
 } = require('../EslintConfigFileUtils/getLintConfiguration');
+function getUnInstalledPlugins(pluginsForCurrentRepo, pluginNamesOfDevDependencyPlugins, devDependencies) {
+  let pluginsInNodeModules = executeSynchronizedCommands(readdirSync, [path.join(getNodeModulesPath(), 'node_modules')], '', 'Unable to get the plugins inside node_modules', true, false);
+  let pluginsToBeInstalled = [];
+  pluginsForCurrentRepo.filter(plugin => {
+    if (plugin.packageName.startsWith('@')) {
+      let scope = plugin.packageName.split('/')[0];
+      let pluginName = plugin.packageName.split('/')[1];
+      let scopedPlugins = executeSynchronizedCommands(readdirSync, [path.join(getNodeModulesPath(), 'node_modules', scope)], '', 'Unable to get the plugins inside the scope inside node_modules', true, false);
+      let isPluginInstalled = scopedPlugins.includes(pluginName) ? true : false;
+      if (!isPluginInstalled) {
+        pluginsToBeInstalled.push(`${plugin.packageName}@${plugin.version}`);
+      }
+    } else {
+      let isPluginInstalled = pluginsInNodeModules.includes(plugin.packageName) ? true : false;
+      if (!isPluginInstalled) {
+        pluginsToBeInstalled.push(`${plugin.packageName}@${plugin.version}`);
+      }
+    }
+    if (pluginNamesOfDevDependencyPlugins.includes(plugin.packageName)) {
+      if (plugin.version !== devDependencies[plugin.packageName]) {
+        pluginsToBeInstalled.push(`${plugin.packageName}@${plugin.version}`);
+      }
+    }
+  });
+  return pluginsToBeInstalled;
+}
 function getAllPlugins() {
   let serviceSpecificPlugins = [];
   const pathToCommonPluginsFile = path.join(getLibraryInstalledLocation(), commonLinterRepoName, 'common', 'pluginVersion.js');
@@ -46,6 +79,29 @@ function checkIfPluginsAreInstalled() {
     noPluginMessage: '',
     uninstalledPlugins: []
   };
+  // let pluginsIndevDependencies = {}
+  // let pluginNamesOfDevDependencyPlugins = []
+  // let arePluginsPresentIndevDependencies = false
+  // var arePluginsPresentForCurrentRepo = false
+
+  // if(existsSync(path.join(getNodeModulesPath(),'package.json'))){
+  //     let packageJsonContent = require(path.join(getNodeModulesPath(),'package.json'))
+  //     pluginsIndevDependencies = packageJsonContent.devDependencies
+
+  //     if(pluginsIndevDependencies !== undefined){
+  //         arePluginsPresentIndevDependencies = true
+  //         pluginNamesOfDevDependencyPlugins = Object.keys(pluginsIndevDependencies)
+  //     }
+  //     else if(pluginsIndevDependencies === undefined){
+  //         Logger.log(Logger.INFO_TYPE,'No devDependencies present!')
+  //     }
+  // }
+  // else{
+  //     arePluginsPresentIndevDependencies = false
+  // }
+
+  // arePluginsPresentForCurrentRepo = pluginsForCurrentRepo.length !== 0 ? true : false
+
   uninstalledPlugins = pluginsForCurrentRepo.map(plugin => {
     const {
       packageName,
@@ -61,6 +117,7 @@ function checkIfPluginsAreInstalled() {
     return `${packageName}@${version}`;
   }).filter(Boolean);
   if (uninstalledPlugins.length > 0) {
+    // uninstalledPlugins = getUnInstalledPlugins(pluginsForCurrentRepo, pluginNamesOfDevDependencyPlugins, pluginsIndevDependencies);
     plugin.noPluginMessage = '';
     plugin.uninstalledPlugins = uninstalledPlugins;
     return plugin;

package/build/utils/PluginsInstallation/installPlugins.js

@@ -6,6 +6,9 @@ const {
 const {
   writeFileSync
 } = require('fs');
+const {
+  checkIfPluginsAreInstalled
+} = require('./checkIfPluginsAreInstalled');
 const {
   executeSynchronizedCommands
 } = require('../General/executeSyncCommands');
@@ -24,30 +27,34 @@ const {
  * @returns {boolean} - indicating if plugins to be installed are installed successfully or not
  */
 function installPlugins(pluginsToBeInstalled) {
-  if (pluginsToBeInstalled.length === 0) {
+  // let {uninstalledPlugins : pluginsToBeInstalled} = checkIfPluginsAreInstalled()
+  if (pluginsToBeInstalled.length > 0) {
+    let packageJsonBeforePluginsInstallation = getPackageJsonContentBeforeInstallingPlugins();
+    let installCommand = `npm install --save-dev ${pluginsToBeInstalled.join(' ')}`;
+    Logger.log(Logger.INFO_TYPE, 'Installing plugins ....');
+    Logger.log(Logger.INFO_TYPE, `Install command being executed: ${installCommand}`);
+    let arePluginsInstalledSuccessfully = executeSynchronizedCommands(execSync, [installCommand, {
+      stdio: 'inherit',
+      cwd: getNodeModulesPath()
+    }], '', 'Some issue occured while installing plugins', false, true);
+    if (arePluginsInstalledSuccessfully) {
+      Logger.log(Logger.SUCCESS_TYPE, 'Plugins installation successful');
+      let isPackageJsonRestored = restorePackageJsonContent(packageJsonBeforePluginsInstallation);
+      if (isPackageJsonRestored) {
+        createVersionControlFile(pluginsToBeInstalled);
+        // return true 
+      } else {
+        Logger.log(Logger.FAILURE_TYPE, 'Unable to restore package.json content');
+        // return false
+      }
+    } else {
+      Logger.log(Logger.FAILURE_TYPE, "Unable to install plugins.Kindly retry the command");
+      // return false
+    }
+  } else {
     Logger.log(Logger.INFO_TYPE, 'Plugins are already installed');
-    return true;
-  }
-  const packageJsonBackup = getPackageJsonContentBeforeInstallingPlugins();
-  const installCommand = `npm install --save-dev ${pluginsToBeInstalled.join(' ')}`;
-  Logger.log(Logger.INFO_TYPE, 'Installing plugins...');
-  Logger.log(Logger.INFO_TYPE, `Install command being executed: ${installCommand}`);
-  const installed = executeSynchronizedCommands(execSync, [installCommand, {
-    stdio: 'inherit',
-    cwd: getNodeModulesPath()
-  }], '', 'Some issue occurred while installing plugins', false, true);
-  if (!installed) {
-    Logger.log(Logger.FAILURE_TYPE, 'Unable to install plugins. Kindly retry the command');
-    return false;
-  }
-  Logger.log(Logger.SUCCESS_TYPE, 'Plugins installation successful');
-  const restored = restorePackageJsonContent(packageJsonBackup);
-  if (!restored) {
-    Logger.log(Logger.FAILURE_TYPE, 'Unable to restore package.json content');
-    return false;
+    // return true
   }
-  createVersionControlFile(pluginsToBeInstalled);
-  return true;
 }
 
 /**
@@ -69,6 +76,53 @@ function restorePackageJsonContent(packageJsonContentBeforePluginsInstallation)
   let isPackageJsonRestored = executeSynchronizedCommands(writeFileSync, [packageJsonFilePath, JSON.stringify(packageJsonContentBeforePluginsInstallation, null, 2)], 'Package.json content restored successfully', 'Unable to restore package.json content', false, true);
   return isPackageJsonRestored;
 }
+
+// function appendInstalledPluginsToPackageJson(pluginsToBeAppendedInPackageJson){
+//     let packageJsonFilePath = `${nodeModulesPathOfProject}/package.json`
+//     let packageJsonContent = require(packageJsonFilePath)
+//     let devDependencies = packageJsonContent.devDependencies
+//     let pluginsToBeAddedInDevDependencies = {}
+
+//     executeSynchronizedCommands(process.chdir,[nodeModulesPathOfProject],'','Unable to navigate to node_modules path when trying to revert changes in package.json',false,false)
+
+//     let gitDiffOutput = executeSynchronizedCommands(execSync,['git diff --name-only'],'','Unable to execute git diff command while checking if package.json is changed',true,false).toString().trim()
+//     let isPackageJsonChanged = gitDiffOutput.includes('package.json') ? true : false
+
+//     if(isPackageJsonChanged){
+//         let packageJsonChangesRevertCommand = `git checkout "${packageJsonFilePath}"`
+//         isPackageJsonChangesRevertedSuccessfully = executeSynchronizedCommands(execSync,[packageJsonChangesRevertCommand,{stdio:'inherit'}],'Changes in package.json reverted successfully','Unable to revert the changes in package.json file',false,true)
+
+//         if(isPackageJsonChangesRevertedSuccessfully){
+//             pluginsToBeAppendedInPackageJson.map(uninstalledPlugin => {
+//                 if(uninstalledPlugin.startsWith('@')){
+//                     let indexOfAtCharacter = uninstalledPlugin.indexOf('@')
+//                     let indexOfSecondOccurenceOfAtCharacter = uninstalledPlugin.indexOf('@',indexOfAtCharacter + 1)
+//                     let unInstalledPluginName = uninstalledPlugin.slice(0,indexOfSecondOccurenceOfAtCharacter)
+//                     let unInstalledPluginVersion = uninstalledPlugin.slice(indexOfSecondOccurenceOfAtCharacter + 1)
+//                     pluginsToBeAddedInDevDependencies[unInstalledPluginName] = unInstalledPluginVersion
+//                 }
+//                 else{
+//                     pluginsToBeAddedInDevDependencies[uninstalledPlugin.split('@')[0]] = uninstalledPlugin.split('@')[1]
+//                 }
+//                 })
+//                 let updatedPluginsIndevDependencies = {
+//                     ...devDependencies,
+//                     ...pluginsToBeAddedInDevDependencies
+//                 }
+//                 packageJsonContent.devDependencies = updatedPluginsIndevDependencies
+
+//                 let modifiedPackageJson = {
+//                     ...packageJsonContent,
+//                 }
+//                 let isPluginsAddedInPackageJson = executeSynchronizedCommands(writeFileSync,[packageJsonFilePath,JSON.stringify(modifiedPackageJson,null,2)],'Newly installed plugins successfully added to package.json','Unable to append installed plugins to package.json',false,true)
+//                 return isPluginsAddedInPackageJson 
+//         }
+//         else{
+//             return true
+//         }
+//     }
+// }
+
 module.exports = {
   installPlugins
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zohodesk/codestandard-validator",
-  "version": "0.0.6-exp-18",
+  "version": "0.0.6-exp-21",
   "description": "library to enforce code standard using eslint",
   "main": "index.js",
   "scripts": {