@zohodesk/codestandard-validator 0.0.6-exp-16 → 0.0.6-exp-18

package/build/hooks/Precommit/pre-commit.js

@@ -4,6 +4,8 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = validateRemotePackages;
+var _executeSyncCommands = require("../../utils/General/executeSyncCommands");
+var _getNodeModulesPath = require("../../utils/General/getNodeModulesPath");
 const {
   cloneViaCdt
 } = require("../../utils/CloneCommonLinterRepo/cloneViaCdt");
@@ -15,14 +17,11 @@ const {
   getStoredCommitHash
 } = require("../../utils/General/getGeneralInfo");
 const {
-  executeMethodsThatReturnBooleanValue
-} = require("../../utils/General/wrapperFunctionToExecuteAFunction");
+  execSync
+} = require("child_process");
 const {
   Logger
 } = require("../../utils/Logger/Logger");
-const {
-  arePluginsInstalled
-} = require("../../utils/PluginsInstallation/arePluginsInstalled");
 async function validateRemotePackages() {
   try {
     if (!(getStoredCommitHash() == getLastCommitHash())) {
@@ -30,7 +29,9 @@ async function validateRemotePackages() {
       await executeMethodsThatReturnBooleanValue("Some issue occurred in creating eslint config file.", createEslintConfigFile, null);
       Logger.log(Logger.SUCCESS_TYPE, "Pre commit setup successfull");
     }
-    arePluginsInstalled();
+    execSync("npx ZDPrecommit setupPlugins", {
+      cwd: (0, _getNodeModulesPath.getNodeModulesPath)()
+    });
   } catch (error) {
     Logger.log(Logger.FAILURE_TYPE, `Kindly retry npm install. & ${error.message}`);
   }

package/build/lib/cli.js

@@ -12,12 +12,12 @@ const {
 const {
   installEslintExtension
 } = require("../utils/ExtensionInstallation/installEslintExtension");
-const {
-  default: validateRemotePackages
-} = require("../hooks/Precommit/pre-commit");
 const {
   Logger
 } = require("../utils/Logger/Logger");
+const {
+  arePluginsInstalled
+} = require("../utils/PluginsInstallation/arePluginsInstalled");
 const [,, action, ...options] = process.argv;
 async function run() {
   switch (action) {
@@ -33,7 +33,7 @@ async function run() {
       }
     case "setupPlugins":
       {
-        validateRemotePackages();
+        arePluginsInstalled();
         break;
       }
     case "setupExtension":

package/build/utils/PluginsInstallation/installPlugins.js

@@ -28,9 +28,8 @@ function installPlugins(pluginsToBeInstalled) {
     Logger.log(Logger.INFO_TYPE, 'Plugins are already installed');
     return true;
   }
-
-  // const packageJsonBackup = getPackageJsonContentBeforeInstallingPlugins();
-  const installCommand = `npm install --no-save ${pluginsToBeInstalled.join(' ')}`;
+  const packageJsonBackup = getPackageJsonContentBeforeInstallingPlugins();
+  const installCommand = `npm install --save-dev ${pluginsToBeInstalled.join(' ')}`;
   Logger.log(Logger.INFO_TYPE, 'Installing plugins...');
   Logger.log(Logger.INFO_TYPE, `Install command being executed: ${installCommand}`);
   const installed = executeSynchronizedCommands(execSync, [installCommand, {
@@ -42,13 +41,11 @@ function installPlugins(pluginsToBeInstalled) {
     return false;
   }
   Logger.log(Logger.SUCCESS_TYPE, 'Plugins installation successful');
-
-  // const restored = restorePackageJsonContent(packageJsonBackup);
-  // if (!restored) {
-  //     Logger.log(Logger.FAILURE_TYPE, 'Unable to restore package.json content');
-  //     return false;
-  // }
-
+  const restored = restorePackageJsonContent(packageJsonBackup);
+  if (!restored) {
+    Logger.log(Logger.FAILURE_TYPE, 'Unable to restore package.json content');
+    return false;
+  }
   createVersionControlFile(pluginsToBeInstalled);
   return true;
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zohodesk/codestandard-validator",
-  "version": "0.0.6-exp-16",
+  "version": "0.0.6-exp-18",
   "description": "library to enforce code standard using eslint",
   "main": "index.js",
   "scripts": {