@zohodesk/codestandard-validator 0.0.4-exp-2 → 0.0.4-exp-6

package/build/lib/postinstall.js

@@ -35,7 +35,7 @@ async function postInstall() {
     isGitInitialized() ? await executeMethodsThatReturnBooleanValue("Some issue occurred in setting up husky.", setupHusky, null) : null;
     await executeMethodsThatReturnBooleanValue("Make sure zgit.csez.zohocorpin.com is accessible", cloneViaCdt, null);
     await executeMethodsThatReturnBooleanValue("Some issue occurred in creating eslint config file.", createEslintConfigFile, null);
-    Logger.log(Logger.SUCCESS_TYPE, "Pre commit setup successful");
+    Logger.log(Logger.SUCCESS_TYPE, "Pre commit setup successfull");
     arePluginsInstalled();
   } catch (error) {
     Logger.log(Logger.FAILURE_TYPE, `Kindly retry npm install. & ${error.message}`);

package/build/utils/FileAndFolderOperations/versionControl.js

@@ -0,0 +1,25 @@
+"use strict";
+
+const path = require('path');
+const {
+  getNodeModulesPath
+} = require('../General/getNodeModulesPath');
+const {
+  writeFileSync
+} = require('fs');
+const {
+  Logger
+} = require('../Logger/Logger');
+function createVersionControlFile(uninstalledPlugins) {
+  Logger.log(Logger.INFO_TYPE, `Rule Plugin Versions are Noted in pluginVersionControl.js`);
+  const versionfilePath = path.join(getNodeModulesPath(), 'node_modules', '@zohodesk', 'codestandard-validator', 'pluginVersionControl.js');
+  writeFileSync(versionfilePath, `module.exports.plugins = [${uninstalledPlugins.map(plugin => {
+    return JSON.stringify({
+      plugin: `${plugin}`,
+      time: `${new Date()}`
+    });
+  }).join(',')}]`);
+}
+module.exports = {
+  createVersionControlFile
+};

package/build/utils/PluginsInstallation/checkIfPluginsAreInstalled.js

@@ -74,30 +74,50 @@ function getAllPlugins() {
  */
 function checkIfPluginsAreInstalled() {
   const pluginsForCurrentRepo = getAllPlugins();
-  let uninstalledPlugins = [];
-  let plugin = {
+  var uninstalledPlugins = [];
+  var plugin = {
     noPluginMessage: '',
     uninstalledPlugins: []
   };
-  let pluginsIndevDependencies = {};
-  let pluginNamesOfDevDependencyPlugins = [];
-  let arePluginsPresentIndevDependencies = false;
-  let arePluginsPresentForCurrentRepo = false;
-  if (existsSync(path.join(getNodeModulesPath(), 'package.json'))) {
-    let packageJsonContent = require(path.join(getNodeModulesPath(), 'package.json'));
-    pluginsIndevDependencies = packageJsonContent.devDependencies;
-    if (pluginsIndevDependencies !== undefined) {
-      arePluginsPresentIndevDependencies = true;
-      pluginNamesOfDevDependencyPlugins = Object.keys(pluginsIndevDependencies);
-    } else if (pluginsIndevDependencies === undefined) {
-      Logger.log(Logger.INFO_TYPE, 'No devDependencies present!');
+  // let pluginsIndevDependencies = {}
+  // let pluginNamesOfDevDependencyPlugins = []
+  // let arePluginsPresentIndevDependencies = false
+  // var arePluginsPresentForCurrentRepo = false
+
+  // if(existsSync(path.join(getNodeModulesPath(),'package.json'))){
+  //     let packageJsonContent = require(path.join(getNodeModulesPath(),'package.json'))
+  //     pluginsIndevDependencies = packageJsonContent.devDependencies
+
+  //     if(pluginsIndevDependencies !== undefined){
+  //         arePluginsPresentIndevDependencies = true
+  //         pluginNamesOfDevDependencyPlugins = Object.keys(pluginsIndevDependencies)
+  //     }
+  //     else if(pluginsIndevDependencies === undefined){
+  //         Logger.log(Logger.INFO_TYPE,'No devDependencies present!')
+  //     }
+  // }
+  // else{
+  //     arePluginsPresentIndevDependencies = false
+  // }
+
+  // arePluginsPresentForCurrentRepo = pluginsForCurrentRepo.length !== 0 ? true : false
+
+  uninstalledPlugins = pluginsForCurrentRepo.map(plugin => {
+    const {
+      packageName,
+      version
+    } = plugin;
+    const {
+      isPluginPresent,
+      pluginPath
+    } = checkPluginsPresentInNodemodules(packageName);
+    if (isPluginPresent && checkPluginHasProperVersion(packageName, pluginPath, version)) {
+      return false;
     }
-  } else {
-    arePluginsPresentIndevDependencies = false;
-  }
-  arePluginsPresentForCurrentRepo = pluginsForCurrentRepo.length !== 0 ? true : false;
-  if (arePluginsPresentForCurrentRepo || arePluginsPresentIndevDependencies) {
-    uninstalledPlugins = getUnInstalledPlugins(pluginsForCurrentRepo, pluginNamesOfDevDependencyPlugins, pluginsIndevDependencies);
+    return `${packageName}@${version}`;
+  }).filter(Boolean);
+  if (uninstalledPlugins.length > 0) {
+    // uninstalledPlugins = getUnInstalledPlugins(pluginsForCurrentRepo, pluginNamesOfDevDependencyPlugins, pluginsIndevDependencies);
     plugin.noPluginMessage = '';
     plugin.uninstalledPlugins = uninstalledPlugins;
     return plugin;
@@ -107,6 +127,25 @@ function checkIfPluginsAreInstalled() {
     return plugin;
   }
 }
+function checkPluginsPresentInNodemodules(rulePluginName) {
+  try {
+    const pluginPath = require.resolve(rulePluginName.toString());
+    return {
+      pluginPath: pluginPath,
+      isPluginPresent: existsSync(pluginPath)
+    };
+  } catch (error) {
+    return {
+      pluginPath: "",
+      isPluginPresent: false
+    };
+  }
+}
+function checkPluginHasProperVersion(rulePluginName, installationPath, remotePluginVersion) {
+  const pluginPathArray = installationPath.toString().split(rulePluginName);
+  const rulePluginPackageJSONPath = path.join(pluginPathArray[0], rulePluginName, 'package.json');
+  return remotePluginVersion == require(rulePluginPackageJSONPath).version ? true : false;
+}
 module.exports = {
   checkIfPluginsAreInstalled
 };

package/build/utils/PluginsInstallation/installPlugins.js

@@ -12,16 +12,20 @@ const {
 const {
   Logger
 } = require('../Logger/Logger');
+const {
+  createVersionControlFile
+} = require('../FileAndFolderOperations/versionControl');
 
 /**
  * @function installPlugins - installs uninstalled plugins for the project
  * @returns {boolean} - indicating if plugins to be installed are installed successfully or not
  */
 function installPlugins() {
-  let uninstalledPlugins = checkIfPluginsAreInstalled();
-  let pluginsToBeInstalled = uninstalledPlugins.uninstalledPlugins;
+  let {
+    uninstalledPlugins: pluginsToBeInstalled
+  } = checkIfPluginsAreInstalled();
   if (pluginsToBeInstalled.length > 0) {
-    let installCommand = `npm install --save-dev ${pluginsToBeInstalled.join(' ')}`;
+    let installCommand = `npm install --no-save ${pluginsToBeInstalled.join(' ')}`;
     Logger.log(Logger.INFO_TYPE, 'Installing plugins ....');
     Logger.log(Logger.INFO_TYPE, `Install command being executed: ${installCommand}`);
     let arePluginsInstalledSuccessfully = executeSynchronizedCommands(execSync, [installCommand, {
@@ -29,6 +33,7 @@ function installPlugins() {
     }], '', 'Some issue occured while installing plugins', false, true);
     if (arePluginsInstalledSuccessfully) {
       Logger.log(Logger.SUCCESS_TYPE, 'Plugins installation successful');
+      createVersionControlFile(pluginsToBeInstalled);
       return true;
     } else {
       Logger.log(Logger.FAILURE_TYPE, "Unable to install plugins.Kindly retry the command");

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zohodesk/codestandard-validator",
-  "version": "0.0.4-exp-2",
+  "version": "0.0.4-exp-6",
   "description": "library to enforce code standard using eslint",
   "main": "index.js",
   "scripts": {