@zohodesk/codestandard-validator 0.0.4-exp-12 → 0.0.4-exp-8

package/build/lib/cli.js

@@ -15,9 +15,6 @@ const {
 const {
   installPlugins
 } = require("../utils/PluginsInstallation/installPlugins");
-const {
-  checkIfPluginsAreInstalled
-} = require("../utils/PluginsInstallation/checkIfPluginsAreInstalled");
 const [,, action, ...options] = process.argv;
 async function run() {
   switch (action) {
@@ -33,10 +30,7 @@ async function run() {
       }
     case "setupPlugins":
       {
-        let {
-          uninstalledPlugins
-        } = checkIfPluginsAreInstalled();
-        await executeMethodsThatReturnBooleanValue("Some issue occurred in installing plugins", installPlugins, uninstalledPlugins);
+        await executeMethodsThatReturnBooleanValue("Some issue occurred in installing plugins", installPlugins, null);
         break;
       }
     case "setupExtension":

package/build/utils/PluginsInstallation/arePluginsInstalled.js

@@ -11,11 +11,10 @@ const {
 } = require('./printUninstalledPlugins');
 function arePluginsInstalled() {
   let {
-    uninstalledPlugins,
-    noPluginMessage
+    uninstalledPlugins
   } = checkIfPluginsAreInstalled();
-  printUninstalledPlugins(uninstalledPlugins, noPluginMessage);
-  installPlugins(uninstalledPlugins);
+  printUninstalledPlugins(uninstalledPlugins);
+  installPlugins();
 }
 module.exports = {
   arePluginsInstalled

package/build/utils/PluginsInstallation/checkIfPluginsAreInstalled.js

@@ -114,10 +114,7 @@ function checkIfPluginsAreInstalled() {
     if (isPluginPresent && checkPluginHasProperVersion(packageName, pluginPath, version)) {
       return false;
     }
-    return {
-      packageName,
-      version
-    };
+    return `${packageName}@${version}`;
   }).filter(Boolean);
   if (uninstalledPlugins.length > 0) {
     // uninstalledPlugins = getUnInstalledPlugins(pluginsForCurrentRepo, pluginNamesOfDevDependencyPlugins, pluginsIndevDependencies);

package/build/utils/PluginsInstallation/installPlugins.js

@@ -1,27 +1,46 @@
 "use strict";
 
+const {
+  execSync
+} = require('child_process');
+const {
+  checkIfPluginsAreInstalled
+} = require('./checkIfPluginsAreInstalled');
+const {
+  executeSynchronizedCommands
+} = require('../General/executeSyncCommands');
 const {
   Logger
 } = require('../Logger/Logger');
 const {
   createVersionControlFile
 } = require('../FileAndFolderOperations/versionControl');
-const installPluginsByWorker = require('./Worker/installPluginsByWoker');
+const {
+  getNodeModulesPath
+} = require('../General/getNodeModulesPath');
 
 /**
  * @function installPlugins - installs uninstalled plugins for the project
  * @returns {boolean} - indicating if plugins to be installed are installed successfully or not
  */
-function installPlugins(pluginsToBeInstalled) {
+function installPlugins() {
+  let {
+    uninstalledPlugins: pluginsToBeInstalled
+  } = checkIfPluginsAreInstalled();
   if (pluginsToBeInstalled.length > 0) {
+    let installCommand = `npm install --no-save ${pluginsToBeInstalled.join(' ')}`;
     Logger.log(Logger.INFO_TYPE, 'Installing plugins ....');
-    try {
+    Logger.log(Logger.INFO_TYPE, `Install command being executed: ${installCommand}`);
+    let arePluginsInstalledSuccessfully = executeSynchronizedCommands(execSync, [installCommand, {
+      stdio: 'inherit',
+      cwd: getNodeModulesPath()
+    }], '', 'Some issue occured while installing plugins', false, true);
+    if (arePluginsInstalledSuccessfully) {
       Logger.log(Logger.SUCCESS_TYPE, 'Plugins installation successful');
-      installPluginsByWorker(pluginsToBeInstalled);
       createVersionControlFile(pluginsToBeInstalled);
       return true;
-    } catch (error) {
-      Logger.log(Logger.FAILURE_TYPE, `Unable to install plugins.Kindly retry the command - ${error.message}`);
+    } else {
+      Logger.log(Logger.FAILURE_TYPE, "Unable to install plugins.Kindly retry the command");
       return false;
     }
   } else {

package/build/utils/PluginsInstallation/printUninstalledPlugins.js

@@ -8,17 +8,17 @@ const {
  * @function printUninstalledPlugins - to notify the user regarding plugins for the repository has been installed or not 
  * @param {Array} uninstalledPlugins - contains list of uninstalled plugins for the project
  */
-function printUninstalledPlugins(uninstalledPlugins, noPluginMessage) {
-  // let commandToInstallPlugins = 'npx ZDPrecommit setupPlugins'
-  if (uninstalledPlugins.length !== 0) {
+function printUninstalledPlugins(uninstalledPlugins) {
+  let commandToInstallPlugins = 'npx ZDPrecommit setupPlugins';
+  if (uninstalledPlugins.uninstalledPlugins.length !== 0) {
     Logger.log(Logger.INFO_TYPE, 'The following plugins are not installed:');
-    uninstalledPlugins.map(plugin => {
-      Logger.log(Logger.INFO_TYPE, `"${plugin.packageName}@${plugin.version}"`);
+    uninstalledPlugins.uninstalledPlugins.map(plugin => {
+      Logger.log(Logger.INFO_TYPE, `"${plugin}"`);
     });
     // Logger.log(Logger.FAILURE_TYPE, `Kindly execute the command \x1b[37m"${commandToInstallPlugins}\x1b[0m" \x1b[31mfrom the location where package.json of the repo is present to install the plugins`)
-  } else if (uninstalledPlugins.length === 0 && noPluginMessage.trim() === '') {
+  } else if (uninstalledPlugins.uninstalledPlugins.length === 0 && uninstalledPlugins.noPluginMessage.trim() === '') {
     Logger.log(Logger.INFO_TYPE, 'Plugins are installed already');
-  } else if (uninstalledPlugins.length === 0 && noPluginMessage.trim() !== '') {
+  } else if (uninstalledPlugins.uninstalledPlugins.length === 0 && uninstalledPlugins.noPluginMessage.trim() !== '') {
     Logger.log(Logger.INFO_TYPE, 'No plugins present for the repository');
   }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zohodesk/codestandard-validator",
-  "version": "0.0.4-exp-12",
+  "version": "0.0.4-exp-8",
   "description": "library to enforce code standard using eslint",
   "main": "index.js",
   "scripts": {