@zohodesk/codestandard-validator 0.0.4-exp-12 → 0.0.4-exp-13

package/build/lib/cli.js

@@ -33,7 +33,7 @@ async function run() {
       }
     case "setupPlugins":
       {
-        let {
+        const {
           uninstalledPlugins
         } = checkIfPluginsAreInstalled();
         await executeMethodsThatReturnBooleanValue("Some issue occurred in installing plugins", installPlugins, uninstalledPlugins);

package/build/utils/PluginsInstallation/checkIfPluginsAreInstalled.js

@@ -114,10 +114,7 @@ function checkIfPluginsAreInstalled() {
     if (isPluginPresent && checkPluginHasProperVersion(packageName, pluginPath, version)) {
       return false;
     }
-    return {
-      packageName,
-      version
-    };
+    return `${packageName}@${version}`;
   }).filter(Boolean);
   if (uninstalledPlugins.length > 0) {
     // uninstalledPlugins = getUnInstalledPlugins(pluginsForCurrentRepo, pluginNamesOfDevDependencyPlugins, pluginsIndevDependencies);

package/build/utils/PluginsInstallation/installPlugins.js

@@ -1,27 +1,44 @@
 "use strict";
 
+const {
+  execSync
+} = require('child_process');
+const {
+  checkIfPluginsAreInstalled
+} = require('./checkIfPluginsAreInstalled');
+const {
+  executeSynchronizedCommands
+} = require('../General/executeSyncCommands');
 const {
   Logger
 } = require('../Logger/Logger');
 const {
   createVersionControlFile
 } = require('../FileAndFolderOperations/versionControl');
-const installPluginsByWorker = require('./Worker/installPluginsByWoker');
+const {
+  getNodeModulesPath
+} = require('../General/getNodeModulesPath');
 
 /**
  * @function installPlugins - installs uninstalled plugins for the project
  * @returns {boolean} - indicating if plugins to be installed are installed successfully or not
  */
 function installPlugins(pluginsToBeInstalled) {
+  // let {uninstalledPlugins : pluginsToBeInstalled} = checkIfPluginsAreInstalled()
   if (pluginsToBeInstalled.length > 0) {
+    let installCommand = `npm install --no-save ${pluginsToBeInstalled.join(' ')}`;
     Logger.log(Logger.INFO_TYPE, 'Installing plugins ....');
-    try {
+    Logger.log(Logger.INFO_TYPE, `Install command being executed: ${installCommand}`);
+    let arePluginsInstalledSuccessfully = executeSynchronizedCommands(execSync, [installCommand, {
+      stdio: 'inherit',
+      cwd: getNodeModulesPath()
+    }], '', 'Some issue occured while installing plugins', false, true);
+    if (arePluginsInstalledSuccessfully) {
       Logger.log(Logger.SUCCESS_TYPE, 'Plugins installation successful');
-      installPluginsByWorker(pluginsToBeInstalled);
       createVersionControlFile(pluginsToBeInstalled);
       return true;
-    } catch (error) {
-      Logger.log(Logger.FAILURE_TYPE, `Unable to install plugins.Kindly retry the command - ${error.message}`);
+    } else {
+      Logger.log(Logger.FAILURE_TYPE, "Unable to install plugins.Kindly retry the command");
       return false;
     }
   } else {

package/build/utils/PluginsInstallation/printUninstalledPlugins.js

@@ -9,11 +9,11 @@ const {
  * @param {Array} uninstalledPlugins - contains list of uninstalled plugins for the project
  */
 function printUninstalledPlugins(uninstalledPlugins, noPluginMessage) {
-  // let commandToInstallPlugins = 'npx ZDPrecommit setupPlugins'
+  let commandToInstallPlugins = 'npx ZDPrecommit setupPlugins';
   if (uninstalledPlugins.length !== 0) {
     Logger.log(Logger.INFO_TYPE, 'The following plugins are not installed:');
     uninstalledPlugins.map(plugin => {
-      Logger.log(Logger.INFO_TYPE, `"${plugin.packageName}@${plugin.version}"`);
+      Logger.log(Logger.INFO_TYPE, `"${plugin}"`);
     });
     // Logger.log(Logger.FAILURE_TYPE, `Kindly execute the command \x1b[37m"${commandToInstallPlugins}\x1b[0m" \x1b[31mfrom the location where package.json of the repo is present to install the plugins`)
   } else if (uninstalledPlugins.length === 0 && noPluginMessage.trim() === '') {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zohodesk/codestandard-validator",
-  "version": "0.0.4-exp-12",
+  "version": "0.0.4-exp-13",
   "description": "library to enforce code standard using eslint",
   "main": "index.js",
   "scripts": {