@zohodesk/codestandard-validator 0.0.2 → 0.0.3

package/build/utils/HuskySetup/initializeHusky.js

@@ -23,7 +23,7 @@ function initializeHusky() {
   let isNavigationToRootDirectorySuccessful = navigateToRootDirectory(getRootDirectory());
   if (isNavigationToRootDirectorySuccessful) {
     try {
-      execSync('npx husky install');
+      execSync('npx husky@7 install');
       return true;
     } catch (error) {
       Logger.log(Logger.FAILURE_TYPE, error.toString());

package/build/utils/HuskySetup/setupHusky.js

@@ -1,21 +1,8 @@
 "use strict";
 
 /* eslint-disable no-console */
-const {
-  execSync
-} = require('child_process');
-const {
-  readdirSync
-} = require('fs');
-const path = require('path');
 const initializeHusky = require('./initializeHusky');
 const configurePrecommitHook = require('./configurePrecommitHook');
-const {
-  getNodeModulesPath
-} = require('../General/getNodeModulesPath');
-const {
-  executeSynchronizedCommands
-} = require('../General/executeSyncCommands');
 const {
   Logger
 } = require('../Logger/Logger');
@@ -26,51 +13,21 @@ let isCustomPrecommitConfigurationSuccessful = false;
  * @returns {boolean} - indicating whether entire custom precommit hook setup using husky process is success or failure
  */
 function setupHusky() {
-  let isHuskyPackageInstalled = installHuskyPackage();
-  if (isHuskyPackageInstalled) {
-    let isHuskyInitializedSuccessfully = initializeHusky();
-    if (isHuskyInitializedSuccessfully) {
-      Logger.log(Logger.SUCCESS_TYPE, 'Husky installation successful');
-      isCustomPrecommitConfigurationSuccessful = configurePrecommitHook();
-      if (isCustomPrecommitConfigurationSuccessful) {
-        Logger.log(Logger.SUCCESS_TYPE, 'Custom pre commit hook setup was successful');
-        return true;
-      } else {
-        Logger.log(Logger.FAILURE_TYPE, 'Couldn\'t configure custom pre commit hook');
-        return false;
-      }
+  let isHuskyInitializedSuccessfully = initializeHusky();
+  if (isHuskyInitializedSuccessfully) {
+    Logger.log(Logger.SUCCESS_TYPE, 'Husky installation successful');
+    isCustomPrecommitConfigurationSuccessful = configurePrecommitHook();
+    if (isCustomPrecommitConfigurationSuccessful) {
+      Logger.log(Logger.SUCCESS_TYPE, 'Custom pre commit hook setup was successful');
+      return true;
     } else {
+      Logger.log(Logger.FAILURE_TYPE, 'Couldn\'t configure custom pre commit hook');
       return false;
     }
   } else {
-    Logger.log(Logger.FAILURE_TYPE, 'Some issue in installing husky package.');
     return false;
   }
 }
-
-/**
- * @function installHuskyPackage - installs husky package if not installed for the project
- * @returns {boolean} - indicating if husky package installed successfully or not
- */
-function installHuskyPackage() {
-  const nodeModulesPathOfProject = path.join(getNodeModulesPath(), 'node_modules');
-  let pluginsInNodeModules = executeSynchronizedCommands(readdirSync, [nodeModulesPathOfProject], '', 'Unable to get directories in node_modules when checking if husky is installed', true, false);
-  let husky = {
-    packageName: 'husky',
-    version: '^7.0.4'
-  };
-  let isHuskyInstalled = pluginsInNodeModules.includes(husky.packageName) ? true : false;
-  if (!isHuskyInstalled) {
-    Logger.log(Logger.INFO_TYPE, 'Installing husky package ....');
-    let installCommand = `npm install ${husky.packageName}@${husky.version} --save-dev`;
-    let isHuskyPackageInstalled = executeSynchronizedCommands(execSync, [installCommand, {
-      stdio: 'inherit'
-    }], 'Husky package Installed Successfully', 'Unable to install husky package', false, true);
-    return isHuskyPackageInstalled;
-  }
-  Logger.log(Logger.SUCCESS_TYPE, 'Husky package already installed!');
-  return true;
-}
 module.exports = {
   setupHusky
 };

package/changeLog.md

@@ -10,4 +10,7 @@
  1. Sets up a custom precommit hook using husky
  2. clones the common linter configuration repository in developer branch 
  3. Based on the cloned configuration folder creates a eslint config file
- 4. Checks for eslint rule violations in the staged files(Impact based) and aborts/allows commit accordingly
+ 4. Checks for eslint rule violations in the staged files(Impact based) and aborts/allows commit accordingly
+
+ # 0.0.3 - modifications in usage of Husky package
+ 1. The husky package is not installed and the required huksy package version is temporarily downloaded from npm registry and used 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zohodesk/codestandard-validator",
-  "version": "0.0.2",
+  "version": "0.0.3",
   "description": "library to enforce code standard using eslint",
   "main": "index.js",
   "scripts": {