@zohodesk/codestandard-validator 0.0.2-exp-10 → 0.0.2-exp-11

package/build/hooks/Precommit/pre-commit.js

@@ -275,17 +275,9 @@ async function preCommitHook() {
         Logger.log(Logger.INFO_TYPE, 'Error executing pre commit hook');
       }
       if (shouldAbortCommit) {
-        if (hasEslintErrorsInChangedLines && areFilesStaged) {
-          Logger.log(Logger.FAILURE_TYPE, `There are eslint errors present. So commit is aborted`);
-          process.exit(1);
-        } else if (hasEslintErrorsInFiles && areFilesStaged) {
-          Logger.log(Logger.FAILURE_TYPE, `There are eslint errors present. So commit is aborted`);
-          process.exit(1);
-        } else if (!hasEslintErrorsInFiles && !hasEslintErrorsInChangedLines && areFilesStaged) {
-          Logger.log(Logger.SUCCESS_TYPE, `Commit Successful`);
-          process.exit(0);
-        }
-      } else if (!shouldAbortCommit && areFilesStaged) {
+        Logger.log(Logger.FAILURE_TYPE, `There are eslint errors present. So commit is aborted. If possible try to fix the eslint warnings also.`);
+        process.exit(1);
+      } else {
         Logger.log(Logger.SUCCESS_TYPE, `Commit Successful`);
         process.exit(0);
       }

package/build/setup/sample.config.js

@@ -14,6 +14,7 @@ const path = require("path");
  * @property {string} tsConfigurationPath - The path of the ts configuration Path
  * @property {number} projectId - project id of repository
  * @property {boolean} impactBasedPrecommit - Indicates if the linting is impact-based in pre commit
+ * @property {boolean} shouldWarningsAbortCommit - Indicates if eslint warnings should abort the commit
  * @property {string} token - Encrypted Authentication Token
  * @property {string} compareBranch - Branch to compare diff
  */

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zohodesk/codestandard-validator",
-  "version": "0.0.2-exp-10",
+  "version": "0.0.2-exp-11",
   "description": "library to enforce code standard using eslint",
   "main": "index.js",
   "scripts": {