@zohodesk/client_build_tool 0.0.5-exp.2 → 0.0.5-exp.3

package/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog and Release Notes
 
+## v0.0.5-exp.3 (11-09-2023)
+
+**changes:--**
+- changing plugin hook stages in i18nRuntimePlugin and sourceMapPlugin
 ## v0.0.5 (6-08-2023)
 
 **Changes:--**

package/README.md

@@ -84,6 +84,10 @@ These commands provide flexibility and control over your client-side build proce
 For more [Details](ConfigurationDocumentation.md)
 # Changelog and Release Notes
 
+## v0.0.5-exp.3 (11-09-2023)
+
+**changes:--**
+- changing plugin hook stages in i18nRuntimePlugin and sourceMapPlugin
 ## v0.0.5 (6-08-2023)
 
 **Changes:--**

package/lib/shared/bundler/webpack/custom_plugins/I18nSplitPlugin/I18nRuntimeDealerPlugin.js

@@ -145,7 +145,7 @@ class I18nRuntimeDealerPlugin {
     if (chunkFilenameHasContentHash) {
       compilation.hooks.processAssets.tap({
         name: pluginName,
-        stage: _webpack.Compilation.PROCESS_ASSETS_STAGE_PRE_PROCESS // additionalAssets: true
+        stage: _webpack.Compilation.PROCESS_ASSETS_STAGE_DERIVED // additionalAssets: true
 
       }, assets => {
         // eslint-disable-next-line no-underscore-dangle
@@ -174,32 +174,28 @@ class I18nRuntimeDealerPlugin {
             runtimeFileName,
             runtimeFileSourceStr,
             i18nChunks
-          })); // NOTE: we don't delete, Because of HTML plugin needs to add runtime file in html and  efc
+          })); // NOTE: we don't delete, Because of HTML plugin needs to add runtime file in html and  efc 
           // compilation.deleteAsset(runtimeFileName);
         }
       });
       compilation.hooks.processAssets.tap({
         name: pluginName,
-        stage: _webpack.Compilation.PROCESS_ASSETS_STAGE_PRE_PROCESS // additionalAssets: true
+        stage: _webpack.Compilation.PROCESS_ASSETS_STAGE_SUMMARIZE // additionalAssets: true
 
       }, () => {
-        console.log('delete starts ==== '); // eslint-disable-next-line no-underscore-dangle
-
+        // eslint-disable-next-line no-underscore-dangle
         const entries = compilation._getChunkGraphEntries(); // eslint-disable-next-line no-restricted-syntax
 
 
         for (const entryChunk of entries) {
           const runtimeFileName = [...entryChunk.files][0] || '';
-          console.log(runtimeFileName, 'runtimeFile==');
 
           if (runtimeFileName.includes('runtime') && runtimeFileName.includes('[locale]')) {
             (0, _logger.verboseLogger)('deleteAsset', runtimeFileName);
-            console.log('deleted successuly====');
             compilation.deleteAsset(runtimeFileName);
           }
         }
       });
-      console.log('completed ====');
     }
   }
 

package/lib/shared/bundler/webpack/custom_plugins/SourceMapPlugin/index.js

@@ -8,7 +8,20 @@ exports.SourceMapPlugin = void 0;
 var _webpack = require("webpack");
 
 /* eslint-disable class-methods-use-this */
-const pluginName = 'SplitSourceMapPlugin';
+function checkSmapFilePattern(assetName) {
+  return /\.js$/.test(assetName) && !/\.i18n\.js$/.test(assetName) || /\.js\.map$/.test(assetName) && !/\.i18n\.js\.map$/.test(assetName);
+}
+
+function skipRuntimeFiles(assetName) {
+  return !assetName.includes('runtime') || !assetName.includes('[locale]');
+}
+
+const pluginName = 'SplitSourceMapPlugin'; // Purpose:
+
+/**
+ * we want build that can load files source map and without sourcemap at the same time,
+ * or can be mentioned as so single build need to support two different clients that one for fast load and one for debugging.
+ */
 
 class SourceMapPlugin {
   apply(compiler) {
@@ -18,12 +31,12 @@ class SourceMapPlugin {
     compiler.hooks.thisCompilation.tap(pluginName, compilation => {
       compilation.hooks.processAssets.tap({
         name: pluginName,
-        stage: _webpack.Compilation.PROCESS_ASSETS_STAGE_DERIVED
+        stage: _webpack.Compilation.PROCESS_ASSETS_STAGE_ADDITIONAL
       }, assets => {
         Object.keys(assets).forEach(assetName => {
           const assetCode = assets[assetName].source();
 
-          if (/\.js$/.test(assetName) && !/\.i18n\.js$/.test(assetName) || /\.js\.map$/.test(assetName) && !/\.i18n\.js\.map$/.test(assetName)) {
+          if (checkSmapFilePattern(assetName) && skipRuntimeFiles(assetName)) {
             compilation.renameAsset(assetName, `smap/${assetName}`);
 
             if (!/\.map$/.test(assetName)) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zohodesk/client_build_tool",
-  "version": "0.0.5-exp.2",
+  "version": "0.0.5-exp.3",
   "description": "A CLI tool to  build  web applications and client libraries",
   "main": "lib/index.js",
   "bin": {
@@ -8,6 +8,7 @@
     "cbt": "cli.js"
   },
   "scripts": {
+    "exp:publish": "npm publish --tag exp",
     "start": "rm -r lib && npm run build -- -w",
     "prepare": "npm run build",
     "build": "babel src --out-dir lib  --copy-files --config-file=./.babelrc",