@zodic/shared 0.0.195 → 0.0.196

package/app/services/ConceptService.ts

@@ -33,7 +33,6 @@ export class ConceptService {
     const kvFailuresStore = this.context.kvConceptFailuresStore();
     const kvKeyEN = buildConceptKVKey('en-us', conceptSlug, combinationString);
     const kvKeyPT = buildConceptKVKey('pt-br', conceptSlug, combinationString);
-    const failureKey = `failures:basic-info:${conceptSlug}:${combinationString}`;
   
     // ✅ Use Durable Object stub
     const id = this.context.env.CONCEPT_NAMES_DO.idFromName(conceptSlug);
@@ -46,33 +45,11 @@ export class ConceptService {
     // ✅ IMMEDIATE SKIP if already exists and override is false
     if (!override && existingEN.name && existingPT.name) {
       console.log(`⚡ Basic info already exists for ${conceptSlug}, skipping.`);
-  
-      // ✅ **Backfill Durable Object** to register the names
-      console.log(`📡 Backfilling Durable Object for ${conceptSlug}...`);
-      try {
-        await Promise.all([
-          stub.fetch(`https://internal/add-name`, {
-            method: 'POST',
-            body: JSON.stringify({ language: 'en-us', name: existingEN.name }),
-            headers: { 'Content-Type': 'application/json' },
-          }),
-          stub.fetch(`https://internal/add-name`, {
-            method: 'POST',
-            body: JSON.stringify({ language: 'pt-br', name: existingPT.name }),
-            headers: { 'Content-Type': 'application/json' },
-          }),
-        ]);
-        console.log(`✅ Successfully backfilled Durable Object for ${conceptSlug}`);
-      } catch (error) {
-        console.error(`❌ Error backfilling Durable Object:`, error);
-      }
-  
-      return; // ✅ Exit early
+      return;
     }
   
     let attempts = 0;
-    const maxAttempts = 2;
-    let newlyGeneratedNames: string[] = []; // ✅ Track generated names in memory
+    const maxAttempts = 3;
   
     while (attempts < maxAttempts) {
       let phase = 'generation';
@@ -90,39 +67,50 @@ export class ConceptService {
           const data = (await response.json()) as { 'en-us': string[]; 'pt-br': string[] };
           allNamesEN = data['en-us'] || [];
           allNamesPT = data['pt-br'] || [];
-          console.log(`✅ Retrieved ${allNamesEN.length} EN names and ${allNamesPT.length} PT names.`);
-        } else {
-          console.log(`❌ Error fetching names from DO for ${conceptSlug}: ${await response.text()}`);
         }
   
         console.log(`✏️ Generating new name...`);
-        // ✅ Merge newly generated names with existing recent names
-        const recentNamesEN = [...allNamesEN.slice(-40), ...newlyGeneratedNames];
-  
         const messages = this.context
           .buildLLMMessages()
           .generateConceptBasicInfo({
             combination: combinationString,
             conceptSlug,
-            existingNames: recentNamesEN,
+            existingNames: allNamesEN.slice(-40),
           });
   
         let aiResponse = await this.context.api().callTogether.single(messages, {});
         if (!aiResponse) throw new Error(`❌ AI returned an empty response`);
   
         phase = 'cleaning';
-        console.log(`🧼 Cleaning AI response...`);
         aiResponse = this.cleanAIResponse(aiResponse);
   
         phase = 'parsing';
-        console.log(`📜 Parsing AI response...`);
         let { nameEN, descriptionEN, poemEN, namePT, descriptionPT, poemPT } =
           this.parseBasicInfoResponse(aiResponse, conceptSlug);
   
         console.log(`🎭 Generated names: EN - "${nameEN}", PT - "${namePT}"`);
   
-        // ✅ **Add the generated names to our local tracking list**
-        newlyGeneratedNames.push(nameEN, namePT);
+        // ✅ **Check name length and retry if too long**
+        const MAX_NAME_LENGTH = 44; // Adjust if needed
+        if (nameEN.length > MAX_NAME_LENGTH || namePT.length > MAX_NAME_LENGTH) {
+          console.warn(`⚠️ Name too long: "${nameEN}" | "${namePT}". Retrying...`);
+  
+          // ✅ **Register name in Durable Object as blocked**
+          await stub.fetch(`https://internal/add-name`, {
+            method: 'POST',
+            body: JSON.stringify({ language: 'en-us', name: nameEN }),
+            headers: { 'Content-Type': 'application/json' },
+          });
+  
+          await stub.fetch(`https://internal/add-name`, {
+            method: 'POST',
+            body: JSON.stringify({ language: 'pt-br', name: namePT }),
+            headers: { 'Content-Type': 'application/json' },
+          });
+  
+          console.log(`✅ Added long name to DO blocklist, retrying...`);
+          continue;
+        }
   
         // ✅ Check uniqueness before storing
         if (allNamesEN.includes(nameEN) || allNamesPT.includes(namePT)) {
@@ -132,7 +120,6 @@ export class ConceptService {
           if (attempts >= maxAttempts) {
             console.log(`🚨 Max attempts reached. Storing name despite duplicate.`);
   
-            // ✅ **Register duplicate storage in KV failures**
             await kvFailuresStore.put(
               `failures:duplicates:${conceptSlug}:${combinationString}`,
               JSON.stringify({
@@ -145,38 +132,8 @@ export class ConceptService {
               })
             );
   
-            // ✅ **Store names in Durable Object**
-            await stub.fetch(`https://internal/add-name`, {
-              method: 'POST',
-              body: JSON.stringify({ language: 'en-us', name: nameEN }),
-              headers: { 'Content-Type': 'application/json' },
-            });
-  
-            await stub.fetch(`https://internal/add-name`, {
-              method: 'POST',
-              body: JSON.stringify({ language: 'pt-br', name: namePT }),
-              headers: { 'Content-Type': 'application/json' },
-            });
-  
-            // ✅ Store the generated basic info in KV
-            Object.assign(existingEN, {
-              name: nameEN,
-              description: descriptionEN,
-              poem: poemEN,
-              status: 'forced', // 🔥 Mark as "forced" due to duplication
-            });
-            await kvStore.put(kvKeyEN, JSON.stringify(existingEN));
-  
-            Object.assign(existingPT, {
-              name: namePT,
-              description: descriptionPT,
-              poem: poemPT,
-              status: 'forced', // 🔥 Mark as "forced" due to duplication
-            });
-            await kvStore.put(kvKeyPT, JSON.stringify(existingPT));
-  
             console.log(`✅ Stored duplicate name after max retries: ${nameEN}, ${namePT}`);
-            return;
+            break;
           }
   
           console.log('🔁 Retrying due to duplicate name...');

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zodic/shared",
-  "version": "0.0.195",
+  "version": "0.0.196",
   "module": "index.ts",
   "type": "module",
   "publishConfig": {