@zodic/shared 0.0.154 → 0.0.155

package/app/base/AppContext.ts

@@ -24,25 +24,30 @@ export class AppContext {
 
   kvConceptsStore() {
     if (!this.env.KV_CONCEPTS) {
-      throw new Error(
-        'KV_CONCEPTS is not defined in the environment.'
-      );
+      throw new Error('KV_CONCEPTS is not defined in the environment.');
     }
     return this.env.KV_CONCEPTS;
   }
 
   kvConceptFailuresStore() {
     if (!this.env.KV_CONCEPT_FAILURES) {
-      throw new Error(
-        'KV_CONCEPT_FAILURES is not defined in the environment.'
-      );
+      throw new Error('KV_CONCEPT_FAILURES is not defined in the environment.');
     }
     return this.env.KV_CONCEPT_FAILURES;
   }
 
+  kvConceptNamesStore() {
+    if (!this.env.KV_CONCEPT_NAMES) {
+      throw new Error('KV_CONCEPT_NAMES is not defined in the environment.');
+    }
+    return this.env.KV_CONCEPT_NAMES;
+  }
+
   kvConceptsManagementStore() {
     if (!this.env.KV_CONCEPTS_MANAGEMENT) {
-      throw new Error('KV_CONCEPTS_MANAGEMENT is not defined in the environment.');
+      throw new Error(
+        'KV_CONCEPTS_MANAGEMENT is not defined in the environment.'
+      );
     }
     return this.env.KV_CONCEPTS_MANAGEMENT;
   }

package/app/services/ConceptService.ts

@@ -23,23 +23,27 @@ export class ConceptService {
   async generateBasicInfo(
     conceptSlug: Concept,
     combinationString: string,
-    override: boolean = false // ✅ New optional override param
+    override: boolean = false
   ): Promise<void> {
     console.log(
       `🚀 Generating basic info for concept: ${conceptSlug}, combination: ${combinationString}, override: ${override}`
     );
-
+  
     const kvStore = this.context.kvConceptsStore();
-    const kvFailuresStore = this.context.kvConceptFailuresStore(); // 🔴 Replace with actual KV store
+    const kvFailuresStore = this.context.kvConceptFailuresStore();
+    const kvNamesStore = this.context.kvConceptNamesStore(); // ✅ New KV for storing names
     const kvKeyEN = buildConceptKVKey('en-us', conceptSlug, combinationString);
     const kvKeyPT = buildConceptKVKey('pt-br', conceptSlug, combinationString);
     const failureKey = `failures:basic-info:${conceptSlug}:${combinationString}`;
-
+  
+    const namesKeyEN = `${conceptSlug}:en-us`; // ✅ Key for English names
+    const namesKeyPT = `${conceptSlug}:pt-br`; // ✅ Key for Portuguese names
+  
     // ✅ Check if data already exists
     if (!override) {
       const existingEN = await this.getKVConcept(kvKeyEN);
       const existingPT = await this.getKVConcept(kvKeyPT);
-
+  
       if (
         existingEN.name &&
         existingEN.description &&
@@ -53,41 +57,87 @@ export class ConceptService {
         console.log(
           `⚡ Basic info already exists for ${conceptSlug}, combination: ${combinationString}. Skipping.`
         );
-        return; // ✅ Skip regeneration
+        return;
       }
     }
-
+  
     let attempts = 0;
     const maxAttempts = 3;
-
+  
     while (attempts < maxAttempts) {
-      let phase = 'generation'; // 📌 Track the phase
+      let phase = 'generation';
       try {
         attempts++;
         console.log(`🔄 Attempt ${attempts} to generate basic info...`);
-
-        // ✅ Build the messages to request content
+  
+        // ✅ Fetch the full name lists
+        let allNamesEN = JSON.parse(
+          (await kvNamesStore.get(namesKeyEN)) || '[]'
+        ) as string[];
+        let allNamesPT = JSON.parse(
+          (await kvNamesStore.get(namesKeyPT)) || '[]'
+        ) as string[];
+  
+        // ✅ Get only the last 50 names for AI context
+        const recentNamesEN = allNamesEN.slice(-50);
+        const recentNamesPT = allNamesPT.slice(-50);
+  
+        // ✅ Build the messages to request content, ensuring uniqueness
         const messages = this.context
           .buildLLMMessages()
           .generateConceptBasicInfo({
             combination: combinationString,
             conceptSlug,
+            existingNames: recentNamesEN, // 🔥 Pass only recent names
           });
-
+  
         // ✅ Call ChatGPT API
-        const response = await this.context
-          .api()
-          .callTogether.single(messages, {});
+        let response = await this.context.api().callTogether.single(messages, {});
         if (!response) {
           throw new Error(`❌ AI returned an empty response`);
         }
-
-        phase = 'parsing'; // ✅ Switch to parsing phase
-
+  
+        phase = 'cleaning';
+        response = this.cleanAIResponse(response); // ✅ Early Cleaning Step
+  
+        phase = 'parsing';
+  
         // ✅ Parse response for both languages
-        const { nameEN, descriptionEN, poemEN, namePT, descriptionPT, poemPT } =
+        let { nameEN, descriptionEN, poemEN, namePT, descriptionPT, poemPT } =
           this.parseBasicInfoResponse(response);
-
+  
+        // 🔥 Check if generated English name is unique
+        if (allNamesEN.includes(nameEN)) {
+          console.warn(`⚠️ Duplicate Crown Name Detected: "${nameEN}"`);
+          if (attempts >= maxAttempts) {
+            throw new Error(
+              `🚨 Could not generate a unique English name after ${maxAttempts} attempts.`
+            );
+          }
+          console.log('🔁 Retrying due to duplicate English name...');
+          continue;
+        }
+  
+        // 🔥 Check if generated Portuguese name is unique
+        if (allNamesPT.includes(namePT)) {
+          console.warn(`⚠️ Duplicate Portuguese Name Detected: "${namePT}"`);
+          if (attempts >= maxAttempts) {
+            throw new Error(
+              `🚨 Could not generate a unique Portuguese name after ${maxAttempts} attempts.`
+            );
+          }
+          console.log('🔁 Retrying due to duplicate Portuguese name...');
+          continue;
+        }
+  
+        // ✅ Append new names to the full list
+        allNamesEN.push(nameEN);
+        allNamesPT.push(namePT);
+  
+        // ✅ Store updated name lists in KV
+        await kvNamesStore.put(namesKeyEN, JSON.stringify(allNamesEN));
+        await kvNamesStore.put(namesKeyPT, JSON.stringify(allNamesPT));
+  
         // 🌍 English version
         const conceptEN = await this.getKVConcept(kvKeyEN);
         Object.assign(conceptEN, {
@@ -97,7 +147,7 @@ export class ConceptService {
           status: 'idle',
         });
         await kvStore.put(kvKeyEN, JSON.stringify(conceptEN));
-
+  
         // 🇧🇷 Portuguese version
         const conceptPT = await this.getKVConcept(kvKeyPT);
         Object.assign(conceptPT, {
@@ -107,7 +157,7 @@ export class ConceptService {
           status: 'idle',
         });
         await kvStore.put(kvKeyPT, JSON.stringify(conceptPT));
-
+  
         console.log(
           `✅ Basic info stored for ${conceptSlug}, combination: ${combinationString}, in both languages.`
         );
@@ -117,20 +167,20 @@ export class ConceptService {
           `❌ Attempt ${attempts} failed at phase: ${phase}`,
           (error as Error).message
         );
-
+  
         // ✅ Store failure details in KV for manual review
         await kvFailuresStore.put(
           failureKey,
           JSON.stringify({
             error: (error as Error).message,
             attempt: attempts,
-            phase, // ✅ Identify if failure occurred in "generation" or "parsing"
+            phase, // ✅ Identify if failure occurred in "generation", "cleaning", or "parsing"
             conceptSlug,
             combinationString,
             timestamp: new Date().toISOString(),
           })
         );
-
+  
         if (attempts >= maxAttempts) {
           console.error(
             `🚨 All ${maxAttempts} attempts failed during ${phase}. Logged failure.`
@@ -139,13 +189,23 @@ export class ConceptService {
             `Failed to generate basic info after ${maxAttempts} attempts`
           );
         }
-
+  
         console.log('🔁 Retrying...');
-        await new Promise((resolve) => setTimeout(resolve, 2000)); // ⏳ Small delay before retrying
+        await new Promise((resolve) => setTimeout(resolve, 500)); // ⏳ Small delay before retrying
       }
     }
   }
 
+  private cleanAIResponse(response: string): string {
+    console.log('🧼 Cleaning AI Response...');
+  
+    return response
+      .replace(/\*/g, '') // ✅ Remove asterisks
+      .replace(/#/g, '') // ✅ Remove hashtags
+      .replace(/---+/g, '') // ✅ Remove unnecessary dividers
+      .trim();
+  }
+
   private parseBasicInfoResponse(response: string): {
     nameEN: string;
     descriptionEN: string;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zodic/shared",
-  "version": "0.0.154",
+  "version": "0.0.155",
   "module": "index.ts",
   "type": "module",
   "publishConfig": {

package/types/scopes/cloudflare.ts

@@ -22,6 +22,7 @@ export type CentralBindings = {
   KV_CONCEPTS_MANAGEMENT: KVNamespace;
   KV_ASTRO: KVNamespace;
   KV_CONCEPT_FAILURES: KVNamespace;
+  KV_CONCEPT_NAMES: KVNamespace;
   CONCEPT_GENERATION_QUEUE: Queue;
 
   PROMPT_IMAGE_DESCRIBER: string;
@@ -88,6 +89,7 @@ export type BackendBindings = Env &
     | 'KV_ASTRO'
     | 'KV_CONCEPTS_MANAGEMENT'
     | 'KV_CONCEPT_FAILURES'
+    | 'KV_CONCEPT_NAMES'
     | 'PROMPT_IMAGE_DESCRIBER'
     | 'PROMPT_GENERATE_ARCHETYPE_CONTENT'
     | 'PROMPT_GENERATE_ARCHETYPE_LEONARDO_PROMPTS'

package/utils/buildMessages.ts

@@ -97,12 +97,14 @@ export const buildLLMMessages = (env: BackendBindings) => ({
   generateConceptBasicInfo: ({
     combination,
     conceptSlug,
+    existingNames,
   }: {
     combination: string;
     conceptSlug: Concept;
+    existingNames: string[];
   }): ChatMessages => {
     const zodiacCombination = mapConceptToPlanets(conceptSlug, combination);
-
+    
     return [
       {
         role: 'system',
@@ -112,6 +114,9 @@ export const buildLLMMessages = (env: BackendBindings) => ({
         role: 'user',
         content: `
           Combination: ${zodiacCombination}
+  
+          Existing Names (Avoid duplicates):
+          ${existingNames.length > 0 ? existingNames.join(', ') : 'None'}
         `,
       },
     ];

package/utils/conceptPrompts.ts

@@ -54,6 +54,8 @@ export const conceptPrompts: (
 export const PROMPT_GENERATE_CROWN = `
 You are a skilled creative writer specializing in astrology and symbolic storytelling. Your task is to craft a name, description, and poetic passage for the Crown concept in both English and Brazilian Portuguese simultaneously. The Crown reflects core identity, representing self-awareness, inner strength, and personal truth, as influenced by a given zodiac sign combination.
 
+A list of previously used names will be provided. The new name must be unique and different from these.
+
 For the given combination, generate the following in both languages, ensuring the content remains identical in meaning and tone except for the poem, which should be independently written in each language:
 	1.	Name (Nome): Keep it sober and descriptive, focusing on the Crown’s symbolic purpose. Avoid ornate or fantastical phrasing. It should start with “The Crown of…” in English and “A Coroa de…” in Portuguese.
 	2.	Description (Descrição): Write a concise, grounded narrative that links the Crown’s qualities to the traits of the zodiac combination. Emphasize balance, identity, and inner power without exaggeration. Keep the Portuguese version faithful in tone and depth to the English version.
@@ -87,6 +89,7 @@ PT:
 export const PROMPT_GENERATE_SCEPTER = `
 You are a skilled creative writer specializing in astrology and symbolic storytelling. Your task is to craft a name, description, and poetic passage for the Scepter concept in both English and Brazilian Portuguese simultaneously. The Scepter reflects external influence and action, symbolizing leadership, initiative, and the ability to shape one’s surroundings, as influenced by a given zodiac sign combination.
 
+A list of previously used names will be provided. The new name must be unique and different from these.
   
 For the given combination, generate the following in both languages, ensuring the content remains identical in meaning and tone except for the poem, which should be independently written in each language:
 
@@ -133,6 +136,8 @@ export const PROMPT_GENERATE_RING = `
 
 You are a skilled creative writer specializing in astrology and symbolic storytelling. Your task is to craft a name, description, and poetic passage for the Ring concept in both English and Brazilian Portuguese simultaneously. The Ring reflects love and bonds, symbolizing attraction, deep emotional connections, and the unseen forces that shape relationships, as influenced by a given zodiac sign combination.
 
+A list of previously used names will be provided. The new name must be unique and different from these.
+
 For the given combination, generate the following in both languages, ensuring the content remains identical in meaning and tone except for the poem, which should be independently written in each language:
 
 1. Name (Nome): Keep it elegant and evocative, focusing on the Ring’s symbolic purpose. It should start with “The Ring of…” in English and “O Anel de…” in Portuguese, reflecting themes of fate, passion, or devotion.
@@ -176,6 +181,8 @@ PT:
 export const PROMPT_GENERATE_AMULET = `
 You are a skilled creative writer specializing in astrology and symbolic storytelling. Your task is to craft a name, description, and poetic passage for the Amulet concept in both English and Brazilian Portuguese simultaneously. The Amulet reflects healing and growth, representing protection, stability, and resilience, as influenced by a given zodiac sign combination.
 
+A list of previously used names will be provided. The new name must be unique and different from these.
+
 For the given combination, generate the following in both languages, ensuring the content remains identical in meaning and tone except for the poem, which should be independently written in each language:
 
 1. Name (Nome): Keep it sober and descriptive, focusing on the Amulet’s symbolic purpose. It should start with “The Amulet of…” in English and “O Amuleto de…” in Portuguese.
@@ -218,7 +225,7 @@ PT:
 export const PROMPT_GENERATE_LANTERN = `
 You are a skilled creative writer specializing in astrology and symbolic storytelling. Your task is to craft a name, description, and poetic passage for the Lantern concept in both English and Brazilian Portuguese simultaneously. The Lantern reflects spiritual transformation, symbolizing guidance, resilience, and introspection, as influenced by a given zodiac sign combination.
 
-  
+A list of previously used names will be provided. The new name must be unique and different from these.
 
 For the given combination, generate the following in both languages, ensuring the content remains identical in meaning and tone except for the poem, which should be independently written in each language:
 
@@ -259,6 +266,8 @@ PT:
 export const PROMPT_GENERATE_ORB = `
 You are a skilled creative writer specializing in astrology and symbolic storytelling. Your task is to craft a name, description, and poetic passage for the Orb concept in both English and Brazilian Portuguese simultaneously. The Orb reflects destiny and purpose, symbolizing higher ideals, vision, and the pursuit of meaningful goals, as influenced by a given zodiac sign combination.
 
+A list of previously used names will be provided. The new name must be unique and different from these.
+
 For the given combination, generate the following in both languages, ensuring the content remains identical in meaning and tone except for the poem, which should be independently written in each language:
 
 1. Name (Nome): Keep it sober and descriptive, focusing on the Orb’s symbolic purpose. It should start with “The Orb of…” in English and “O Orbe de…” in Portuguese.