@zip.js/zip.js 2.16.0 → 2.16.1

package/dist/zip-core.js

@@ -1283,12 +1283,12 @@
 	class AESDecryptionStream extends TransformStream {
 
 		constructor({ password, rawPassword, encryptionStrength, checkPasswordOnly, checkAuthenticationCode = true }) {
+			const aesCrypto = {};
 			super({
 				start() {
-					initAesCrypto(this, password, rawPassword, encryptionStrength);
+					initAesCrypto(aesCrypto, password, rawPassword, encryptionStrength);
 				},
 				async transform(chunk, controller) {
-					const aesCrypto = this;
 					const {
 						password,
 						strength,
@@ -1307,6 +1307,9 @@
 					} else {
 						await ready;
 					}
+					if (aesCrypto.discarded) {
+						return;
+					}
 					const output = new Uint8Array(chunk.length - AUTHENTICATION_CODE_LENGTH - ((chunk.length - AUTHENTICATION_CODE_LENGTH) % BLOCK_LENGTH));
 					controller.enqueue(append(aesCrypto, chunk, output, 0, AUTHENTICATION_CODE_LENGTH, true));
 				},
@@ -1315,9 +1318,12 @@
 						engine,
 						pendingInput,
 						ready
-					} = this;
+					} = aesCrypto;
 					if (engine) {
 						await ready;
+						if (aesCrypto.discarded) {
+							return;
+						}
 						const originalAuthenticationCode = subarray(pendingInput, pendingInput.length - AUTHENTICATION_CODE_LENGTH);
 						const decryptedChunkArray = new Uint8Array(subarray(pendingInput, 0, pendingInput.length - AUTHENTICATION_CODE_LENGTH));
 						engine.process(decryptedChunkArray, true);
@@ -1327,27 +1333,26 @@
 							invalidAuthenticationCode |= authenticationCode[indexByte] ^ originalAuthenticationCode[indexByte];
 						}
 						if (invalidAuthenticationCode && checkAuthenticationCode) {
-							throw new Error(ERR_INVALID_AUTHENTICATION_CODE);
+							controller.error(new Error(ERR_INVALID_AUTHENTICATION_CODE));
+							return;
 						}
 						controller.enqueue(decryptedChunkArray);
 					}
-				},
-				cancel() {
-					disposeEngine(this);
 				}
 			});
+			setDisposingReadable(this, aesCrypto);
 		}
 	}
 
 	class AESEncryptionStream extends TransformStream {
 
 		constructor({ password, rawPassword, encryptionStrength }) {
+			const aesCrypto = {};
 			super({
 				start() {
-					initAesCrypto(this, password, rawPassword, encryptionStrength);
+					initAesCrypto(aesCrypto, password, rawPassword, encryptionStrength);
 				},
 				async transform(chunk, controller) {
-					const aesCrypto = this;
 					const {
 						password,
 						strength,
@@ -1361,6 +1366,9 @@
 					} else {
 						await ready;
 					}
+					if (aesCrypto.discarded) {
+						return;
+					}
 					const output = new Uint8Array(preamble.length + chunk.length - (chunk.length % BLOCK_LENGTH));
 					output.set(preamble, 0);
 					controller.enqueue(append(aesCrypto, chunk, output, preamble.length, 0, false));
@@ -1370,19 +1378,20 @@
 						engine,
 						pendingInput,
 						ready
-					} = this;
+					} = aesCrypto;
 					if (engine) {
 						await ready;
+						if (aesCrypto.discarded) {
+							return;
+						}
 						const encryptedChunkArray = new Uint8Array(pendingInput);
 						engine.process(encryptedChunkArray, false);
 						const authenticationCode = subarray(engine.digest(), 0, AUTHENTICATION_CODE_LENGTH);
 						controller.enqueue(concat(encryptedChunkArray, authenticationCode));
 					}
-				},
-				cancel() {
-					disposeEngine(this);
 				}
 			});
+			setDisposingReadable(this, aesCrypto);
 		}
 	}
 
@@ -1391,7 +1400,37 @@
 			ready: new Promise(resolve => aesCrypto.resolveReady = resolve),
 			password: encodePassword(password, rawPassword),
 			strength: encryptionStrength - 1,
-			pendingInput: EMPTY_UINT8_ARRAY
+			pendingInput: EMPTY_UINT8_ARRAY,
+			discarded: false
+		});
+	}
+
+	function setDisposingReadable(stream, aesCrypto) {
+		const reader = stream.readable.getReader();
+		const readable = new ReadableStream({
+			async pull(controller) {
+				try {
+					const { value, done } = await reader.read();
+					if (done) {
+						controller.close();
+					} else {
+						controller.enqueue(value);
+					}
+				} catch (error) {
+					disposeEngine(aesCrypto);
+					reader.cancel(error).catch(() => { });
+					throw error;
+				}
+			},
+			cancel(reason) {
+				disposeEngine(aesCrypto);
+				return reader.cancel(reason);
+			}
+		});
+		Object.defineProperty(stream, "readable", {
+			get() {
+				return readable;
+			}
 		});
 	}
 
@@ -1424,7 +1463,9 @@
 		}
 	}
 
-	function disposeEngine({ engine }) {
+	function disposeEngine(aesCrypto) {
+		const { engine } = aesCrypto;
+		aesCrypto.discarded = true;
 		if (engine && engine.dispose) {
 			engine.dispose();
 		}
@@ -1441,6 +1482,9 @@
 		const keyLength = KEY_LENGTH[strength];
 		const compositeKey = await deriveKey(password, salt, keyLength * 2 + PASSWORD_VERIFICATION_LENGTH);
 		aesCrypto.engine = createEngine(subarray(compositeKey, 0, keyLength), subarray(compositeKey, keyLength, keyLength * 2));
+		if (aesCrypto.discarded) {
+			disposeEngine(aesCrypto);
+		}
 		return subarray(compositeKey, keyLength * 2);
 	}
 
@@ -1592,11 +1636,11 @@
 	}
 
 	function createKeys(target, password, rawPassword) {
-		const keys = [0x12345678, 0x23456789, 0x34567890];
+		const cryptoKeys = [0x12345678, 0x23456789, 0x34567890];
 		Object.assign(target, {
-			keys,
-			crcKey0: new Crc32(keys[0]),
-			crcKey2: new Crc32(keys[2])
+			cryptoKeys,
+			crcKey0: new Crc32(cryptoKeys[0]),
+			crcKey2: new Crc32(cryptoKeys[2])
 		});
 		if (rawPassword) {
 			for (let index = 0; index < rawPassword.length; index++) {
@@ -1610,17 +1654,17 @@
 	}
 
 	function updateKeys(target, byte) {
-		let [, key1] = target.keys;
+		let [, key1] = target.cryptoKeys;
 		target.crcKey0.append([byte]);
 		const key0 = ~target.crcKey0.get();
 		key1 = getInt32(Math.imul(getInt32(key1 + getInt8(key0)), 134775813) + 1);
 		target.crcKey2.append([key1 >>> 24]);
 		const key2 = ~target.crcKey2.get();
-		target.keys = [key0, key1, key2];
+		target.cryptoKeys = [key0, key1, key2];
 	}
 
 	function getByte(target) {
-		const temp = target.keys[2] | 2;
+		const temp = target.cryptoKeys[2] | 2;
 		return getInt8(Math.imul(temp, (temp ^ 1)) >>> 8);
 	}
 
@@ -1668,11 +1712,16 @@
 		const reader = readable.getReader();
 		return new ReadableStream({
 			async pull(controller) {
-				const { value, done } = await reader.read();
-				if (done) {
-					controller.close();
-				} else {
-					controller.enqueue(value);
+				try {
+					const { value, done } = await reader.read();
+					if (done) {
+						controller.close();
+					} else {
+						controller.enqueue(value);
+					}
+				} catch (error) {
+					reader.cancel(error).catch(() => { });
+					throw error;
 				}
 			},
 			cancel(reason) {
@@ -1975,28 +2024,25 @@
 		pump();
 		return new ReadableStream({
 			async pull(controller) {
-				let result;
 				try {
-					result = await read();
+					const { value, done } = await read();
+					if (done) {
+						controller.close();
+					} else {
+						outputLength += value.length;
+						if (outputLength > outputSize) {
+							throw new Error(ERR_INVALID_UNCOMPRESSED_SIZE);
+						}
+						if (outputCrc32) {
+							outputCrc32.append(value);
+						}
+						controller.enqueue(value);
+					}
 				} catch (error) {
+					rejectTrailerReady(error);
+					await cancel(reader, error);
 					throw trailerWritten ? getTrailerError(error) : error;
 				}
-				const { value, done } = result;
-				if (done) {
-					controller.close();
-				} else {
-					outputLength += value.length;
-					if (outputLength > outputSize) {
-						const error = new Error(ERR_INVALID_UNCOMPRESSED_SIZE);
-						rejectTrailerReady(error);
-						await cancel(reader, error);
-						throw error;
-					}
-					if (outputCrc32) {
-						outputCrc32.append(value);
-					}
-					controller.enqueue(value);
-				}
 			},
 			cancel(reason) {
 				rejectTrailerReady(reason);
@@ -2275,10 +2321,15 @@
 		const reader = readable.getReader();
 		return new ReadableStream({
 			async pull(controller) {
-				let result;
 				try {
-					result = await reader.read();
+					const { value, done } = await reader.read();
+					if (done) {
+						controller.close();
+					} else {
+						controller.enqueue(value);
+					}
 				} catch (error) {
+					await cancel(reader, error);
 					if (error && error.message) {
 						throw error;
 					}
@@ -2286,12 +2337,6 @@
 					mappedError.cause = error;
 					throw mappedError;
 				}
-				const { value, done } = result;
-				if (done) {
-					controller.close();
-				} else {
-					controller.enqueue(value);
-				}
 			},
 			cancel(reason) {
 				return reader.cancel(reason);
@@ -5346,8 +5391,8 @@
 			const passThroughCompression = Boolean(passThrough);
 			const passThroughEncryption = passThrough === true;
 			checkPasswordOption(password, rawPassword);
-			password = password && password.length && password;
-			rawPassword = rawPassword && rawPassword.length && rawPassword;
+			password = password && password.length ? password : UNDEFINED_VALUE;
+			rawPassword = rawPassword && rawPassword.length ? rawPassword : UNDEFINED_VALUE;
 			if (extraFieldAES) {
 				if (extraFieldAES.originalCompressionMethod != COMPRESSION_METHOD_AES) {
 					throw new Error(ERR_UNSUPPORTED_COMPRESSION);
@@ -6108,7 +6153,7 @@
 	async function findEndOfCentralDirectory(reader, rejectAmbiguous, maxAppendedDataSize) {
 		const { size } = reader;
 		const anchoredLength = Math.min(size, END_OF_CENTRAL_DIR_LENGTH + MAX_16_BITS);
-		const remoteProbeBudget = { count: MAX_END_OF_CENTRAL_DIR_PROBES };
+		const remoteProbeBudget = { remaining: MAX_END_OF_CENTRAL_DIR_PROBES };
 		let endOfDirectoryInfo;
 		let plausibleEndOfDirectoryInfo;
 		let endOfDirectoryReachingEndCount = 0;
@@ -6201,8 +6246,8 @@
 		if (signatureOffset >= anchoredOffset) {
 			return getUint32$1(view, signatureOffset - anchoredOffset);
 		}
-		if (remoteProbeBudget.count > 0) {
-			remoteProbeBudget.count--;
+		if (remoteProbeBudget.remaining > 0) {
+			remoteProbeBudget.remaining--;
 			const signatureArray = await readUint8Array(reader, signatureOffset, 4);
 			return getUint32$1(getDataView(signatureArray), 0);
 		}
@@ -7118,9 +7163,11 @@
 		const passThrough = checkPassThroughOption(getOptionValue(zipWriter, options, OPTION_PASS_THROUGH));
 		const passThroughCompression = Boolean(passThrough);
 		const passThroughEncryption = passThrough === true;
-		const password = getOptionValue(zipWriter, options, OPTION_PASSWORD);
-		const rawPassword = getOptionValue(zipWriter, options, OPTION_RAW_PASSWORD);
+		let password = getOptionValue(zipWriter, options, OPTION_PASSWORD);
+		let rawPassword = getOptionValue(zipWriter, options, OPTION_RAW_PASSWORD);
 		checkPasswordOption(password, rawPassword);
+		password = password && password.length ? password : UNDEFINED_VALUE;
+		rawPassword = rawPassword && rawPassword.length ? rawPassword : UNDEFINED_VALUE;
 		const encryptionStrength = getNumberOptionValue(zipWriter, options, OPTION_ENCRYPTION_STRENGTH, 3);
 		const zipCrypto = getOptionValue(zipWriter, options, PROPERTY_NAME_ZIPCRYPTO);
 		const extendedTimestamp = getOptionValue(zipWriter, options, OPTION_EXTENDED_TIMESTAMP, true);
@@ -8818,7 +8865,7 @@
 	 EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 	 */
 
-	const VERSION = "2.16.0";
+	const VERSION = "2.16.1";
 
 	/*
 	 Copyright (c) 2025 Gildas Lormeau. All rights reserved.