@ziggs-ai/api-client 0.1.22 → 0.1.24

package/dist/http/AgreementClient.js

@@ -126,8 +126,15 @@ export async function respondToAgreement(agreementId, action, creds, opts = {})
     }
     const proposedTo = agreement.parties?.proposedTo;
     if (isBroadcastTarget(proposedTo)) {
-        if (action === 'reject')
-            return agreement;
+        if (action === 'reject') {
+            // ZIG-719: an open/broadcast proposal is offered to many via a sentinel
+            // `proposedTo` ('everyone' | 'org'), so there is no per-recipient party
+            // slot for one recipient to reject and nothing a single reject could
+            // change server-side. Returning the agreement here reported a fake
+            // success while the item stayed claimable. Fail honestly instead — the
+            // caller either claims it (action=approve → POST /claim) or ignores it.
+            throw new Error(`Agreement ${agreementId} is an open/broadcast proposal (proposedTo="${String(proposedTo)}") and cannot be rejected by a single recipient — it has no personal approval slot. Ignore it to pass on it, or use action=approve to claim it.`);
+        }
         const { agreement: updated } = await claimAgreement(agreementId, creds);
         return updated;
     }
@@ -233,57 +240,65 @@ export async function getAgreementStatus(agreementId, creds) {
 }
 export async function listAgreements(filters = {}, creds) {
     assertCreds(creds, 'list agreements');
+    // ZIG-699 — return an empty array only for a genuine empty 200 result. Any
+    // failure (non-2xx / network) throws so the MCP tool reports a real error
+    // instead of "you have no agreements". The status stays whitespace-delimited
+    // so the tool's toolError/classifyToolError maps it to a stable code.
+    // Canonical query path: GET /agreements?scope=&status=&engagementKind=&...
+    const url = new URL(getAgreementBaseUrl());
+    if (filters.status)
+        url.searchParams.set('status', filters.status);
+    if (filters.engagementKind)
+        url.searchParams.set('engagementKind', filters.engagementKind);
+    if (filters.proposalStatus)
+        url.searchParams.set('proposalStatus', filters.proposalStatus);
+    if (filters.hasTask != null)
+        url.searchParams.set('hasTask', String(filters.hasTask));
+    let res;
     try {
-        // Canonical query path: GET /agreements?scope=&status=&engagementKind=&...
-        const url = new URL(getAgreementBaseUrl());
-        if (filters.status)
-            url.searchParams.set('status', filters.status);
-        if (filters.engagementKind)
-            url.searchParams.set('engagementKind', filters.engagementKind);
-        if (filters.proposalStatus)
-            url.searchParams.set('proposalStatus', filters.proposalStatus);
-        if (filters.hasTask != null)
-            url.searchParams.set('hasTask', String(filters.hasTask));
-        const res = await fetch(url.toString(), { method: 'GET', headers: buildHeaders(creds) });
-        if (!res.ok) {
-            const body = await res.text().catch(() => '');
-            runtimeLog.warn('AgreementClient', `⚠️ List agreements failed: ${res.status} ${res.statusText} ${body?.slice(0, 200)}`);
-            return [];
-        }
-        const data = await res.json().catch(() => null);
-        return Array.isArray(data?.['agreements']) ? data['agreements'] : [];
+        res = await fetch(url.toString(), { method: 'GET', headers: buildHeaders(creds) });
     }
     catch (e) {
         runtimeLog.warn('AgreementClient', `⚠️ List agreements failed: ${e.message}`);
-        return [];
+        throw new Error(`GET /agreements network error: ${e.message}`);
+    }
+    if (!res.ok) {
+        const body = await res.text().catch(() => '');
+        runtimeLog.warn('AgreementClient', `⚠️ List agreements failed: ${res.status} ${res.statusText} ${body?.slice(0, 200)}`);
+        throw new Error(`GET /agreements ${res.status} ${body?.slice(0, 200)}`);
     }
+    const data = await res.json().catch(() => null);
+    return Array.isArray(data?.['agreements']) ? data['agreements'] : [];
 }
 export async function getMyAgreements(filters = {}, creds) {
     assertCreds(creds, 'get my agreements');
+    // ZIG-699 — empty array only for a genuine empty 200; any failure throws so
+    // the tool surfaces a real error rather than "no agreements" (see listAgreements).
+    // Canonical query path: GET /agreements?scope=mine returns the enriched
+    // shape (tasks + originChatId + isYou flags).
+    const url = new URL(getAgreementBaseUrl());
+    url.searchParams.set('scope', 'mine');
+    if (filters.engagementKind)
+        url.searchParams.set('engagementKind', filters.engagementKind);
+    if (filters.proposalStatus)
+        url.searchParams.set('proposalStatus', filters.proposalStatus);
+    if (filters.hasTask != null)
+        url.searchParams.set('hasTask', String(filters.hasTask));
+    let res;
     try {
-        // Canonical query path: GET /agreements?scope=mine returns the enriched
-        // shape (tasks + originChatId + isYou flags).
-        const url = new URL(getAgreementBaseUrl());
-        url.searchParams.set('scope', 'mine');
-        if (filters.engagementKind)
-            url.searchParams.set('engagementKind', filters.engagementKind);
-        if (filters.proposalStatus)
-            url.searchParams.set('proposalStatus', filters.proposalStatus);
-        if (filters.hasTask != null)
-            url.searchParams.set('hasTask', String(filters.hasTask));
-        const res = await fetch(url.toString(), { method: 'GET', headers: buildHeaders(creds) });
-        if (!res.ok) {
-            const body = await res.text().catch(() => '');
-            runtimeLog.warn('AgreementClient', `⚠️ Get my agreements failed: ${res.status} ${res.statusText} ${body?.slice(0, 200)}`);
-            return [];
-        }
-        const data = await res.json().catch(() => null);
-        return Array.isArray(data?.['agreements']) ? data['agreements'] : [];
+        res = await fetch(url.toString(), { method: 'GET', headers: buildHeaders(creds) });
     }
     catch (e) {
         runtimeLog.warn('AgreementClient', `⚠️ Get my agreements failed: ${e.message}`);
-        return [];
+        throw new Error(`GET /agreements?scope=mine network error: ${e.message}`);
     }
+    if (!res.ok) {
+        const body = await res.text().catch(() => '');
+        runtimeLog.warn('AgreementClient', `⚠️ Get my agreements failed: ${res.status} ${res.statusText} ${body?.slice(0, 200)}`);
+        throw new Error(`GET /agreements?scope=mine ${res.status} ${body?.slice(0, 200)}`);
+    }
+    const data = await res.json().catch(() => null);
+    return Array.isArray(data?.['agreements']) ? data['agreements'] : [];
 }
 export async function getAgreement(agreementId, creds) {
     if (!agreementId)

package/dist/http/ChatClient.js

@@ -112,23 +112,27 @@ export async function sendChatMessage(input, creds) {
 }
 export async function listMyChats(creds) {
     assertCreds(creds, 'list my chats');
+    // ZIG-699 — empty array only for a genuine empty 200; any failure (non-2xx /
+    // network) throws so ziggs_list_chats reports a real error instead of "you
+    // have no chats". Status stays whitespace-delimited for toolError classification.
+    let res;
     try {
-        const res = await fetch(`${getBackendUrl()}/chats/mine`, {
+        res = await fetch(`${getBackendUrl()}/chats/mine`, {
             method: 'GET',
             headers: buildHeaders(creds),
         });
-        if (!res.ok) {
-            const body = await res.text().catch(() => '');
-            runtimeLog.warn('ChatClient', `⚠️ listMyChats failed: ${res.status} ${res.statusText} ${body?.slice(0, 200)}`);
-            return [];
-        }
-        const data = await res.json().catch(() => null);
-        return Array.isArray(data?.['chats']) ? data['chats'] : [];
     }
     catch (e) {
         runtimeLog.warn('ChatClient', `⚠️ listMyChats failed: ${e.message}`);
-        return [];
+        throw new Error(`GET /chats/mine network error: ${e.message}`);
     }
+    if (!res.ok) {
+        const body = await res.text().catch(() => '');
+        runtimeLog.warn('ChatClient', `⚠️ listMyChats failed: ${res.status} ${res.statusText} ${body?.slice(0, 200)}`);
+        throw new Error(`GET /chats/mine ${res.status} ${body?.slice(0, 200)}`);
+    }
+    const data = await res.json().catch(() => null);
+    return Array.isArray(data?.['chats']) ? data['chats'] : [];
 }
 export class ChatClient {
     creds;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ziggs-ai/api-client",
-  "version": "0.1.22",
+  "version": "0.1.24",
   "description": "HTTP and WebSocket client for the Ziggs backend API",
   "type": "module",
   "main": "dist/index.js",