@ziggs-ai/api-client 0.1.21 → 0.1.23

package/dist/http/AgreementClient.js

@@ -233,81 +233,95 @@ export async function getAgreementStatus(agreementId, creds) {
 }
 export async function listAgreements(filters = {}, creds) {
     assertCreds(creds, 'list agreements');
+    // ZIG-699 — return an empty array only for a genuine empty 200 result. Any
+    // failure (non-2xx / network) throws so the MCP tool reports a real error
+    // instead of "you have no agreements". The status stays whitespace-delimited
+    // so the tool's toolError/classifyToolError maps it to a stable code.
+    // Canonical query path: GET /agreements?scope=&status=&engagementKind=&...
+    const url = new URL(getAgreementBaseUrl());
+    if (filters.status)
+        url.searchParams.set('status', filters.status);
+    if (filters.engagementKind)
+        url.searchParams.set('engagementKind', filters.engagementKind);
+    if (filters.proposalStatus)
+        url.searchParams.set('proposalStatus', filters.proposalStatus);
+    if (filters.hasTask != null)
+        url.searchParams.set('hasTask', String(filters.hasTask));
+    let res;
     try {
-        // Canonical query path: GET /agreements?scope=&status=&engagementKind=&...
-        const url = new URL(getAgreementBaseUrl());
-        if (filters.status)
-            url.searchParams.set('status', filters.status);
-        if (filters.engagementKind)
-            url.searchParams.set('engagementKind', filters.engagementKind);
-        if (filters.proposalStatus)
-            url.searchParams.set('proposalStatus', filters.proposalStatus);
-        if (filters.hasTask != null)
-            url.searchParams.set('hasTask', String(filters.hasTask));
-        const res = await fetch(url.toString(), { method: 'GET', headers: buildHeaders(creds) });
-        if (!res.ok) {
-            const body = await res.text().catch(() => '');
-            runtimeLog.warn('AgreementClient', `⚠️ List agreements failed: ${res.status} ${res.statusText} ${body?.slice(0, 200)}`);
-            return [];
-        }
-        const data = await res.json().catch(() => null);
-        return Array.isArray(data?.['agreements']) ? data['agreements'] : [];
+        res = await fetch(url.toString(), { method: 'GET', headers: buildHeaders(creds) });
     }
     catch (e) {
         runtimeLog.warn('AgreementClient', `⚠️ List agreements failed: ${e.message}`);
-        return [];
+        throw new Error(`GET /agreements network error: ${e.message}`);
+    }
+    if (!res.ok) {
+        const body = await res.text().catch(() => '');
+        runtimeLog.warn('AgreementClient', `⚠️ List agreements failed: ${res.status} ${res.statusText} ${body?.slice(0, 200)}`);
+        throw new Error(`GET /agreements ${res.status} ${body?.slice(0, 200)}`);
     }
+    const data = await res.json().catch(() => null);
+    return Array.isArray(data?.['agreements']) ? data['agreements'] : [];
 }
 export async function getMyAgreements(filters = {}, creds) {
     assertCreds(creds, 'get my agreements');
+    // ZIG-699 — empty array only for a genuine empty 200; any failure throws so
+    // the tool surfaces a real error rather than "no agreements" (see listAgreements).
+    // Canonical query path: GET /agreements?scope=mine returns the enriched
+    // shape (tasks + originChatId + isYou flags).
+    const url = new URL(getAgreementBaseUrl());
+    url.searchParams.set('scope', 'mine');
+    if (filters.engagementKind)
+        url.searchParams.set('engagementKind', filters.engagementKind);
+    if (filters.proposalStatus)
+        url.searchParams.set('proposalStatus', filters.proposalStatus);
+    if (filters.hasTask != null)
+        url.searchParams.set('hasTask', String(filters.hasTask));
+    let res;
     try {
-        // Canonical query path: GET /agreements?scope=mine returns the enriched
-        // shape (tasks + originChatId + isYou flags).
-        const url = new URL(getAgreementBaseUrl());
-        url.searchParams.set('scope', 'mine');
-        if (filters.engagementKind)
-            url.searchParams.set('engagementKind', filters.engagementKind);
-        if (filters.proposalStatus)
-            url.searchParams.set('proposalStatus', filters.proposalStatus);
-        if (filters.hasTask != null)
-            url.searchParams.set('hasTask', String(filters.hasTask));
-        const res = await fetch(url.toString(), { method: 'GET', headers: buildHeaders(creds) });
-        if (!res.ok) {
-            const body = await res.text().catch(() => '');
-            runtimeLog.warn('AgreementClient', `⚠️ Get my agreements failed: ${res.status} ${res.statusText} ${body?.slice(0, 200)}`);
-            return [];
-        }
-        const data = await res.json().catch(() => null);
-        return Array.isArray(data?.['agreements']) ? data['agreements'] : [];
+        res = await fetch(url.toString(), { method: 'GET', headers: buildHeaders(creds) });
     }
     catch (e) {
         runtimeLog.warn('AgreementClient', `⚠️ Get my agreements failed: ${e.message}`);
-        return [];
+        throw new Error(`GET /agreements?scope=mine network error: ${e.message}`);
     }
+    if (!res.ok) {
+        const body = await res.text().catch(() => '');
+        runtimeLog.warn('AgreementClient', `⚠️ Get my agreements failed: ${res.status} ${res.statusText} ${body?.slice(0, 200)}`);
+        throw new Error(`GET /agreements?scope=mine ${res.status} ${body?.slice(0, 200)}`);
+    }
+    const data = await res.json().catch(() => null);
+    return Array.isArray(data?.['agreements']) ? data['agreements'] : [];
 }
 export async function getAgreement(agreementId, creds) {
     if (!agreementId)
         return null;
     assertCreds(creds, 'get agreement');
+    // ZIG-698 — a genuine 404 (and 200-with-no-agreement) is a real "not found"
+    // and returns null. Every other failure (403/5xx/network) must throw so the
+    // caller can tell "does not exist" from "could not fetch" instead of a 403
+    // masquerading as not-found. The MCP tool classifies the thrown status via
+    // toolError; the message keeps the status whitespace-delimited for that.
+    let res;
     try {
-        const res = await fetch(`${getAgreementBaseUrl()}/${agreementId}`, {
+        res = await fetch(`${getAgreementBaseUrl()}/${agreementId}`, {
             method: 'GET',
             headers: buildHeaders(creds),
         });
-        if (res.status === 404)
-            return null;
-        if (!res.ok) {
-            const body = await res.text().catch(() => '');
-            runtimeLog.warn('AgreementClient', `⚠️ Get agreement failed: ${res.status} ${res.statusText} ${body?.slice(0, 200)}`);
-            return null;
-        }
-        const data = await res.json().catch(() => null);
-        return data?.['agreement'] ?? null;
     }
     catch (e) {
         runtimeLog.warn('AgreementClient', `⚠️ Get agreement failed: ${e.message}`);
+        throw new Error(`GET /agreements/${agreementId} network error: ${e.message}`);
+    }
+    if (res.status === 404)
         return null;
+    if (!res.ok) {
+        const body = await res.text().catch(() => '');
+        runtimeLog.warn('AgreementClient', `⚠️ Get agreement failed: ${res.status} ${res.statusText} ${body?.slice(0, 200)}`);
+        throw new Error(`GET /agreements/${agreementId} ${res.status} ${body?.slice(0, 200)}`);
     }
+    const data = await res.json().catch(() => null);
+    return data?.['agreement'] ?? null;
 }
 export async function createAgreement(body, creds) {
     if (!body)

package/dist/http/ChatClient.js

@@ -112,23 +112,27 @@ export async function sendChatMessage(input, creds) {
 }
 export async function listMyChats(creds) {
     assertCreds(creds, 'list my chats');
+    // ZIG-699 — empty array only for a genuine empty 200; any failure (non-2xx /
+    // network) throws so ziggs_list_chats reports a real error instead of "you
+    // have no chats". Status stays whitespace-delimited for toolError classification.
+    let res;
     try {
-        const res = await fetch(`${getBackendUrl()}/chats/mine`, {
+        res = await fetch(`${getBackendUrl()}/chats/mine`, {
             method: 'GET',
             headers: buildHeaders(creds),
         });
-        if (!res.ok) {
-            const body = await res.text().catch(() => '');
-            runtimeLog.warn('ChatClient', `⚠️ listMyChats failed: ${res.status} ${res.statusText} ${body?.slice(0, 200)}`);
-            return [];
-        }
-        const data = await res.json().catch(() => null);
-        return Array.isArray(data?.['chats']) ? data['chats'] : [];
     }
     catch (e) {
         runtimeLog.warn('ChatClient', `⚠️ listMyChats failed: ${e.message}`);
-        return [];
+        throw new Error(`GET /chats/mine network error: ${e.message}`);
     }
+    if (!res.ok) {
+        const body = await res.text().catch(() => '');
+        runtimeLog.warn('ChatClient', `⚠️ listMyChats failed: ${res.status} ${res.statusText} ${body?.slice(0, 200)}`);
+        throw new Error(`GET /chats/mine ${res.status} ${body?.slice(0, 200)}`);
+    }
+    const data = await res.json().catch(() => null);
+    return Array.isArray(data?.['chats']) ? data['chats'] : [];
 }
 export class ChatClient {
     creds;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ziggs-ai/api-client",
-  "version": "0.1.21",
+  "version": "0.1.23",
   "description": "HTTP and WebSocket client for the Ziggs backend API",
   "type": "module",
   "main": "dist/index.js",